[00:01:40] (PS5) Eileen: Further fix on 'Remove bulk update blank addresses from being treated as 'updates'.' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341737 (https://phabricator.wikimedia.org/T159396) [00:03:41] (PS2) Eileen: Also treat address updates with no change to material fields as ones to ignore for removing blanks. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341919 (https://phabricator.wikimedia.org/T159402) [00:03:50] (CR) jerkins-bot: [V: -1] Also treat address updates with no change to material fields as ones to ignore for removing blanks. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341919 (https://phabricator.wikimedia.org/T159402) (owner: Eileen) [00:07:29] (PS3) Eileen: Do not record void 'N0NE PROVIDED' address data' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341753 [00:07:30] (PS3) Eileen: Do not record dummy data 'N0NE PROVIDED' to the database, [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) [00:08:32] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341919 (https://phabricator.wikimedia.org/T159402) (owner: Eileen) [00:10:33] (PS4) Eileen: Do not record dummy data 'N0NE PROVIDED' to the database, [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) [00:11:00] (Abandoned) Eileen: Do not record void 'N0NE PROVIDED' address data' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341753 (owner: Eileen) [00:12:17] awight: if you feel enthused this is ready for review, but it's also not urgent https://gerrit.wikimedia.org/r/#/c/341754/ [00:33:20] eileen: hehe, the hack that will not die [00:34:30] awight: there is a minecraft song my kids play that sounds like that line [00:35:33] I have a lot to look forward to, I see [00:42:03] (CR) Awight: [C: -1] "Hoping this can go somewhere more discoverable..." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [00:43:08] (PS1) Eileen: Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) [00:43:19] (CR) jerkins-bot: [V: -1] Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [00:43:59] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [00:44:09] (CR) jerkins-bot: [V: -1] Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [00:45:24] eileen: I would ask for your opinion about the DonationInterface validation changes in https://gerrit.wikimedia.org/r/341727 but it might be a heavy on context... [00:45:30] *bit [00:45:56] ohh there is a lot there [00:46:18] LOL our DonationInterface unit tests cover 0.34% of the code [00:46:49] Yeah there's a small, lost city and forgotten history [00:49:42] in general I see lots of validation coming out & some being added in https://gerrit.wikimedia.org/r/#/c/341727/14/gateway_common/gateway.adapter.php [00:51:58] I can kinda see the big picture on it & it makes sense, not sure down to a line-level tho [00:53:24] Cool, yeah it's not quite right but I'm hoping will be more maintainable. [00:53:53] There's an interesting processing stage that might be familiar to you from other projects, I'd love some help putting a name on it-- [00:54:09] after validation, we check whether the currency is invalid, and if so we attempt to fall back to a default currency [00:54:25] It doesn't really fit with other normalizations or validations [00:55:15] and if the fallback conditional runs, then we probably need to do another validation to be sure that the new currency and other fields are supported. [00:55:52] Maybe I'm just looking at this wrong, and it's simpler [01:13:54] sorry was just getting food [01:14:13] I'm just rambling, you didn't miss much [01:14:32] This code is teeming with hidden dependencies... [01:14:38] I don't know if it is applicable but with the api we resolve things before doing validation [01:14:44] & then validate the resolved stuff [01:15:13] so is the order right? ie. should transformations be done before validation? [01:15:34] Well the order is currently * normalize * validate * stage [01:16:06] Where "staging" is, mapping from normalized values to a structure ready for posting to the remote API [01:16:25] I think currency fallback is most like normalization, I can get behind that. [01:17:11] (PS2) Eileen: Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) [01:18:06] (Abandoned) Eileen: Further fix on 'Remove bulk update blank addresses from being treated as 'updates'.' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341737 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [01:19:20] (Abandoned) Eileen: Also treat address updates with no change to material fields as ones to ignore for removing blanks. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341919 (https://phabricator.wikimedia.org/T159402) (owner: Eileen) [01:29:59] (PS5) Eileen: Do not record dummy data 'N0NE PROVIDED' to the database, [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) [01:35:26] awight: the test still passes with the code moved to nomalize_msg ! https://gerrit.wikimedia.org/r/#/c/341754/ [01:35:53] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [01:36:32] (CR) jerkins-bot: [V: -1] Do not record dummy data 'N0NE PROVIDED' to the database, [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [01:37:04] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341754 (https://phabricator.wikimedia.org/T158268) (owner: Eileen) [01:37:19] getting a lot of fail-then-work or vice versa from jenkins lately [01:42:47] yeesh, it's probably worth filing a task to look into it [01:42:57] gtg make fud, see you tomorrow! [01:45:56] (PS1) Awight: [WIP] A few changes. distinguish between unstaged and normalized, split construct, validate and stage steps. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342553 (https://phabricator.wikimedia.org/T159910) [01:48:05] (CR) jerkins-bot: [V: -1] [WIP] A few changes. distinguish between unstaged and normalized, split construct, validate and stage steps. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342553 (https://phabricator.wikimedia.org/T159910) (owner: Awight) [01:59:47] (PS3) Eileen: Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) [01:59:49] (PS1) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [01:59:51] (PS1) Eileen: E-notice fix. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342555 [02:00:24] (Abandoned) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/341730 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [02:05:53] (CR) jerkins-bot: [V: -1] Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [02:54:04] (PS2) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [02:54:42] (PS3) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [02:55:41] (CR) jerkins-bot: [V: -1] Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [03:04:16] (PS4) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [03:26:48] (PS5) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [03:34:36] (PS6) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [03:56:19] (PS7) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [04:21:07] (PS8) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [04:21:50] (CR) jerkins-bot: [V: -1] Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [14:30:35] Fundraising-Backlog, fundraising-tech-ops: upgrade samarium from precise to jessie - https://phabricator.wikimedia.org/T156848#3097957 (Jgreen) [14:31:43] Fundraising-Backlog, fundraising-tech-ops: upgrade samarium from precise to jessie - https://phabricator.wikimedia.org/T156848#2987733 (Jgreen) [14:32:35] Fundraising-Backlog, fundraising-tech-ops: upgrade samarium from precise to jessie - https://phabricator.wikimedia.org/T156848#2987733 (Jgreen) [14:41:59] Jeff_Green: this is infuriatingly century link hosted but is a pretty good doc dealing with what we're thinking about https://www.ctl.io/developers/blog/post/cron-in-production [14:43:56] heads up: samarium going down for rebuild [14:44:04] cwd looking [14:44:30] also here is that script on github https://gist.github.com/liquidgecka/9788122 [14:45:09] oh nice, did you find out anything about licensing? [14:45:30] not yet, the email form on his website is broken :P [14:45:37] i'll try through github [14:47:15] re. article yup, cron was never intended to do any of that stuff [14:47:54] and if jenkins was, it doesn't work :-P [16:28:21] fundraising-tech-ops: upgrade all frack servers to debian/jessie - https://phabricator.wikimedia.org/T146479#3098461 (Jgreen) [16:28:23] Fundraising-Backlog, fundraising-tech-ops: upgrade samarium from precise to jessie - https://phabricator.wikimedia.org/T156848#3098459 (Jgreen) Open>Resolved this is done [17:35:50] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, and 5 others: Purge Varnish cache when a banner is saved - https://phabricator.wikimedia.org/T154954#3098754 (AndyRussG) >>! In T154954... [18:00:21] fr-tech: Women treat us just as humanity treats its gods. They worship [18:00:21] us and are always bothering us to do something for them. [18:00:21] -- Wilde [18:00:21] -- discuss. [18:01:02] X| [18:02:11] was fortune written in the 1950s? [18:03:22] slander: I disapprove of that quote because sexism... :/ [18:04:53] https://en.wikipedia.org/wiki/The_Picture_of_Dorian_Gray 1890 [18:39:24] (CR) Ejegg: [C: 2] Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [18:44:14] (Merged) jenkins-bot: Rerun previous blank_address updates with slightly wider catchment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342552 (https://phabricator.wikimedia.org/T159396) (owner: Eileen) [18:52:45] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [20:09:09] (PS9) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [20:16:21] (CR) jerkins-bot: [V: -1] Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [20:49:29] (PS1) Ejegg: WIP stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 [20:55:07] (PS10) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [21:00:42] (PS2) Ejegg: WIP stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) [21:01:21] (CR) jerkins-bot: [V: -1] Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [21:12:37] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Spike, Technical-Debt: Spike: Better design for currency fallback stage - https://phabricator.wikimedia.org/T160384#3099878 (ggellerman) p:Triage>Normal [21:13:26] Fundraising-Backlog, FR-Paypal: Paypal audit - don't look up name when we already have it - https://phabricator.wikimedia.org/T160134#3099883 (Ejegg) [21:16:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface CI tests are failing for MediaWiki 1.28 branch - https://phabricator.wikimedia.org/T160379#3099901 (ggellerman) p:Normal>Low [21:16:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface CI tests are failing for MediaWiki 1.28 branch - https://phabricator.wikimedia.org/T160379#3099902 (awight) Let's disable them to not squander CI resources. [21:21:15] (PS11) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [21:22:35] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface, Technical-Debt: [Tech Debt] Unit tests are sensitive to local SmashPig.yaml settings - https://phabricator.wikimedia.org/T160376#3099939 (ggellerman) p:Triage>Normal [21:25:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: [Data Retention] Be more careful logging user IP to long-term logs. - https://phabricator.wikimedia.org/T160366#3099948 (DStrine) [21:25:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: [Data Retention] Be more careful logging user IP to long-term logs. - https://phabricator.wikimedia.org/T160366#3099949 (awight) Sounds like we're getting conflicting advice, PCI might demand retaining for a year, and WMF Legal might suggest ma... [21:25:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: [Data Retention] Be more careful logging user IP to long-term logs. - https://phabricator.wikimedia.org/T160366#3099950 (ggellerman) p:Triage>Normal [21:26:47] Fundraising-Backlog, FR-Paypal: Paypal audit - don't look up name when we already have it - https://phabricator.wikimedia.org/T160134#3099960 (ggellerman) p:Triage>Low [21:28:15] Fundraising-Backlog, FR-Smashpig: SmashPig context is broken in tests - https://phabricator.wikimedia.org/T160104#3099974 (ggellerman) p:Triage>Normal [21:30:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Technical-Debt: [Tech Debt] Separate gateway constructor, addData, and validate - https://phabricator.wikimedia.org/T159910#3099989 (ggellerman) p:Triage>Normal [21:30:59] (CR) jerkins-bot: [V: -1] WIP stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) (owner: Ejegg) [21:31:10] Fundraising-Backlog, FR-Smashpig: SmashPig should log via PSR-3 standards - https://phabricator.wikimedia.org/T160470#3099993 (awight) [21:31:12] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface, and 2 others: [Tech Debt] Separate gateway constructor, addData, and validate - https://phabricator.wikimedia.org/T159910#3100005 (DStrine) [21:32:27] Fundraising-Backlog, FR-Smashpig: SmashPig should log via PSR-3 standards - https://phabricator.wikimedia.org/T160470#3100010 (awight) [21:32:29] Fundraising Tech Backlog, Fundraising-Backlog, FR-Smashpig: Scrap custom fundraising logging, integrate with PSR-3 core stuff - https://phabricator.wikimedia.org/T87065#3100009 (awight) [21:33:03] Fundraising-Backlog, FR-Smashpig: SmashPig should log via PSR-3 standards - https://phabricator.wikimedia.org/T160470#3100013 (ggellerman) p:Triage>Normal [21:38:35] Fundraising Sprint English Cuisine, Fundraising-Backlog, FR-Paypal, Patch-For-Review: Paypal audit - stop undoing normalization for recurring messages - https://phabricator.wikimedia.org/T160138#3089956 (Ejegg) a:Ejegg [21:58:37] (CR) Ejegg: [C: 2] Comments and whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341469 (owner: Awight) [22:01:51] .zargo file, huh? [22:02:56] hahaha [22:03:01] ah, cool, ArgoUML [22:03:14] wait, I didn't think I'd checked that in yet? [22:03:24] hehe, yep, it's in there! [22:03:40] oops. Which patch? [22:03:50] nvm I can find it [22:04:08] https://gerrit.wikimedia.org/r/341477 [22:04:38] (PS3) Awight: Comments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341477 [22:04:39] (PS5) Awight: Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 [22:04:42] (PS4) Awight: Form should not validate if manual errors are present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341592 (https://phabricator.wikimedia.org/T98447) [22:04:43] (PS4) Awight: Remove deprecated function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341721 [22:04:46] (PS5) Awight: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 [22:04:48] (PS2) Awight: Comments and todos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342547 [22:04:50] (PS2) Awight: Correct parameters to wfMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342548 [22:04:52] (PS15) Awight: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) [22:04:54] (PS2) Awight: [WIP] A few changes. distinguish between unstaged and normalized, split construct, validate and stage steps. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342553 (https://phabricator.wikimedia.org/T159910) [22:05:01] That diagram is definitely not ready for prime time [22:05:20] k [22:05:37] I do think it'll be useful to work on the sequence diagrams for describing our more idea world, though [22:05:53] ejegg: feel free to fast-forward to https://gerrit.wikimedia.org/r/342553 [22:06:11] if you want to evaluate whether I should go ahead and sic the ctor or not [22:06:13] thanks for pulling that 'form should not validate if manual errors are present' one forward [22:06:23] ah yeah. I don't think it solves everything tho [22:11:15] (Merged) jenkins-bot: More verbose test titles [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341468 (owner: Awight) [22:11:28] (Merged) jenkins-bot: Comments and whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341469 (owner: Awight) [22:11:30] (Merged) jenkins-bot: Check for maintenance mode before anything [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341470 (owner: Awight) [22:12:49] fr-tech: I'm thinking that we can perform the various adapter operations at the specific site where they are needed, rather than in the constructor. For example, never unstage unless we're actually processing data returned from the PSP. [22:13:11] Only stage once the transaction is known, and do it right before we need the staged values to send to the PSP. [22:14:05] (CR) Ejegg: "Best practice, but we definitely need to look at all the places we display this stuff. Also, maybe add some validation rules to entirely r" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [22:17:17] ah, they're closing up the library, will be back on from the apartment [22:36:19] (PS12) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [22:42:44] (CR) jerkins-bot: [V: -1] Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [22:49:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, FR-Smashpig, MediaWiki-extensions-DonationInterface: Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3100201 (awight) [22:54:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, FR-Smashpig, MediaWiki-extensions-DonationInterface: Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3100236 (awight) [23:03:33] (PS13) Eileen: Restore blanked addresses overwritten on merge. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/342554 (https://phabricator.wikimedia.org/T159408) [23:09:19] (CR) jerkins-bot: [V: -1] [WIP] A few changes. distinguish between unstaged and normalized, split construct, validate and stage steps. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342553 (https://phabricator.wikimedia.org/T159910) (owner: Awight) [23:21:22] ejegg: I think I might be at the end of the line in terms of what it is worth figuring out wrt the addresses overwritten by blanks… https://gerrit.wikimedia.org/r/#/c/342554/13/sites/all/modules/wmf_civicrm/update_restore_addresses.php [23:21:57] it's down to around 2000 complicated ones - e.g that have been through multiple merges [23:22:36] so, the original address record was associated with one ancestor of the merged contact [23:23:06] and there are a bunch of other deleted previous address records associated with other deleted contacts [23:23:21] yeah, that sounds ugly [23:23:47] so, this is one example, has been through multiple merges & brought the address…. [23:23:47] civicrm/contact/view?reset=1&cid=141577 [23:24:18] most of the ones I have spot checked of the remaining are like that - i.e. they do actually have an address as well as the blank one [23:25:15] I have some precautions in the script to try to avoid the more complex ones [23:25:46] it's worth noting that the major gifts ones should in theory be less affected as they would be manually merged if there were an address conflict [23:26:04] ah, that's a plus! [23:28:49] I'm in 2 minds about restoring the address table & re-running all updates. It would be nice to run through again, but it took forever! [23:28:56] hence I have put in a drush job [23:30:24] ie it will need to run in batches.... [23:42:44] (PS3) Ejegg: Stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) [23:46:56] whew, those comments are absolutely essential [23:48:41] off to dinner, back later! [23:50:45] (CR) Awight: [C: -1] "Great ideas! Just one typo to correct." (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) (owner: Ejegg) [23:52:43] (PS4) Awight: Stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) (owner: Ejegg) [23:52:48] (CR) Awight: [C: 2] Stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) (owner: Ejegg) [23:55:26] (CR) jerkins-bot: [V: -1] Stop denormalizing paypal recurring messages in audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/342693 (https://phabricator.wikimedia.org/T160138) (owner: Ejegg) [23:55:30] gtg, grarr