[12:27:50] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#3114172 (JAllemandou) Hi @Jseddon , We setup a (non-production) near-realtime job a while ago indeed. Couple of weeks ago, we upgraded our cluster... [15:50:35] dstrine I'll be a few minutes late to the tech priorities meeting, sorry! [15:52:04] ok thanks for the note [16:22:40] (PS2) XenoRyet: Recurring Message Normalization. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) [16:40:06] hi fr-tech! I wasn't able to figure out the memcache expiration thing, and the dutch campaign starts tomorrow. [16:42:02] but I did make a (kinda lame) workaround for the issue: https://gerrit.wikimedia.org/r/342266 [16:42:30] would be really nice to get that up today. Anyone free for review? [16:43:01] i am 3 hours into trying to get puppet to make a simple change [16:43:36] dunno if you saw my email but i am out after tomorrow and feeling extremely swamped with the civi upgrade issue [16:44:13] it seems unwise to be running this campaign if we don't have enough tech resources to make sure it goes smoothly [16:47:12] (CR) Ejegg: [C: -1] "Looking pretty good! Need to account for txn_types besides signup and payment, though!" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [16:50:54] cwd anything I can do to help with the upgrade? [16:51:16] XenoRyet|sorta: any chance you can take a look at https://gerrit.wikimedia.org/r/342266 ? [16:51:34] Yea, I'll take a look. [16:51:37] thanks! [16:52:57] ejegg|meet: i have a list of things [16:53:11] but until i can get puppet to change something it's pretty moot [16:53:22] oof, sounds frustrating [16:53:53] getting and error with a dozen stack overflow posts with zero replies [16:53:55] ejegg|meet: About the paypal patch, the docs seem to only talk about signup and payment as far as the new recurring_ stuff goes. Do you know another place to look to find info on the other types? [16:54:43] XenoRyet|sorta: if you grep the logs for my name in March, you should find a cancellation IPN message [16:54:59] Cool, I'll try that. [17:00:43] fr-tech: Not to mention the fact that most of the good code for PC minix seems [17:00:43] to have been written by Bruce Evans. [17:00:43] -- Linus Torvalds, comp.os.minix, Jan. 1992 [17:00:44] -- discuss. [17:18:56] cwd want to talk out any of the puppet stuff in -talk? [17:19:19] ah i have a meeting with k4 in a minute [17:19:27] i finally got it to work [17:19:32] woohoo! [17:19:36] i removed and remade the certs probably 50 times [17:19:40] and on the 50th time it worked [17:19:55] i didn't do anything different or learn a lesson for next time [17:19:58] k, I'll be available after if you want to talk about more steps [17:20:08] oh jeez, that's annoying [17:20:15] file permissions maybe? [17:20:24] that keeps biting me with my own ssl adventures [17:20:26] pretty sure it's just that puppet is horrible [17:20:29] :( [17:20:33] hi awight ! [17:20:42] SPOF by design [17:21:08] i could have made the change in 30s [17:21:14] XenoRyet|sorta: here's the full list of ipn txn types: https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNandPDTVariables/#id08CTB0S055Z [17:21:16] but took 3 hours to get puppet to do something [17:22:22] looks like 8 different kinds of recurring_ [17:23:38] Hmm... weird that they only talk about the two down where they're saying what messages have which variables. This might take some research. [17:23:40] o/ [17:26:29] (CR) Ejegg: [C: -1] "Bunch of these things could go in var_map to simplify the code" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [17:27:39] ejegg: Do we have var_map in SmashPig? [17:27:52] yeah, just for the paypal messages [17:28:33] cool. I've been daydreaming that we might even use the Transformers paradigm for those normalizations [17:28:48] Certainly no benefit to the SmartRecord pattern [17:29:15] right, so for a lot of the variables, we just map keys [17:29:16] oh ActiveRecord [17:29:50] and the others are specific to a group of txn_types [17:30:44] XenoRyet|sorta: oh hey, we've got all the recurring types listed in SmashPig.yaml already: https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/1fe70c8818a27f30ae02962ed58f8bc984c3b542/SmashPig.yaml#L408 [17:31:38] oh hey, and most of those things I tagged in the last comment are actually already handled by var_map [17:31:44] so you can just delete that code [17:32:27] Are you two thinking that we want to actually parse all those notification types? [17:32:44] we want to get the cancellations in at least [17:33:53] and if we don't want to send along the other types, we should at least remove them from SmashPig.yaml [17:33:58] AndyRussG: hey andy you about? [17:34:38] XenoRyet|sorta / awight I'm in -talk if you want to work this stuff out live! [17:35:06] ah k headed [17:35:46] I'm no good for video right now. Got all manner of chainsaws and other two-stroke tools going on a few meters from my mic right now. [17:48:25] (CR) XenoRyet: [C: 2] "This will do the job." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/342266 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [17:57:08] Seddon: yep I'm here! [17:57:35] AndyRussG: Do you have the centralnotice status code documented somewhere? [17:57:53] Seddon: Yep, in the code. Sending a link, one sec [17:58:34] (Merged) jenkins-bot: Work around Memcache not expiring some things [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/342266 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [17:59:25] Seddon: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/resources/subscribing/ext.centralNotice.display.state.js#L27-L58 [17:59:43] I guess some of the non-obvious reason codes could do with further explanation... Pls lmk if u need more info! [18:01:51] Seddon: the first list are the main status codes (the units) and the reasons are what comes after the decimal point [18:25:37] (CR) Awight: [C: -1] "Can you write this as a new class, to improve testability and separation of responsibility?" (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343417 (owner: Ejegg) [18:31:53] (CR) Ejegg: "Good idea, will do." [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343417 (owner: Ejegg) [18:33:08] (CR) Awight: [C: -1] "Rad, and thanks for the tests!" (4 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [18:40:29] aw dang, yuvi's leaving? [18:43:00] aargh all the people with yu*i names [18:46:39] hehehe [18:55:42] (CR) Ejegg: [C: -1] "Per IRC, the things marked as candidates for var_map are already in there. That code can just be deleted!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [18:56:52] (PS1) Ejegg: Update smashpig lib [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343699 [18:56:56] (CR) Ejegg: [C: 2] Update smashpig lib [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343699 (owner: Ejegg) [19:00:46] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/343703 [19:00:51] (CR) Ejegg: [C: 2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/343703 (owner: Ejegg) [19:08:06] (CR) Cdentinger: Send failmail (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [19:11:23] (PS6) Ejegg: Send failmail [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 [19:13:10] (CR) Ejegg: "fixed a couple of things, nother PS coming" (3 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [19:17:50] (CR) jerkins-bot: [V: -1] Send failmail [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [19:21:00] (PS7) Ejegg: Send failmail [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 [19:26:36] (CR) Ejegg: "more thoughts on at-most-once failmailing" (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [19:29:07] (CR) Ejegg: Send failmail (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [19:30:41] (CR) Ejegg: [V: 2 C: 2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/343703 (owner: Ejegg) [19:36:57] (Merged) jenkins-bot: Update smashpig lib [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343699 (owner: Ejegg) [19:37:07] finally.... [19:41:37] Wikimedia-Fundraising: Remove IE9 specific code from banners once JS is disabled for it - https://phabricator.wikimedia.org/T160945#3115806 (Pcoombe) [19:43:04] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/343732 [19:44:13] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/343732 (owner: Ejegg) [20:07:29] holy zuul backup, batman! [20:09:47] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/343732 (owner: Ejegg) [20:36:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949#3115981 (Ejegg) [20:39:19] cwd: Want to chat tasks? [20:39:28] awight: sure [20:39:40] what i have so far: [20:39:40] what can I do? :) [20:39:43] k [20:39:53] puppet patch for process-control-jobs repo [20:40:01] editable by fr-tech [20:40:23] in there is a bunch of files, all commented out, that show the commands from jenkins [20:40:36] can change them into job.conf format [20:41:06] what i don't have: a way to get process-control onto a live server [20:41:13] oic [20:41:21] okay lemme increase haste on the .deb [20:41:26] I think I'm one file away [20:41:38] there's nothing technically stopping me from adding it as a git repo [20:41:43] but i don't think jeff would be happy with me [20:42:09] What I need in order to work independently: something in fr deployment (or a one-off) can run "cron-generate dir/*.conf > /etc/crontab.d/foo" [20:42:58] ok, i will figure something out for that now [20:43:17] Might be non-trivial cos I haven't figured out the python path fu [20:44:26] awight: doesn't script just pipe out the confs? [20:44:53] and i can redirect that to the spot [20:44:59] yeah so that needs to have permissions somehow [20:45:12] what I mean about paths though is that PYTHONPATH won't include the process-control modules yet [20:45:15] yeah i can take care of that [20:45:19] oh [20:45:33] I can easily write the commandline, but making it work out of the box is going to be fun [20:45:52] what appends to pythonpath now? [20:46:15] I see Jeff brutally hacked /usr/share/slander [20:46:20] nothing does [20:46:41] Usually, python packages are installed to system paths that are already in the search path. [20:47:25] awight: oh, but the cron generator put the full path in there [20:48:00] ah but you mean for the call to cron-generator? [20:48:03] ah right nice, that covers bin/, but PYTHONPATH will still be wrong [20:48:08] that too [20:48:35] Maybe I can solve most of this by writing a setup.py? [20:49:03] awight: i guess i would say, if we are installing a .deb we could symlink to /usr/local/bin [20:52:03] or move it there, either way [21:04:47] getting killed by a thousand cuts [21:04:55] Let's assume I can figure out .deb [21:05:14] What else will we need... [21:06:33] awight: sorry surprise interview [21:08:59] Am I reckless to follow the advice at http://debian-python.readthedocs.io/en/latest/debian-policy.html and only support python 3? [21:10:14] awight: go for it, python3 will be available [21:13:35] Fundraising-Backlog: Thank-you page should report current waiting time until you can expect a receipt - https://phabricator.wikimedia.org/T151981#2834095 (Pcoombe) This is not always accurate though, since some payment methods are dependent on the bank processing time e.g. iDEAL. See T133072 [21:18:50] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, and 6 others: Benevity: Create an import method for matching gifts and payroll deduc... - https://phabricator.wikimedia.org/T115044#1726874 [21:21:23] (PS3) Awight: [WIP] Debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343218 [21:21:25] (PS1) Awight: Create a bin dir [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343761 [21:21:28] (PS1) Awight: Barely functional debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343762 [21:21:35] cwd: k that might be a usable package [21:22:28] awesome [21:22:31] (PS1) Awight: Only run under python3 [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343763 [21:23:04] ah I think we need a top-level package [21:23:16] what does that mean? [21:23:16] btw, setup.py may have taken care of the PYTHONPATH fu [21:23:43] just that I'm exporting modules with names like "lock.py" to /usr/lib/python2.7/dist-packages/ [21:23:46] which just feels rude [21:23:57] oh, yeah [21:27:02] (PS1) Awight: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 [21:27:15] et voila [21:31:23] (PS2) Awight: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 [21:39:46] (CR) Awight: [C: -1] Send failmail (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [21:41:03] (CR) Awight: [C: -1] Send failmail (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [21:42:19] awight: y no CI on here? https://gerrit.wikimedia.org/r/#/c/343761/1 [21:44:40] I think zuul is dead? [21:45:34] Been chugging on a MobileFrontend patch for half an hour. [21:45:41] :( [21:45:55] I do see 434761 later in the queue [21:46:14] you can run "tox" locally though, it's profitable [21:51:20] (PS3) Awight: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 [21:53:03] cwd: k I installed on my box as a .deb and was able to run both scripts successfully. [21:53:13] holler if I can help you wire it into the deployment tool [21:54:05] (PS4) Awight: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 [21:54:07] awight: excellent, thank you [21:54:13] will be off this call shortly [21:54:24] cool--I have a short meeting, will be back in 30 minutes [21:54:39] zuul should be working by then :p [21:54:53] * cwd buys zuul another round [22:07:31] (CR) jerkins-bot: [V: -1] Only run under python3 [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343763 (owner: Awight) [22:17:30] (CR) Ejegg: Send failmail (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [22:18:10] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/343774 [22:18:14] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/343774 (owner: Ejegg) [22:28:56] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/343774 (owner: Ejegg) [22:33:56] cwd: ready to heads-down if you wish [22:34:23] awight: it's my dad's birthday, i have to head there soon [22:34:29] My goal for tomorrow would be that we can deploy one of these crontabs and experiment with it [22:34:33] kk no worries [22:34:39] yeah i think we can for sure [22:35:03] lemme see what i can get done in the next bit, might make a breakthrough with the packaging [22:35:26] which packaging? [22:35:30] I have the .deb working now [22:35:43] yep, just trying to plumb that into our frack packages repo [22:35:52] needs some CR fwiw [22:36:03] yeah, will do that too [22:36:20] i can test in the virtual box [22:37:08] awight: about to deploy DonationInterface. It's got a couple of super-low-risk patches with your name on 'em [22:37:44] https://gerrit.wikimedia.org/r/343732 [22:38:41] not deploying to barium though? [22:38:53] ejegg: Thanks! [22:39:21] cwd: barium only gets DI as a submodule on the CRM repo [22:39:37] yeah [22:39:40] but still [22:39:59] we let it get pretty far behind at times [22:39:59] if there was an [] in there [22:40:03] cool [22:40:48] cwd yeah, keeping this to the upgraded machines! [22:41:21] awight: how did you build the package? [22:41:23] pbuilder? [22:41:32] i have no idea what i'm doing [22:41:57] cwd: I think Jeff has a build_pkg.sh script there [22:42:13] but I've been building with "debuild -us -uc" [22:42:40] you'll probably have to tar the directory to satisfy some stuff: cd .. && tar cjf process-control_0.0.1~rc1.orig.tar.bz2 process-control && cd process-control [22:42:43] "of course" [22:43:41] * cwd winces [22:45:27] !log updated payments-wiki from f991f154d69479e5260267afa88ee29d8049e6be to 9622a4bf331426ce85362e2fdb442f226068e971 [22:45:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:45:42] awight: i may have spoke too soon, don't have python3-all [22:45:45] can probably add [22:46:31] there is a python3 bin...i don't understand the python ecosystem well enough [22:49:03] ooh, warnings about number_format parameters [22:49:07] new? [22:49:23] nope, old [22:54:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix warnings in Amount staging helper - https://phabricator.wikimedia.org/T160962#3116419 (Ejegg) [22:54:37] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix warnings in Amount staging helper - https://phabricator.wikimedia.org/T160962#3116433 (Ejegg) p:Triage>Normal [22:59:30] woot, expiring and retrying after 5 min even [23:03:31] cwd: are you building on a < Jessie system? [23:04:55] cwd: fwiw, python3-all is nothing but: [23:04:56] Depends: python3 (= 3.5.3-1), python3.5 [23:05:02] on my system [23:07:01] awight: it's jessie [23:07:27] Python 3.4.2 [23:07:51] https://packages.debian.org/jessie/python3-all [23:08:16] Donno why there is a recommendation to depend on python3-all and not just python3 [23:09:26] that's not part of the process-control packaging? [23:10:02] hmm? [23:10:11] I do depend on python3-all [23:10:26] You can try just python3 for now, so you can build it, though I think that's not best practice [23:12:24] awight: i'll be damned, it worked [23:12:38] hot dog [23:14:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949#3116471 (Ejegg) [23:16:03] * awight does muted happy dance [23:16:30] cwd: Cool. That gives us a solid foundation to build on. [23:16:35] awight: si [23:16:41] i have to go sing happy birthday now [23:16:44] but i think i have enough to go on [23:16:49] haha right on [23:16:54] i'll be back later and see if i can't wire up a way to deploy [23:16:55] See you tomorrow [23:17:00] :D [23:17:08] so long cwd! [23:17:19] :) [23:25:38] (CR) Awight: [C: -1] Send failmail (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [23:30:56] (CR) Awight: [C: 2] Send failmail (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [23:31:36] ejegg: oops, we're headed for conflict [23:31:48] c.f. my moduleization patch [23:32:14] (CR) Ejegg: Send failmail (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [23:32:54] awight: that globalconfig patch is trivial, don't worry about stepping on it! [23:33:01] (CR) Awight: [C: -1] Global config (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343417 (owner: Ejegg) [23:33:06] I haven't started fixing it [23:33:28] line count is low anyway, conflict is n.b.d. [23:33:50] eileen: will be in meet in 1 min! [23:34:00] cool [23:34:28] (CR) Awight: [C: 2] "Great!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343421 (owner: Ejegg) [23:35:25] (Merged) jenkins-bot: Send failmail [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343365 (owner: Ejegg) [23:35:38] dang, cafenet drowning in molasses [23:36:59] yummm [23:37:56] (PS2) Awight: Create a bin dir [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343761 [23:37:58] (PS4) Awight: [WIP] Debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343218 [23:38:00] (PS2) Awight: Barely functional debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343762 [23:38:02] (PS2) Awight: Only run under python3 [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343763 [23:38:04] (PS5) Awight: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 [23:39:16] (Abandoned) Awight: Barely functional debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343762 (owner: Awight) [23:39:33] (Merged) jenkins-bot: Split out queue tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343421 (owner: Ejegg) [23:40:55] (PS3) Awight: Only run under python3 [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343763 [23:40:57] (PS6) Awight: House modules under a package [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343764 [23:40:59] (PS5) Awight: Debian packaging [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343218 [23:46:13] (PS6) Awight: Integration test that the PayPal legacy gateway shows an error form rather than redirect. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341478 [23:46:15] (PS5) Awight: Form should not validate if manual errors are present [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341592 (https://phabricator.wikimedia.org/T98447) [23:46:17] (PS5) Awight: Remove deprecated function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341721 [23:46:19] (PS6) Awight: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 [23:46:21] (PS3) Awight: Comments and todos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342547 [23:46:23] (PS3) Awight: Correct parameters to wfMessage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342548 [23:46:25] (PS16) Awight: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) [23:47:47] (PS1) Eileen: Attempt to get a few more blanked addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343793 (https://phabricator.wikimedia.org/T159408) [23:50:18] ejegg|meet: Looking at my validation patch again, it actually doesn't have the initial load bug I was describing. [23:50:56] (CR) Ejegg: [C: 2] Attempt to get a few more blanked addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343793 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [23:52:35] * awight resists having second thoughts about tackling error encapsulation next [23:52:45] awight: k, lemme look. I know we'll hit the validation with paypal gws since they're isProcessImmediate [23:52:57] Right [23:54:31] ooh. and I was wrong to be so cavalier about solving the fallback currency edge cases [23:54:49] just want to check we get appropriate messages for ingenico with no amount or too little [23:54:55] cos of the problems we discussed last week, we need access to the error messages and stuff [23:54:56] on the query string [23:55:31] or a different place to stash info messages that aren't validation errors [23:55:41] (Merged) jenkins-bot: Attempt to get a few more blanked addresses. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/343793 (https://phabricator.wikimedia.org/T159408) (owner: Eileen) [23:57:18] awight: ah phooey, amount too low shows obnoxious red complaints for every field [23:57:32] in ingenico [23:57:37] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343794 [23:57:52] doublechecking existing behavior [23:58:13] ejegg: I will include 'Detect normalized paypal messages in queue consumer [23:58:14] ' in the deploy - is that OK [23:58:31] eileen: errr, do you mind cherry-picking? [23:58:36] glargh [23:58:46] ejegg: ok [23:58:50] thanks! [23:59:32] (PS1) Awight: [WIP] Perform currency fallback earlier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343795 [23:59:34] awight: yeah, current code doesn't do that [23:59:35] (PS1) Eileen: Attempt to get a few more blanked addresses. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343796 (https://phabricator.wikimedia.org/T159408) [23:59:45] ejegg: OK, thanks for the catch, I'll write a unit test [23:59:50] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/343794 (owner: Eileen)