[00:00:26] Alright, I'm off for the evening as well. See you folks tomorrow. [00:08:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] new round of common dedupe conflicts - https://phabricator.wikimedia.org/T153019#3120408 (Eileenmcnaughton) [00:08:26] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising-Backlog, and 3 others: Stop creating addresses N0NE Provided & delete them where we have them - https://phabricator.wikimedia.org/T158268#3031850 (Eileenmcnaughton) Open>R... [00:16:48] Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Revert updates that set valid addresses to blank, and have no further actions against them - https://phabricator.wikimedia.org/T159408#3120438 (Eileenmcnaughto... [00:16:50] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What should we do to fix data where blank addresses have overwritten valid addresses - https://phabricator.wikimedia.org/T153917#3120439 (Eileenmcnaughton) [00:17:01] (PS3) Awight: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 [00:17:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] new round of common dedupe conflicts - https://phabricator.wikimedia.org/T153019#3120441 (Eileenmcnaughton) [00:17:04] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising-Backlog, and 2 others: We still have contacts whose merge is blocked on mis-rounded geocodes - https://phabricator.wikimedia.org/T158271#3120440 (Eileenmcnaughton) Open>Re... [00:40:49] (CR) jerkins-bot: [V: -1] [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [02:31:41] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface: iDEAL bank lookup should also cache failures - https://phabricator.wikimedia.org/T161072#3120623 (Ejegg) [02:37:03] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle attempts to donate via iDEAL in unsupported currencies - https://phabricator.wikimedia.org/T161073#3120639 (Ejegg) [10:51:02] (CR) Hashar: "recheck" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [10:53:32] (CR) Hashar: "recheck" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/333823 (owner: Ejegg) [13:06:43] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising-Backlog, and 5 others: Mediawiki namespace pages, including CentralNotice banners, are slow to save - https://phabricator.wikimedia.org/T158084#3026116 (hashar) Typo fixed `Exter... [13:08:37] 1234 [16:13:46] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Smashpig: Need to distinguish between paypal and paypal_ec for refund IPN messages - https://phabricator.wikimedia.org/T161121#3122221 (Ejegg) [16:17:18] (PS5) Ejegg: Recurring Message Normalization. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [16:17:57] (CR) Ejegg: "todo for a future patch ( https://phabricator.wikimedia.org/T161121 )" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [16:19:01] (CR) Ejegg: [C: 2] "Looks like this should do the trick!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [16:22:26] (Merged) jenkins-bot: Recurring Message Normalization. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/343324 (https://phabricator.wikimedia.org/T157074) (owner: XenoRyet) [17:00:43] fr-tech: Does a good farmer neglect a crop he has planted? [17:00:43] Does a good teacher overlook even the most humble student? [17:00:43] Does a good father allow a single child to starve? [17:00:43] Does a good programmer refuse to maintain his code? [17:00:43] -- Geoffrey James, "The Tao of Programming" [17:00:44] -- discuss. [17:08:07] fr-tech I'm in -talk [17:15:23] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Smashpig: Need to distinguish between paypal and paypal_ec for refund IPN messages - https://phabricator.wikimedia.org/T161121#3122433 (Ejegg) Dang, for one-time payments, the refund IPN messages have all the same fields. The only clear distinction i... [17:28:39] Yeah that was a compelling robo-call to action [18:18:26] (PS1) Awight: stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 [18:20:21] (CR) Ejegg: [C: 2] stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [18:20:31] o hey thanks! [18:20:51] ejegg: I'll keep my eyes peeled for the path hack :) [18:20:54] (CR) jerkins-bot: [V: -1] stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [18:21:14] (CR) jerkins-bot: [V: -1] stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [18:22:22] yipes. right, lemme fix that [18:22:45] oop! [18:24:13] Now that I've edited all the .yamls, I'm thinking we made the wrong call [18:24:45] and should perhaps have a default stdout_destination /var/log/process-control/.log [18:25:47] ejegg: hmm, I'm running into default_job_config problems in the tests [18:25:54] awight: oh? [18:28:42] (PS4) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [18:28:55] now with /usr/bin/run-job ^^ [18:29:43] missing key or something? [18:30:12] (CR) jerkins-bot: [V: -1] Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [18:33:12] (PS5) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [18:33:36] (CR) jerkins-bot: [V: -1] Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [18:34:13] still? [18:34:43] oright, flake8 [18:35:27] (PS6) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [18:36:02] (CR) jerkins-bot: [V: -1] Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [18:36:57] (PS7) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [18:38:08] XenoRyet: are you following along with this process-control stuff? [18:38:36] Still early days, the scripts could use plenty of scrutiny! [18:38:45] Only a little. I could try to catch up some. [18:38:59] want to livechat? [18:39:15] I'll hop in the -talk hangout [18:39:37] Yea, give me a minute or two and I'll hop on. [18:39:52] rockin [18:41:04] (PS2) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [18:43:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: for JS linting, switch from jshint+jscs to eslint - https://phabricator.wikimedia.org/T161142#3122784 (AndyRussG) [18:44:38] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [18:45:55] (PS3) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [18:49:30] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [18:49:50] Aaarg [18:52:54] ejegg: Hangout died on me. Be right back. [19:08:20] (PS4) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [19:14:04] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [19:18:18] (PS5) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [19:26:23] c'mon jenkinzzz [19:28:35] XenoRyet: sorry, I seem to be booted from hangout [19:29:13] anyway, take a look at the test_ files in the tests dir and let me know if you have any questions [19:29:41] No worries. Yea, will do. I think that was enough of an interduction that I can just start pulling on stuff and figure it out. [19:29:49] those @patch annotations are really powerful, letting you mock things even when they're not provided with dependency injection [19:31:00] good times [19:34:06] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [19:35:37] Not again!!!! Rrrg [19:37:00] (PS2) Awight: stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 [19:37:02] (PS1) Awight: More cron syntax checks [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 [19:38:03] (PS6) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [19:38:36] (CR) Awight: [C: -1] "Security suggestion..." (3 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [19:45:15] (PS8) Ejegg: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 [19:45:25] (CR) Awight: Comments and cleanup for config (5 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344057 (owner: Ejegg) [19:59:49] (CR) Ejegg: [C: -1] "I don't think we want it in default_job_config or we'll end up with the same bad behavior" (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [20:17:20] AndyRussG: weird cos the link in the email says > Use the new prompt to browse the bvfs (bacula virtual filesystem) if file metadata has not been expired from the database. Standard ls, cd commands apply. mark the files/dirs you want restored. If you specified a date old enough you will not be able to browse and you will have to restore the entire fileset [20:18:32] awight: huh... I haven't looked at it all, since it's stuff I'm completely unfamiliar with... If you have comments/suggestions, though, I think that's fantastic :) [20:19:11] hehe yeah on second thought let me not be involved ;) [20:19:45] Fundraising-Backlog, FR-Smashpig: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3123126 (Ejegg) [20:21:29] (CR) Awight: stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [20:24:06] (CR) Awight: stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [20:38:16] Fundraising-Backlog: process-control should save a log file per job run - https://phabricator.wikimedia.org/T161155#3123198 (awight) [20:44:15] (PS3) Awight: stdout_destination is required. You'll have to say "/dev/null" out loud if you want it. [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 [20:52:11] !log disabling Ingenico orphan rectifier [20:52:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:17:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: for JS linting, switch from jshint+jscs to eslint - https://phabricator.wikimedia.org/T161142#3123289 (Krinkle) [21:25:12] !log reenabling Jenkins orphan rectifier job [21:25:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:31:46] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Orphan rectifier is silent about communication failures - https://phabricator.wikimedia.org/T161160#3123331 (awight) [21:34:11] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Orphan rectifier is silent about communication failures - https://phabricator.wikimedia.org/T161160#3123349 (awight) ``` 21:31:46 X Rectifying orphan: X 21:31:46 WD DonationInterface: orphans:globalcollect_gateway_trxn:... [21:52:24] (CR) Ejegg: "still devnulling in process-control.yaml defaults" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [21:56:31] Fundraising Sprint Far Beer, Fundraising-Backlog, FR-Smashpig, Unplanned-Sprint-Work: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3123403 (Ejegg) a:Ejegg [21:59:55] (CR) Awight: Move some things into global config (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [22:00:19] ejegg: I'm happy to merge this and we can make tweaks in followons, as you wish [22:00:55] k, sounds good! [22:01:20] (CR) Awight: [C: 2] Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [22:01:54] ejegg: My comments on https://gerrit.wikimedia.org/r/#/c/344057/1 are all TODOs also, so I'll merge that [22:01:55] (Merged) jenkins-bot: Move some things into global config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344046 (owner: Ejegg) [22:01:57] (CR) Awight: [C: 2] Comments and cleanup for config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344057 (owner: Ejegg) [22:02:16] (PS2) Awight: Comments and cleanup for config [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344057 (owner: Ejegg) [22:05:32] (PS4) Awight: [WIP] Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 [22:06:27] (CR) jerkins-bot: [V: -1] [WIP] Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (owner: Awight) [22:08:55] hmm, iDEAL listener is not necessarily ingenico-specific [22:09:13] cool! [22:09:14] but the ingenico provider will want to read any cached outage information [22:09:42] maybe outage cache key goes in the default config node? [22:09:45] Smashpig does have a database... [22:09:47] seems odd [22:09:54] hehe, right [22:10:30] ah, oops, designflaw [22:10:36] hmm [22:10:40] we need this info on payments machines [22:10:46] oh [22:10:56] and they're not going to be listening for XML [22:11:00] * awight irks at thinking of API communication from payments to HQ [22:11:27] hmph [22:11:33] Is there anything else like this? I guess currency rates but we aren't treating them right [22:12:15] not that I can think of [22:13:24] dangit! [22:14:14] oh right--it's not allowed [22:14:22] right [22:14:32] Only the deployment machine can send data, and that can't come from an automatic process [22:14:36] or something? [22:14:43] something like that [22:14:46] well, if we knew ahead of time it might work [22:15:09] that XML doesn't have begin/end timestamps tho [22:15:12] I wonder when the push service notifies? [22:15:13] yeah [22:15:20] that's sort of appalling [22:15:33] write-only mindset [22:15:46] Maybe we could tug their coat about this [22:16:23] I just pointed our Ingenico contact at the XML subscription [22:16:32] would be awesome if they could incorporate that info [22:16:43] in the directory results [22:18:06] damn, this seemed so easy for a sec [22:20:28] Nasty. I removed application default config but added validation at the same time, so tests need their own global config [22:20:54] hmm [22:21:15] where to configure the global config path? [22:21:49] We do need that, cos /etc/fundraising is not for everyone [22:22:18] environment var ??? [22:22:30] It always comes down to this ;) [22:24:10] ah again, we have security concerns and can't let the config file be specified [22:24:34] * awight goes back to mock.patching GlobalConfiguration [22:24:55] eww, for every test? [22:26:19] so... PCI can't actually dictate that no info imparted by IPNs is allowed to get to the webservers that host payment forms [22:26:23] Maybe tox can help us [22:26:49] No PCI can't, but we'll have to move everything after human review? [22:26:53] I wonder [22:27:06] that seems like a thing people generally want to have, especially if they're selling things [22:27:57] Probably why the actual payment page is often hosted on a machine that doesn't have CRM etc [22:31:20] undocumented api, anyone? http://availability.ideal.nl/api/api/GetHistoryData?bankName=Knab&daysAgo=0&isMobile=false [22:31:28] :P [22:31:49] O_O [22:32:01] I hope you're outside their jurisdiction [22:32:05] hehehe [22:32:21] That looks like exceptionally useless data, too [22:32:26] math? [22:32:41] it's for a graph [22:32:49] but I bet there are more useful endpoints! [22:33:02] An api for very difficult linear algebra in two variables :) [22:33:27] jackpot: http://availability.ideal.nl/api/api/GetIssuers [22:33:38] Oh sit [22:33:44] bankids and everything :) [22:33:45] AllGreen: true [22:34:30] We could really use the scheduled downtime one, too [22:34:57] "LastUpdate" hey this is downright helpful [22:35:46] whoa, /me listens to oingo boingo for the first time since early childhood [22:39:37] oh hey, weev's conviction was vacated [22:39:58] That sounds like deep bio [22:40:27] that was the '3 years for a bunch of GETs to apple's activation URLs' case [22:40:40] oh, AT&T's activation URLs [22:41:34] saucy! Disproportionate :( [22:43:31] User-Agent: Please_don't_sue_us [23:01:02] (PS5) Awight: Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 [23:01:05] ejegg: I think that's ready for a peek ^ [23:02:07] ejegg: Hey, can I get rid of inline config default= in code? [23:02:32] sure, go ahead [23:03:02] ah nuts I was deceived by the tape insert [23:04:41] (PS1) Awight: Remove unused config inline defaults [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344260 [23:04:47] so, great tape was not oingo boingo [23:05:47] Still at 100% coverage :D [23:05:48] nosetests --with-coverage --cover-html --cover-package=processcontrol [23:06:37] (PS6) Awight: Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (https://phabricator.wikimedia.org/T161155) [23:06:39] (PS2) Awight: Remove unused config inline defaults [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344260 [23:08:32] :) warm fuzzy blanket of test coverage [23:08:53] It makes it more fun to play with a camp stove in bed [23:10:20] awight: output_directory is not overridable per job? [23:10:26] naw [23:10:28] k [23:10:44] It gets pretty messy, I don't know that we'll like this [23:10:55] Think we should have a dir per job? [23:11:03] grepping is going to be slow, too [23:11:20] shell collecting */* probably takes longer than grepping a few big files [23:11:39] ls /tmp/*.log | wc [23:11:39] 52 130 1895 [23:11:48] dir per job seems right [23:11:54] kk [23:17:11] nice, a little LP skipping on this tape [23:17:27] retro within a retro [23:18:46] (PS3) Awight: Remove unused config inline defaults [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344260 [23:18:48] (PS7) Awight: Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (https://phabricator.wikimedia.org/T161155) [23:18:56] dir per job is done [23:19:14] <3 anything but PHP sometimes [23:21:31] dang. ABC - Beauty Stab [23:22:03] rockin! the rest looked great [23:24:38] rest of what? [23:27:42] (CR) Ejegg: "Thanks for the config cleanup!" (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (https://phabricator.wikimedia.org/T161155) (owner: Awight) [23:29:11] cool, travis-ci just caught a py3 error [23:30:21] (PS8) Awight: Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (https://phabricator.wikimedia.org/T161155) [23:32:42] (PS1) Ejegg: Hack to get availability straight from iDEAL [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344272 (https://phabricator.wikimedia.org/T161153) [23:33:01] (PS2) Awight: More cron syntax checks [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 [23:33:09] gotta leave the library, seeya in a bit