[00:00:28] (PS1) Awight: Copy example configuration to docs during install [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344273 [00:05:44] ejegg|afk: Are you messing with the Ingenico GET_DIRECTORY or is that just how awesome the service is? [00:12:10] That endpoint has it all! [00:14:28] Would you like a plate of fail with that graph of a straight line? [00:16:05] ejegg: Found a fun wart: we were relying on shell to set environment variables, so those need to be specified in the job files [00:16:31] ooh, good catch [00:16:49] does subprocess handle those nicely ? [00:17:24] yep, looks like we pass a hash [00:18:09] env=, cool [00:21:34] (PS1) Awight: Pass environment variables to the subprocess [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344279 [00:21:41] gtg, see you tomorrow! [00:22:46] seeya [01:57:42] (PS7) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [11:07:52] Fundraising-Backlog, Analytics-Kanban, Patch-For-Review: Productionize banner impressions druid/pivot dataset - https://phabricator.wikimedia.org/T155141#3124560 (JAllemandou) @Jseddon : near-realtime job restarted successfully, enjoy your goodie ;) [14:37:08] (CR) Ejegg: [C: 2] Remove unused config inline defaults [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344260 (owner: Awight) [14:38:25] (Merged) jenkins-bot: Remove unused config inline defaults [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344260 (owner: Awight) [14:44:11] holler from somerville [14:49:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface, and 2 others: Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3125276 (hashar) [14:57:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface, and 2 others: Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3125297 (hashar) [15:01:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface, and 2 others: Disable fundraising CI jobs that are non-voting and always fail - https://phabricator.wikimedia.org/T160476#3125303 (hashar) Open>Resolved a:hashar All done. mwext-d... [15:30:12] hi cwd|afk ! [15:32:19] (CR) Ejegg: [C: 2] Introducing output_directory, where we save a file per run (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (https://phabricator.wikimedia.org/T161155) (owner: Awight) [15:32:55] (Merged) jenkins-bot: Introducing output_directory, where we save a file per run [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344181 (https://phabricator.wikimedia.org/T161155) (owner: Awight) [15:38:39] (CR) Ejegg: [C: -1] "We shouldn't need to ban % signs" (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 (owner: Awight) [16:24:55] (PS2) Ejegg: Hack to get availability straight from iDEAL [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344272 (https://phabricator.wikimedia.org/T161153) [16:25:16] fr-tech anyone want to look at this hack? ^^^ [16:25:47] It'll get us all the bank names, codes, and availability straight from iDEAL's servers [16:26:17] but... it's not an official API, just a thing they use to build this page: http://availability.ideal.nl/ [16:27:16] Tricksy. Yea, I'll take a look. [16:30:23] ejegg: Did you figure out what the percentage actually means? [16:30:47] XenoRyet: same as the emails, I guess [16:31:00] trying to use that bank works about that much of the time [16:31:13] Well, there you go I guess. [16:35:09] Fundraising Sprint Far Beer, Fundraising-Backlog, FR-Smashpig, Patch-For-Review, Unplanned-Sprint-Work: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3125506 (Ejegg) This idea doesn't quite work - we need the outage information on the payments servers, but they w... [16:35:48] (CR) Ejegg: [C: 2] Copy example configuration to docs during install [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344273 (owner: Awight) [16:41:30] ejegg: So what happens if that site just up and disappears? Empty bank list? [16:43:16] (CR) Ejegg: [C: -1] "When not specified, let's stick with the default (inheriting parent env) rather than clearing out everything. Maybe even add specified var" (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344279 (owner: Awight) [16:45:46] XenoRyet: if it's a 404, the SmashPig lib call with throw an exception [16:46:02] and the DonationInterface logic catches that and uses the hardcoded list [16:46:15] Good times, that sounds right and proper. [16:46:33] Well, cool. Looks good to me then. [16:47:10] Or as good as an unofficial api can look, I suppose. [16:47:18] hehe, great! [16:49:15] (CR) XenoRyet: [C: 2] "All the cautions about using unofficial and undocumented APIs apply, but looks like this will do the job until we get official support." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344272 (https://phabricator.wikimedia.org/T161153) (owner: Ejegg) [16:51:05] (Merged) jenkins-bot: Hack to get availability straight from iDEAL [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344272 (https://phabricator.wikimedia.org/T161153) (owner: Ejegg) [17:00:43] fr-tech: Everyone knows that dragons don't exist. But while this simplistic [17:00:43] formulation may satisfy the layman, it does not suffice for the [17:00:43] scientific mind. The School of Higher Neantical Nillity is in fact [17:00:43] wholly unconcerned with what _d_o_e_s exist. Indeed, the banality of [17:00:44] existence has been so amply demonstrated, there is no need for us to [17:00:44] discuss it any further here. The brilliant Cerebron, attacking the [17:00:44] problem analytically, discovered three distinct kinds of dragon: the [17:00:45] mythical, the chimerical, and the purely hypothetical. They were all, [17:00:45] one might say, nonexistent, but each nonexisted in an entirely [17:00:46] different way ... [17:00:46] -- Stanislaw Lem, "Cyberiad" [17:00:47] -- discuss. [17:06:46] slander: good one today, yah! [17:08:43] nice [17:08:56] Lem is so fun [17:11:44] hehe--Borges has a similar rant in the Encyclopedia of Imaginary Beings, where he points out that the chimera has been imagined in so many different ways that it doesn't even bring to mind an imaginary image any more, but just its unimaginability [17:11:51] (PS1) Ejegg: Headers default to empty array, not null [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344430 [17:12:10] XenoRyet: oops, I need one little fix more ^^^ [17:12:17] (single line) [17:12:17] looking [17:12:20] thanks! [17:12:47] err, and 3 lines of whitespace [17:12:48] * AndyRussG hypothetically daydreams about the hypothetical [17:13:02] (CR) XenoRyet: [C: 2] Headers default to empty array, not null [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344430 (owner: Ejegg) [17:13:10] ty [17:13:13] No worries [17:13:40] (CR) Awight: More cron syntax checks (1 comment) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 (owner: Awight) [17:14:25] (Merged) jenkins-bot: Headers default to empty array, not null [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344430 (owner: Ejegg) [17:14:28] (PS3) Awight: More cron syntax checks [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 [17:15:21] (PS2) Awight: Use argparse to read the CLI; cron-generate is flaggy rather than pipey [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343960 [17:16:20] fr-tech-talk? [17:17:46] awight: hey I'm gonna keep hiding... heads-down banner sequence feels like it'd most productive for me todey... apologies and thanks 4 understanding! [17:17:56] kk [17:19:02] (PS3) Awight: Use argparse to read the CLI; cron-generate is flaggy rather than pipey [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343960 [17:19:04] (PS2) Awight: Fixes suggested by thcipriani [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343965 [17:26:20] awight: I'm in the hangout [17:27:19] ejegg: aww sorry, I have a chat with K4 in 3 minutes [17:29:24] no worries [17:29:49] (CR) Awight: "Oh wow, thanks for looking up the details." [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344279 (owner: Awight) [17:30:59] (CR) Ejegg: [C: 2] More cron syntax checks [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 (owner: Awight) [17:32:45] (Merged) jenkins-bot: More cron syntax checks [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344189 (owner: Awight) [18:14:53] (PS1) Ejegg: Update SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344453 [18:16:56] (CR) Ejegg: [C: 2] Update SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344453 (owner: Ejegg) [18:18:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Security-General, Spike: Spike: Is the Verisign seal even PCI compliant? - https://phabricator.wikimedia.org/T140318#3125837 (Jgreen) [18:19:16] (PS1) Ejegg: Update SmashPig lib [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/344454 [18:22:59] (CR) Ejegg: [V: 2 C: 2] Update SmashPig lib [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/344454 (owner: Ejegg) [18:23:57] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344455 [18:25:25] (Merged) jenkins-bot: Update SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344453 (owner: Ejegg) [18:26:36] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344455 (owner: Ejegg) [18:40:34] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344455 (owner: Ejegg) [19:08:23] hm, hangout only ? [19:30:17] You were hoping for teleporation? [19:47:12] (PS2) Awight: Copy example configuration to docs during install [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344273 [19:47:13] librarynet is being difficult [19:47:16] one moment [19:47:58] (PS4) Awight: Use argparse to read the CLI; cron-generate is flaggy rather than pipey [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343960 [20:19:24] (PS2) Awight: Pass environment variables to the subprocess [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344279 [20:21:01] awight do we want shell=True so we can glob things, like for moving audit files? [20:26:19] ejegg: I don't think so, we probably want maximum determinism [20:26:28] What did you think about my env={} comment? [20:26:49] It was accidental, but in retrospect I think we might want that behavior. [20:27:14] (CR) Ejegg: [C: 2] "OK, so long as it's intentional!" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344279 (owner: Awight) [20:28:21] oops! I was gonna read some more--fine though, we can revert if that turns out to be wrong [20:29:14] oops [20:30:13] huh, I'm seeing that #!/usr/bin/env is just to search PATH for your binary [20:30:18] not to clear out the environment vars [20:31:35] yep, hashbang compatibility for funky layouts I guess [20:33:57] ufff, git fetch in the mediawiki repo is taking ages. [20:37:57] (Merged) jenkins-bot: Pass environment variables to the subprocess [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344279 (owner: Awight) [20:38:46] (PS5) Awight: Use argparse to read the CLI; cron-generate is flaggy rather than pipey [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343960 [20:38:47] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/344497 [20:38:52] (PS3) Awight: Fixes suggested by thcipriani [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343965 [20:38:57] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/344497 (owner: Ejegg) [20:46:18] (PS1) Awight: run-job option flag is required now [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344499 [20:46:41] (CR) jerkins-bot: [V: -1] run-job option flag is required now [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344499 (owner: Awight) [20:49:25] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/344497 (owner: Ejegg) [20:51:52] (PS2) Awight: run-job option flag is required now [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344499 [20:52:23] ok, trying out the new deployment code [20:52:44] Jeff_Green: available to help recover just in case? [20:53:11] ejegg if you do it really quick, I gotta go in a minute [20:53:36] just ran update, about to rsync [20:53:54] cool [20:54:30] the main thing I worry about a little is the "remove this file?" thing, if you see that and it's obviously making a bad call just say "no" and it will continue as normal [20:54:40] ok [20:54:58] that takes localsettings tweezes into account, right? [20:55:02] yes [20:56:13] (PS1) Awight: Test for environment parameter [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344501 [20:56:37] * Jeff_Green going! ejegg SMS me if it becomes dire. I'll bring my laptop [20:56:38] oh huh, there are a bunch of untracked files [20:56:51] ok, just say 'n' [20:56:51] , thanks Jeff_Green [20:57:15] email the list or something so I can investigate later [21:00:28] !log updated payments from 9622a4bf331426ce85362e2fdb442f226068e971 to bb956bf1ea7f0c7a9b08877cce7f25b201bd2bbf [21:00:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:01:09] revertin... [21:05:37] !log rolled back payments-wiki to 9622a4bf331426ce85362e2fdb442f226068e971 [21:05:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:19:33] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Orphan rectifier is silent about communication failures - https://phabricator.wikimedia.org/T161160#3126631 (awight) I just noticed that the error is likely related to my recent upheaval of DI code: `Failed data validation` Th... [21:33:40] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Orphan rectifier is silent about communication failures - https://phabricator.wikimedia.org/T161160#3123331 (Ejegg) Some of the issues are because we're trying to rectify iDEAL donors. We shouldn't do that! [21:41:51] Fundraising-Backlog, FR-Smashpig: SmashPig pending db pruner is broken - https://phabricator.wikimedia.org/T161260#3126774 (awight) [21:46:17] Fundraising-Backlog, FR-Smashpig: SmashPig pending db pruner is broken - https://phabricator.wikimedia.org/T161260#3126774 (Ejegg) Most are paypal. There's a Jenkins config that should be pruning paypal messages after 14 days, but it's possible I screwed up the config matrix. [22:01:03] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344541 [22:01:04] (PS1) Awight: Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344542 (https://phabricator.wikimedia.org/T161160) [22:01:09] (CR) jerkins-bot: [V: -1] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344541 (owner: Awight) [22:01:11] (CR) jerkins-bot: [V: -1] Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/344542 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [22:02:39] (PS1) Awight: Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) [22:05:19] (CR) jerkins-bot: [V: -1] Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [22:05:34] aww shucks [22:05:47] ?? [22:05:53] oh, dear [22:05:59] what now? [22:06:30] glad to see tests actually covered the lines I changed, tho [22:07:15] oho, bad test data! [22:07:58] (PS2) Awight: Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) [22:09:43] (PS1) Awight: [HOTFIX] Patch orphan rectifier to drop non-cc records [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/344552 (https://phabricator.wikimedia.org/T161160) [22:09:51] (CR) jerkins-bot: [V: -1] Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [22:10:36] jerkins-bot: Say that to my face [22:13:28] wtf, how's that happening? [22:13:36] I'm running locally to find out [22:13:39] (CR) jerkins-bot: [V: -1] [HOTFIX] Patch orphan rectifier to drop non-cc records [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/344552 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [22:13:59] hehe that's even weirder ^ [22:14:20] dumb phplint [22:14:30] yep [22:16:14] k I can reproduce locally [22:23:24] d'argh, my box isn't syslogging during unit tests [22:25:17] vagrant? [22:26:12] aw shucks, I was hoping the error was that we didn't accept Mastercard here [22:26:15] ahhh, snap, unit tests hijack the logger [22:26:17] good call, I'll head there [22:26:28] I swear I've seen logging during our tests [22:26:35] on my other dev box [22:26:36] who knows [22:27:22] sigh. kernel module woes [22:28:14] lmao [22:28:14] ./arch/x86/include/asm/realmode.h:66:9: error: implicit declaration of function ‘ALIGN’ [-Werror=i [22:28:22] ok. So PHPStorm [22:28:37] no. printfs [22:29:54] ?? [22:31:03] https://sd.keepcalm-o-matic.co.uk/i/keep-calm-and-printf-debugging.png [22:32:30] what the heck man [22:32:38] How was this test ever passing... [22:33:18] I think validation was short-circuited by the missing payment_method! [22:34:46] (PS3) Awight: Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) [22:37:03] (CR) jerkins-bot: [V: -1] Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [22:37:15] More exciting error that time. [22:38:02] XenoRyet: are you following this stuff? [22:38:24] Can you do some CR if I have to leave in 20 min? [22:38:32] Just out of the corner of my eye. [22:38:49] Yea, I'll be around for a while, but I have a hard out at 5:00 [22:39:24] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Missing payment_method in gateway page URLs is really confusing - https://phabricator.wikimedia.org/T160968#3127023 (awight) See also T140269 [22:40:20] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Missing payment_method in gateway page URLs is really confusing - https://phabricator.wikimedia.org/T160968#3127025 (awight) In another interesting twist, the fact that we aren't validating that payment_method isn't empty is masking an unknown... [22:40:30] ejegg: I'm ready to deploy it like this. [22:40:49] I don't think the remaining error is related to my patch [22:41:23] What I believe happened is that once I added payment_method to the test data, other method-based validations kicked in. [22:42:32] I have to leave in < 1hr actually, so maybe it's imprudent to deploy at all. [22:42:42] sure, I'm fine with the vendor patch [22:42:47] oh huh [22:43:01] hard deadline at the kid's school [22:43:12] That's me as well, I'm on solo parent night. [22:43:12] i can pick this up early tomorrow [22:43:38] Thanks! [22:43:47] I'll try to fix the test nonsense, at least. [22:44:37] Yeah probably best to not rush this out late tonight cos the side-effects could be subtle and would require MBeat to detect [22:44:52] MBeat: heads-up that we're probably going to leave the orphan rectifier buggy until tomorrow AM [22:44:58] cool, thanks gents [22:45:01] especially with newdeploytools [22:45:05] right right [22:46:11] well, sounds like the national team beat bolivia, at least :) [22:46:31] hehe I never know if the streets are safer after a win or a loss [22:46:35] so no grumpy colombianos tonight [22:48:08] oh good, the team colors are exactly the same so that shouldn't be a risk factor [22:49:11] huh, guess away jerseys is why locals are wearing different versions? [22:53:15] we were totally not exercising the whole cc code path [22:53:39] e.g. post_process_get_orderstatus if $method == 'cc' [22:54:14] ooh. only under orphan tho, right? [22:54:54] yeah--and only under this crap test I wrote [22:56:38] k, I need to go meet someone for dinner [22:56:48] later, all! [22:56:58] bubye [22:57:29] hahaha it was triggering an email domain fraud rule [22:58:09] (PS4) Awight: Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) [23:04:42] I'm gonna wander around with a shell-shocked look and then go home [23:04:45] see ya! [23:09:16] I'm out for the day too.