[16:31:52] (CR) Ejegg: [V: 2 C: 2] [HOTFIX] Patch orphan rectifier to drop non-cc records [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/344552 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [16:35:34] (CR) jerkins-bot: [V: -1] [HOTFIX] Patch orphan rectifier to drop non-cc records [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/344552 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [16:47:32] (PS1) Ejegg: Pull in orphan rectifier hotfix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/344654 [16:47:34] (CR) Ejegg: [C: 2] Pull in orphan rectifier hotfix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/344654 (owner: Ejegg) [16:47:51] (Merged) jenkins-bot: Pull in orphan rectifier hotfix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/344654 (owner: Ejegg) [17:00:43] fr-tech: Reality is for people who lack imagination. [17:00:43] -- discuss. [17:01:09] slander: interesting, but false! [17:13:38] (maybe slander doesn't care, 'cause its caught up in posmodern nihilismz) [17:14:52] (CR) Ejegg: [C: 2] Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [17:15:59] AndyRussG: between this and the sexist comments, slander's sounding too much like the current US gov [17:17:50] hehehe [17:18:31] (Merged) jenkins-bot: Patch orphan rectifier to drop non-cc records [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344545 (https://phabricator.wikimedia.org/T161160) (owner: Awight) [17:18:49] ejegg: indeed... what has the world come to? [17:30:26] (PS8) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [17:36:14] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [17:43:03] aaaaaaaahhrrrmmfff [17:43:30] jenkins the linter of javascript goo [17:45:49] (PS9) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [17:46:08] I should probably figure out how to run that locally [17:50:59] (CR) jerkins-bot: [V: -1] [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (owner: AndyRussG) [17:51:41] AndyRussG: npm install; npm test seems to work! [17:54:37] oh it's that easy? [17:55:15] seems so! [17:55:51] ejegg: fwiw do you happen to know if T161142 is trivial? Is it just a matter of switching the config file, or is there more setup/CI config? [17:55:51] T161142: CentralNotice: for JS linting, switch from jshint+jscs to eslint - https://phabricator.wikimedia.org/T161142 [17:56:21] that I don't know [17:56:23] On the WIP patch I had to remove an es3 test, but apparently eslint is easier to set up with OOjs [17:56:28] hmmm [17:56:48] the npm commands are from core dir, or from extension dir? [17:56:56] ah, we can stop with the es3 compatibility since they're calling IE9 a no-js browser now [17:56:58] or both? [17:57:03] Ah hmmm [17:57:08] npm commands are from the CentralNotice dir [17:57:16] woot! K thx [17:58:11] Here it sez IE9 is still on board... maybe not up-to-date? https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix [17:58:33] oh, huh [17:58:50] I thought IE9 was why we needed es3, but I might have been wrong [17:59:00] Mmm not sure also [17:59:23] oh, mightabeen IE8 [17:59:35] that one was deemed nojs in MW 1.27 [18:00:10] Here's a patch for a different extension's switch to eslint https://gerrit.wikimedia.org/r/#/c/339082/ [18:02:34] ejegg: ah cool! heh I thought of looking at other extensions' config for using eslint, but not their process of how they switched... good call :) [18:10:55] !log updated CiviCRM from d3c439f6391b8c6d351caf61eacbcc196dac5d7a to b6c8f3e28ffbd202b1b4221ac07ebc2b44a39069 [18:11:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:13:57] just asked on -editing if anything else is needed... Maybe not, since package.json has lint config info [18:14:01] or setup, rather [18:14:15] or, to be more concise, just config [18:16:24] (PS1) Ejegg: Add blank index.html [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/344670 [18:16:50] (CR) Ejegg: [C: 2] "self-merging to get the repo in sync with prod" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/344670 (owner: Ejegg) [18:22:00] ejegg: good news--James_F offered to pull the eslint switch for us! [18:23:35] nice! [18:23:40] yurp! [18:26:14] (Merged) jenkins-bot: Add blank index.html [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/344670 (owner: Ejegg) [18:36:47] (CR) Ejegg: [C: -1] "let's leave run-job accepting a single arg without needing to flag it" (2 comments) [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343960 (owner: Awight) [18:38:27] (CR) Ejegg: [C: 2] "Looks good! What do you think of making the whole lock a context object?" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/343965 (owner: Awight) [18:39:21] (CR) Ejegg: [C: -2] "Let's leave the argument positional instead" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344499 (owner: Awight) [18:40:35] (PS1) Jforrester: build: Replace jshint and jscs with eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344673 (https://phabricator.wikimedia.org/T161142) [18:43:42] (PS1) Jforrester: build: Enable eslint rule 'eqeqeq' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 [18:43:44] (PS1) Jforrester: build: Enable eslint rule 'no-multi-spaces' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344675 [18:59:08] (CR) Krinkle: [C: 1] build: Replace jshint and jscs with eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344673 (https://phabricator.wikimedia.org/T161142) (owner: Jforrester) [19:34:48] (PS2) AndyRussG: build: Replace jshint and jscs with eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344673 (https://phabricator.wikimedia.org/T161142) (owner: Jforrester) [19:42:19] (CR) AndyRussG: [C: 2] "Thanks much!!! :D" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344673 (https://phabricator.wikimedia.org/T161142) (owner: Jforrester) [19:44:48] (Merged) jenkins-bot: build: Replace jshint and jscs with eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344673 (https://phabricator.wikimedia.org/T161142) (owner: Jforrester) [19:46:32] (PS1) Ejegg: Use https endpoint for iDEAL availability [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344684 (https://phabricator.wikimedia.org/T161153) [19:55:14] (CR) Ejegg: [C: 2] Test for environment parameter [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/344501 (owner: Awight) [20:00:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: for JS linting, switch from jshint+jscs to eslint - https://phabricator.wikimedia.org/T161142#3129100 (AndyRussG) Woohoo! Thanks!!! [20:00:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: for JS linting, switch from jshint+jscs to eslint - https://phabricator.wikimedia.org/T161142#3129101 (AndyRussG) Open>Resolved [20:41:15] (PS1) AndyRussG: Minor cleanup and comments on issues found by eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344686 (https://phabricator.wikimedia.org/T161142) [20:47:52] (CR) Ejegg: [C: 2] Minor cleanup and comments on issues found by eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344686 (https://phabricator.wikimedia.org/T161142) (owner: AndyRussG) [20:48:49] ejegg|afk: thx! [20:51:43] (Merged) jenkins-bot: Minor cleanup and comments on issues found by eslint [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344686 (https://phabricator.wikimedia.org/T161142) (owner: AndyRussG) [20:53:07] oops, not afk [20:54:57] AndyRussG: did you see the little questions on https://gerrit.wikimedia.org/r/334410 ? [20:55:03] I'm happy to merge as-is [20:56:22] ejegg: ah yeah right! I did see it, and it slipped into to-do oblivion, sorry... IIRC I was thinking you're right, we should have such a thing [20:56:47] (i.e., we should have an unknown region value, so let's not merge yet...) [20:57:12] Heh I thought you were cod reviewing telepathically! [20:57:32] hehe [20:57:43] (and left the afk tag on just to show off :p ) [20:57:55] look no hands! [20:58:56] got the webcam translating shrugs and smirks into keystrokes [21:00:46] (PS10) AndyRussG: [WIP] Custom mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 [21:01:03] hehehe [21:01:18] damn [21:01:33] mine only recognizes grunts and burps [21:05:50] AndyRussG: is the 'purge' patch still externally blocked? [21:06:19] I think I heard you say you might just purge the administrator's language? [21:06:56] ejegg: yeah that seems the way to go [21:07:16] and then maybe a manual purge button if you need to do other langugaes [21:07:39] (say for emergencies) [21:12:49] k [21:47:58] (PS1) Ejegg: Example refund IPNs from express checkout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/344701 (https://phabricator.wikimedia.org/T161121) [21:48:26] XenoRyet: ^^^ there are a couple IPNs to use for testing [21:48:34] Cool [21:48:39] anonymized versions of a couple refunds [21:49:08] see the comment on phab, though, for the one-time donation refund there's not a lot to distinguish [21:49:16] between paypal and paypal_ec [21:51:08] Yea, it's a shame the fields aren't different. [21:53:04] we could do something like put .ec in the custom / txn_subject field for the ec donations, instead of copying in the item description [21:53:45] Yea, could do. It's not like item description is terribly useful to us. [21:54:42] well, we need it in the one place for the donor [21:54:49] just need to double check which that is [21:58:44] so, feel like pulling that ticket into sprint? [21:59:40] Yea, I suppose we should. [22:01:06] Fundraising Sprint Far Beer, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Smashpig, Patch-For-Review: Need to distinguish between paypal and paypal_ec for refund IPN messages - https://phabricator.wikimedia.org/T161121#3129429 (XenoRyet) a:XenoRyet [22:02:57] so, the real versions of those two refund IPNs ended up in the damaged message table [22:03:10] I edited both to use gateway=paypal_ec [22:03:13] and requeued them [22:03:22] but only one of them made it through [22:03:46] huh, what happened to the other one? [22:03:49] so, we might need to fix something more, i think with the recurring donation refund [22:04:04] it's back in the damaged table - couldn't find the original donation to refund [22:59:20] (PS2) Jforrester: build: Enable eslint rule 'eqeqeq' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 [23:27:17] (CR) AndyRussG: [C: -1] "Cool, thanks! Just one minor detail to check.... :)" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 (owner: Jforrester) [23:28:05] (PS3) Jforrester: build: Enable eslint rule 'eqeqeq' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 [23:28:11] (PS2) AndyRussG: build: Enable eslint rule 'no-multi-spaces' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344675 (owner: Jforrester) [23:29:12] (CR) Jforrester: build: Enable eslint rule 'eqeqeq' and make pass (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 (owner: Jforrester) [23:31:53] (CR) AndyRussG: [C: 2] "Thx!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 (owner: Jforrester) [23:33:02] (CR) AndyRussG: [C: 2] "Nice!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344675 (owner: Jforrester) [23:35:24] (Merged) jenkins-bot: build: Enable eslint rule 'eqeqeq' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344674 (owner: Jforrester) [23:36:45] (Merged) jenkins-bot: build: Enable eslint rule 'no-multi-spaces' and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344675 (owner: Jforrester) [23:48:41] (PS1) Ejegg: Fix dictionary comparison [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/344725 [23:49:14] (CR) jerkins-bot: [V: -1] Fix dictionary comparison [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/344725 (owner: Ejegg) [23:53:11] (PS1) Ejegg: WIP Test audit data for Express Checkout refunds [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/344727 (https://phabricator.wikimedia.org/T161121) [23:53:45] (CR) jerkins-bot: [V: -1] WIP Test audit data for Express Checkout refunds [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/344727 (https://phabricator.wikimedia.org/T161121) (owner: Ejegg)