[00:04:32] (CR) jerkins-bot: [V: -1] Include logfile path in failmails [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/346583 (owner: Awight) [00:04:33] (CR) jerkins-bot: [V: -1] Strip extra newline after job status [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/346585 (owner: Awight) [00:13:31] (PS1) Ejegg: Add text to assertions [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/346922 [00:15:27] hmm, something race-y about those tests [00:17:35] (CR) Ejegg: [C: 2] "recheck" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/346583 (owner: Awight) [00:23:59] (Merged) jenkins-bot: Include logfile path in failmails [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/346583 (owner: Awight) [00:25:01] (Merged) jenkins-bot: Strip extra newline after job status [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/346585 (owner: Awight) [00:41:31] (PS3) AndyRussG: Admin UI campaign editor: Isolate and selectively load js/css [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/346034 (https://phabricator.wikimedia.org/T144453) [00:54:43] got that fence all mended? [00:58:16] Wow more than 1 hr for Jenkins to verify the last patch... [01:00:24] ejegg: yep! got a nice size splinter out of the deal [01:00:38] yowch! [01:09:18] awww [01:09:22] sorry to hear that [01:37:52] ft-tech hey... looks like these two need another kick to get them thru the pipeline? https://gerrit.wikimedia.org/r/#/c/346033 https://gerrit.wikimedia.org/r/#/c/346034 thx in advance!! :) [02:09:09] AndyRussG: i am out of my element but it looks like they just need someone to press submit? happy to do it even though i am ignorant of the contents [02:10:42] * cwd be's bold [02:15:32] (PS1) Krinkle: CNChoiceDataModule: Avoid deprecated getModifiedHash() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/346936 [02:17:41] AndyRussG: awight: Do you know when the next update to CentralNotice is (e.g. merging from master to wmf_deploy?) [02:17:54] Looks like last time was January [02:28:54] Krinkle: There's no particular schedule but we can certainly do one [02:29:43] Right now I'm working on a sizeable feature (banner sequence) that would hopefully be merged and deployed after it's thru basic testing [02:31:38] cwd: thanks much! Yeah some ghost of Gerrit was scaring the merge jobs or something ;p [02:32:49] Krinkle: if it's small and urgent, it can be a SWAT, or bigger and less urgent, could just be sent with the train [02:38:12] AndyRussG: Nothing urgent right now. Was just looking at the commits and saw a lot of minor fixes, which together seems like a lot. The main one (not yet merged) is getModifiedHash. it's negligible, but for sanity I'd like to have it phased out from production usage. Should be a minor perf win and also simplifies the flame graphs I use to find new [02:38:12] regressions (right now there's a narrow but steep separate stack just for CN basically). [02:38:43] AndyRussG: When would you expect the next merge to be if not SWAT'ed? E.g. the new feature. [02:39:00] I assume it's related to the commits already in master so an earlier complete merge would not work? [02:39:44] Krinkle: dunno exactly when the new feature would go out, sometime in the next week or so, I hope :) [02:40:13] It should be OK to just merge smaller stuff onto the train... Lemme take a look at what's there :) [02:52:51] (Krinkle: distracted a bit right now, should be able to check it out later this evening or tomorrow morning at the latest :) ) [14:39:56] (PS20) AndyRussG: [WIP] Custom campaign mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) [14:48:14] (PS7) AndyRussG: [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [14:51:09] (CR) jerkins-bot: [V: -1] [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [15:45:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#3164104 (DStrine) Open>declined [15:46:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#298567 (DStrine) There are many ways to cause this effect and we have not heard of this happening r... [15:57:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#3164114 (DStrine) declined>Open [15:59:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#298567 (DStrine) I'm reopening this again. There are several duplicates of this task and many are o... [16:02:29] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#3164129 (Nemo_bis) Thanks for looking into it. Is https://wikitech.wikimedia.org/wiki/CentralNotice... [16:04:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#298567 (AndyRussG) >>! In T28234#3164129, @Nemo_bis wrote: > Thanks for looking into it. Is https:/... [16:33:26] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: donation page format error - https://phabricator.wikimedia.org/T162300#3158511 (demon) So we can move donatewiki back to wmf.19? Good. If someone from fundraising can ping me on IRC... [17:00:19] fr-tech: Chamberlain's Laws: [17:00:19] 1: The big guys always win. [17:00:19] 2: Everything tastes more or less like chicken. [17:00:19] -- discuss. [17:05:02] Ouch [17:05:32] So, slander, the suggestion is to eat of lot of chicken-tasting calories to get big and win? [17:05:54] * AndyRussG heads to kitchen [17:19:12] Fundraising-Backlog: Banner impressions loader exception - https://phabricator.wikimedia.org/T162466#3164246 (Ejegg) [17:27:26] AndyRussG: I've been following that advice for some time [17:32:15] Seddon: the question is, what will we win? [17:35:49] fundraising-tech-ops: replace boron (fundraising build server) with new hardware running jessie - https://phabricator.wikimedia.org/T145117#3164343 (faidon) [17:35:51] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#3164344 (faidon) [17:36:22] fundraising-tech-ops, Operations, ops-ulsfo: rack/setup frbackup2001 - https://phabricator.wikimedia.org/T162469#3164345 (RobH) [17:43:29] fundraising-tech-ops, Operations, ops-ulsfo: rack/setup frbackup2001 - https://phabricator.wikimedia.org/T162469#3164368 (Jgreen) [18:25:27] Krinkle: hey... So, it should be no problem to deploy all the CN patches currently in master as is (plus the RL hash patch) at any time [18:25:48] I don't see any patches w/ non-working states [18:26:10] We could put it all on the train next week, or, if you prefer, we could cherry-pick the RL patch and SWAT it [18:26:24] Either way is fine :) [19:06:36] Fundraising-Backlog, FR-Ingenico, FR-Email: Spike: Stop spamming donors who have pending donations - https://phabricator.wikimedia.org/T162476#3164564 (Ejegg) [19:26:12] the-wub: Heya, you about? Wondering about donatewiki / wmf.19 / T162300 [19:26:13] T162300: donation page format error - https://phabricator.wikimedia.org/T162300 [19:26:19] (cc legoktm) [20:00:11] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: donation page format error - https://phabricator.wikimedia.org/T162300#3164771 (demon) [21:41:38] fundraising-tech-ops, Operations, ops-ulsfo: rack/setup frbackup2001 - https://phabricator.wikimedia.org/T162469#3165199 (Papaul) [21:42:22] XenoRyet: can you help me figure out what's the matter on the new civi server? [22:01:00] ack [22:17:23] (PS1) Ejegg: Add debugging output to recent file parsing [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/347125 [22:31:34] (PS2) Ejegg: Add debugging output to recent file parsing [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/347125 [22:36:48] (CR) XenoRyet: [C: 2] Add debugging output to recent file parsing [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/347125 (owner: Ejegg) [22:50:20] (CR) XenoRyet: [V: 2 C: 2] Add debugging output to recent file parsing [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/347125 (owner: Ejegg) [22:59:52] (PS1) Ejegg: Use correct UDP_LOG_PATH [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/347131 [23:00:06] XenoRyet: think that's the real fix^^^ [23:00:14] 10-4 [23:00:16] looking [23:00:34] freaking deprecated commit_manually thing needs to go too [23:00:55] but it's still just warning on civi1001, not crashing like it does on my django version [23:02:50] Fundraising-Backlog: Replace deprecated transaction.commit_manually in DjangoBannerLoader - https://phabricator.wikimedia.org/T162504#3165397 (Ejegg) [23:04:20] (CR) XenoRyet: [V: 2 C: 2] Use correct UDP_LOG_PATH [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/347131 (owner: Ejegg) [23:05:13] thanks, i'll just friday-deploy that [23:06:41] !log updated DjangoBannerStats from 220f80ece976aecbfbfbe1cb476d79910eb48ff4 to 9e6b11712851919e4318930e19bdf9c941d8ae38 [23:06:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:06:52] Friday late day at that. ;-) [23:07:40] XenoRyet: so, for more background on the other, more urgent problem: https://phabricator.wikimedia.org/T162094 [23:08:04] want to help me track down some of those in the payments logs? [23:08:27] ah shoot, I need to run a backfill job on those banner impressions, one sec [23:08:43] or, do you want to do it, to get some practice with the jenkins replacement? [23:09:26] Na, you go ahead. Vagrant just spit some red lines at me I want to look at. [23:10:31] I'll learn about the jenkins replacement next time. [23:10:48] k, I could really use some help puzzling out the missing iDEAL txns [23:11:03] Yea, let me read that ticket, catch up some. [23:34:18] (CR) Aaron Schulz: [C: 2] CNChoiceDataModule: Avoid deprecated getModifiedHash() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/346936 (owner: Krinkle) [23:38:42] (Merged) jenkins-bot: CNChoiceDataModule: Avoid deprecated getModifiedHash() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/346936 (owner: Krinkle) [23:39:53] damn, I can't stay [23:40:15] No worries, I was gonna have to bail to get the kid in a few anyway. [23:40:33] I'll poke around for a few more minutes though, we'll get back to it on Monday. [23:40:40] guess so