[00:00:36] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3188450 (Dzahn) @Jgreen @Robh @Cmjohnson since the combination of decom and fundraising doesn't happen that often i am unsure about the workflow here. I did check the... [00:02:06] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3188455 (Dzahn) it might also appear in the pfw and other fundraising config in other repos. is that also part of it? [00:27:04] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Patch-For-Review, Unplanned-Sprint-Work: Paypal audit parser still not working for new recurring express checkout - https://phabricator.wikimedia.org/T162975#3188516 (Ejegg) a:Ejegg [00:29:50] (PS2) Ejegg: Update smashpig lib [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/348027 (https://phabricator.wikimedia.org/T161073) [00:29:53] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3188529 (Jgreen) We probably should have followed a template of some kind... - remove from DNS - disk wipe - physical disposal - update racktables - router config chang... [00:30:16] (CR) Ejegg: [C: 2] Update smashpig lib [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/348027 (https://phabricator.wikimedia.org/T161073) (owner: Ejegg) [00:33:32] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3188531 (Dzahn) >>! In T162952#3188529, @Jgreen wrote: > We probably should have followed a template of some kind... @Robh has made [[ https://wikitech.wikimedia.org/wi... [00:34:36] (Merged) jenkins-bot: Update smashpig lib [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/348027 (https://phabricator.wikimedia.org/T161073) (owner: Ejegg) [00:42:46] (PS1) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [00:45:59] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [01:09:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: CentralNotice: order for assigned banners in Admin UI campaign editor? - https://phabricator.wikimedia.org/T163173#3188638 (AndyRussG) [01:57:50] (PS2) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [02:00:35] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [02:17:44] (PS3) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [02:21:08] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [03:05:28] (PS4) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [03:08:33] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [12:41:57] Fundraising-Backlog, fundraising-tech-ops: Need additional fundraising database access for CPS analysts - https://phabricator.wikimedia.org/T163145#3189582 (Jgreen) Open>Resolved this is done for both lutetium and frdev1001 [14:15:04] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#3189838 (DStrine) a:XenoRyet [15:03:06] Fundraising-Backlog, fundraising-tech-ops: Need additional fundraising database access for CPS analysts - https://phabricator.wikimedia.org/T163145#3189959 (CCogdill_WMF) Thanks! Le mar. 18 avr. 2017 à 05:41, Jgreen a écrit : > Jgreen closed this task as "Resolved".... [16:15:57] pcoombe: hi! yt? [16:18:21] Hi AndyRussG XenoRyet cwd [16:20:06] sup ejegg [16:30:37] ejegg: cwd hey! [16:30:47] XenoRyet: hi! [16:30:54] Howdy all [16:32:14] this OOJS stuff is pretty quirky [16:36:17] ejegg: yeah! hey if you're looking at the BannerSequence (BS) stuff, let me just send the latest version... [16:36:40] XenoRyet: do you have any successful EC recurring in Civi? [16:37:48] Mine never made it in, and unfortunately it looks like we don't create subscriptions based on audit files, only IPNs [16:38:05] weak link in our redundancy there [16:38:13] AndyRussG: thanks! [16:38:20] Mine from a while ago didn't make it in either, and I think that cause my cancelation to fail as well. [16:38:27] I could try another one today. [16:38:42] (PS15) AndyRussG: [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [16:39:11] ejegg: ^ The server-side bit might work, haven't tested it yet 8p [16:39:12] XenoRyet: that would be great! [16:39:22] ejegg: also thank u :) [16:39:43] XenoRyet: we should have at least one successful thing of each type before we put donors on it for an hour, don't you think? [16:41:46] Yea, seems prudent [16:49:57] AndyRussG: server-side bit seems pretty good, just have to use a !empty to check for the $mixinConfig['customAdminUIControlsModule'] so there's no undef index warning [16:50:17] Ejegg: Ok, yep. Donation made it in to civi and it's set to recur. Gateway is EC and it came in from the listener. [16:50:30] Nice! [16:50:49] We've had successful one-times already, yea? [16:52:25] XenoRyet: yep, a while back at least! [16:52:34] Good times [16:52:41] also, do you feel like deploying that tools stuff? [16:54:06] ejegg: Sure, if you'd like me to. [16:54:27] thanks, that would be great! [16:59:55] (CR) jerkins-bot: [V: -1] [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [17:00:20] fr-tech: A likely impossibility is always preferable to an unconvincing possibility. [17:00:20] -- Aristotle [17:00:20] -- discuss. [17:03:02] Back in a little while :) [17:05:14] (PS1) XenoRyet: Merge branch 'master' into HEAD 8b6cd72 Pretend stomp never happened. d1f40e4 Test PP audit with CSV files 9c88317 Fix missing subscr id for ec recurring [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/348767 [17:05:51] (CR) XenoRyet: [C: 2] Merge branch 'master' into HEAD 8b6cd72 Pretend stomp never happened. d1f40e4 Test PP audit with CSV files 9c88317 Fix missing subscr id for [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/348767 (owner: XenoRyet) [17:05:55] (Merged) jenkins-bot: Merge branch 'master' into HEAD 8b6cd72 Pretend stomp never happened. d1f40e4 Test PP audit with CSV files 9c88317 Fix missing subscr id for ec recurring [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/348767 (owner: XenoRyet) [17:12:40] !log updated tools from a8b8d7242799b61dd2a48ef4e804164cd1818bc9 to a1e9342e093a85032255fc1d9904db7df13680b7 [17:12:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:18:11] ejegg: tools deploy is done. [17:25:57] I'm going to pop out to the store real fast, there's an alarming shortage of caffine in this house. [17:51:35] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#3190598 (XenoRyet) @Pcoombe You can select the Express Checkout form with a link like this: https://pa... [18:32:29] AndyRussG|bassoo: will you be able to call into the CPS meeting? [18:38:51] dstrine: coming! sorry ! [18:42:20] (CR) Ejegg: "Looks like a pretty solid basis for custom controls, once you get used to the OOJS extension and mixin conventions." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [19:03:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico: Contribution_tracking table missing contribution_id for many iDEAL donations in Civi - https://phabricator.wikimedia.org/T163240#3190967 (Ejegg) [19:22:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico: Contribution_tracking table missing contribution_id for many iDEAL donations in Civi - https://phabricator.wikimedia.org/T163240#3191111 (Ejegg) Open>Invalid [19:30:56] Hey XenoRyet, looks like we've got some failmail [19:37:29] XenoRyet: did you see those? I think we may have to make some bigger changes to the EC recurring [19:40:36] Taking a look now [19:42:10] The ones from 9:47 this morning, you mean? [20:18:28] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/348808 [20:23:16] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/348811 [20:23:59] XenoRyet|meet: ok, maybe not as big changes as I though. We just need to not send the payment from the front end as early as we are now [20:32:24] XenoRyet: OK, so we have to fix something in the frontend to make it send just one payment message, WITH the subscr_id, for recurring [20:32:50] And we have to fix something in the listener to do the right thing with recurring_payment_profile_created messages [20:33:15] Which would you like to tackle? [20:33:34] I'll take the listener side. [20:34:00] So what did you turn up anyway? I didn't get to do much digging before I had that meeting. [20:34:04] k, i'll push up the failing test I just made from the IPN this morning [20:34:11] XenoRyet: just looking at the failmails [20:34:34] INVALID_MESSAGE Recurring donation, but no subscription ID found. [20:34:58] i'm PRETTY sure thats because the front end is sending two donation messages [20:35:10] first, one without the subscr_id [20:35:18] then, one that's missing other stuff [20:35:23] Yea, like doing a one-time then setting up the recurring. [20:35:43] Right, that's technically how it's working [20:36:05] but we mean to be recording that one-time along with the subsc_id for the recurring that will follow it [20:36:34] So when we're about to set up the recurring, we should hold off sending the message [20:37:53] Yea, ok [20:39:25] (PS1) Ejegg: (failing) test for EC recurring [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/348837 [20:39:42] XenoRyet: wanna take that over and make it pass? ^^^ [20:39:52] Sure [20:40:03] I'll get some tests on the front end that actually look at the messages that get sent [20:41:42] (CR) jerkins-bot: [V: -1] (failing) test for EC recurring [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/348837 (owner: Ejegg) [20:43:10] (PS2) Ejegg: Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/348808 [20:44:19] XenoRyet: oh, that json file is misname, should be recurring_payment_profile_created probably [20:44:31] 10-4 [20:44:42] (PS2) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/348811 [20:47:03] (PS3) Ejegg: WIP test queue stuff with PDO/sqlite [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316500 [20:47:05] (PS1) Ejegg: Clean up Mustache form test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/348843 [20:55:12] (PS4) Ejegg: Test a bit of Amazon queue stuff with PDO/sqlite [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/316500 [21:02:22] Fundraising-Backlog, FR-Paypal: Paypal audit parser sending too many fields for refunds - https://phabricator.wikimedia.org/T163147#3191620 (Ejegg) p:Triage>Low [21:04:58] Fundraising-Backlog, fundraising-tech-ops: Delete old process-control logs - https://phabricator.wikimedia.org/T163131#3191626 (ggellerman) p:Triage>High [21:07:24] Fundraising-Backlog, FR-Smashpig, Monitoring: Write Ganglia monitors for SmashPig database things - https://phabricator.wikimedia.org/T162946#3191640 (ggellerman) p:Triage>Normal [21:12:07] Fundraising-Backlog, Spike: Spike: Come up with protocol to avoid being blindsided by donatewiki regressions - https://phabricator.wikimedia.org/T162843#3191662 (ggellerman) p:Triage>Normal [21:13:53] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: CentralNotice: order for assigned banners in Admin UI campaign editor? - https://phabricator.wikimedia.org/T163173#3191667 (ggellerman) p:Triage>Low [21:39:12] fundraising-tech-ops, Operations, ops-ulsfo, Patch-For-Review: rack/setup frbackup2001 - https://phabricator.wikimedia.org/T162469#3191820 (ayounsi) [21:41:35] fundraising-tech-ops, Operations, ops-eqiad: move frdb1002 from pfw1 to pfw2 - https://phabricator.wikimedia.org/T163268#3191829 (Jgreen) [21:47:58] ejegg: hey...thx for the CR! Not sure if I understand your comment about !empty() here: https://gerrit.wikimedia.org/r/#/c/343953/23/special/SpecialCentralNotice.php@483 [21:49:07] AndyRussG: Oh, just b/c PHP will throw error notices when you try to look at an undefined array element [21:49:10] unlike js [21:49:35] but !empty tests for existence before it actually accesses it [21:50:16] aaarg [21:51:25] silly silliness [21:51:59] Heh I wasn't even looking at my apache error log [21:55:58] Funny how one language or another can just take over your brain for a while [21:56:10] I was almost used + for string concat too there [21:56:45] hehe, silly hp [21:56:48] php [21:56:54] silly keyboard... [21:57:10] silly phpeyboard [21:57:19] Mmm thx btw! [21:58:02] Always happy to CR your stuff [21:58:25] http://stackoverflow.com/questions/4559925/why-check-both-isset-and-empty [21:58:44] :) heh more where that came from! [22:14:17] (PS24) AndyRussG: [WIP] Custom campaign mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) [22:15:29] (CR) AndyRussG: "Thx!!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [22:41:03] dstrine: currently both the large banner limit and impression diet (impression limiting) mixins use localstorage and fall back to cookies if localstorage is unavailable, but only for fundraising campaigns... So I'm setting up BS to work the same way... sound good? [22:42:14] AndyRussG: yeah sounds good [22:42:46] K thx! [22:46:02] dstrine: another detail.. so if there are no storage options available (localstorage for non-FR campaigns, and neither localstorage nor cookies for FR campaigns) then impression diet shows no banner, and large banner goes directly to the small banner [22:46:45] I think in the case of BS, for simplicity, if there's no storage opiton, we'll also not show anything, also, just like impression diet [22:47:35] The last comment sounds good. the first example sounds very edge-case-y [22:48:42] dstrine: both are quite edge-case-y, fortunately almost everyone has localstorage these days [22:48:51] yeah [22:49:11] myself, I always have an extra one in my pocket, for example [22:55:35] ? [22:56:11] http://www.huffingtonpost.com/entry/small-pocket-jeans-watches-cowboys_us_56a7720ce4b0b87beec5eb5f [22:58:20] (PS1) Ejegg: Paypal EC recurring: queue one correctly formed message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/348874 [22:58:36] XenoRyet: phew, that oughtta do it ^^^ [22:58:53] Cool, I'll check it out in a bit. [22:59:00] Since it needed tests that look at the queue, I threw it on top of another couple patches that set that up [22:59:08] Cool [23:00:34] XenoRyet: any luck with the listener patch? [23:00:46] I'd love to do some live collaboration! [23:01:16] (CR) jerkins-bot: [V: -1] Paypal EC recurring: queue one correctly formed message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/348874 (owner: Ejegg) [23:01:42] Eh, workin on it. [23:02:32] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Unplanned-Sprint-Work: payments frontend sending duplicate malformed queue messages for EC recurring - https://phabricator.wikimedia.org/T163281#3192176 (Ejegg) [23:03:12] Probably have to come back to it later tonight. Marek's school is on weird hours this week so I have to go get him early all this week. [23:03:34] Think we should call off the 1 hour test? [23:03:44] rgh virtualbox/lxc has my brain in a knot, i'm going to head out for now but i'll be back later [23:04:01] Not yet. This doesn't feel like something that's going to take that long to fix. [23:05:53] great! [23:06:17] Those freaking DI tests are still interfering with each other :( [23:16:26] Alright, gotta go get that kid, but I think I'm on the right path here. [23:59:13] oh wow, I really dunno what's up with that persistent in-memory PDO [23:59:46] seems to share a database across tests, but I can't seem to access the same thing to clear the tables out in tearDown [23:59:58] always a different connection hash