[00:21:50] (PS1) Ejegg: Add Bijcard in initial install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350100 [00:23:06] (CR) jerkins-bot: [V: -1] Add Bijcard in initial install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350100 (owner: Ejegg) [00:25:59] (PS2) Ejegg: Fix adding Bijcard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350100 [00:27:17] Jeff_Green: ohai [00:27:26] hiho [00:27:47] i was just trying to build p-c and it was blank again, i think cause i didn't delete the makefile first [00:28:14] oh fun [00:28:26] note to self, don't have the guy who is about to leave for a couple months be the silo of information for the new SPOF [00:28:34] ha [00:29:13] maybe the thing to do is rip out all the python-level installer foo, and stop letting the package builder stuff use it [00:29:29] yeah i think so [00:29:49] anyway i just managed to (i think) get the broken one out of my local reprepro [00:31:40] /usr/lib/python2.7/dist-packages/process_control-1.0.5.egg-info [00:31:49] i don't know why that still says .5 [00:31:54] i changed everything to .6 [00:31:59] except... setup.py [00:41:56] ok that "fixed" it [00:42:11] hacking the source files before building the package is sub ideal [00:43:54] Jeff_Green, ejegg - i think i have a working patch for the packages repo to build the current code [00:44:02] but i am afk tomorrow [00:44:14] want me to push it up, or just wait? [00:45:13] i guess in a pinch I can just repackage the previous version and hand-reinstall it [00:45:15] Is there a way to roll back? [00:45:23] k, let's go for it! [00:45:27] not an awesome one [00:45:33] sub awesome [00:45:41] just awesome enough [00:46:23] every release is a snowflake at this point cause of the source file hacking [00:46:34] so rebuilding the previous one might get ugly [00:46:51] luckily we can use mintaka as a canary [00:46:52] and we have decent test coverage [00:47:07] having to hack source files is not ok [00:47:22] no [00:47:51] any idea why it broke this time? [00:48:04] just cause i forgot to delete the makefile before building [00:48:14] and then i had to hack the version number into setup.py [00:48:23] how about we delete the makefile from the source in git? [00:48:31] i don't know if that would have technically broken it but it make a .egg file with the wrong number [00:49:29] yeah i think we should probably delete the makefile from the repo [00:49:43] it doesn't affect the way i've been building it anyway but i'm not sure what adam had in mind [00:49:49] or how many tendrils that file has [00:50:39] it's definitely too easy at this point to accidentally the whole donation pipeline [00:51:26] because of making and deploying a broken package? [00:51:32] yeah [00:51:43] good thing this doesn't change very often [00:52:00] yeah hopefully we get to a point where it doesn't effectively change [00:52:18] my vote is to rip out anything unnecessary from the source [00:52:29] agreed [00:52:49] we don't need this thing to build in every environment everywhere, we need it to build every time in our environment [00:53:48] yeah, the cross platform stuff is a magnet for premature optimization [00:54:50] i will file a bug for stripping the unnecessary bits [00:55:54] Makefile should probably go with the debian packaging, i guess? [00:56:48] it appears to break debian packaging at this point [00:56:58] it's not used in packaging right? [00:56:59] but i have no understanding of why [00:58:47] Jeff_Green: one other hack, i changed build_package.sh to look for just /debian/ instead of /debian-version-platform/ [00:58:52] because we're only building for jessie now [00:59:03] and the dch tool expected the file to be named that [00:59:44] cwd ok [01:00:24] there's probably an option [01:00:32] the documentation surrounding this is also a little sparse [01:00:55] yeah [01:01:10] very hard to get clear answers re. deb packaging in my experience [01:02:20] the first rule of deb packaging is you don't talk about deb packagin [01:02:29] (PS1) Eileen: Fix payment instrument lookup function to work above the 25 limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350102 [01:02:35] the second rule is you're doing it wrong [01:02:55] could be because i've always done it wrong? maybe? [01:03:15] i can neither confirm nor deny this suspicion [01:03:33] ooh, there's a ticket for process-control logs, i'm gonna close it now! [01:04:32] ejegg: you didn't hit any failures around 'CIVI_CONFIG Payment Instrument 'Credit Card: Visa' not found [01:04:32] ' recently? I hit it trying to pull in civi updates but can't see why we would never have hit it before - fix at https://gerrit.wikimedia.org/r/#/c/350102/ [01:05:03] eileen1: no, that one's new to me! [01:05:03] Fundraising-Backlog: Remove build scaffolding from process-control - https://phabricator.wikimedia.org/T163759#3208483 (cwdent) [01:06:05] yeah the issue is that our function was only checking the first 25 payment instruments - so if feels like it should have hit us [01:06:23] wow, yeah! We've had more than that for a little while now [01:07:06] We might want to keep throwing that exception on missing though [01:07:17] let's see where we're using that fn [01:07:20] (CR) jerkins-bot: [V: -1] Fix payment instrument lookup function to work above the 25 limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350102 (owner: Eileen) [01:07:41] Jeff_Green: ah, little perl module needfulness in the log archiver [01:07:48] see cronmail... [01:08:24] ejegg: we only call it from one place & there is a throw there [01:09:02] hmm that test passes locally - am having problems with discrepancies on local vs remote with tests [01:10:26] Fundraising-Backlog, fundraising-tech-ops: Delete old process-control logs - https://phabricator.wikimedia.org/T163131#3208504 (Jgreen) Open>Resolved a:Jgreen This is done: - local archive dir at /srv/archive/{hostname}/process-control - logs that end in "----------- end command output", or a... [01:10:39] That one refund test always fails for me locally [01:10:53] cwd: looking [01:14:52] (PS2) Eileen: Fix payment instrument lookup function to work above the 25 limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350102 [01:15:26] ejegg: ah - my test was out of sync with my fix. We had 3 places where an invalid payment_instrument would cause an exception (including the civi api) - down to 2 now [01:17:16] ok cronspam missing module is fixed [01:18:04] eileen1: ok, looks like that should still deal with the missing ones the same way [01:18:14] * Jeff_Green heading out again. have a good night people [01:18:25] ejegg: yeah - I feel I could have been more brutal but didn't want to at this stage [01:19:03] Re the refundTest - if I step through it in phpstorm if gives the same error as the remote but if I let it run it doesn't! [01:19:22] (CR) Ejegg: [C: 2] Fix payment instrument lookup function to work above the 25 limit. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350102 (owner: Eileen) [01:19:51] Heh, I really should debug that [01:20:15] something about my test db, i'm sure. using one that's pretty full of fake data [01:20:37] it's doing my head in - there was a change in the PEAR DB.php class for php 7 I think [01:21:38] & it has caused the DB_mysqli::freeResult(): Couldn't fetch mysqli_result errors with Civi codebase [01:22:58] it's a PHPUnit_Framework_Error_Warning - so perhaps something in the error level there [01:23:20] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [01:25:28] ejegg: there is a patch in your home dir on boron to bring process control up to date [01:25:44] if y'all want to build it tomorrow you can just pass that to jeff? [01:26:43] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [01:26:47] it's for the packages repo [01:34:53] cwd oh, that's a new repo to me! [01:35:20] thank you, I'm about to go afk for the evening [01:35:27] cool, me too [01:35:32] yeah it's just a local repo [01:35:35] have a good one tomorrow! [01:35:37] for building .debs [01:35:40] thanks! [01:42:09] (PS9) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [01:45:28] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [02:10:08] (PS1) Eileen: Minor tweak to prevent e-notice during test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350108 [02:10:35] very minor test-only patch is anyone is able to review ^^ [02:19:06] (PS10) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [02:22:38] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [03:41:04] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad, Patch-For-Review: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3208700 (Dzahn) @Robh @Jgreen see DNS change above. in this case it removes both main IP and mgmt at once, realizing that normally we do it seperat... [03:43:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [03:47:19] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [03:57:27] (PS11) Eileen: 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 [04:01:59] (CR) jerkins-bot: [V: -1] 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/348659 (owner: Eileen) [04:29:18] (PS1) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [04:33:34] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [04:44:19] (PS2) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [04:48:05] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [04:52:36] (PS3) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [04:57:11] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [04:59:11] (PS4) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [05:04:07] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [05:47:25] (PS1) Eileen: Fix test error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350118 [05:47:59] (CR) Eileen: "Failure should be fixed by https://gerrit.wikimedia.org/r/#/c/350118/" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [05:48:27] This is another minor patch if anyone can review https://gerrit.wikimedia.org/r/#/c/350118/ [05:58:47] (PS5) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [06:03:38] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [06:20:20] (PS6) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [06:21:58] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [06:24:21] (PS7) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [06:29:00] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [07:26:16] Chicocvenancio_ in which language? [10:42:45] Wikimedia-Fundraising-Banners: Fundraising banner display issues with 4+ payment methods e.g. in Argentina - https://phabricator.wikimedia.org/T162352#3209247 (Pcoombe) @TSkaff @spatton @jrobell I modified the buttons to have a 2x2 layout when there are 4 payment methods. Can you check if these look okay? If... [12:38:30] (PS1) Hashar: Update composer.lock with composer 1.4.1 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350188 [12:39:58] (PS1) Hashar: Lint json files from composer / custom script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) [12:40:00] (PS1) Hashar: Lint PHP files using composer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) [12:53:21] (CR) Hashar: "That is merely so that the follow up changes do not alter composer.lock with random cruft." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350188 (owner: Hashar) [12:53:31] (CR) Hashar: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [12:53:33] (CR) Hashar: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [17:00:19] fr-tech: My notion of a husband at forty is that a woman should [17:00:19] be able to change him, like a bank note, for two twenties. [17:00:19] -- discuss. [17:04:17] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-Paypal, Recurring-Donations, Patch-For-Review: Paypal recurring donations missing contribution_tracking link since 2017-04-10 - https://phabricator.wikimedia.org/T163443#3210654 (Ejegg) Hi @pcoombe, the fix is deployed and I... [17:38:43] (PS19) AndyRussG: [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [18:44:09] 2 very minor gerrits if someone can QA them - both are test related issues https://gerrit.wikimedia.org/r/#/c/350118/ [18:44:22] https://gerrit.wikimedia.org/r/#/c/350108/ [18:53:27] (PS1) Ejegg: Remove Verisign secure seal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350262 (https://phabricator.wikimedia.org/T163807) [18:55:48] (CR) jerkins-bot: [V: -1] Remove Verisign secure seal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350262 (https://phabricator.wikimedia.org/T163807) (owner: Ejegg) [18:58:29] (PS2) Ejegg: Remove Verisign secure seal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350262 (https://phabricator.wikimedia.org/T163807) [19:04:31] (CR) Ejegg: [C: 2] "Looks legit. Timezones!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350188 (owner: Hashar) [19:09:13] (Merged) jenkins-bot: Update composer.lock with composer 1.4.1 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350188 (owner: Hashar) [19:11:01] XenoRyet: are you free for a call? [19:11:33] Was actually just going to grab some food. After? [19:11:44] (Abandoned) Hashar: Lint json files from composer / custom script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:11:47] k [19:37:17] (Restored) Hashar: Lint json files from composer / custom script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:38:14] (PS2) Hashar: Lint json files from npm / grunt-jsonlint [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) [19:50:02] (CR) Hashar: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:50:35] (PS20) AndyRussG: [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [19:50:57] Mmm finished commenting up ext.centralNotice.bannerSequence.js [19:51:45] Still gotta re-read and comment ext.centralNotice.adminUi.bannerSequence.js... and fix a new wee bug in the patch 8p [19:59:38] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-Paypal, Recurring-Donations, Patch-For-Review: Paypal recurring donations missing contribution_tracking link since 2017-04-10 - https://phabricator.wikimedia.org/T163443#3211431 (Pcoombe) Wonderful, thank you @Ejegg! 9 in th... [20:14:39] XenoRyet: want to hop in -talk ? [20:15:35] Yea, give me one minute. I had a WIP of a light touch fix for that Ingenico bug. Gimme a sec to finish it up an post it. [20:23:07] (PS1) XenoRyet: WIP Ingenico server timeout fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832) [20:25:09] (CR) jerkins-bot: [V: -1] WIP Ingenico server timeout fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832) (owner: XenoRyet) [20:53:16] XenoRyet: lost you there! [21:07:21] Fundraising-Backlog, fundraising-tech-ops: Remove build scaffolding from process-control - https://phabricator.wikimedia.org/T163759#3211763 (ggellerman) p:Triage>High [21:14:11] Fundraising-Backlog: Compile list of systems we depend on and should check all the time - https://phabricator.wikimedia.org/T163509#3211825 (ggellerman) p:Triage>Normal [21:16:16] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Paypal: deal with 10486 (redirect donor back to pp) - https://phabricator.wikimedia.org/T163458#3211833 (ggellerman) p:Triage>Normal [21:21:25] Fundraising-Backlog: discuss how MG might allow event attendees to donate en masse - https://phabricator.wikimedia.org/T163395#3211857 (ggellerman) Open>Resolved [22:29:25] (PS2) XenoRyet: Ingenico server timeout fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832)