[00:16:14] (CR) Ejegg: [C: -1] "This seems like a good approach! Array vs scalar issue. And tests are always nice to have." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832) (owner: XenoRyet) [00:28:47] (CR) Eileen: "OK now I see, that is an invalid test... the amount is rounded by mysql on insert according to the field definition" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/347796 (owner: Eileen) [00:30:42] ejegg: were you ok to approve this - https://gerrit.wikimedia.org/r/#/c/350118/ will help me get the other part working [00:31:54] oh yeah, definitely. Just wondering how it hasn't been biting us all along! [00:32:06] (CR) Ejegg: [C: 2] Fix test error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350118 (owner: Eileen) [00:32:56] ejegg: it didn't matter before because the only place there was no logged in user the class api was being used & silently ignoring the error - it has been biting me locally when I do weird things [00:34:04] oh, weird, I didn't realize the class API bypassed that [00:35:20] (PS21) AndyRussG: [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [00:36:18] (Merged) jenkins-bot: Fix test error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350118 (owner: Eileen) [00:43:23] ejegg: I found the class api is actually incompatible with later mysqli driver now in Civi & probably was quickly supporting memory leaks. I have started removing it [00:43:40] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350336 [00:43:42] ooh, nasty [00:43:48] (CR) Eileen: [C: 2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350336 (owner: Eileen) [00:44:09] sorry quietly not quickly [00:44:18] (CR) jerkins-bot: [V: -1] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350336 (owner: Eileen) [00:45:26] (CR) Eileen: [C: 2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350336 (owner: Eileen) [00:47:49] Wow, we have a /lot/ of repos we can ditch: https://phabricator.wikimedia.org/diffusion/query/qNqfmGtbh9uE/#R [00:47:58] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [00:49:14] we don't need our own copy of civicrm-core any more, right? [00:51:46] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [00:55:24] ejegg: probably not - I still do some magic when new releases come out - but I use a copy on github & do rebasing. I hope to get rid of it & get us onto stock civi [00:56:49] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/350338 [00:58:53] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-core] - https://gerrit.wikimedia.org/r/350339 [00:58:58] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-drupal] - https://gerrit.wikimedia.org/r/350340 [00:59:03] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-joomla] - https://gerrit.wikimedia.org/r/350341 [00:59:08] (PS2) Eileen: Minor tweak to prevent e-notice during test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350108 [00:59:10] (PS8) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [00:59:12] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-packages] - https://gerrit.wikimedia.org/r/350342 [00:59:16] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-wordpress] - https://gerrit.wikimedia.org/r/350343 [00:59:24] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit/vendor/totten/git-scan] - https://gerrit.wikimedia.org/r/350344 [00:59:29] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/phpmailer] - https://gerrit.wikimedia.org/r/350345 [00:59:34] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/stomp] - https://gerrit.wikimedia.org/r/350346 [00:59:42] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit/vendor/totten] - https://gerrit.wikimedia.org/r/350347 [00:59:47] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit/vendor] - https://gerrit.wikimedia.org/r/350348 [01:00:19] * ejegg takes finger off The Button [01:02:18] oh wait, that's not a stick insect... [01:02:36] (PS1) Ejegg: Blank deprecated repo [wikimedia/fundraising/twig] - https://gerrit.wikimedia.org/r/350349 [01:03:14] I'm seeing all these 'Welcome Eileen' emails :-) [01:03:25] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [01:03:53] Hehe. New general council, huh? [01:03:59] *sel [01:04:00] thash me [01:05:09] (PS9) Eileen: Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 [01:10:13] first round of removing class_api - https://gerrit.wikimedia.org/r/#/c/350117/ [01:15:33] just trying to remember what was up with that PEAR error hack [01:17:26] eileen1: the hack is 'Overly specific hack to bubble up DB_Error details' ? [01:21:55] this one ? $GLOBALS['_PEAR_default_error_mode'] = NULL; [01:22:08] I can't quite figure it out - I think it is not relevant now [01:22:58] I mean, you added that global to somehow avoid the need for that particular hack? [01:25:15] yeah - there is a have in CRM_Core_Error [01:25:29] I have not removed that yet, but in order to remove it there is an e-notice issue [01:25:37] the hack was put in before I started with wmf [01:25:59] right, I thought we needed it to get the actual details of db errors to bubble up [01:26:11] I don't think so any more [01:26:20] ah, well that's nice! [01:26:23] if we do need 'something' I'd rather figure out what that is [01:26:32] & get it upstreamed [01:26:53] but I think that if we use civicrm_api3 with is_debug = 1 we will get the db error [01:27:18] oh, hmm, but we wouldn't want to use is_debug all the time [01:27:33] i imagine there's some performance hit? [01:27:39] no - only reporting [01:27:58] it's just what gets returned to the api [01:28:22] (PS1) Eileen: Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 [01:28:29] (CR) jerkins-bot: [V: -1] Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 (owner: Eileen) [01:28:46] - am pushing up a stock version to see what happens with our tests - [01:30:37] (PS2) Eileen: Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 [01:31:07] k, I've satisfied myself that the api3 patch doesn't change any of the test assertions [01:32:11] (CR) Ejegg: [C: 2] "TODO: Maybe these 4 lines should go in the test suite setup?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350108 (owner: Eileen) [01:32:21] (CR) Ejegg: [C: 2] Update CiviFixtures to use civicrm_api3. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [01:32:48] thanks ejegg [01:34:10] any time! [01:34:30] (CR) jerkins-bot: [V: -1] Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 (owner: Eileen) [01:36:36] (Merged) jenkins-bot: Minor tweak to prevent e-notice during test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350108 (owner: Eileen) [01:36:38] (CR) jerkins-bot: [V: -1] Update CiviFixtures to use civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [01:37:41] Hmm [01:38:15] d'oh! [01:38:21] the amp change is upstreamed [01:38:35] but I guess the phar hasn't been rebuilt yet [01:38:45] I got that same error just earlier [01:38:45] I'll just copy a fresh one to the CI servers for now [01:38:51] & recheck made it go away [01:39:04] Oh huh, musta hit a different server [01:39:12] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350117 (owner: Eileen) [01:39:18] I'll put a bandaid on 1003 [01:42:42] ohh, there's a 2nd build dir on there [01:42:50] I guess for when it has to do two at once? [01:44:32] well, that one's patched too now [01:45:29] merged! [01:45:59] derp, looking at wrong patch [01:46:59] needed a kick - gate & submit wouldn't re-run, but it's merged now [01:53:30] oh hey, eileen1, mind approving this one? https://gerrit.wikimedia.org/r/350100 [01:53:55] embarrasing error in the earlier patch - put the update function declaration inside the previous fn [01:54:30] think I'm too used to functions all being inside classes and instinctively put it before the last closing curly brace [01:54:51] (CR) Eileen: [C: 2] Fix adding Bijcard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350100 (owner: Ejegg) [01:54:55] ty! [01:55:04] yeah - that seemed pretty simple [01:56:37] ooh, max execution time exceeded on that stock civi upgrade? [01:57:02] dang - I saw that yesterday too & it said it was 10 seconds! [01:57:24] definitely don't want a test taking longer than that [01:58:21] hmm - is that for a single test? [01:58:25] (Merged) jenkins-bot: Fix adding Bijcard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350100 (owner: Ejegg) [01:58:27] not the whole suite? [01:59:04] I'm putting stock civi on staging & I'll chip away at the test side of it [02:00:04] i'm going to merge this other CI-related thing, just a yaml linter run via npm/grunt [02:00:13] passes locally [02:00:20] (PS3) Ejegg: Lint json files from npm / grunt-jsonlint [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [02:00:35] (CR) Ejegg: [C: 2] "Thanks Hashar!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [02:04:06] (Merged) jenkins-bot: Lint json files from npm / grunt-jsonlint [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [02:10:17] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Move staging / unstaging helpers into SmashPig - https://phabricator.wikimedia.org/T163867#3212783 (Ejegg) [02:11:23] (PS1) Ejegg: WIP Move a couple easy staging helpers into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350355 (https://phabricator.wikimedia.org/T163867) [02:14:45] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Move already-encapsulated useful classes into SmashPig - https://phabricator.wikimedia.org/T163868#3212798 (Ejegg) [02:20:09] (PS10) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [02:22:16] (PS6) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 (https://phabricator.wikimedia.org/T163868) [02:27:32] k, I'm going to sign off for the night [02:27:36] see ya eileen1 [03:21:56] (PS1) Eileen: Remove trailing whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350357 [03:32:09] (PS1) Eileen: Remove call to class_api in favour of civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350358 [03:32:11] (PS1) Eileen: Remove call to class_api in favour of civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350359 [03:35:38] (CR) jerkins-bot: [V: -1] Remove call to class_api in favour of civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350359 (owner: Eileen) [03:41:48] (PS2) Eileen: Remove call to class_api in favour of civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350359 [03:53:04] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, Patch-For-Review: Benevity import not updating emails for existing contacts - https://phabricator.wikimedia.org/T161666#3138993 (Eileenmcnaughton... [03:54:08] (PS1) Eileen: Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) [03:54:14] (CR) jerkins-bot: [V: -1] Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) (owner: Eileen) [04:35:24] (PS2) Eileen: Enable CiviCampaign. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350361 (https://phabricator.wikimedia.org/T161758) [04:41:16] (PS22) AndyRussG: [WIP] Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [13:05:08] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 16 failures. Last run 8 minutes ago with 16 failures. Failed resources (up to 3 shown) [13:05:09] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 8 minutes ago with 2 failures. Failed resources (up to 3 shown) [13:05:18] PROBLEM - check_puppetrun on saiph is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 8 minutes ago with 2 failures. Failed resources (up to 3 shown): File[/etc/pam_script/pam_script_auth],File[/var/www/index.html] [13:10:08] RECOVERY - check_puppetrun on frbackup2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [13:10:09] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [13:10:10] RECOVERY - check_puppetrun on saiph is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [15:22:35] cwd: I hope this is true-- https://www.techdirt.com/articles/20170421/12072037207/senate-id-cards-use-photo-chip-rather-than-actual-smart-chip.shtml [15:23:09] ha ha brilliant [16:03:15] Wikimedia-Fundraising-Banners: Fundraising banner display issues with 4+ payment methods e.g. in Argentina - https://phabricator.wikimedia.org/T162352#3214503 (Pcoombe) Open>Resolved Thanks @TSkaff for reviewing these. I've updated current best with the changes. [16:03:18] Wikimedia-Fundraising-Campaigns (Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017)), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Latin America 1 (May 2 - May 30) - https://phabricator.wikimedia.org/T162287#3214505 (Pcoombe) [17:00:30] fr-tech: MODESTY: [17:00:30] Being comfortable that others will discover your greatness. [17:00:31] -- discuss. [17:06:34] Wikimedia-Fundraising-Banners: Desktop small nag appears too early on Italian Wikipedia - https://phabricator.wikimedia.org/T162289#3214810 (Pcoombe) Open>Resolved This was due to the `#siteNotice div { margin: 0; }` rule in https://it.wikipedia.org/wiki/MediaWiki:Vector.css, apparently introduced in... [18:15:47] (CR) Ejegg: "Need logic to avoid complaining about missing required fields on first form display" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [18:34:37] XenoRyet: free for a call? Hoping to talk out how to make ^^^ work [18:36:04] Sure, for a little while. Gotta meet someone at noon, but I could talk until then. [18:37:20] I'm in -talk [18:44:23] (PS7) Ejegg: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [18:44:25] (PS17) Ejegg: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [18:44:27] (PS1) Ejegg: WIP only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 [18:46:35] (CR) jerkins-bot: [V: -1] WIP only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (owner: Ejegg) [19:27:17] bwahahaha just one more small file to proofread/comment! [19:35:49] (PS2) Ejegg: WIP only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 [19:37:54] (CR) jerkins-bot: [V: -1] WIP only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (owner: Ejegg) [19:42:09] (PS26) AndyRussG: Custom campaign mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) [19:45:36] (PS23) AndyRussG: Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [19:46:19] Adieu, WIP tag pour banner séquence!!!!! [20:14:34] (PS3) Ejegg: WIP only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 [20:15:13] AndyRussG: woohoo! [21:19:55] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API call to create hosted payment - https://phabricator.wikimedia.org/T163946#3215775 (Ejegg) [21:27:12] every time I open my email I see more 'welcome Eileen' messages :-) [21:41:02] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3215828 (Ejegg) [21:43:09] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API calls to get payment status - https://phabricator.wikimedia.org/T163948#3215844 (Ejegg) [21:59:55] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API calls to capture or cancel payments - https://phabricator.wikimedia.org/T163952#3215970 (Ejegg) [22:01:00] (PS3) XenoRyet: Ingenico server timeout fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832) [22:05:13] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API call to tokenize payments - https://phabricator.wikimedia.org/T163953#3215996 (Ejegg) [22:11:55] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API calls for tokenized payments - https://phabricator.wikimedia.org/T163953#3216014 (Ejegg) [22:22:09] Fundraising-Backlog: Paypal std possibly going to stop supporting redirect with GET - https://phabricator.wikimedia.org/T163955#3216042 (Eileenmcnaughton) [22:24:23] Fundraising-Backlog: Add firewall hole for staging to access silverpop - https://phabricator.wikimedia.org/T163956#3216054 (Eileenmcnaughton) [22:29:18] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#3216067 (XenoRyet) [22:29:20] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#3216066 (XenoRyet) Open>Resolved [22:30:09] Fundraising-Backlog, Recurring-Donations, Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#3216083 (XenoRyet) [22:30:11] Fundraising-Backlog, Recurring-Donations: WorldPay Recurring - https://phabricator.wikimedia.org/T103448#3216084 (XenoRyet) [22:30:14] Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, and 5 others: Move gateway-specific normalizations out of recurring.module - https://phabricator.wikimedia.org/T107372#3216082 (XenoRyet) Open>... [22:31:33] Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, and 3 others: IPN listener should normalize new PayPal recurring messages - https://phabricator.wikimedia.org/T157074#3216089 (XenoRye... [22:32:23] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, and 3 others: Need to distinguish between paypal and paypal_ec for refund IPN messages - https://phabricator.wikimedia.org/T161121#3216091 (XenoRyet... [22:32:53] (PS1) Ejegg: Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) [22:34:53] (CR) jerkins-bot: [V: -1] Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) (owner: Ejegg) [22:35:10] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, and 2 others: Get rid of -new suffix on refund and recurring queues - https://phabricator.wikimedia.org/T162852#3216114 (Ejegg) Open>Resolved [22:35:18] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-Ingenico: SmashPig failing with Ingenico "NO DIRECTORY FOUND" - https://phabricator.wikimedia.org/T162087#3216115 (Ejegg) Open>Resolved [22:35:29] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), and 2 others: payments frontend sending duplicate malformed queue messages for EC recurring - https://phabricator.wikimedia.org/T163281#3216116 (Eje... [22:35:38] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-Paypal, Recurring-Donations, Patch-For-Review: Paypal recurring donations missing contribution_tracking link since 2017-04-10 - https://phabricator.wikimedia.org/T163443#3216117 (Ejegg) Open>Resolved [22:40:11] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-Ingenico: break out Ingenico reintegration work - https://phabricator.wikimedia.org/T162840#3176676 (Ejegg) a:Ejegg [22:40:45] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog: recheck onboarding docs and steps - https://phabricator.wikimedia.org/T162832#3216131 (cwdent) a:cwdent [22:42:06] (PS24) AndyRussG: Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [22:42:28] Wikimedia-Fundraising-Campaigns: Fundraise in India - https://phabricator.wikimedia.org/T131118#3216137 (Ejegg) [22:42:30] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#3216136 (Ejegg) [22:42:33] Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, and 7 others: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#3216135 (Ejegg) O... [22:42:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add firewall hole for staging to access silverpop - https://phabricator.wikimedia.org/T163956#3216138 (DStrine) [22:43:36] Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout 1 hour test - https://phabricator.wikimedia.org/T131816#2179341 (Ejegg) [22:43:39] Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, and 7 others: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#1268061 (Ejegg) R... [22:44:04] Fundraising-Backlog, FR-Paypal: Paypal std possibly going to stop supporting redirect with GET - https://phabricator.wikimedia.org/T163955#3216144 (DStrine) [22:45:25] Fundraising-Backlog, FR-Paypal: Paypal std possibly going to stop supporting redirect with GET - https://phabricator.wikimedia.org/T163955#3216162 (Eileenmcnaughton) Just noting the reason I thought of this is I logged this with Civi in response to an email mid-last-year https://issues.civicrm.org/jira/... [22:49:07] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising-Backlog, and 2 others: Spike: investigate getting silverpop data into civi - https://phabricator.wikimedia.org/T159767#3216168 (Eileenmcnaughton) Open>... [22:50:17] Fundraising Sprint I 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add firewall hole for staging to access silverpop - https://phabricator.wikimedia.org/T163956#3216171 (DStrine) [22:50:20] Fundraising Sprint I 2017, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Paypal: deal with 10486 (redirect donor back to pp) - https://phabricator.wikimedia.org/T163458#3216175 (DStrine) [22:50:21] Fundraising Sprint I 2017, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, and 2 others: Move staging / unstaging helpers into SmashPig - https://phabricator.wikimedia.org/T163867#3216173 (DStrine) [22:50:24] Fundraising Sprint I 2017, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, and 2 others: Move already-encapsulated useful classes into SmashPig - https://phabricator.wikimedia.org/T163868#3216172 (DStrine) [22:50:26] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog: recheck onboarding docs and steps - https://phabricator.wikimedia.org/T162832#3216178 (DStrine) [22:50:28] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog, FR-Ingenico: break out Ingenico reintegration work - https://phabricator.wikimedia.org/T162840#3216177 (DStrine) [22:50:31] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Admin UI for campaigns may submit input with errors - https://phabricator.wikimedia.org/T163057#3216176 (DStrine) [22:50:32] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog, Patch-For-Review: process-control lock contention cronspam - https://phabricator.wikimedia.org/T162738#3216179 (DStrine) [22:50:34] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog: Develop shared understanding of definition of Tech Debt - https://phabricator.wikimedia.org/T161817#3216180 (DStrine) [22:50:36] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog, and 3 others: retrieve the text/ html and statistics data for mail we have sent - https://phabricator.wikimedia.org/T161758#3216181 (DStrine) [22:50:38] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog, FR-Amazon: NULL referrers - https://phabricator.wikimedia.org/T161539#3216182 (DStrine) [22:50:41] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint I 2017, Fundraising-Backlog, and 3 others: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3216183 (DStrine) [22:50:43] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint I 2017, Fundraising-Backlog: process-control will need to run some jobs sequentially - https://phabricator.wikimedia.org/T161035#3216184 (DStrine) [22:50:48] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, and 2 others: Errors in CiviCRM dedupe scrren - https://phabricator.wikimedia.org/T160571#3216185 (DStrine) [22:50:51] Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, and 5 others: [Tech Debt] Consolidate DonationInterface validation - https://phabricator.wikimedia.org/T160385#3216186 (DStrine) [22:50:52] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 8 others: Mediawiki namespace pages, including CentralNotice banners, are slow to sa... - https://phabricator.wikimedia.org/T158084#3216187 [22:50:55] Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, and 5 others: Review fr-tech data retention guidelines - https://phabricator.wikimedia.org/T156317#3216189 (DStrine) [22:50:58] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint I 2017, Fundraising-Backlog, Patch-For-Review: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3216192 (DStrine) [22:51:01] Fundraising Sprint I 2017, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#3216194 (DStrine) [22:51:05] Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, and 8 others: CentralNotice banner sequence: implement feature for MVP - https://phabricator.wikimedia.org/T144453#3216191 (DStrine) [22:51:08] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint Dirt Farming, and 10 others: Store and update list of currently working iDEAL banks - https://phabricator.wikimedia.org/T128692#3216193 (DStrine) [22:51:10] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, and 9 others: Purge Varnish cache when a banner is saved - https://phabricator.wikimedia.org/T154954#3216190 (DStrine) [22:51:13] Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, and 8 others: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#3216195 (DStrine) [23:04:05] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/350338 (owner: Ejegg) [23:04:55] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-core] - https://gerrit.wikimedia.org/r/350339 (owner: Ejegg) [23:05:50] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-drupal] - https://gerrit.wikimedia.org/r/350340 (owner: Ejegg) [23:05:57] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-joomla] - https://gerrit.wikimedia.org/r/350341 (owner: Ejegg) [23:06:05] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-packages] - https://gerrit.wikimedia.org/r/350342 (owner: Ejegg) [23:07:16] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit/vendor/totten/git-scan] - https://gerrit.wikimedia.org/r/350344 (owner: Ejegg) [23:08:06] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-wordpress] - https://gerrit.wikimedia.org/r/350343 (owner: Ejegg) [23:08:16] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/phpmailer] - https://gerrit.wikimedia.org/r/350345 (owner: Ejegg) [23:08:28] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/stomp] - https://gerrit.wikimedia.org/r/350346 (owner: Ejegg) [23:08:42] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit/vendor/totten] - https://gerrit.wikimedia.org/r/350347 (owner: Ejegg) [23:09:08] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/civicrm-buildkit/vendor] - https://gerrit.wikimedia.org/r/350348 (owner: Ejegg) [23:09:28] (CR) Ejegg: [V: 2 C: 2] Blank deprecated repo [wikimedia/fundraising/twig] - https://gerrit.wikimedia.org/r/350349 (owner: Ejegg) [23:20:28] eileen1: ah yeah that does look like an iptables thing so may not involve netops [23:21:02] cwd - cool [23:22:35] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint Dirt Farming, and 9 others: Store and update list of currently working iDEAL banks - https://phabricator.wikimedia.org/T128692#3216283 (Ejegg) [23:22:45] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog, FR-Smashpig, and 2 others: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3216284 (Ejegg) [23:26:26] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog: process-control will need to run some jobs sequentially - https://phabricator.wikimedia.org/T161035#3119337 (Ejegg) With consume/thank you, I think... [23:37:40] (PS2) Ejegg: Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) [23:48:59] (PS4) Ejegg: Only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (https://phabricator.wikimedia.org/T160385) [23:54:12] (CR) Ejegg: [C: 2] Ingenico server timeout fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832) (owner: XenoRyet) [23:56:10] (Merged) jenkins-bot: Ingenico server timeout fix [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350277 (https://phabricator.wikimedia.org/T157832) (owner: XenoRyet)