[00:10:05] cwd - changing to https still works locally - so that port 80 in what I sent should be ignored [00:20:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:20:42] * cwd puts phone on silent [00:25:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:30:05] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:35:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:36:25] (CR) Ejegg: [C: -1] "This is great! One concern about custom control placement." (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [00:40:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:45:05] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:48:07] (CR) Ejegg: [C: 2] "Ah, I see now that the input element is a hidden var used to submit the form, not the visible inputs! Looks great." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [00:50:00] (CR) jerkins-bot: [V: -1] Custom campaign mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [00:50:17] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:55:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:00:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:02:22] (CR) Ejegg: [C: 2] "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [01:04:43] (Merged) jenkins-bot: Custom campaign mixin param handlers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [01:05:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:10:05] PROBLEM - check_mysql on db1025 is CRITICAL: Cant connect to local MySQL server through socket /tmp/mysql.sock (2) [01:10:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:15:15] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:15:15] PROBLEM - check_mysql on db1025 is CRITICAL: Cant connect to local MySQL server through socket /tmp/mysql.sock (2) [01:16:26] (PS1) Ejegg: Use consistent width constraints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350506 [01:20:05] PROBLEM - check_mysql on db1025 is CRITICAL: Cant connect to local MySQL server through socket /tmp/mysql.sock (2) [01:20:06] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [01:25:09] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 1688406 Threads: 1 Questions: 46443062 Slow queries: 9074 Opens: 9731 Flush tables: 1 Open tables: 602 Queries per second avg: 27.507 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [01:26:53] ejegg|away: thanks!!!! [03:31:47] (CR) AndyRussG: "Thanks much!!!!! :D" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [04:24:06] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog: recheck onboarding docs and steps - https://phabricator.wikimedia.org/T162832#3216627 (cwdent) https://wikitech.wikimedia.org/wiki/Fundraising Quick overview of the different wikis would b... [06:01:37] (PS1) Eileen: WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 [06:02:40] (CR) jerkins-bot: [V: -1] WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 (owner: Eileen) [06:09:32] (PS2) Eileen: WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 [06:10:32] (CR) jerkins-bot: [V: -1] WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 (owner: Eileen) [06:14:19] (PS3) Eileen: WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 [06:15:25] (CR) jerkins-bot: [V: -1] WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 (owner: Eileen) [06:19:19] (PS4) Eileen: WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 [06:22:57] (CR) jerkins-bot: [V: -1] WIP Replace rest of class_api instances [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350510 (owner: Eileen) [08:40:08] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet last ran 8 hours ago [08:45:08] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet last ran 8 hours ago [08:50:08] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet last ran 8 hours ago [08:55:08] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 29 seconds ago with 0 failures [12:46:22] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#3217343 (Jgreen) [12:46:24] fundraising-tech-ops: replace db1025 with new hardware running jessie - https://phabricator.wikimedia.org/T145107#3217341 (Jgreen) Open>Resolved done! [12:47:00] fundraising-tech-ops: decommission beryllium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T147934#3217344 (Jgreen) [12:47:02] fundraising-tech-ops: frack eqiad hardware refresh - https://phabricator.wikimedia.org/T133524#2234514 (Jgreen) [15:16:32] (PS1) AndyRussG: campaignManager.js: Comments and doc for custom mixin UIs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/350577 [15:26:35] Fundraising Sprint UB40, Fundraising-Backlog: contribution_source triggers failed for 3% of a sample of donations - https://phabricator.wikimedia.org/T98643#3217991 (Pcoombe) As @awight determined above, this does seem to happen when there are more than 3 terms in the utm_source. This can be due to an er... [15:51:13] (PS1) AndyRussG: Campaign mixin config: remove customAdminUIControls prop and improve README [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/350588 (https://phabricator.wikimedia.org/T144453) [15:51:28] (PS25) AndyRussG: Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [15:53:34] Jeff_Green: how's it lookin? [15:55:38] (CR) AndyRussG: "Comments addressed in follow-on changes Id04030dc3e and Ifccb8c5414a. Thanks again!!!!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/343953 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [16:10:05] cwd: so far so good [16:14:15] \o/ [16:14:52] indeed [16:15:05] so now we can pull db1025 from the rack and start on frlog1001 [16:21:33] it's going in its place? [16:22:05] yup [16:24:34] fr-tech: Unless anybody has objections, I'm going to do a donation interface deploy to get that Ingenico fix out. [16:25:34] XenoRyet: have fun! [16:25:59] When might be good for folks for chatting about Banner Sequence (BS), BTW? [16:27:05] Looks like we've got metrics meeting later this morning, but I'm good any time outside of that and standup. So whatevere's good with you and ejegg works for me. [16:29:52] i can chat BS in 5 minutes [16:30:54] ejegg: sure... XenoRyet? [16:32:23] Yea, go ahead and get started and I'll jump in when I finish this deploy. [16:32:48] (PS1) XenoRyet: Merge branch 'master' into HEAD [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350599 [16:33:10] K :) [16:33:17] (Abandoned) XenoRyet: Merge branch 'master' into HEAD [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350599 (owner: XenoRyet) [16:34:42] want to discuss it in -talk? [16:36:53] ejegg: yep! [16:37:38] ejegg: just gimme 1 min to grab some bread 'n' cheeze [16:41:38] (PS1) XenoRyet: Merge branch 'master' into deployment 3ea71cd Integration test that the PayPal legacy gateway shows an error form rather than redirect. 9b27304 Remove deprecated function c80fbb1 Comments and todos 67453c2 Add paypal_ec to form settings 8405d8b Ingenico s [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350601 [16:41:58] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment 3ea71cd Integration test that the PayPal legacy gateway shows an error form rather than redirect. 9b27 [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350601 (owner: XenoRyet) [16:59:09] (Merged) jenkins-bot: Merge branch 'master' into deployment 3ea71cd Integration test that the PayPal legacy gateway shows an error form rather than redirect. 9b27304 Remove deprecated function c80fbb1 Comments and todos 67453c2 Add paypal_ec to form settings 8405d8b Ingenico s [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350601 (owner: XenoRyet) [17:00:30] fr-tech: On the day of his anniversary, Joe was frantically shopping [17:00:31] around for a present for his wife. He knew what she wanted, a [17:00:31] grandfather clock for the living room, but he found the right one [17:00:31] almost impossible to find. Finally, after many hours of searching, Joe [17:00:31] found just the clock he wanted, but the store didn't deliver. Joe, [17:00:31] desperate, paid the shopkeeper, hoisted the clock onto his back, and [17:00:31] staggered out onto the sidewalk. On the way home, he passed a bar. [17:00:32] Just as he reached the door, a drunk stumbled out and crashed into Joe, [17:00:32] sending himself, Joe, and the clock into the gutter. Murphy's law [17:00:33] being in effect, the clock ended up in roughly a thousand pieces. [17:00:33] "You stupid drunk!" screamed Joe, jumping up from the [17:00:34] wreckage. "Why don't you look where the hell you're going!" [17:00:34] With quiet dignity the drunk stood up somewhat unsteadily and [17:00:35] dusted himself off. "And why don't you just wear a wristwatch like a [17:05:43] (PS1) XenoRyet: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350606 [17:05:53] (CR) XenoRyet: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350606 (owner: XenoRyet) [17:12:29] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350606 (owner: XenoRyet) [17:20:09] !log Updated paymentswiki from ee7d402216f6eae71cc85137741187ab096ead33 to 030b2f90b155aea8fd3aea4aecf73d0a41d6482b [17:20:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:25:44] !log reverted paymentswiki from 030b2f90b155aea8fd3aea4aecf73d0a41d6482b to ee7d402216f6eae71cc85137741187ab096ead33 [17:25:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:44:29] !log Updated paymentswiki from ee7d402216f6eae71cc85137741187ab096ead33 to 030b2f90b155aea8fd3aea4aecf73d0a41d6482b [17:44:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:27:57] Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Paypal: deal with 10486 (redirect donor back to pp) - https://phabricator.wikimedia.org/T163458#3198208 (Ejegg) a:Ejegg [18:33:26] (PS18) Ejegg: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [18:34:07] (PS8) Ejegg: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [18:34:59] (PS5) Ejegg: Only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (https://phabricator.wikimedia.org/T160385) [18:35:12] (PS3) Ejegg: Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) [18:35:38] XenoRyet: would you mind trying those things out locally? ^^^ [18:40:46] !log Roll back paymentswiki from 030b2f90b155aea8fd3aea4aecf73d0a41d6482b to ee7d402216f6eae71cc85137741187ab096ead33 [18:40:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:46:20] (PS1) Ejegg: Fix paypal form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350633 [18:48:33] (CR) jerkins-bot: [V: -1] Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [18:48:35] (CR) jerkins-bot: [V: -1] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [18:49:04] XenoRyet: This should fix the deploy: https://gerrit.wikimedia.org/r/350633 [18:49:18] looking [18:50:01] (CR) jerkins-bot: [V: -1] Only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (https://phabricator.wikimedia.org/T160385) (owner: Ejegg) [18:51:51] (PS9) Ejegg: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [18:51:52] (PS19) Ejegg: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [18:51:55] (PS6) Ejegg: Only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (https://phabricator.wikimedia.org/T160385) [18:52:36] (CR) XenoRyet: [C: 2] Fix paypal form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350633 (owner: Ejegg) [18:52:46] (CR) jerkins-bot: [V: -1] Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) (owner: Ejegg) [18:54:55] (Merged) jenkins-bot: Fix paypal form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350633 (owner: Ejegg) [18:57:00] Ok, that's merged. Going to deploy again. [18:58:12] thanks! [18:58:22] Sorry I hadn't tried out the form chooser on that one [19:02:59] (PS1) XenoRyet: Merge branch 'master' into deployment b9c3d5e Fix paypal form settings [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350639 [19:03:17] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment b9c3d5e Fix paypal form settings [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350639 (owner: XenoRyet) [19:05:09] (Merged) jenkins-bot: Merge branch 'master' into deployment b9c3d5e Fix paypal form settings [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350639 (owner: XenoRyet) [19:07:28] (PS1) XenoRyet: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350640 [19:07:50] (CR) XenoRyet: [C: 2] Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350640 (owner: XenoRyet) [19:14:22] (Merged) jenkins-bot: Update DonationInterface Submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350640 (owner: XenoRyet) [19:20:47] !log Updated paymentswiki from ee7d402216f6eae71cc85137741187ab096ead33 to 1620b8233321099262ff4333a2269f0563107e66 [19:20:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:21:34] * ejegg crosses fingers [19:30:56] fundraising-tech-ops, Operations, ops-eqiad: move frdb1002 from pfw1 to pfw2 - https://phabricator.wikimedia.org/T163268#3218937 (Cmjohnson) Open>Resolved This has been fixed....confirmed wokring via IRC w/Jeff cmjohnson1 okay done Jeff_Green he shut off 11/0/14 Jeff_Green it's responding to... [19:32:51] (PS1) Ejegg: Test with real form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350647 [19:33:08] XenoRyet: here's a test that would have caught that breakage ^^^ [19:33:56] Heh, I guess that's one way to find out where we need more tests. [19:36:59] (CR) XenoRyet: [C: 2] Test with real form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350647 (owner: Ejegg) [19:40:38] (PS4) Ejegg: Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) [19:42:48] XenoRyet: I'm really hoping to get awight's changes and the fixes merged before we do much more in DonationInterface. They're pretty extensive, so rebasing will quickly get messy [19:43:33] Do you think you can look at https://gerrit.wikimedia.org/r/350462 some today? [19:43:43] Yea, for sure. [19:44:03] I'm about ready to merge its parent patches, but I wouldn't want to leave them without that fix for long [19:44:29] Yea, I'll check it out after standup [19:44:38] oh right, standup time! [19:45:01] Thank you XenoRyet [19:45:10] No worries [19:46:19] (Merged) jenkins-bot: Test with real form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350647 (owner: Ejegg) [19:46:56] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad, Patch-For-Review: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3218993 (Dzahn) [19:47:18] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad, Patch-For-Review: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3181286 (Dzahn) added decom checklist template from https://wikitech.wikimedia.org/wiki/Server_Lifecycle/reclaim_checklist [21:08:38] (PS2) Ejegg: Get rid of MultiQueueWriter, 'verified' alias [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/349086 [21:20:04] (CR) Ejegg: [C: -1] "Oops, need to fix normalizedMessage stuff to be arrays. Also should add some tests about that!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/349086 (owner: Ejegg) [21:28:27] ejegg: ok i think we are probably ready to roll the new p-c [21:28:32] do you want to check it out on fr-dev? [21:28:39] cwd sure thing [21:29:22] k, looks like it's running the dedupe job! [21:32:47] ejegg: can you think of any reason not to update it live? [21:34:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#3219445 (Nemo_bis) >>! In T28234#3164147, @AndyRussG wrote: > No, I'm afraid that page is completel... [21:47:29] cwd I think we're all set to go... [21:50:41] (PS3) Ejegg: Get rid of MultiQueueWriter, 'verified' alias [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/349086 [21:51:41] (CR) jerkins-bot: [V: -1] Get rid of MultiQueueWriter, 'verified' alias [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/349086 (owner: Ejegg) [21:57:27] !log updated process-control to 1.0.6 [21:57:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:59:53] (PS4) Ejegg: Get rid of MultiQueueWriter, 'verified' alias [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/349086 [22:02:42] (PS5) Ejegg: Get rid of MultiQueueWriter, 'verified' alias [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/349086 [22:04:04] (PS1) Ejegg: Remove unused imports [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350751 [22:04:11] (CR) XenoRyet: [C: 2] "Looks good, does the job." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (https://phabricator.wikimedia.org/T160385) (owner: Ejegg) [22:05:38] (CR) Ejegg: [C: 2] "TODO: validation rules to reject at least angle brackets" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [22:07:25] (Merged) jenkins-bot: Stop prematurely escaping [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342047 (owner: Awight) [22:08:17] (CR) Ejegg: [C: 2] Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [22:09:23] Thanks XenoRyet ! I need to make that validation rule to reject angle brackets [22:09:53] (Merged) jenkins-bot: Deprecate "manual" errors and shift responsibility for validation into the adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341727 (https://phabricator.wikimedia.org/T160385) (owner: Awight) [22:10:09] Oh, here's another one little fix to go with those awight patches: https://gerrit.wikimedia.org/r/350495 [22:10:11] (Merged) jenkins-bot: Only check for required fields in do_transaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350462 (https://phabricator.wikimedia.org/T160385) (owner: Ejegg) [22:10:21] (PS5) Ejegg: Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) [22:11:59] (PS2) Ejegg: Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [22:16:12] (PS5) Ejegg: Remove "too many banners" warning [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247785 (https://phabricator.wikimedia.org/T109714) (owner: Awight) [22:16:19] (CR) Ejegg: [C: 2] Remove "too many banners" warning [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247785 (https://phabricator.wikimedia.org/T109714) (owner: Awight) [22:17:53] (PS2) Ejegg: [WIP] Remove irrelevant test? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341722 (owner: Awight) [22:18:23] (PS3) Ejegg: Remove irrelevant test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341722 (owner: Awight) [22:18:31] (CR) Ejegg: [C: 2] Remove irrelevant test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341722 (owner: Awight) [22:23:49] (Merged) jenkins-bot: Remove "too many banners" warning [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247785 (https://phabricator.wikimedia.org/T109714) (owner: Awight) [22:27:34] (Merged) jenkins-bot: Remove irrelevant test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/341722 (owner: Awight) [22:29:11] Fundraising-Backlog: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3219608 (CCogdill_WMF) [22:35:28] (PS1) Ejegg: Use non-deprecated PHPunit mock creator [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350759 [22:36:26] (CR) jerkins-bot: [V: -1] Use non-deprecated PHPunit mock creator [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350759 (owner: Ejegg) [22:48:10] (PS1) Ejegg: Disallow angle brackets in name and address [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350761 [22:48:53] XenoRyet: I think we should merge ^^^ before we deploy the error simplification patches [22:49:11] I'll take a look [22:49:14] thank you [22:52:33] (CR) Ejegg: [C: -1] "Oops, that's only valid in PHPUnit >= 5.4.0" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350759 (owner: Ejegg) [22:53:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234#298567 (Jseddon) Not currently no. [22:53:46] (CR) XenoRyet: [C: 2] "Yep, angle brackets disallowed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350761 (owner: Ejegg) [22:55:31] (Merged) jenkins-bot: Disallow angle brackets in name and address [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350761 (owner: Ejegg) [23:01:22] whee! [23:11:11] ok, looks like the payment methods are generally still working. Let's try deploying this stuff... [23:12:59] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350764 [23:13:05] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350764 (owner: Ejegg) [23:14:07] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/350764 (owner: Ejegg) [23:14:46] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350772 [23:14:49] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350772 (owner: Ejegg) [23:24:17] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/350772 (owner: Ejegg) [23:27:24] !log udated payments-wiki from 1620b8233321099262ff4333a2269f0563107e66 to 4c5630283c57efbc454cc70d47218f7f22ea252a [23:27:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:29:28] !log rolled back payments-wiki to 1620b8233321099262ff4333a2269f0563107e66 [23:29:32] oof [23:29:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:30:52] wha happen? [23:33:37] whitescreen on every page [23:33:40] nothing in the logs