[01:15:29] !log udated payments-wiki from 1620b8233321099262ff4333a2269f0563107e66 to 4c5630283c57efbc454cc70d47218f7f22ea252a [01:15:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:18:33] !log rolled payments-wiki back to 1620b8233321099262ff4333a2269f0563107e66 [01:18:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:14:22] Wikimedia-Fundraising-Campaigns (Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017)), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Latin America 1 (May 2 - May 30) - https://phabricator.wikimedia.org/T162287#3221374 (Pcoombe) [16:14:25] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Donation form extends off the right side of the page in some mobile browsers - https://phabricator.wikimedia.org/T149247#3221372 (Pcoombe) Open>Resolved Fixed on donatewiki. * reduced padding a little on mobi... [16:16:58] Fundraising-Backlog: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3221375 (CCogdill_WMF) @MNoorWMF adding Moska here. [16:19:28] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: Maybe Later link in desktop small banner nag not working in IE9/10 - https://phabricator.wikimedia.org/T162049#3221405 (Pcoombe) [16:50:13] PROBLEM - check_puppetrun on heka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 8 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/archive/database_dumps] [16:55:10] RECOVERY - check_puppetrun on heka is OK: OK: Puppet is currently enabled, last run 5 seconds ago with 0 failures [17:00:30] fr-tech: It is possible that blondes also prefer gentlemen. [17:00:30] -- Maimie Van Doren [17:00:31] -- discuss. [17:13:21] (PS3) Ejegg: Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:13:59] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:14:27] (CR) jerkins-bot: [V: -1] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:15:11] (CR) jerkins-bot: [V: -1] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:19:15] (CR) Ejegg: "Oh hey, just realized that those svgs are full of fluff, if you wanted to (over)optimize: http://petercollingridge.appspot.com/svg-optimis" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [17:20:10] PROBLEM - check_puppetrun on boron is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [17:20:31] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:22:05] (CR) jerkins-bot: [V: -1] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:25:10] RECOVERY - check_puppetrun on boron is OK: OK: Puppet is currently enabled, last run 39 seconds ago with 0 failures [17:42:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: Tracking Task: Banners immediately returning after being dismissed. - https://phabricator.wikimedia.org/T164099#3221641 (DStrine) [17:53:17] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [17:54:39] (CR) jerkins-bot: [V: -1] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [18:01:19] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [18:02:14] mepps: Hello and welcome! [18:09:29] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: Maybe Later link in desktop small banner nag not working in IE9/10 - https://phabricator.wikimedia.org/T162049#3221719 (Pcoombe) Open>Resolved Well this was **fun**. Seems it was down to the jQuery .focus() method being called on t... [18:11:10] (CR) jerkins-bot: [V: -1] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [18:26:26] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [18:27:33] (CR) jerkins-bot: [V: -1] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [18:31:08] (CR) Ejegg: [C: 2] Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [18:33:25] (Merged) jenkins-bot: Remove an unused default parameter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/343969 (owner: Awight) [19:06:43] (PS2) Ejegg: Lint PHP files using composer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:13:06] (PS3) Ejegg: Lint PHP files using composer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:18:19] (CR) Ejegg: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:51:55] (CR) Ejegg: [C: 2] Lint PHP files using composer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:56:15] (Merged) jenkins-bot: Lint PHP files using composer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350190 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [19:56:22] (PS1) Ejegg: Tweak smashpig initialiazation order [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350895 (https://phabricator.wikimedia.org/T128692) [20:23:09] cwd did you find anything appalling in f_c_u ? [20:26:37] Jeff_Green: it looks fine to me [20:26:58] ok gonna deploy it [20:31:59] testing with a civicrm-authonly deploy to frdev1001 [20:42:55] fr-tech: hi everyone! I'm also on phabricator now under mepps [20:43:45] mepps: o/ [20:43:56] nice! [20:44:04] you have an enviable first letter last name combo [20:44:06] hi mepps! [20:45:33] cwd thanks! i like it except on wikipedia someone has already used my username... :/ [20:45:45] hi Jeff_Green! [20:54:51] Jeff_Green: did that deploy go alright? [20:55:33] yeah [20:55:41] great! [20:55:44] thinking about the snafu, it should just work, right? [20:56:15] Yep, I'll check timestamps after I f_c_u again to make sure [20:56:16] files with changed contents will get refreshed by git, mtime will change even if file size doesnt [20:56:19] k [20:57:16] mepps: speaking of phab, i just cc'd you on a ticket where i was fixing to post some onboarding docs [20:57:31] unfortunately we don't have anything like that so i just chose some random technical docs [20:58:18] https://phabricator.wikimedia.org/T162832 [20:59:12] Jeff_Green: yep, timestamps on the two trivially changed files are updated to just now [20:59:20] rsync oughtta get 'em [20:59:30] great [21:00:04] !log updated payments-wiki from 1620b8233321099262ff4333a2269f0563107e66 to 4c5630283c57efbc454cc70d47218f7f22ea252a [21:00:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:03:02] `cool, looks like it's all working [21:03:15] great [21:14:14] (PS1) Ejegg: Lint .module, .install, .inc PHP files too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350907 [21:26:31] * Jeff_Green heading out, have a good weekend! [21:39:24] (PS26) AndyRussG: Banner sequence campaign mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) [21:42:34] (CR) AndyRussG: "As per discussion, improved overall error tracking for banner sequence UI. However, I left in the per-step error trackers, since each step" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [22:24:43] (PS1) Ejegg: WIP processDonorReturn returns PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350959 (https://phabricator.wikimedia.org/T163458) [22:24:45] (PS1) Ejegg: WIP Paypal EC: send donor back to PP on code 10486 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458) [22:25:07] XenoRyet: does that look like a sane way to do it? ^^^ [22:26:59] (CR) jerkins-bot: [V: -1] WIP Paypal EC: send donor back to PP on code 10486 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458) (owner: Ejegg) [22:35:43] ejegg: I'll take a look a bit later. Need to be on Dad patrol for a bit here. [22:36:12] (PS2) Ejegg: WIP Paypal EC: send donor back to PP on code 10486 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458) [22:50:16] Hi mepps!! Welcome!!!!!!! :D [23:00:47] (PS2) Ejegg: WIP processDonorReturn returns PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350959 (https://phabricator.wikimedia.org/T163458) [23:25:27] it's dinner time [23:48:34] (PS3) Ejegg: processDonorReturn returns PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350959 (https://phabricator.wikimedia.org/T163458) [23:57:27] (PS3) Ejegg: WIP Paypal EC: send donor back to PP on code 10486 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458)