[00:07:28] (PS4) Ejegg: Paypal EC: send donor back to PP on code 10486 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458) [00:20:37] ok, I think that should do it! ^ [05:33:38] (CR) XenoRyet: [C: 2] "Makes sense, and does the trick." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458) (owner: Ejegg) [05:37:48] thanks XenoRyet|dadding - does the parent patch look good too? [05:38:07] Just looking through that one, but yea it's looking good so far,. [05:38:11] rockin [05:39:00] I tried to secure it with tests pretty well, but I haven't really verified it locally [05:39:34] those return-from-processor bits being the most difficult to actually hit on a test rig... [05:40:08] Yea, it's pretty hard to do. The tests seem comprehensive enough to keep us safe though. [05:46:44] * ejegg fades back into the night [05:47:49] (CR) XenoRyet: [C: 2] processDonorReturn returns PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350959 (https://phabricator.wikimedia.org/T163458) (owner: Ejegg) [05:47:56] Yep, that's it for me too. [05:49:35] (Merged) jenkins-bot: processDonorReturn returns PaymentResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350959 (https://phabricator.wikimedia.org/T163458) (owner: Ejegg) [05:49:41] (Merged) jenkins-bot: Paypal EC: send donor back to PP on code 10486 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350960 (https://phabricator.wikimedia.org/T163458) (owner: Ejegg) [17:00:31] fr-tech: How doth the little crocodile [17:00:32] Improve his shining tail, [17:00:32] And pour the waters of the Nile [17:00:32] On every golden scale! [17:00:32] How cheerfully he seems to grin, [17:00:33] How neatly spreads his claws, [17:00:33] And welcomes little fishes in, [17:00:33] With gently smiling jaws! [17:00:33] -- Lewis Carroll, "Alice's Adventures in Wonderland" (1865) [17:00:33] -- discuss.