[00:27:35] ejegg: there is a test issue that drove me to distraction yesterday - if I run DonationQueueTest [00:27:35] class in isolation it always fails [00:27:51] Oh? [00:28:07] if I run AntifraudQueueTest [00:28:07] & BannerHistoryTest [00:28:07] test first it passes [00:28:17] ah jeez, missing test setup? [00:28:42] DonationQueueTest is the first one to instantiate the PendingDB [00:28:59] I think it needs this to run first [00:29:00] $config = TestingSmashPigDbQueueConfiguration::instance(); [00:29:29] thanks! I can make that patch [00:29:44] but I can't just add that as I get the error I get for BannerTest if run in isolation then.... [00:29:46] Fatal error: Call to a member function addEventToContext() on null in /Users/emcnaughton/buildkit/build/d46/vendor/wikimedia/smash-pig/Core/Logging/Logger.php on line 130 [00:30:29] because Context::initWithLogger( $config ); [00:30:30] is futher down [00:30:33] I think [00:30:47] errr, huh, lemme replicate [00:32:48] freaky, call to undefined setDisallowChangesToGlobalState [00:35:09] red herring... that was a phpunit version mismatch thing [00:38:21] oops, no, we need to put the mock pending db settings in the QueueTestConfiguration [00:39:57] oho, that's what the config_db_and_queue.yaml file is for [00:40:02] but... we're not using it [00:43:42] guh, that still breaks [00:45:49] (PS1) Ejegg: Fix queue test setup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351231 [00:46:04] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad, Patch-For-Review: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3226716 (Dzahn) [00:46:12] eileen: Does that fix it for you? ^^^^ [00:47:30] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad, Patch-For-Review: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3181286 (Dzahn) I checked all the boxes in the description that i could check. I can confirm it's out of puppet repo, the production IP is gone. th... [00:47:54] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3226720 (Dzahn) [00:53:05] ejegg: yes it does! [00:53:46] great! [00:54:22] (CR) Eileen: [C: 2] "Without this patch I was unable to run DonationQueueTest or BannerHistoryTest in isolation. With it I can. Since the patch only affects un" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351231 (owner: Ejegg) [00:54:38] ejegg: jenkins seems a bit tardy tho [00:56:14] ooh, that new node test is really slowing things down :( [00:56:21] just for linting yaml files [00:56:49] I shoulda approved the one that used a custom php script with 'composer test' [00:57:00] well, I'll take care of that tomorrow [00:57:07] ah, there it goes [00:57:13] fundraising-tech-ops, DC-Ops, Operations, netops, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3226748 (Dzahn) [00:57:45] gotta go get some dinner! [00:57:50] see you tomorrow [00:58:16] (Merged) jenkins-bot: Fix queue test setup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351231 (owner: Ejegg) [00:59:36] fundraising-tech-ops, DC-Ops, Operations, netops, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3226767 (Dzahn) adding #netops for the "switch port" check boxes. needs access to srx550s. [01:01:29] (PS3) Eileen: Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 [01:05:33] (CR) jerkins-bot: [V: -1] Stock Civi 4.7.19 upgrade (WIP) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/350353 (owner: Eileen) [01:10:12] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, and 3 others: retrieve the text/ html and statistics data for mail we have sent - https://phabricator.wikimedia.org/T161758#3142109 (... [01:13:45] dinner time! [01:53:36] (PS6) Krinkle: Rename some impressionDiet variables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [01:54:14] (CR) Krinkle: "Switched to Date.now() which performs better and is available in all Grade A browsers since we require ES5 now." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [01:54:44] (CR) Krinkle: "(Avoids object construction for getting that what is essentially the default value of the first parameter to the constructor)." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319003 (https://phabricator.wikimedia.org/T121178) (owner: Ejegg) [01:54:56] (CR) Krinkle: [C: 2] campaignManager.js: Comments and doc for custom mixin UIs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/350577 (owner: AndyRussG) [01:55:06] (PS2) Krinkle: Campaign mixin config: remove customAdminUIControls prop and improve README [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/350588 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG) [01:57:30] (Merged) jenkins-bot: campaignManager.js: Comments and doc for custom mixin UIs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/350577 (owner: AndyRussG) [02:58:09] (CR) MZMcBride: "Hmmmm, maybe we should just invert the logic. That is, make it so that CentralNotice ads only show up on the implicit action=view and all " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/296275 (https://phabricator.wikimedia.org/T138177) (owner: Ori.livneh) [07:03:55] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3227101 (ayounsi) [07:04:25] fundraising-tech-ops, DC-Ops, Operations, ops-eqiad: decom barium.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T162952#3181286 (ayounsi) Switch port cleaned up in T162950 [08:14:35] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3227173 (fgiunchedi) @Jgreen any news/updates on having FR fully on jessie? [14:34:19] Wikimedia-Fundraising-Campaigns (FY Q3 Jan-Mar 2017), Wikimedia-CentralNotice-Administration (Q1-2017): WMF Fundraising - 2016-17 - Netherlands (Mar 21 - Apr 18) - https://phabricator.wikimedia.org/T158905#3227930 (Pcoombe) Open>Resolved a:Pcoombe [14:35:21] Wikimedia-Fundraising-Campaigns (Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017)), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Spain (Apr 4 - May 4) - https://phabricator.wikimedia.org/T160164#3227936 (Pcoombe) [14:36:02] Wikimedia-Fundraising-Campaigns (Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017)), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Latin America 1 (Jun 6 - Jul 4) - https://phabricator.wikimedia.org/T162287#3227942 (Pcoombe) [14:36:41] Wikimedia-Fundraising-Campaigns (Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017)), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Latin America 1 (Jun 6 - Jul 4) - https://phabricator.wikimedia.org/T162287#3157901 (Pcoombe) This has been delayed so we can complete the... [14:42:44] Wikimedia-Fundraising-Campaigns (FY Q3 Jan-Mar 2017), User-JSeddon, Wikimedia-CentralNotice-Administration (Q1-2017): Notify community via "the pub" or community portal - https://phabricator.wikimedia.org/T159259#3227969 (MarcoAurelio) Open>Resolved a:MarcoAurelio Boldly closing since the... [14:42:46] Wikimedia-Fundraising-Campaigns (FY Q3 Jan-Mar 2017), Wikimedia-CentralNotice-Administration (Q1-2017): WMF Fundraising - 2016-17 - Netherlands (Mar 21 - Apr 18) - https://phabricator.wikimedia.org/T158905#3227972 (MarcoAurelio) [14:47:50] Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Poland/Romania/Slovakia (May 16 - Jun 13) - https://phabricator.wikimedia.org/T164268#3227986 (Pcoombe) [14:51:41] Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Latvia/Hungary (Jun 6 - Jul 4) - https://phabricator.wikimedia.org/T164269#3228006 (Pcoombe) [17:00:30] fr-tech: I would rather be a serf in a poor man's house [17:00:30] and be above ground than reign among the dead. [17:00:30] -- Achilles, "The Odyssey", XI, 489-91 [17:00:30] -- discuss. [17:14:18] hi XenoRyet, hope the kid's feeling better today! [17:15:13] Hi. He's in good enough spirits, but we still had a 104.5 degree fever last night. [17:15:59] He's coughing quite a bit today too, but that's actually a good thing. For so long he didn't have any other symptoms so they couldn't tell what kind of virus it was. [17:16:18] Cough means it's probably just a cold variant and there's nothing for it but to wait it out. [17:27:02] uff, poor guy [17:31:15] XenoRyet: some of yesterday's failmail was from a bit of the paypal audit parser we neglected to update for the normalization switch [17:31:43] the 'SAR' files are all the subscr_signup and subscr_cancel messages [17:32:31] got a patch here that i THINK should fix em: https://gerrit.wikimedia.org/r/351215 [17:33:10] Cool. Let me catch up a bit more then I'll dig up that failmail and take a look at that patch. [17:40:41] my dad had a thing a couple months ago where he had a fever for like 4 days and not much else [17:41:04] he went to the doc and the doc said "your symptoms don't make sense" [17:41:10] but...he got better [17:41:49] Yea, that's about where we're at with this one. [17:42:19] But we've ruled out the nastier bugs, so as long as the fever keeps responding to medicine we're supposed to not worry about it. [17:49:33] easier said than done of course [17:52:05] Always is. It does help that Marek is in plenty good spirits when the fever isn't high. Whatever's going on doesn't seem to be bothering him too much. [18:04:26] (CR) Ejegg: "Well shoot, we're seeing a lot of CI delay waiting for node tests. Maybe we should resurrect your patch to do it in composer instead. Sorr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [18:12:32] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3228701 (DStrine) [18:19:15] (PS1) Ejegg: Resurrecting hashar's original composer json linter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351351 [18:35:19] (CR) XenoRyet: [C: 2] Normalize subscr_ messages from SAR files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/351215 (https://phabricator.wikimedia.org/T164226) (owner: Ejegg) [18:35:48] (Merged) jenkins-bot: Normalize subscr_ messages from SAR files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/351215 (https://phabricator.wikimedia.org/T164226) (owner: Ejegg) [19:07:27] Fundraising-Backlog, FR-Email: Donatewiki: add device type to utm_campaign when utm_medium = email - https://phabricator.wikimedia.org/T164295#3228925 (Ejegg) [19:12:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface: Store device type as a separate column in donation stats tables - https://phabricator.wikimedia.org/T164298#3228981 (Ejegg) [19:35:36] Fundraising-Backlog, FR-Email: Donatewiki: add device type to utm_campaign when utm_medium = email - https://phabricator.wikimedia.org/T164295#3229096 (CCogdill_WMF) @Ejegg this would be so helpful! I honestly didn't know it was a possibility. I'm looking into starting a contract with a paid, closed sour... [20:57:47] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/351441 [20:58:44] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/351441 (owner: Ejegg) [20:58:50] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/351441 (owner: Ejegg) [21:00:32] (PS1) Ejegg: Remove tests [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/351452 [21:00:40] (CR) Ejegg: [C: 2] Remove tests [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/351452 (owner: Ejegg) [21:00:48] (Merged) jenkins-bot: Remove tests [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/351452 (owner: Ejegg) [21:05:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface: Store device type as a separate column in donation stats tables - https://phabricator.wikimedia.org/T164298#3229333 (ggellerman) p:Triage>Low [21:09:12] Fundraising-Backlog, FR-Email: Donatewiki: add device type to utm_campaign when utm_medium = email - https://phabricator.wikimedia.org/T164295#3229339 (ggellerman) p:Triage>Normal [21:10:47] (CR) Hashar: "Yup that might be the reason why I wrote a PHP based json linter: to prevent triggering a npm test job and thus an extra instance in CI." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350189 (https://phabricator.wikimedia.org/T163781) (owner: Hashar) [21:14:28] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: Tracking Task: Banners immediately returning after being dismissed. - https://phabricator.wikimedia.org/T164099#3229345 (DStrine) @Jseddon are you able to get more information from @Romaine [21:14:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: Tracking Task: Banners immediately returning after being dismissed. - https://phabricator.wikimedia.org/T164099#3229346 (ggellerman) p:Triage>Normal [21:15:33] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3229364 (Ejegg) [21:16:04] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API calls for tokenized payments - https://phabricator.wikimedia.org/T163953#3229366 (ggellerman) p:Triage>Normal [21:17:17] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API calls to capture or cancel payments - https://phabricator.wikimedia.org/T163952#3229370 (ggellerman) p:Triage>Normal [21:19:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: Tracking Task: Banners immediately returning after being dismissed. - https://phabricator.wikimedia.org/T164099#3221602 (K4-713) When we investigate this further, please make sure we drill down into these... [21:20:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, FR-Smashpig: Donation queue consumer: support alternate ID for pending row - https://phabricator.wikimedia.org/T163951#3229387 (ggellerman) p:Triage>Normal [21:26:32] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Create Ingenico orphan rectifier maintenance script - https://phabricator.wikimedia.org/T163949#3215872 (ggellerman) p:Triage>Normal [21:28:04] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API calls to get payment status - https://phabricator.wikimedia.org/T163948#3215844 (ggellerman) p:Triage>Normal [21:30:14] Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3229402 (ggellerman) p:Triage>High [21:31:02] Fundraising-Backlog, FR-Ingenico, FR-Smashpig: Implement Ingenico Connect API call to create hosted payment - https://phabricator.wikimedia.org/T163946#3215775 (ggellerman) p:Triage>Normal [21:34:30] Fundraising-Backlog, FR-Paypal: Paypal std possibly going to stop supporting redirect with GET - https://phabricator.wikimedia.org/T163955#3216042 (Ejegg) Update: got feedback from our contact at Paypal - they're turning off GET for name/value pair API calls, but not for donor browser-side redirects. Our... [21:45:42] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3229480 (DStrine) a:cwdent [21:48:40] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog: recheck onboarding docs and steps - https://phabricator.wikimedia.org/T162832#3176409 (cwdent) Open>Resolved [22:11:28] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3229551 (cwdent) @MNoorWMF Hi, do you have a yubikey yet? It's something you will need to get from OIT in order to log on to the server. [22:15:04] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3229595 (CCogdill_WMF) @cwdent no, she doesn't have one yet. Somehow I thought that request had to come through tech... All very confusing who grants what access! I've reached out to...