[00:59:53] (PS11) Ejegg: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [01:02:04] (CR) jerkins-bot: [V: -1] [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [01:05:48] we have 2 new lambs [01:05:58] they will grow up to be black sheep! [01:08:29] congratulations! [01:08:59] (PS12) Ejegg: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [01:17:01] ooh, passing tests! [01:17:07] but still not ready for prime time [01:52:48] (PS13) Ejegg: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [01:54:18] (PS14) Ejegg: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [03:22:13] (PS15) Ejegg: [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [03:23:59] (CR) jerkins-bot: [V: -1] [WIP] Encapsulate errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [04:08:46] (PS1) Eileen: Log hack to mysqli driver. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/352743 [04:12:01] (CR) jerkins-bot: [V: -1] Log hack to mysqli driver. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/352743 (owner: Eileen) [04:30:12] (PS5) Eileen: Further removal of class_api3 call in favour of civicrm_api3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351127 [04:30:56] (PS12) Eileen: Further removal of class_api3 call in favour of civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351128 [04:33:38] (PS6) Eileen: Further removal of class_api3 call in favour of civicrm_api3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351127 [04:33:40] (PS13) Eileen: Further removal of class_api3 call in favour of civicrm_api3. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351128 [06:17:02] (PS1) Eileen: Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 [06:17:41] (PS1) Eileen: Remove further instance of class_api in favour of civicrm_api3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352747 [06:17:57] (CR) Eileen: "fixed" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/351127 (owner: Eileen) [08:00:13] fundraising-tech-ops, Operations, netops: BGP session between pfw clusters flapping - https://phabricator.wikimedia.org/T164777#3246519 (ayounsi) [10:07:29] fundraising-tech-ops, Operations, netops: BGP session between pfw clusters flapping - https://phabricator.wikimedia.org/T164777#3246796 (Qse24h) [10:08:22] fundraising-tech-ops, Operations, netops: BGP session between pfw clusters flapping - https://phabricator.wikimedia.org/T164777#3245035 (Qse24h) [10:09:13] fundraising-tech-ops, Operations, netops: BGP session between pfw clusters flapping - https://phabricator.wikimedia.org/T164777#3245035 (Qse24h) [10:12:41] fundraising-tech-ops, Operations, netops: BGP session between pfw clusters flapping - https://phabricator.wikimedia.org/T164777#3245035 (Qse24h) [10:13:36] fundraising-tech-ops, Operations, netops: BGP session between pfw clusters flapping - https://phabricator.wikimedia.org/T164777#3245035 (Qse24h) [10:15:33] (PS1) Hashar: Rebuild composer material with composer v1.4.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/352777 [10:21:50] (PS1) Hashar: build: add parallel-lint [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/352780 [14:00:23] fundraising-tech-ops: replace indium (eqiad fundraising logger) with new hardware running jessie - https://phabricator.wikimedia.org/T145116#3248107 (Cmjohnson) [16:33:21] Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Refine PayPal EC donation itemization - https://phabricator.wikimedia.org/T137730#3248719 (XenoRyet) This is working now. Looks like the EC flow will respect the paypal user's language settings for the lang... [17:00:30] fr-tech: It is very vulgar to talk like a dentist when one isn't a dentist. [17:00:30] It produces a false impression. [17:00:30] -- Oscar Wilde [17:00:30] -- discuss. [17:09:24] XenoRyet: hope you're feeling better [17:09:41] Not 100%, but getting there. [17:10:04] so the itemization thing is all set? [17:10:53] Yea, should be good to go. There is still the possibility that there will be a language mismatch, depending on what the user has set on the Papal side, but I don't think we'd want to overrride those settings, even if paypal would let us. [17:11:01] right [17:11:35] so, this error encapsulation thing is in a workable state now, I think: https://gerrit.wikimedia.org/r/344042 [17:11:42] very curious what you think of it [17:12:01] Cool. I've got a bit more catching up to do, then I'll take a look. [17:13:06] I'm still a bit unsure of two things: mixing PaymentError and ValidationError in a single array, and not putting a messageKey on the PaymentError, relying on that error code map instead [17:14:17] Noted, I'll take an extra look at those bits. [17:16:54] (CR) Ejegg: "Oops, need to add a bunch more strings too - things like fname can get the 'correct errors in your....' message if for example they pass a" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/344042 (owner: Awight) [17:56:05] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/352867 [17:58:31] (CR) Mepps: [C: 1] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/352867 (owner: Mepps) [18:00:59] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/352867 (owner: Mepps) [18:03:28] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/352867 (owner: Mepps) [18:16:07] !log updated SmashPig from 200f63eedb05f5e6665d9837bba97e7e7237a41d to 0145e2dd3a5c69d61f0dd9b210f6fddc56dc6aec [18:16:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:21:43] nice mepps [18:38:42] mepps this bug looks like it shouldn't be too complicated, but it stumped me last time I looked at it: T161260 [18:38:43] T161260: SmashPig pending db pruner is broken - https://phabricator.wikimedia.org/T161260 [18:42:03] cwd so... when's good to try re-running those triggers? [18:42:27] did the staging refresh happen? [18:48:29] it did not [18:48:37] i thought you determined that they were actually there? [18:52:17] cwd some of the tables were different from prod [18:52:43] ahhh, right, sorry [18:53:12] there were a lot of red herrings [18:53:15] k, going to look at that temp file listing them and make sure it's what we expect [18:53:25] cool [18:53:36] i'll look at refreshing the staging db anyway [18:53:37] but... there were differences in table structure from prod to staging [18:53:48] which tables? [18:56:04] there was an opening_balance column missing in one of the account tables, lessee [18:57:27] civicrm_financial_account and the log table for same [18:57:30] from a civi update? [18:57:37] most likely [18:57:37] should that happen through drush or what? [18:58:09] ah yeah, that would probably work [18:58:57] huh, doesn't show when I do drush updb [18:59:36] are we getting errors from code because it's missing? [19:01:30] I haven't noticed, it just broke the trigger script [19:02:58] ejegg, cool [19:04:58] mepps: that's the script Maintenance/DeleteExpiredPendingMessages.php [19:05:43] calling Core\DataStores\PendingDatabase::deleteOldMessages [19:11:19] ok, so all the triggers mentioned in the create script are named in the file. Didn't compare the full text [19:12:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Enable ability to look up contacts by phone number - https://phabricator.wikimedia.org/T97372#3249220 (Ejegg) Looks like the triggers are actually there now, but might have been missing for a while in the past. We should just run the update, I guess. [19:13:12] mepps: regarding that trigger thing, I think we should script out the data fix as a batched db_update [19:15:30] so like wmf_civicrm_update_7320, just hitting 100k rows at a time to not lock the table for too long [19:15:45] ejegg, okay where is this smashpig job set up to run? [19:16:41] mepps it's being run by that run-job script [19:16:53] also i see update 7310 in wmf_civicrm but not 7320 [19:18:02] the config file is localsettings/process-control/civi1001/expire_pending_messages.yaml [19:18:26] so the log files are on civi1001 in /var/log/process-control/expire_pending_messages [19:19:36] cool thanks [19:19:41] wmf_civicrm.install line 2376 [19:20:49] probably no need to do the whole temp table thing for the phones [19:23:50] why do the ids start at 210000? [19:32:01] mepps: oh, I think that's where they ended [19:32:18] should have done a select max(id) first, probably [19:33:07] dstrine-commute / AndyRussG / XenoRyet : backlog grooming? [19:33:21] Ah, on my way. [19:36:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Enable ability to look up contacts by phone number - https://phabricator.wikimedia.org/T97372#1240406 (Ejegg) a:mepps [19:37:33] Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Enable ability to look up contacts by phone number - https://phabricator.wikimedia.org/T97372#1240406 (Ejegg) [19:40:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Can we customize thank you letter for contributions function/page in Civi - https://phabricator.wikimedia.org/T164794#3249291 (DStrine) p:Triage>Normal [19:44:34] Fundraising-Backlog, Wikimedia-Fundraising: Missing Polish translation of Thank You email - https://phabricator.wikimedia.org/T164510#3235950 (Ejegg) Please translate this on-wiki! Also, we probably want to translate the latest version of the English TY letter, right? https://meta.wikimedia.org/w/index.p... [19:44:44] Fundraising-Backlog: RE-investigaet PCI - https://phabricator.wikimedia.org/T164864#3249331 (DStrine) [19:48:37] Fundraising-Backlog: RE-investigaet PCI - https://phabricator.wikimedia.org/T164864#3249333 (DStrine) p:Triage>Normal [19:50:53] Fundraising-Backlog: RE-investigate PCI - https://phabricator.wikimedia.org/T164864#3249339 (Aklapper) [19:54:32] Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Patch-For-Review: Paypal: deal with 10486 (redirect donor back to pp) - https://phabricator.wikimedia.org/T163458#3249347 (Ejegg) Open... [19:54:46] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, Patch-For-Review: process-control lock contention cronspam - https://phabricator.wikimedia.org/T162738#3249348 (Ejegg) Open... [19:54:54] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, Patch-For-Review: process-control lock contention cronspam - https://phabricator.wikimedia.org/T162738#3173084 (Ejegg) a:awi... [19:55:10] Fundraising Sprint Ivory Tower Defense Games, Fundraising-Backlog, FR-Paypal, Patch-For-Review, Unplanned-Sprint-Work: Non-normalized paypal subscription messages coming in via audit - https://phabricator.wikimedia.org/T164226#3249351 (Ejegg) Open>Resolved p:Triage>Normal [19:55:47] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog: process-control will need to run some jobs sequentially - https://phabricator.wikimedia.org/T161035#3249355 (Ejegg) Open>Resolved a:Ejegg [20:20:05] Fundraising-Backlog: Re-investigate PCI - https://phabricator.wikimedia.org/T164864#3249490 (DStrine) [20:28:43] (PS1) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352893 (https://phabricator.wikimedia.org/T97372) [20:29:41] (CR) jerkins-bot: [V: -1] Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352893 (https://phabricator.wikimedia.org/T97372) (owner: Mepps) [20:35:38] (PS1) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352897 (https://phabricator.wikimedia.org/T97372) [20:36:45] (Abandoned) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352893 (https://phabricator.wikimedia.org/T97372) (owner: Mepps) [21:00:51] (PS2) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352897 (https://phabricator.wikimedia.org/T97372) [21:02:17] (PS1) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352940 (https://phabricator.wikimedia.org/T97372) [21:03:07] (PS1) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352943 (https://phabricator.wikimedia.org/T97372) [21:04:42] (Abandoned) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352897 (https://phabricator.wikimedia.org/T97372) (owner: Mepps) [21:05:12] (Abandoned) Mepps: Add update_7522 to allow for search by phone number Bug: T97372 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352940 (https://phabricator.wikimedia.org/T97372) (owner: Mepps) [21:05:26] sorry for all the pings everyone, just learning gerrit review here [21:19:08] mepps: it's a long and winding road [22:01:12] (PS1) Eileen: CRM-20539 Do not heed dao default for field when setting defaults on reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/352966 (https://phabricator.wikimedia.org/T161758) [23:59:42] (CR) Ejegg: [C: -1] "Update looks good! Setup needs a fix." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352943 (https://phabricator.wikimedia.org/T97372) (owner: Mepps)