[02:41:45] (PS1) Ejegg: QueueWrapper for pushing messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354176 [02:57:36] (PS1) Ejegg: Allow overriding source name, type, and version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354177 (https://phabricator.wikimedia.org/T95647) [03:13:48] (CR) Ejegg: "Should the mouse hunt live in the teardown of the benevity test or base checks file test? Mickey doesn't make an appearance in the rest of" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [08:47:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web-Backlog: Showing banner causes JavaScript syntax error - https://phabricator.wikimedia.org/T165637#3272815 (phuedx) This appears to be an issue with the CentralNotice extension /cc @AndyRussG @Pcoombe [09:29:53] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web-Backlog: Showing banner causes JavaScript syntax error - https://phabricator.wikimedia.org/T165637#3272879 (Pcoombe) Open>Resolved a:Pcoombe There was an error in the [[ https://meta.wikimedia.org/wik... [09:36:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MobileFrontend, Reading-Web-Backlog: Showing banner causes JavaScript syntax error - https://phabricator.wikimedia.org/T165637#3272888 (phuedx) Yeesh. Thanks for the quick turnaround @Pcoombe!!1 [13:05:58] Fundraising-Backlog: Drush thank you task naming causes confusion - https://phabricator.wikimedia.org/T165671#3273298 (mepps) [13:07:35] (PS1) Mepps: Change thank you and thank you test to thank you send [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354224 (https://phabricator.wikimedia.org/T165671) [13:08:44] ejegg: tiny patch for the drush tasks as discussed yesterday [15:39:57] pcoombe: great work there wit the speedy banner fix! [15:40:02] thanks! [15:58:13] (CR) Jforrester: [C: 1] "Ready when this repo runs composer in CI." [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/354145 (owner: Umherirrender) [16:02:53] mepps thanks, checking it out [16:04:53] feeling better XenoRyet ? [16:05:41] Eh, everything sounds like it's underwater, but the doc did give me something for the pain. [16:05:56] I'm gonna be crap for calls today, but I should be able to get some work done. [16:06:46] XenoRyet: yesterday pcoombe switched the paypal traffic over to EC for a bit, and we got a few of those 'Request forbidden' in the logs [16:07:04] Cool. The logging turn up anything useful? [16:07:05] I wasn't quite sure what to make of it [16:07:22] I'll go take a look in a minute here, see if I can parse anything out of it. [16:09:51] (PS2) Ejegg: Change thank you and thank you test to thank you send [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354224 (https://phabricator.wikimedia.org/T165671) (owner: Mepps) [16:10:30] (CR) Ejegg: [C: 2] "Thanks! Let's deploy this soon so we don't forget we have to change the job." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354224 (https://phabricator.wikimedia.org/T165671) (owner: Mepps) [16:11:27] (CR) jerkins-bot: [V: -1] Change thank you and thank you test to thank you send [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354224 (https://phabricator.wikimedia.org/T165671) (owner: Mepps) [16:11:36] d'oh [16:12:33] (CR) Ejegg: [C: 2] Change thank you and thank you test to thank you send [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354224 (https://phabricator.wikimedia.org/T165671) (owner: Mepps) [16:13:01] XenoRyet / mepps: We'll want these for the rest of the TY letter template generation: https://gerrit.wikimedia.org/r/353927 [16:15:40] How are you with regex mepps? I'm a bit rusty, but I can take that one if you don't want it. [16:16:13] haha i'm happy to tackle it XenoRyet [16:16:19] Cool [16:16:21] It's all yours. [16:17:35] (Merged) jenkins-bot: Change thank you and thank you test to thank you send [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354224 (https://phabricator.wikimedia.org/T165671) (owner: Mepps) [16:33:42] (PS2) Ejegg: Allow overriding source name, type, and version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354177 (https://phabricator.wikimedia.org/T95647) [16:37:37] ejegg do you use the thank you drush command? i ask because it's telling me batch size is not configured [16:38:05] mepps: oh, there's a UI for that, one sec [16:38:19] i found the config ui [16:38:48] cool, does setting the batch there fix it for you? [16:39:13] but config options don't seem to save, and batch size seems to be set [16:40:15] so no it doesn't [16:42:11] hmm, it just worked for me locally, but I'm using an old db that had it set long ago [16:44:28] drush variable-get thank_you_batch gives you a number? [16:46:18] mepps ^^ ? [16:46:49] nope [16:46:51] if not, maybe the problem is with the settings ui [16:47:01] yeah i was looking at that earlier [16:47:03] try drush variable-set thank_you_batch 1 [16:47:51] hmm drush variable-get now works but i'm getting the same error [16:50:37] hang on [16:50:53] okay got it working now [16:53:12] cool [16:53:23] but the variables don't seem to change if i update them in the ui [16:53:38] for either thank_you or queue2civicrm [16:54:39] dang... any error messages in the logs? [16:55:31] also, you could do a mysql general log and see if anything is trying to update a table called 'variables' [16:58:30] back in a few [17:00:19] fr-tech: Predestination was doomed from the start. [17:00:19] -- discuss. [17:16:48] hehe, nice one slander [17:27:06] XenoRyet: what do you think of those? Should we be logging more? [17:28:11] also, XenoRyet and mepps, are you available to talk about the multiple payment identifiers in an hour? [17:28:53] yup [17:29:59] great! I'll add a few more notes to T163947 in the meantime [17:29:59] T163947: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947 [17:30:54] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3273777 (Ejegg) Amazon IDs / concepts documented here: https://images-... [17:31:28] I'll try, but I dunno how video calls are going to go with my ears all jacked up. [17:40:09] (CR) Jforrester: [C: 2] "Ah, mwext-testextension has been changed." [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/354145 (owner: Umherirrender) [17:40:53] oh shoot, that's right [17:41:34] (PS1) Ejegg: DRY up logic to remove source_ fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354255 [17:42:30] (Merged) jenkins-bot: Add phpcs and make pass [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/354145 (owner: Umherirrender) [17:43:10] (PS1) Umherirrender: Add phpcs and make pass [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/354256 [17:43:12] XenoRyet: got time for some CR? I'm trying to get the queue wrapper working again in SmashPig to get rid of a bunch of repeated code [17:43:47] I know we had those weird segfaults with the last attempt, but I think those were weird flukes [17:43:58] also, I'm doing it slightly differently this time [17:44:20] Sure, which patch needs looking at? [17:50:10] last three in SmashPig [17:50:32] 10-4 [17:50:35] queue wrapper probably most important [18:29:10] mepps / XenoRyet I'm ready when you are to talk T163947 [18:29:11] T163947: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947 [18:29:28] I'll be in https://hangouts.google.com/hangouts/_/wikimedia.org/fr-tech-talk [18:52:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: CentralNotice: How can we better monitor/provide tools/collaborate to prevent errors in banners? - https://phabricator.wikimedia.org/T165686#3273868 (AndyRussG) [19:02:09] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Add payment session ID to pending & donations queue messages - https://phabricator.wikimedia.org/T165687#3273905 (Ejegg) [19:30:38] and I'd bet we got most of them already via the notification listener [19:31:45] oops [19:45:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store recurring tokens in Civi's payment_token tale - https://phabricator.wikimedia.org/T165695#3274065 (mepps) [20:02:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store merchant reference in invoice id - https://phabricator.wikimedia.org/T165696#3274086 (Ejegg) [20:03:58] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3274107 (Ejegg) We had a really productive discussion and found places... [20:24:24] (PS1) Ejegg: Add payment_session_id to pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) [20:25:52] (PS1) Ejegg: Mark some more deprecated donationData fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354267 [20:39:52] (PS2) Ejegg: Add gateway_session_id to pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) [20:44:22] (CR) Ejegg: [C: -1] "Oh hey, this may not be necessary. Looks like we're doing fine getting them by order ID for deletion, and the orphan rectifiers just get t" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [21:10:15] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Puppet has 19 failures. Last run 9 minutes ago with 19 failures. Failed resources (up to 3 shown) [21:15:05] PROBLEM - check_puppetrun on alnitak is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/sudoers.d/nagios] [21:15:15] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/sudoers.d/nagios] [21:15:16] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 19 seconds ago with 0 failures [21:20:15] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/etc/sudoers.d/nagios] [21:20:16] RECOVERY - check_puppetrun on alnitak is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [21:25:15] RECOVERY - check_puppetrun on americium is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [21:27:49] (PS1) Ejegg: Add gateway_session_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354370 (https://phabricator.wikimedia.org/T165687) [21:38:10] (PS1) Ejegg: Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) [21:40:33] (Abandoned) Ejegg: Move fallback message to the currency_code slot [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350495 (https://phabricator.wikimedia.org/T98447) (owner: Ejegg) [21:41:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Store merchant reference in invoice id - https://phabricator.wikimedia.org/T165696#3274269 (Ejegg) p:Triage>Normal [21:41:59] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3274277 (Ejegg) [21:42:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Store merchant reference in invoice id - https://phabricator.wikimedia.org/T165696#3274086 (Ejegg) [21:42:20] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Store merchant reference in invoice id - https://phabricator.wikimedia.org/T165696#3274086 (Ejegg) [21:42:33] (CR) jerkins-bot: [V: -1] Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [21:50:57] (PS2) Ejegg: Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) [21:51:32] XenoRyet: if you want any live Q-n-A on the reviewables, just ask [21:51:52] Yea, will do [21:54:52] (CR) jerkins-bot: [V: -1] Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [21:57:53] (PS3) Ejegg: Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) [21:59:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store and show merchant reference ID in Civi - https://phabricator.wikimedia.org/T137834#3274322 (Ejegg) [21:59:26] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Store merchant reference in invoice id - https://phabricator.wikimedia.org/T165696#3274325 (Ejegg) [22:07:53] (CR) Ejegg: "Dang, so we're stuffing the order_id up front with other identifiers when it's empty. This patch gets around that by adding yet another me" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [23:25:47] (PS1) Ejegg: Quit stuffing order_id with other fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) [23:26:30] (CR) jerkins-bot: [V: -1] Quit stuffing order_id with other fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [23:27:11] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [23:50:38] (PS4) Ejegg: Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) [23:51:47] (CR) Ejegg: "Update: the order_id stuffing was totally no longer needed, probably because of some logging improvements." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [23:53:55] (CR) jerkins-bot: [V: -1] Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [23:55:39] (PS5) Ejegg: Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696)