[00:09:31] (PS4) Ejegg: [WIP] Unstaged -> normalized, split construct, validate and stage steps. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342553 (https://phabricator.wikimedia.org/T159910) (owner: Awight) [00:11:15] (CR) jerkins-bot: [V: -1] [WIP] Unstaged -> normalized, split construct, validate and stage steps. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/342553 (https://phabricator.wikimedia.org/T159910) (owner: Awight) [05:12:49] (PS1) AndyRussG: [WIP] QUnit tests for ext.centralNotice.bannerSequence [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/354379 (https://phabricator.wikimedia.org/T144456) [05:15:15] (CR) jerkins-bot: [V: -1] [WIP] QUnit tests for ext.centralNotice.bannerSequence [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/354379 (https://phabricator.wikimedia.org/T144456) (owner: AndyRussG) [08:21:05] (CR) Jforrester: [C: 2] Add phpcs and make pass [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/354256 (owner: Umherirrender) [08:22:50] (Merged) jenkins-bot: Add phpcs and make pass [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/354256 (owner: Umherirrender) [14:30:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#3276372 (mepps) a:mepps [15:12:23] (PS1) Mepps: Create time limit based on user configuration Bug: T163412 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) [15:18:42] (PS2) Mepps: Create time limit based on user configuration Bug: T163412 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) [15:21:36] (PS3) Mepps: Create time limit based on user configuration Bug: T163412 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) [16:14:13] Wikimedia-Fundraising, fundraising-tech-ops: Norton-secured shield on payments.wikimedia.org - https://phabricator.wikimedia.org/T134824#3276970 (Jgreen) [16:14:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Security-General, Spike: Spike: Is the Verisign seal even PCI compliant? - https://phabricator.wikimedia.org/T140318#3276972 (Jgreen) [16:15:58] Wikimedia-Fundraising, fundraising-tech-ops: Norton-secured shield on payments.wikimedia.org - https://phabricator.wikimedia.org/T134824#2278404 (Jgreen) [16:16:35] Wikimedia-Fundraising, fundraising-tech-ops: Norton-secured shield on payments.wikimedia.org - https://phabricator.wikimedia.org/T134824#3276976 (Jgreen) Open>Resolved a:Jgreen The decision has been made to remove the seal altogether, see T163807. [16:18:54] (PS2) AndyRussG: [WIP] QUnit tests for ext.centralNotice.bannerSequence [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/354379 (https://phabricator.wikimedia.org/T144456) [16:30:58] (CR) jerkins-bot: [V: -1] [WIP] QUnit tests for ext.centralNotice.bannerSequence [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/354379 (https://phabricator.wikimedia.org/T144456) (owner: AndyRussG) [16:33:12] (CR) XenoRyet: [C: 2] QueueWrapper for pushing messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354176 (owner: Ejegg) [16:34:17] (Merged) jenkins-bot: QueueWrapper for pushing messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354176 (owner: Ejegg) [16:41:59] (CR) XenoRyet: [C: 2] Allow overriding source name, type, and version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354177 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:43:23] (Merged) jenkins-bot: Allow overriding source name, type, and version [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354177 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:47:17] thanks XenoRyet! [16:47:29] Yea, no worries. [16:47:42] Just looking at that source fields patch now. [16:48:11] feel like doing more CR after that, or are you back to the dead session stuff? [16:48:29] I could do a little more CR before I switch back. Whatcha got? [16:48:59] oh, there's a ton hanging out. let's see... [16:49:25] a few really trivial but nice-to-have? [16:49:38] I'm down to merge nice to haves. [16:49:42] like some css: https://gerrit.wikimedia.org/r/350506 [16:50:03] some CI config: https://gerrit.wikimedia.org/r/350907 [16:51:01] last replacement of our phpqueue fork: https://gerrit.wikimedia.org/r/353345 [16:51:45] oh hey, Jeff_Green's been wanting this for a while: get rid of verisign seal - https://gerrit.wikimedia.org/r/350262 [16:52:08] Yea, definitely do that one. [16:52:41] oh yes, that would be great [16:57:36] oh yeah, we should probably revert the popout-after-process patch too: https://gerrit.wikimedia.org/r/353644 [17:00:19] fr-tech: Gold's Law: [17:00:19] If the shoe fits, it's ugly. [17:00:19] -- discuss. [17:00:21] Well, cool. I'll work my way through those. [17:02:48] (CR) XenoRyet: [C: 2] DRY up logic to remove source_ fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354255 (owner: Ejegg) [17:03:40] (Merged) jenkins-bot: DRY up logic to remove source_ fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354255 (owner: Ejegg) [17:04:47] ejegg: i have a strong memory that we did that as groundwork for another change [17:05:11] i feel like a simple revert might not be the best idea [17:05:43] I think we split out the serious groundwork stuff [17:06:12] oh yeah, we actually did the ingenico resultswitcher de-duplication as groundwork for that change [17:06:27] so hey, some good came out of it! [17:07:14] that revert patch ends up being pretty minor [17:10:05] ah yeah that sounds right [17:32:08] (PS12) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [17:32:45] (Abandoned) Ejegg: WIP queueWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/316387 (owner: Ejegg) [17:41:26] (CR) XenoRyet: [C: 2] Use consistent width constraints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350506 (owner: Ejegg) [17:42:27] (PS7) Ejegg: Capture Adyen payments missing pending messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/319489 (https://phabricator.wikimedia.org/T149861) [17:42:38] (CR) XenoRyet: [C: 2] Lint .module, .install, .inc PHP files too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350907 (owner: Ejegg) [17:43:52] (Merged) jenkins-bot: Use consistent width constraints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350506 (owner: Ejegg) [17:46:03] ejegg i see a bunch of gerrit reviews from you for the team--any in particular you'd like me to look at? i also pushed out the thank you timer this morning [17:46:18] mepps oh cool, I'll take a look at that! [17:46:41] let's see, I guess that one with the regexes for the TY letter would be nice to have [17:47:26] (Merged) jenkins-bot: Lint .module, .install, .inc PHP files too [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/350907 (owner: Ejegg) [17:47:49] ejegg, cool [17:47:57] also, i was naughty and picked the low-hanging fruit on the multiple identifiers: https://gerrit.wikimedia.org/r/354370 , https://gerrit.wikimedia.org/r/354371 , https://gerrit.wikimedia.org/r/354374 [17:48:09] i should have saved those for someone else, sorry [17:48:42] haha okay i'll take a look [17:49:27] there's a bot which should add gerrit reviewers based on this page: https://www.mediawiki.org/wiki/Git/Reviewers [17:49:59] but it looks like the bot is broken right now, so feel free to add the fundraising group as reviewers in gerrit on any of your own patches [17:56:46] (CR) XenoRyet: [C: 2] Remove Verisign secure seal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350262 (https://phabricator.wikimedia.org/T163807) (owner: Ejegg) [17:58:41] (Merged) jenkins-bot: Remove Verisign secure seal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350262 (https://phabricator.wikimedia.org/T163807) (owner: Ejegg) [18:00:30] (CR) Ejegg: [C: -1] "Instead of the while loop, I think you just want an if ( timeExpired) { break; } at the end of the foreach" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) (owner: Mepps) [18:13:36] (CR) Mepps: [C: 2] Add gateway_session_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354370 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [18:15:04] (CR) Mepps: [C: 2] "This looks good and I like that you added a test! does not identify a registered user or group" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354370 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [18:15:18] (CR) Mepps: More horrifying regexps for ty letter template generation (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353927 (owner: Ejegg) [18:16:04] (Merged) jenkins-bot: Add gateway_session_id to queue messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354370 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [18:18:13] (CR) Ejegg: "Thanks for the review mepps" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353927 (owner: Ejegg) [18:19:32] (CR) Mepps: [C: 2] "Looks pretty straightforward and accomplishes what it says!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [18:23:53] has everybody filled out that engagement survey? [18:26:22] (CR) Mepps: [C: 2] Quit stuffing order_id with other fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [18:27:03] (CR) Mepps: [C: 2] "I went ahead and +2d but my only question is whether there will be confusion over the old data." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [18:28:38] (CR) Ejegg: "We haven't been persisting the stuffed field in the db so far, so we only have the logs to worry about. And it looks like we haven't actua" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [18:31:19] (Merged) jenkins-bot: Quit stuffing order_id with other fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354374 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [18:31:21] (Merged) jenkins-bot: Store order id in invoice_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354371 (https://phabricator.wikimedia.org/T165696) (owner: Ejegg) [18:36:40] oof, we really need to clean up those translation messages [18:36:46] so much wasted effort [18:40:53] (CR) XenoRyet: [C: 2] Use upstream PHP-Queue [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/353345 (owner: Ejegg) [18:42:18] (Merged) jenkins-bot: Use upstream PHP-Queue [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/353345 (owner: Ejegg) [18:56:10] (CR) XenoRyet: [C: 2] Revert "process payment before popping out of iframe" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353644 (owner: Ejegg) [18:57:55] (Merged) jenkins-bot: Revert "process payment before popping out of iframe" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353644 (owner: Ejegg) [18:59:20] (PS1) Ejegg: Rename 'complete' queue to 'donations' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354559 (https://phabricator.wikimedia.org/T95647) [19:05:14] Fundraising-Backlog, Epic: [epic] PCI gap analysis and Improvements - https://phabricator.wikimedia.org/T77912#3277242 (Jgreen) [19:06:20] fundraising-tech-ops: Write alerts for missing or empty logfiles - https://phabricator.wikimedia.org/T87683#3277245 (Jgreen) a:Jgreen>None [19:10:17] fundraising-tech-ops, Operations, Traffic: Fix nits in HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#3277249 (Jgreen) [19:10:43] fundraising-tech-ops, Operations, Traffic: Fix nits in HTTPS/HSTS configs in wikimedia.org domain - https://phabricator.wikimedia.org/T137161#2359459 (Jgreen) [19:11:22] fundraising-tech-ops, Operations, Traffic: Fix nits in HTTPS/HSTS configs in externally-hosted fundraising domains - https://phabricator.wikimedia.org/T137161#2359459 (Jgreen) [19:13:11] fundraising-tech-ops, Operations, Traffic: Fix nits in HTTPS/HSTS configs in externally-hosted fundraising domains - https://phabricator.wikimedia.org/T137161#3277260 (Jgreen) a:Jgreen>None This isn't something fr-tech-ops can fix, it's an external site. [19:19:42] fundraising-tech-ops, Operations, Traffic: Fix nits in HTTPS/HSTS configs in externally-hosted fundraising domains - https://phabricator.wikimedia.org/T137161#3277275 (Krinkle) [19:19:55] (PS1) Ejegg: Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) [19:20:06] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: overhaul payments-wiki deployment process - https://phabricator.wikimedia.org/T136963#3277279 (Jgreen) [19:20:08] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: evaluate scap3 as a possible replacement for FrDeploy tools - https://phabricator.wikimedia.org/T136966#3277277 (Jgreen) Open>Resolved Casey got a good sense of what scap3 is, and at this point it doesn't seem worth the effo... [19:37:41] fundraising-tech-ops: adjust fundraising nginx->apache2 to use low ports - https://phabricator.wikimedia.org/T165804#3277318 (Jgreen) [19:38:44] (CR) Umherirrender: [C: -1] "Needs rebase" [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/352777 (owner: Hashar) [19:44:18] (CR) jerkins-bot: [V: -1] Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [20:04:09] fundraising-tech-ops: adjust fundraising nginx->apache2 to use low ports - https://phabricator.wikimedia.org/T165804#3277401 (cwdent) a:cwdent [20:18:51] (PS4) Mepps: Create time limit based on user configuration Bug: T163412 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) [20:21:24] (CR) Mepps: Create time limit based on user configuration Bug: T163412 (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) (owner: Mepps) [20:30:07] (CR) Mepps: Create time limit based on user configuration Bug: T163412 (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) (owner: Mepps) [20:36:32] ejegg i'm thinking i have a syntax issue because i'm getting this error on the time() line: Undefined variable: 1495226150 thank_you.module:823 [notice] [20:38:57] taking a look! [20:39:48] mepps just a $$ typo [20:40:56] that is, $$endTime instead of $endTime on 826 [20:41:42] ah got it [20:42:52] (PS5) Mepps: Create time limit based on user configuration Bug: T163412 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) [20:47:57] (CR) Ejegg: [C: -1] "Cool! One issue. Also, maybe log 'Time limit elapsed' before the break?" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) (owner: Mepps) [20:55:25] (PS2) Ejegg: Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) [21:11:29] (PS6) Mepps: Create time limit based on user configuration Bug: T163412 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354511 (https://phabricator.wikimedia.org/T163412) [21:11:46] ejegg ^^ updated based on comment [21:14:02] mepps: thanks for the logging! Want to take a look at the inline comments from PS5 too? [21:20:31] I had to leave for the day to grab the baby, maybe later tonight [21:26:01] Actually while walking I'm realizing we would want the if at the top of the foreach in the case where the user sets batch time to 0 [21:26:08] Right? [21:26:24] ejegg [21:26:25] I wouldn't worry about that edge case [21:26:34] in fact, maybe 0 should mean no time limit [21:27:07] or...yeah, it does make more sense at the top [21:27:47] anyway, enjoy baby time [21:28:06] Hmm yeah I think on the queue 0 is no time limit which we should keep consistent and cool, will move to the top [21:28:09] I will!! [22:27:28] argh, the mismatch between a few keys in the front and backend is really annoying [22:28:02] So far, SmashPig has been mostly working with the normalized-for-queue versions [22:28:11] first_name instead of fname [22:28:24] gross instead of amount [22:29:06] but if we want to use it for more frontend logic, it'll run into the other versions [22:33:59] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface: DonationInterface needs to use the same data keys as the backend - https://phabricator.wikimedia.org/T165818#3277672 (Ejegg) [22:35:16] Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface: DonationInterface needs to use the same data keys as the backend - https://phabricator.wikimedia.org/T165818#3277688 (Ejegg) p:Triage>High [22:37:34] (PS1) Ejegg: WIP consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [22:39:53] (CR) jerkins-bot: [V: -1] WIP consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [22:47:34] (PS1) Ejegg: Use normalized key for supplemental_address_1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354606 [22:48:06] (PS2) Ejegg: Use normalized key for supplemental_address_1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354606 [22:48:39] XenoRyet: do you agree about needing to use the same data keys in the frontend as everywhere else? [22:49:04] Yea, I think that's a good idea. [22:49:22] I feel like amount -> gross will be the thorniest [22:51:59] Honestly we probably should've done it a while ago. [23:15:39] Well, no time like the present! [23:17:03] (PS3) Ejegg: Use normalized key for supplemental_address_1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354606 (https://phabricator.wikimedia.org/T165818) [23:17:05] (PS1) Ejegg: Rename 'street' field to normalized 'street_address' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354610 (https://phabricator.wikimedia.org/T165818) [23:17:16] phew, tedious stuff [23:17:32] also, bound to go stale quick [23:25:49] XenoRyet: you want to tackle fname->first_name / lname -> last_name [23:25:52] ? [23:26:00] That way we can trade off reviews [23:26:17] Yea, sounds good. [23:26:25] Probably won't get to it today, but yea I'll take that bit. [23:27:00] Nice. I'll start looking at the audit code that reads the stuff from the logs [23:32:49] Sounds like a plan. [23:49:17] we seriously can't let this sit though. Once we start, we'll have to finish before translation updates make it all unmergable [23:55:28] (PS1) Ejegg: Audit processors can read normalized fields in logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354613 (https://phabricator.wikimedia.org/T165818) [23:56:01] Yea, let's try to bang it all out on Monday. Get through it quick as we can. [23:56:22] In any case, I'm off for the evening. Have a good weekend. [23:56:30] cool. I'll deploy all the things beforehand so we isolate the potential breakage [23:56:38] Good call [23:57:03] that CRM audit patch should be safe to deploy whenever [23:57:07] oops