[01:06:07] <ejegg>	 so long!
[04:15:52] <wikibugs>	 (CR) Cdentinger: [C: 2] Only send selected payment identifiers in failmail [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/355171 (https://phabricator.wikimedia.org/T104473) (owner: Ejegg)
[04:16:28] <wikibugs>	 (Merged) jenkins-bot: Only send selected payment identifiers in failmail [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/355171 (https://phabricator.wikimedia.org/T104473) (owner: Ejegg)
[07:33:24] <wikibugs>	 (CR) Jforrester: [C: 1] Switch TestingAccessWrapper to librarized version [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/349092 (https://phabricator.wikimedia.org/T163434) (owner: Gergő Tisza)
[12:36:31] <mepps>	 ejegg we should talk about the civi queue errors when you're around
[12:36:39] <mepps>	 i'm wondering if it has to do with removing the use of orderid?
[12:42:30] <mepps>	 ejegg it's probably because we deployed civi but no other repos
[12:42:46] <mepps>	 ejegg
[12:45:19] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/355210
[13:15:30] <wikibugs>	 (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/355210 (owner: Mepps)
[14:19:28] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3286333 (CCogdill_WMF) Hi @cwdent, Moska will be getting her yubikey tomorrow. Can we get this set up?
[14:22:33] <wikibugs>	 Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3286340 (CCogdill_WMF)
[15:22:51] <mepps>	 ejegg i got things started for deployment but wasn't sure how we handled mediawiki
[15:25:02] <wikibugs>	 (PS1) AndyRussG: Merge branch 'master' (7b30a66) into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/355233
[15:38:56] <wikibugs>	 (CR) AndyRussG: [C: 2] Merge branch 'master' (7b30a66) into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/355233 (owner: AndyRussG)
[15:39:47] <AndyRussG>	 fr-tech ^ merge to deploy branch for CN.....
[15:40:06] <cwd>	 godspeed AndyRussG !
[15:40:13] <AndyRussG>	 cwd: thx! heheheh
[15:40:35] <cwd>	 mepps: do you need a hand with that? i am probably still familiar enough
[15:40:45] <AndyRussG>	 Just tested locally with that exact commit, works fine...
[15:40:53] <cwd>	 do you mean how to update mediawiki? or a submodule of it?
[15:42:08] <mepps>	 cwd great, well that's part of the question
[15:42:21] <mepps>	 and on the other projects i would use the deployment branch and compare it to master
[15:42:36] <mepps>	 but since the mediawiki project uses the fundraising branch i wasn't sure if there was different naming
[15:45:21] <cwd>	 yeah the git dance is pretty involved
[15:45:26] <cwd>	 what project do you want to deploy?
[15:45:36] <mepps>	 donation interface
[15:46:15] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' (7b30a66) into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/355233 (owner: AndyRussG)
[15:50:03] <cwd>	 mepps: the extensions are all still submodules right?
[15:50:09] <mepps>	 yes
[15:51:35] <cwd>	 ok, the basic procedure is
[15:51:47] <cwd>	 update the deployment branch of DI
[15:51:56] <cwd>	 make sure your master is up to date and all that
[15:52:06] <cwd>	 git pull --rebase usually works
[15:52:43] <cwd>	 you can get the list of changes you want to merge however is your preference but an easy way is:
[15:52:48] <cwd>	 git cherry -v deployment master
[15:54:07] <cwd>	 for posterity take that list of commits and paste it into the merge commit
[15:54:22] <cwd>	 which is made by: git checkout deployment && git merge master
[15:58:27] <cwd>	 if you get that far without problems you can push the deployment branch change up to gerrit
[16:02:00] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355242
[16:03:32] <mepps>	 cool thanks cwd just wasn't sure if donation interface used the same deployment branch naming, i'm not sure if i should wait for ejegg to confirm that the deployment should happen?
[16:04:12] <cwd>	 ah yeah afaik it's just deployment
[16:04:38] <cwd>	 and you did the right thing deleting the tests
[16:04:42] <cwd>	 strong work
[16:04:53] <cwd>	 you are clearly farther along than i thought :)
[16:05:33] <mepps>	 haha ejegg and i have a done a couple pair merge deploys :)
[16:06:45] <mepps>	 i like git cherry -v it's very simple
[16:08:07] <cwd>	 i put significant effort into automating this https://github.com/caseydentinger/frig
[16:08:12] <cwd>	 but eventually gave up
[16:08:26] <cwd>	 there are just too many holes to fall into
[16:32:15] <wikibugs>	 (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355242 (owner: Mepps)
[16:47:29] <ejegg>	 mepps hi
[16:47:37] <ejegg>	 sorry to be late
[16:48:12] <ejegg>	 so, there's one thing I want to merge before we deploy all the field name changes
[16:48:50] <ejegg>	 ooh, composer failed in CI?
[16:50:28] <mepps>	 huh ejegg just saw that
[16:51:39] <ejegg>	 https://gerrit.wikimedia.org/r/355173
[16:52:14] <ejegg>	 mepps if people are in the middle of donations when we change all those names, I think ^^^ should keep things working
[16:55:23] <ejegg>	 looks like there's a little bit of activity right now
[16:55:46] <mepps>	 ejegg did you see the failmail messages from this morning?
[16:56:07] <wikibugs>	 (CR) Mepps: [C: 2] Allow old keys in session values [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[16:56:35] <ejegg>	 yeah, I'm wondering what to do about those duplicate invoice numbers
[17:00:20] <slander>	 fr-tech: Welcome to boggle - do you want instructions?
[17:00:20] <slander>	 D    G    G    O
[17:00:20] <slander>	 O    Y    A    N
[17:00:20] <slander>	 A    D    B    T
[17:00:20] <slander>	 K    I    S    P
[17:00:20] <slander>	 Enter words:
[17:00:21] <slander>	 >
[17:00:22] <slander>	  -- discuss.
[17:03:46] <wikibugs>	 (CR) jerkins-bot: [V: -1] Allow old keys in session values [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[17:13:28] <ejegg>	 haha, fortune boggle
[17:14:14] <wikibugs>	 (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[17:15:13] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3286918 (Ejegg)
[17:15:56] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3286932 (Ejegg) p:Triage>High
[17:25:05] <mepps>	 ejegg not sure why the build is breaking on my merge into deployment--it looks to me like all i did is delete the tests?
[17:28:57] <wikibugs>	 (PS1) Ejegg: Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159)
[17:29:28] <ejegg>	 mepps what does the full log say?
[17:31:08] <wikibugs>	 (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg)
[17:37:30] <mepps>	 ejegg, grabbing lunch, back shortly
[17:39:58] <ejegg>	 XenoRyet: working on anything interesting / puzzling?
[17:40:11] <ejegg>	 I'm sort of between tasks and available to chat
[17:41:01] <ejegg>	 Trying to decide how to handle T166159 for non-recurring, if you have any ideas
[17:41:02] <stashbot>	 T166159: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159
[17:41:33] <ejegg>	 well, I guess I can rebase stuff around the field rename, if that's even possible
[17:41:43] <XenoRyet>	  MBeat mentioned that the status 600 errors are coming back, so I was looking into that a bit.
[17:42:12] <XenoRyet>	 Nothing really to chat about yet, just checking stuff out.
[17:43:16] <XenoRyet>	 That invoice ID one does seem weird.
[17:44:21] <ejegg>	 well, the recurring duplicates make sense
[17:44:24] <wikibugs>	 (CR) jerkins-bot: [V: -1] Allow old keys in session values [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[17:44:30] <ejegg>	 urgh
[17:44:39] <ejegg>	 asking about the composer failures in -releng
[17:45:13] <XenoRyet>	 Yea, but that non-recurring that showed up 8 times is weird.
[17:59:08] <wikibugs>	 (CR) jerkins-bot: [V: -1] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg)
[18:05:20] <wikibugs>	 Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Smashpig, MediaWiki-extensions-DonationInterface, and 3 others: DonationInterface needs to use the same data keys as the backend - https://phabricator.wikimedia.org/T165818#3287027 (Ejegg) a:Ejegg
[18:06:03] <wikibugs>	 Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: New resultswitcher framebusting order messes up error display - https://phabricator.wikimedia.org/T165106#3257156 (Ejegg) Open>Resolved a:Ejegg
[18:09:19] <wikibugs>	 (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[18:11:08] <wikibugs>	 Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface, and 2 others: "Return to PayPal" error not handled right for recurring - https://phabricator.wikimedia.org/T165089#3287066 (Ejegg) Open>Resolved
[18:11:46] <wikibugs>	 Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, and 7 others: [Tech Debt] Consolidate DonationInterface validation - https://phabricator.wikimedia.org/T160385#3287069 (Ejegg) Ope...
[18:17:08] <wikibugs>	 (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355242 (owner: Mepps)
[18:18:52] <wikibugs>	 (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355242 (owner: Mepps)
[18:29:59] <ejegg>	 mepps odd, looks like they must have changed the CI configuration for our deployment branch
[18:30:11] <ejegg>	 so it's running the onUnitTests hook
[18:30:18] <mepps>	 ahh
[18:30:28] <ejegg>	 I guess we can make that conditional on the TestConfiguration file existing
[18:31:35] <wikibugs>	 (CR) jerkins-bot: [V: -1] Allow old keys in session values [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[18:32:31] <wikibugs>	 (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[18:34:07] <ejegg>	 mepps so, the first step to troubleshoot CI is to make a comment with just the word 'recheck'
[18:34:16] <ejegg>	 that triggers another run of the tests
[18:34:23] <ejegg>	 in case of transient failure
[18:34:39] <mepps>	 ejegg good to know!
[18:34:49] <ejegg>	 if it fails again, join #wikimedia-releng and let them know
[18:35:11] <ejegg>	 I've been asking about this set of failures over there for a bit
[18:35:21] <ejegg>	 nobody's quite sure what's going on
[18:37:45] <mepps>	 ejegg would they have changed the CI config?
[18:37:49] <ejegg>	 mepps want to write a patch for DonationInterface.class.php?
[18:38:00] <ejegg>	 mepps: oh, they're always changing the CI config :P
[18:38:19] <ejegg>	 fancy new linters and style checkers and such
[18:38:28] <ejegg>	 or just reconfiguring the infrastructure
[18:38:58] <mepps>	 ejegg, haha, and sure! do we need to video chat? I'm in a shared workspace for another half an hour or so then i'll be available, but happy to take something on though while i'm here
[18:39:16] <ejegg>	 I figure we just bail out of onDonationInterfaceUnitTests at the top if the TestConfiguration file doesn't exist
[18:39:34] <ejegg>	 looks like returning true is the no-error path
[18:41:16] <ejegg>	 vidchat might be nice for the deploy once we finally get the CI stuff sorted out
[18:41:24] <mepps>	 cool
[18:46:35] <wikibugs>	 (PS1) Mepps: Bail out of tests if no config file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263
[18:48:33] <mepps>	 ejegg ^^ this worked locally
[18:51:18] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3287173 (cwdent) @CCogdill_WMF - no problem, I have an access request out to Lisa and will set the accounts up when I hear back.
[18:52:33] <wikibugs>	 (CR) Ejegg: [C: -1] "Looks good, just some style nitpicks. Outside of CRM, we try to follow https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263 (owner: Mepps)
[18:54:10] <ejegg>	 uff, one more dumb gerrit trick for situations like this: https://gerrit.wikimedia.org/r/#/c/355173/
[18:54:22] <ejegg>	 has C+2 and V+2, marked 'Ready to Submit'
[18:54:34] <ejegg>	 but that repo only is submittable by jenkins
[18:54:55] <ejegg>	 and jenkins doesn't know to run the gate-and-submit jobs because the V+2 only happened on recheck
[18:55:06] <ejegg>	 so, the fix is to remove the C+2 and re-apply it
[18:55:37] <wikibugs>	 (CR) Ejegg: [C: 2] "Re-applying mepps's C+2 to trigger gate-and-submit" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[19:01:15] <ejegg>	 i'm going to grab some food and hope gerrit is less frustrating when I get back
[19:04:40] <wikibugs>	 (Merged) jenkins-bot: Allow old keys in session values [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355173 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[19:31:04] <wikibugs>	 fundraising-tech-ops, Operations, Traffic: Fix nits in HTTPS/HSTS configs in externally-hosted fundraising domains - https://phabricator.wikimedia.org/T137161#3287257 (Jgreen) @BBlack ok I upgraded nginx and *ssl, and civicrm and the other frack-hosted sites should be fixed to include the HSTS header...
[19:36:54] <wikibugs>	 (PS2) Mepps: Bail out of tests if no config file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263
[19:37:32] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: CentralNotice: How can we better monitor/provide tools/collaborate to prevent errors in banners? - https://phabricator.wikimedia.org/T165686#3287284 (ggellerman) p:Triage>Normal
[19:40:48] <wikibugs>	 (CR) Ejegg: "couple lines still start with spaces" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263 (owner: Mepps)
[19:43:14] <wikibugs>	 (PS3) Mepps: Bail out of tests if no config file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263
[19:43:25] <wikibugs>	 (PS1) AndyRussG: Admin UI: allow all configurable buckets in campaignmanager.js [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/355275
[19:44:19] <wikibugs>	 Fundraising-Backlog, FR-Amazon, FR-Smashpig: Amazon IPN listener should send failmail on verification fail - https://phabricator.wikimedia.org/T166087#3287299 (ggellerman) p:Triage>Normal
[19:49:36] <wikibugs>	 Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3286340 (Ejegg) Hi @CCogdill_WMF , we can't A/B test with the current code, and we're not inserting the web beacon pixels that would track open rates. We can get some idea of unsubscr...
[19:50:11] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store recurring tokens in Civi's payment_token table - https://phabricator.wikimedia.org/T165695#3287316 (ggellerman) p:Triage>Normal
[19:52:35] <wikibugs>	 Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface: Deal with paypal EC error 11607, show thank you page - https://phabricator.wikimedia.org/T165635#3287320 (ggellerman) p:Triage>High
[19:54:22] <wikibugs>	 Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Patch-For-Review: Drush thank you task naming causes confusion - https://phabricator.wikimedia.org/T165671#3287323 (ggellerman)
[19:54:24] <wikibugs>	 Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Patch-For-Review: Add payment session ID to pending & donations queue messages - https://phabricator.wikimedia.org/T165687#3287324 (...
[19:54:43] <wikibugs>	 Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3287326 (Ejegg) a:Ejegg
[19:56:29] <wikibugs>	 Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, and 3 others: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3287330 (ggellerman)
[19:57:46] <wikibugs>	 Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint Dirt Farming, and 10 others: Store and update list of currently working iDEAL banks - https://phabricator.wikimedia.org/T128692#3287332 (ggellerman)
[20:02:39] <wikibugs>	 (CR) AndyRussG: "Thanks much for 4 the reviews, all!!" (7 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/344988 (https://phabricator.wikimedia.org/T144453) (owner: AndyRussG)
[20:10:22] <ejegg|food>	 mepps: there's this page: https://www.mediawiki.org/wiki/Git/Reviewers
[20:10:47] <ejegg|food>	 where you can add your gerrit username under each project you want to automatically get assigned as a reviewer on
[20:12:20] <wikibugs>	 (CR) Ejegg: [C: 2] Bail out of tests if no config file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263 (owner: Mepps)
[20:14:47] <wikibugs>	 (Merged) jenkins-bot: Bail out of tests if no config file [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355263 (owner: Mepps)
[20:18:02] <ejegg>	 ok mepps, we should be able to merge to deployment now!
[20:18:11] <mepps>	 ejegg working on it!
[20:19:03] <ejegg>	 sorry, don't mean to rush you
[20:20:11] <mepps>	 here's what's holding me up--should i worry about making this commit an amend to the previous master merge?
[20:22:02] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355281
[20:23:03] <mepps>	 ejegg i'm not sure i did that right..
[20:25:32] <ejegg>	 mepps oh sorry, looking
[20:26:05] <ejegg>	 I think they do need to all merge at once
[20:26:19] <ejegg>	 since the parent won't get approved as is
[20:27:21] <ejegg>	 but you can just start over if you want
[20:29:44] <wikibugs>	 (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355283
[20:29:52] <mepps>	 okay ejegg ^^
[20:31:01] <ejegg>	 looking
[20:31:28] <wikibugs>	 (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355283 (owner: Mepps)
[20:32:32] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355283 (owner: Mepps)
[20:34:08] <mepps>	 ejegg i'm not sure if you saw this or if this was what you meant earlier but should we be deploying these smashpig changes too: https://gerrit.wikimedia.org/r/#/c/355210/
[20:34:47] <ejegg>	 mepps oho, another fun one!
[20:34:52] <ejegg>	 let's do them one at a time
[20:34:58] <ejegg>	 both are potentially risky
[20:34:59] <mepps>	 ejegg haha sounds good
[20:35:09] <mepps>	 should we video chat to go ahead iwht donation interface?
[20:35:21] <ejegg>	 sure, I'll be in -talk in a sec
[20:35:38] <ejegg>	 want to get the mediawiki 1.27 patch ready?
[20:36:15] <mepps>	 oh this was one of my questions earlier is how we handle that
[20:36:49] <ejegg>	 the core branch fundraising/REL1_27 has submodules for our deployed extensions
[20:37:12] <ejegg>	 so you make sure your local checkout is up to date, then update the DonationInterface submodule
[20:37:31] <ejegg>	 commit that, review, and you can again self-merge (C+2)
[20:38:40] <wikibugs>	 (PS1) Mepps: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/355284
[20:39:19] <wikibugs>	 (CR) Mepps: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/355284 (owner: Mepps)
[20:40:01] <ejegg>	 XenoRyet|food: we're about to deploy all those field name changes
[20:40:14] <mepps>	 XynoRyet we're deploying the Donation Interface fix now
[20:40:24] <mepps>	 Woops XenoRyet ^^
[20:40:39] <XenoRyet>	 Cool, I'll keep an eye out.
[20:42:56] <wikibugs>	 fundraising-tech-ops, Operations, netops, ops-eqiad: rack/setup/wire/deploy msw2-c1-eqiad - https://phabricator.wikimedia.org/T166171#3287418 (RobH)
[20:43:28] <cwd>	 mepps: fyi you can tab complete names
[20:43:37] <cwd>	 X<tab>
[20:43:43] <cwd>	 keeps the wrist surgery at bay
[20:44:17] <mepps>	 haha thanks cwd!
[20:44:26] <mepps>	 ejegg i think i lost you in hangouts
[20:44:39] <mepps>	 but we'll need to deal with these build failures before we deploy
[20:45:05] <ejegg>	 mepps sorry, bad cell signal right here, moving
[20:45:11] <ejegg>	 try removing your +2 and re-applying it
[20:46:13] <mepps>	 oh nvm
[20:46:29] <mepps>	 we're fine--it was just the wrong window
[20:47:06] <mepps>	 ejegg let me know if you get to a better spot
[20:47:42] <wikibugs>	 (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/355284 (owner: Mepps)
[20:50:14] <ejegg>	 great!
[20:50:19] <ejegg>	 ok, getting back on the call
[20:52:23] <wikibugs>	 (PS1) Raimond Spekking: Revert "Localisation updates from https://translatewiki.net." Looks wrong.  [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355312
[21:00:31] <mepps>	 !log deployed payment wiki 0c06f8e6c998dccaa9857476dd71c16103e9b9e2
[21:00:39] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[21:04:03] <ejegg>	 XenoRyet: reverting
[21:04:11] <XenoRyet>	 Yep
[21:06:06] <ejegg>	 I'm starting to think the 'gross' field should stay 'amount'
[21:06:17] <ejegg>	 I think we can revert that one without much fuss
[21:06:57] <ejegg>	 'gross' is really just used in messages
[21:07:04] <ejegg>	 CRM uses 'amount' as well
[21:07:29] <XenoRyet>	 Makes sense
[21:07:39] <ejegg>	 let's see how this goes
[21:08:00] <ejegg>	 so, the donation amount header on the CC forms was different too
[21:08:07] <ejegg>	 I dunno where that came from
[21:12:19] <wikibugs>	 (PS1) Ejegg: Revert "Rename amount to gross" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355352
[21:12:24] <ejegg>	 XenoRyet: ^^^
[21:12:34] <XenoRyet>	 looking
[21:15:33] <wikibugs>	 (CR) XenoRyet: [C: 2] Revert "Rename amount to gross" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355352 (owner: Ejegg)
[21:16:38] <ejegg>	 thanks!
[21:16:47] <ejegg>	 doing a bit more testing locally
[21:17:25] <wikibugs>	 (Merged) jenkins-bot: Revert "Rename amount to gross" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355352 (owner: Ejegg)
[21:29:12] <ejegg>	 ok, mostly looking good
[21:32:09] <ejegg>	 so, we need tests that look at payments-init and payments-antifraud messages
[21:36:34] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Test coverage for generating payments-init and payments-antifraud queue messages - https://phabricator.wikimedia.org/T166182#3287714 (Ejegg)
[21:37:38] <ejegg>	 XenoRyet: mind taking a look at two little CRM patches?
[21:37:59] <XenoRyet>	 Sure, whatcha got?
[21:38:07] <ejegg>	 https://gerrit.wikimedia.org/r/354613 <- needed to keep audit parsers happy with new field names in logs
[21:38:31] <ejegg>	 https://gerrit.wikimedia.org/r/355252 <- will stop us rejectingrecurring donations we shouldn't
[21:38:45] <XenoRyet>	 Cool, taking a look.
[21:39:00] <ejegg>	 thanks!
[21:39:16] <ejegg>	 I'mma go tutor kids for a couple hours, but I'll be back on to respond to any comments after that
[21:39:50] <XenoRyet>	 10-4,  have fun.
[22:03:12] <wikibugs>	 (CR) XenoRyet: [C: 2] Audit processors can read normalized fields in logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354613 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[22:04:30] <wikibugs>	 (CR) jerkins-bot: [V: -1] Audit processors can read normalized fields in logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354613 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[22:14:16] <wikibugs>	 (CR) XenoRyet: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg)
[22:17:18] <wikibugs>	 (CR) jerkins-bot: [V: -1] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg)
[22:20:49] <wikibugs>	 (CR) XenoRyet: [C: 2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354613 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[22:21:36] <wikibugs>	 (CR) jerkins-bot: [V: -1] Audit processors can read normalized fields in logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354613 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[22:25:12] <wikibugs>	 (Merged) jenkins-bot: Audit processors can read normalized fields in logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/354613 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg)
[22:36:39] <wikibugs>	 Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3287800 (CCogdill_WMF) Thanks, @Ejegg. Is there a reason we don't insert the tracking pixel?  We send a really small amount of email (generally 4 or less per donor per year) so it's k...
[22:38:31] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3287803 (CCogdill_WMF) Okay, thank you!  Le mar. 23 mai 2017 à 20:51, cwdent <no-reply@phabricator.wikimedia.org> a écrit :  > cwdent added a comment. > > @CCogdill_WMF <https://phab...
[23:23:21] <AndyRussG>	 fr-tech so, Thursday at 3 pm PDT sound good for a CentralNotice deploy to the main cluster for Banner Sequence? Anyone else want to also participate?
[23:58:39] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3287956 (cwdent) @MNoorWMF - in order to get you shell access you'll need to generate an ssh key for the fundraising cluster.  On Mac OS this can be done by running the following in...