[00:51:42] (PS2) Ejegg: Rename 'complete' queue to 'donations' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354559 (https://phabricator.wikimedia.org/T95647) [01:02:34] (PS3) Ejegg: Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) [01:15:22] (PS2) Ejegg: WIP consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [01:17:19] (CR) jerkins-bot: [V: -1] WIP consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [01:30:19] (PS3) Ejegg: WIP consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [01:32:13] (CR) jerkins-bot: [V: -1] WIP consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [01:38:53] (PS4) Ejegg: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [01:45:56] (PS5) Ejegg: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [02:05:04] (PS1) Ejegg: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 [02:07:12] (CR) jerkins-bot: [V: -1] Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (owner: Ejegg) [02:09:16] (PS2) Ejegg: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) [08:13:11] fundraising-tech-ops, Operations, netops, ops-eqiad: rack/setup/wire/deploy msw2-c1-eqiad - https://phabricator.wikimedia.org/T166171#3288263 (ayounsi) As ETA is very short for the new routers and switches, let's wait for them and plan/rack everything at the same time. [08:14:01] fundraising-tech-ops, Operations, netops, ops-eqiad: rack/setup/wire/deploy msw2-c1-eqiad - https://phabricator.wikimedia.org/T166171#3288264 (ayounsi) a:Cmjohnson [14:13:50] (CR) Mepps: [C: 2] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [14:16:46] (CR) jerkins-bot: [V: -1] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [14:21:01] (CR) Mepps: Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [14:21:05] (CR) Mepps: [C: 2] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [14:21:54] (CR) jerkins-bot: [V: -1] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [14:40:31] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Preparing Slave SQL: Yes Seconds Behind Master: (null) [14:45:31] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Preparing Slave SQL: Yes Seconds Behind Master: (null) [14:50:31] RECOVERY - check_mysql on payments2001 is OK: Uptime: 5258637 Threads: 3 Questions: 54373 Slow queries: 0 Opens: 29 Flush tables: 1 Open tables: 92 Queries per second avg: 0.010 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [15:52:02] (CR) Ejegg: "Recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [15:56:15] (CR) jerkins-bot: [V: -1] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [16:05:03] (CR) Mepps: "It looks like this is failing now because it can't find the UtcDate class." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [16:05:31] (PS2) Ejegg: Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) [16:06:49] (CR) Mepps: [C: 2] "The fix looks good. Let's see if the build works!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [16:10:26] (CR) jerkins-bot: [V: -1] Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [16:12:38] (Merged) jenkins-bot: Unique-ify invoice ID for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355252 (https://phabricator.wikimedia.org/T166159) (owner: Ejegg) [16:40:22] Wikimedia-Fundraising-Banners: Ensure fundraising banners work in right-to-left languages - https://phabricator.wikimedia.org/T165528#3289378 (Pcoombe) Notes so far from desktop: Need translations in He - "Maybe later" - "Secure transaction" Dsk small nag should come from right Dsk small close is weird [16:59:32] hi fr-tech! [16:59:41] thanks for getting that patch through mepps [17:00:20] fr-tech: Not everything worth doing is worth doing well. [17:00:20] -- discuss. [17:02:58] ejegg: boo! [17:03:12] Hi AndyRussG ! [17:03:25] I heartily disagree with slander today 8p [17:05:46] hmm, there's a lot that doesn't demand perfection [17:09:02] (PS1) Ejegg: WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 [17:09:26] XenoRyet: ^^^ is going to fail and illustrate a problem I'd like your input on [17:09:48] Ok, let me take a look. [17:10:14] which is that we can't initialize the whole SmashPig context / configuration until we know which gateway we're using [17:11:33] So, we're going to need to do things like choose a gateway based on their capabilities [17:11:45] (CR) jerkins-bot: [V: -1] WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (owner: Ejegg) [17:12:03] which will need us to load config for several different gateways at the same time [17:12:30] in the process-control project, we've got a global configuration and job configurations [17:13:29] If something doesn't demand perfection and resources are limited, then doing it well means doing it to the quality that circumstances demand. In such a case, doing that thing to perfection isn't doing it well... [17:14:00] good point AndyRussG [17:14:16] ;p [17:14:24] On a not unrelated topic, it looks like we can't deploy BS because this change hasn't gone out to production yet: https://gerrit.wikimedia.org/r/#/c/348310/ [17:15:07] Just tested on the beta cluster, and indeed dragging and dropping steps gives messed up sequence state [17:15:27] well dang! [17:15:49] yurp [17:16:05] asking now on #wikimedia-editing when it might go out... [17:16:06] it merged a month ago - what's the holdup? [17:16:28] Yea... Well oojs is included in mw core as a library [17:16:32] dependency [17:16:36] ohhhhh [17:16:44] so only released versions go out to prod [17:17:00] oojs-ui has been released since, but oojs-core hasn't [17:17:06] I can nudge ppl in Scrum of Scrums if that might help [17:17:24] prod is still on oojs-core version 2.0.0 [17:17:27] speaking of which: anything for scrum of scrums, fr-tech? [17:17:54] bugfix is at least worth a minor point release, right? [17:17:59] Mmm ejegg mebbe, though maybe also wait, since I'm just doing the first nudging of it [17:18:11] k, that meeting's in 20 min [17:18:30] Nothing for SoS from me. [17:18:34] Fundraising-Backlog, Operations, Technical-Debt: Determine if benefactorevents.wikimedia.org should be hosted on the production cluster or still on Microsoft Azure - https://phabricator.wikimedia.org/T166240#3289505 (Dereckson) [17:18:42] nothing here, thanks! [17:19:02] I'd also assumed sufficient time had passed for it to be merged... just getting some replies on -editing... So, maybe let's not scale up to SoS just yet? thx though!!! [17:19:05] wat, we're hosting stuff on Azure? [17:19:05] ejegg: ^ [17:20:52] ok, I'll just say the Banner Sequence deploy is held up on dependencies, but that you're talking with the relevant people [17:21:20] ejegg: yea that sounds great, thanks! ... I should have verified this earlier [17:21:35] nothing else I can think of for SoS [17:22:56] XenoRyet: so, I feel like we need the same sort of split configs for SmashPig [17:23:10] but I'm not sure of the best place to split them [17:24:27] Ok, yea. [17:24:54] I'll play around with that a bit and see if a good place suggests itself. [17:25:07] in the past we've overridden the failmail destination for a specific gateway, so only the person that broke it has to hear about e.g. an adyen breakage [17:25:27] but besides that, we don't do much overriding of what's in the default node [17:29:54] We'll want to put all the stuff from the gateway config dirs into smashpig eventually, and that definitely shouldn't all be stuffed into SmashPig.yaml [17:30:11] True [17:41:34] AndyRussG: Joseph from analytics mentioned 'purging eventlogging mysql'. looking for more details... [17:48:35] ejegg: ah K... Mmm we don't have stuff in eventlogging mysql fortunately. Everything we have is in Hive. (Our EventLogging schema isn't compatible with the mysql storage option...) [17:49:21] ah, wonderful! [17:49:52] ejegg can i go ahead and close this: https://phabricator.wikimedia.org/T165671 or how would it get resolved? [17:50:23] mepps: yep, go right ahead [17:50:34] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Patch-For-Review: Drush thank you task naming causes confusion - https://phabricator.wikimedia.org/T165671#3289615 (mepps) Open>Resolved [17:50:38] in fact... fr-tech anything else we can close out on the sprint board? [17:51:41] Taking a look. [17:54:11] how about this one ejegg: https://phabricator.wikimedia.org/T163412 [17:54:32] mepps oh, let's test that out [17:54:47] want to set it to a low value temporarily and make sure you see the timeout in the logs? [17:55:04] my only concern is that wouldn't some users not get thank yous? [17:55:26] mepps they'll get them on the next cycle [17:56:04] we grab the whole batch at once based on contributions with no thank_you_date, but we update that column individually after each one is sent [17:57:56] got it [17:58:19] just saw the timeout occur! [17:58:26] rockin! [17:58:44] how often does the thank you job run? [17:58:48] actually, we should set that to 2 minutes minus the timeout on the queue consumer [17:59:07] so, there's a combined job that runs first the donation queue consumer, then the thank you job [17:59:15] and that runs every two minutes [17:59:30] it complains with a failmail if the previous run is still alive [17:59:37] which is why we needed your fix [18:00:03] so now we can adjust the timing of both child jobs to never exceed 1 minute 59 seconds [18:01:03] ah cool, set the thank you job to 54 seconds then [18:01:07] but we can definitely close out the task [18:01:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank you mail send should have a time limit - https://phabricator.wikimedia.org/T163412#3289690 (mepps) Open>Resolved a:mepps [18:01:32] yay! [18:01:42] :) [18:02:57] (PS1) Ejegg: Allow old 'currency_code' param for form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355462 [18:03:04] XenoRyet: just thought of one more thing for the re-key ^^^ [18:03:12] looking [18:03:20] thanks! [18:08:14] fr-tech some thoughts on the global / gateway config in https://etherpad.wikimedia.org/p/fr-tech-talk [18:08:20] please add your own input! [18:08:49] (CR) XenoRyet: [C: 2] Allow old 'currency_code' param for form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355462 (owner: Ejegg) [18:09:10] thanks XenoRyet ! [18:09:17] No worries [18:09:29] I think I'm going to try another payments deploy [18:09:53] Sounds good. [18:10:48] (Merged) jenkins-bot: Allow old 'currency_code' param for form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355462 (owner: Ejegg) [18:20:23] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355468 [18:21:24] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355468 (owner: Ejegg) [18:21:34] :S [18:22:30] ohh, lintyaml is still called on deployment. guess we have to leave one thing in the tests folder... [18:22:43] (PS2) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355468 [18:23:11] hmm, maybe I'll actually just change the composer test scripts on deployment [18:24:21] (PS3) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355468 [18:26:55] oh hey, fr-tech: does anyone have issues with git-review using a different remote and sometimes reporting extra commits that you know are already merged? [18:27:11] Can't say I've run into that one. [18:27:37] ah, ok. is your main remote named 'gerrit' ? [18:27:58] mine is named origin, and on the backup machine git-review set up a new 'gerrit' remote for each repo [18:28:19] but that remote wouldn't stay in sync unless I fetched it all the time [18:28:35] anyway, there's a global git config var you can set [18:28:49] git config --global gitreview.remote origin [18:28:59] mepps did you have that issue? ^^^ [18:29:13] back in a bit! [18:29:35] also, mepps, want to set your IRC client to notify you when 'fr-tech' shows up in chat? [18:29:57] oh ejegg i did have that issue and oh yes i do want to do that [18:30:08] cool! [18:30:23] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355468 (owner: Ejegg) [18:32:41] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/355468 (owner: Ejegg) [18:32:44] i think i just set it up--fingers crossed [18:32:53] let's try it! [18:33:13] fr-tech: this is a test of the IRC notification system [18:33:16] fr-tech batsignal! [18:33:53] haha so can you test one more time--i had accidentally set it up to notify me of all updates (i thought the option was all updates when highlight word is used) [18:34:25] (PS1) Ejegg: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/355470 [18:34:32] fr-tech [18:34:34] ejegg: Heya, I wanna go ahead and put https://gerrit.wikimedia.org/r/#/c/342857/ live. Got time after swat finishes? I'm pretty confident, but don't want to break donatewiki :) [18:34:39] worked! [18:34:41] nice [18:34:53] (we've put this off too long :)) [18:36:49] RainbowSprinkles: sure, I'm available! [18:37:23] Awesome thx [18:37:29] Actually, that password shouldn't even need to be there [18:37:43] nothing outside of the payments cluster can touch that db since forever [18:37:56] and the payments cluster config is managed totally separately [18:38:22] The only thing that we really care about in that file is the maintenance flag, I think [18:38:34] looking into it [18:39:16] hah, totally out of date too [18:46:25] RainbowSprinkles: sorry I didn't look into that sooner - commented just now [18:49:45] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, Patch-For-Review, Scap (Scap3-MediaWiki-MVP): Clean up Contribution Tracking settings in main wmf config repo - https://phabricator.wikimedia.org/T147479#3289911 (Ejegg) [18:51:34] Fundraising-Backlog, FR-Smashpig: Track more stages of the donation funnel - https://phabricator.wikimedia.org/T149746#3289920 (Ejegg) [18:51:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Epic: [Epic] Keep event-based donation history rather than 1:1 properties - https://phabricator.wikimedia.org/T122355#3289919 (Ejegg) [18:51:38] ejegg: Even better! Will amend [18:53:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface, Epic: [Epic] Keep event-based donation history rather than 1:1 properties - https://phabricator.wikimedia.org/T122355#3289927 (Ejegg) [18:53:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: [Epic] Contribution tracking reform - https://phabricator.wikimedia.org/T158009#3289926 (Ejegg) [18:55:40] ejegg: New patch up for review [18:58:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#3289952 (mepps) @ejegg what happens if no risk score is set? [19:01:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#3289961 (Ejegg) @mepps minfraud just won't show up in the fraud score breakdown sent to the payments-antifraud queue (and stored in fredge). How about adding a new co... [19:02:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#3289967 (Ejegg) You would add that in extension.json and set a default, with a mention in README. Then use the gateway->getGlobal() fn to look it up for use in the fil... [19:08:18] going to relocate to a food source before deploy. back in a bit! [19:08:41] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, Patch-For-Review, and 2 others: Clean up Contribution Tracking settings in main wmf config repo - https://phabricator.wikimedia.org/T147479#3289986 (demon) Open>Resolved a:demon Ya... [19:20:02] (PS1) Mepps: Log error if Minfraud service not reached and add configured risk score Bug: T150072 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) [19:21:37] (CR) jerkins-bot: [V: -1] Log error if Minfraud service not reached and add configured risk score Bug: T150072 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [19:22:11] ejegg do i have something wrong in my commit messages for the phabricator hook? it's currently not syncing up it looks like [19:22:21] oh nm ejegg i see you're afk [19:25:58] (PS2) Mepps: Log error if Minfraud service not reached and add configured risk score Bug: T150072 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) [19:28:41] (CR) jerkins-bot: [V: -1] Log error if Minfraud service not reached and add configured risk score Bug: T150072 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [19:43:02] hi mepps, I'll take a look [19:43:48] mepps there should be a blank line after the commit message 'headline' [19:45:33] (PS3) Mepps: Log error if Minfraud service not reached and add configured risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) [19:45:37] cool, thanks! [19:46:03] also i'm trying to get the tests working but i'm getting PDOException: could not find driver [19:46:09] i'm wondering if i'm missing a setting? [19:46:21] oh? weird [19:46:29] using php7, right? [19:46:53] you might need to change some connection strings from mysql to mysqli [19:46:59] (CR) jerkins-bot: [V: -1] Log error if Minfraud service not reached and add configured risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [19:47:00] that's just a general thing, though [19:47:07] I think mediawiki mostly uses PDO [19:47:32] haha, it's just noticed it's JERKins-bot, not jenkins-bot. appropriate [19:47:48] ha! [19:48:50] (CR) Ejegg: "Oh hey, that try/catch isn't very helpful. Let's either get rid of it, or put the query_minfraud call inside of it and move the NoResponse" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [19:50:50] (CR) Ejegg: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/355470 (owner: Ejegg) [19:57:16] (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/355470 (owner: Ejegg) [19:58:28] (CR) Ejegg: "also, let's dial that error all the way up to critical" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [19:58:49] XenoRyet: ok, going to try that deploy again [20:00:47] MBeat: sorta-risky deploy imminent. Changing a few internal names for data fields that are used in tons of places [20:01:06] ok, will keep an eye out for odd stuff [20:01:19] 10-4 [20:04:44] !log updated payments-wiki from 5fa4a70e97cd37609b5e314f55195fc00dc8828c to 4786e7c223fe7bc61bc9d03b63d85a7eaee4c622 [20:04:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:06:02] ok, form looks good [20:06:11] failure & try again links are OK [20:06:46] paypal redirect is good [20:07:07] logs are looking fine so far. [20:07:30] Oop, failmails [20:07:32] amazon form is remembering the amount after login [20:07:48] reverting [20:08:51] !log reverted payments-wiki to 5fa4a70e97cd37609b5e314f55195fc00dc8828c [20:09:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:09:01] shoot [20:09:11] let's fix that downstream and do a civi deploy [20:09:20] Sounds good [20:11:25] I'm gonna go grab some food, and I'll be available for any needed CR when I get back. [20:25:06] (PS1) Ejegg: Payments-init consumer can handle 'currency' message field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355488 (https://phabricator.wikimedia.org/T165818) [20:25:43] mepps so, that's a blind spot in our tests... [20:26:37] would be awesome to have an end to end test case where we fed the queue messages output from DI into our civi consumers and made sure the right stuff got inserted into the db [20:26:56] but that would be a pretty complex job [20:27:50] we should at least write more tests for DonationInterface's queue message output [20:28:59] huh, I should fix those damaged messages and re-queue them [20:29:13] mepps want to follow along with that hackery? [20:34:20] ejegg yes in 20? I'm picking my son up early because we have the late meeting [20:35:15] sure, 20 min is fine [20:41:54] (PS1) Ejegg: Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 [21:02:21] okay i'm back [21:02:53] ejegg i'm on fr-tech-talk [21:30:12] (PS1) Ejegg: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 [21:32:21] (CR) jerkins-bot: [V: -1] Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 (owner: Ejegg) [21:43:12] (PS2) Ejegg: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 [21:44:10] (CR) jerkins-bot: [V: -1] Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 (owner: Ejegg) [21:46:10] (PS3) Ejegg: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 [22:23:50] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, FR-Email: retrieve lists of contacts who received a particular mailing - https://phabricator.wikimedia.org/T161762#3290598 (Eileenmcnaughton) a:Eileenmcnaughton [22:24:23] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, MediaWiki-extensions-DonationInterface: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3290604 (Ejegg) [22:24:25] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Store merchant reference in invoice id - https://phabricator.wikimedia.org/T165696#3290602 (Ejegg) Open>Resolved a:Ejegg [22:26:28] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Smashpig, Patch-For-Review: SmashPig pending db pruner is broken - https://phabricator.wikimedia.org/T161260#3290606 (Ejegg) Open>Resolved [22:28:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Find and Merge Duplicate Contacts function isn't working in Civi - https://phabricator.wikimedia.org/T165615#3290609 (Eileenmcnaughton) a:Eileenmcnaughton [22:32:48] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#3290613 (ggellerman) Open>Resolved [22:32:51] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Enable ability to look up contacts by phone number - https://phabricator.wikimedia.org/T97372#3290614 (ggellerman) Open>Resolved [22:33:41] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog, FR-Smashpig, Patch-For-Review: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3290617 (Ejegg) This is actually unhelpful 'cause we're contractually not allowed... [22:34:31] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint Dirt Farming, and 9 others: Store and update list of currently working iDEAL banks - https://phabricator.wikimedia.org/T128692#3290620 (Ejegg) This is a... [22:34:51] Fundraising Sprint K 2017, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#3290623 (Eileenmcnaughton) [22:35:30] Fundraising Sprint K 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, FR-Email: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3290624 (Eileenmcnaughton) [22:38:22] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3290631 (ggellerman) [22:38:28] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, FR-Smashpig, and 4 others: DonationInterface needs to use the same data keys as the backend - https://phabricator.wikimedia.org/T165818#3290634 (ggellerman) [22:38:31] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Add payment session ID to pending & donations queue messages - https://phabricator.wikimedia.org/T165687#3290635 (ggellerman) [22:38:33] Fundraising Sprint K 2017, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface: Deal with paypal EC error 11607, show thank you page - https://phabricator.wikimedia.org/T165635#3290636 (ggellerman) [22:38:36] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Spike: Investigate cause of large banner impression surge in NL and ES fr campaigns - https://phabricator.wikimedia.org/T164996#3290638 (ggellerman) [22:38:41] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, FR-Ingenico, and 2 others: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3290640 (ggellerman) [22:38:43] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, and 4 others: Move already-encapsulated useful classes into SmashPig - https://phabricator.wikimedia.org/T163868#3290641 (ggellerman) [22:38:46] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, and 4 others: Move staging / unstaging helpers into SmashPig - https://phabricator.wikimedia.org/T163867#3290642 (ggellerman) [22:38:48] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog: Compile list of systems we depend on and should check all the time - https://phabricator.wikimedia.org/T163509#3290643 (ggellerman) [22:38:50] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, and 3 others: CentralNotice: Admin UI for campaigns may submit input with errors - https://phabricator.wikimedia.org/T163057#3290644 (ggell... [22:38:53] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, and 2 others: break out Ingenico reintegration work - https://phabricator.wikimedia.org/T162840#3290645 (ggellerman) [22:38:55] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: retrieve lists of contacts who received a particular mailing - https://phabricator.wikimedia.org/T161762#3290646 (ggellerman) [22:38:57] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 5 others: retrieve the text/ html and statistics data for m... - https://phabricator.wikimedia.org/T161758#3290647 [22:38:59] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 3 others: NULL referrers - https://phabricator.wikimedia.org/T161539#3290648 (ggellerman) [22:39:01] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, and 4 others: Errors in CiviCRM dedupe screen - https://phabricator.wikimedia.org/T160571#3290649 (ggellerman) [22:39:03] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 10 others: Mediawiki namespace pages, including CentralNotice banners, are slow to s... - https://phabricator.wikimedia.org/T158084#3290650 [22:39:06] Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, and 7 others: Review fr-tech data retention guidelines - https://phabricator.wikimedia.org/T156317#3290651 (ggellerman) [22:39:10] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, and 11 others: Purge Varnish cache when a banner is saved - https://phabricator.wikimedia.org/T154954#3290652 (ggellerman) [22:39:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for email only works if primary email address - https://phabricator.wikimedia.org/T152048#2836522 (Ejegg) Is this going to be fixed in 4.7.19 along with the phone number search? [22:39:16] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice banner sequence: unit tests - https://phabricator.wikimedia.org/T144456#3290655 (ggellerman) [22:39:19] Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, and 10 others: CentralNotice banner sequence: implement feature for MVP - https://phabricator.wikimedia.org/T144453#3290656 (ggellerman) [22:39:22] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 3 others: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3290657 (ggellerman) [22:39:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for email only works if primary email address - https://phabricator.wikimedia.org/T152048#2836522 (mepps) @ejegg yes that is handled by the patch that's in the upgrade. [22:55:06] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice banner sequence: unit tests - https://phabricator.wikimedia.org/T144456#3290716 (AndyRussG) a:AndyRussG [22:57:15] Fundraising Sprint Judgement Suspenders, Fundraising Sprint K 2017, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Add payment session ID to pending & donations queue messages - https://phabricator.wikimedia.org/T165687#3290723 (Ejegg) Open>Resolved [23:27:00] https://gerrit.wikimedia.org/r/355488 [23:27:04] XenoRyet: ^^^ [23:30:42] (CR) XenoRyet: [C: 2] Payments-init consumer can handle 'currency' message field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355488 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg) [23:33:59] thanks XenoRyet [23:34:13] do you mind prepping a civi deploy with that? [23:34:25] i'll be back at kbd in 5 [23:34:37] Yea, let me get that rolling. [23:35:29] (Merged) jenkins-bot: Payments-init consumer can handle 'currency' message field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/355488 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg) [23:43:22] (PS1) XenoRyet: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/355569 [23:44:00] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/355569 (owner: XenoRyet) [23:45:14] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/355569 (owner: XenoRyet) [23:45:49] ejegg: Ok, that's prepped [23:46:51] great! [23:46:58] looks like a safe one [23:47:07] want to do the honors? [23:47:14] Sure [23:49:34] !log updated civicrm from 9b7a74c2921acb11d37271a9d388fdd2b804b450 to 9c06bd2f4c2298607de995efc114baae79d6476a [23:49:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:51:03] Ok, that should be good [23:51:33] rockin! [23:51:44] i'll redo the payments deploy [23:52:13] Cool. I gotta run in 10 mins, but we should still be able to get through this, I think. [23:53:45] !log updated payments-wiki from 5fa4a70e97cd37609b5e314f55195fc00dc8828c to 4786e7c223fe7bc61bc9d03b63d85a7eaee4c622 [23:53:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:54:20] cool, and we can re-queue those -init messages from the last deploy