[00:53:47] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 10 others: Mediawiki namespace pages, including CentralNotice banners, are slow to s... - https://phabricator.wikimedia.org/T158084#3290888 [00:58:07] Fundraising-Backlog: Stop warning about "potential cache slam" - https://phabricator.wikimedia.org/T120470#3290896 (Ejegg) Open>Resolved a:Ejegg No longer using APC in config class [00:58:59] Fundraising-Backlog: SmashPig: Use existing YAML library for configuration - https://phabricator.wikimedia.org/T114822#3290900 (Ejegg) Open>Resolved a:Ejegg Looks like this is all set now! [01:02:54] (PS1) Ejegg: Route all config access through Context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) [01:03:52] (PS2) Ejegg: Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 [01:03:54] (PS4) Ejegg: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 [02:13:14] (PS1) Ejegg: WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 [02:14:07] (CR) jerkins-bot: [V: -1] WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (owner: Ejegg) [11:07:57] Fundraising-Backlog, Wikimedia-Fundraising: Missing message "donate_interface-amount-legend" on donatewiki - https://phabricator.wikimedia.org/T166302#3291517 (Pcoombe) [12:59:19] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface, Patch-For-Review: Orphan rectifier is silent about communication failures - https://phabricator.wikimedia.org/T161160#3291717 (Krinkle) [12:59:49] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Handle attempts to donate via iDEAL in unsupported currencies - https://phabricator.wikimedia.org/T161073#3291722 (Krinkle) [13:17:56] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 9 others: Mediawiki namespace pages, including CentralNotice banners, are slow to sa... - https://phabricator.wikimedia.org/T158084#3291765 [14:02:09] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: General DonationInterface code cleanup - https://phabricator.wikimedia.org/T87043#3291931 (Krinkle) Is this resolved? [14:07:23] Fundraising-Backlog, MW-1.29-release-notes: Investigate and bring back data & functionality previously held in contribution tracking table - https://phabricator.wikimedia.org/T150055#3291946 (Krinkle) Is this resolved? [14:16:50] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Deferential Equations, Fundraising Sprint Dirt Farming, and 8 others: Store and update list of currently working iDEAL banks - https://phabricator.wikimedia.org/T128692#3292019 (Krinkle) [15:02:07] (CR) Mepps: "@Ejegg in terms of the try catch, is there any exception we would want to catch (if the query were in the try) where we would want to assi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [15:05:19] (PS4) Mepps: Log error if Minfraud service not reached and add configured risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) [15:06:27] (PS5) Mepps: Log error if Minfraud service not reached and add configured risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) [15:08:48] (CR) jerkins-bot: [V: -1] Log error if Minfraud service not reached and add configured risk score [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [15:20:02] Fundraising-Backlog: Fix visible code in donation form: ⧼donate_interface-amount-legend⧽ - https://phabricator.wikimedia.org/T166314#3292256 (MBeat33) [15:26:09] Fundraising-Backlog: Fix visible code in donation form: ⧼donate_interface-amount-legend⧽ - https://phabricator.wikimedia.org/T166314#3292280 (MBeat33) [15:34:35] Fundraising-Backlog: Fix visible code in donation form: ⧼donate_interface-amount-legend⧽ - https://phabricator.wikimedia.org/T166314#3292317 (MBeat33) This is a donor-facing error and hopefully not too complicated a fix, so I would recommend **Unbreak Now** as the priority. [15:53:40] (CR) Ejegg: "Nope, we would use the same placeholder score for an exception as for a missing risk_score" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [15:54:57] (CR) Mepps: Log error if Minfraud service not reached and add configured risk score (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355480 (https://phabricator.wikimedia.org/T150072) (owner: Mepps) [15:57:15] fr-tech: how does a page get added on wikitech? wanted to create a place to start adding my notes on manual setup [15:58:32] meppa just navigate to where the page would be, then click the edit button [15:59:15] there might be a good spot for it under mediawiki.org/Fundraising_tech [16:00:06] ejegg should it be there and not wikitech? [16:00:45] yeah, we're trying to consolidate there [16:00:52] oh interesting, i didn't see that the first time but was at https://wikitech.wikimedia.org/wiki/Fundraising/tech [16:01:57] it looks like this is the spot: https://www.mediawiki.org/wiki/Fundraising_Tech/Donation_Pipeline_Setup [16:01:58] sorry, i pasted a bad url, should be https://mediawiki.org/wiki/Fundraising_tech [16:02:10] yeah it had a link correction :) [16:02:17] yep, that looks good! [16:02:25] cool, thanks! [16:05:39] should we delete the wikitech pages or add a link to this page? i really never even saw it when i was getting set up [16:11:53] mepps let's link for starters [16:15:16] K, will do that after lunch! [17:00:19] fr-tech: Pelorat sighed. [17:00:19] "I will never understand people." [17:00:19] "There's nothing to it. All you have to do is take a close look [17:00:19] at yourself and you will understand everyone else. How would Seldon have [17:00:19] worked out his Plan -- and I don't care how subtle his mathematics was -- [17:00:19] if he didn't understand people; and how could he have done that if people [17:00:20] weren't easy to understand? You show me someone who can't understand [17:00:20] people and I'll show you someone who has built up a false image of himself [17:00:24] -- no offense intended." [17:00:24] -- Isaac Asimov, "Foundation's Edge" [17:00:24] -- discuss. [17:01:16] XenoRyet|sorta: when you get a chance, can you give me some feedback on the SmashPig configuration patches? [17:01:35] not sure if that's exactly the way to go [17:02:38] Yea, kinda got distracted away from it yesterday, but I'll take another look at it today. [17:11:07] thanks! [17:11:37] I'll polish up that last WIP a bit more to make it clear where I'm trying to go [18:08:31] mepps: I'm also curious to hear what you think of the SmashPig configuration changes [18:09:02] I can talk out the motivation for them if you like [18:09:24] ejegg can you send me a link to the gerrit review? [18:10:32] The big one is here: https://gerrit.wikimedia.org/r/355577 [18:10:51] (and the version on my machine is metastasizing further still) [18:11:54] But the idea is to split out settings that should be the same for all providers, like the queue and db connections [18:12:06] from things that should be provider-specific [18:12:49] One complication is that we want to be able to use things like the logger when we're not in a specific provider context [18:12:57] i.e. the pending queue consumer or db pruner [18:13:12] but we also want the logger settings to be overridable per provider [18:13:30] so we can debug ingenico but leave paypal at normal logging level, for instance [18:17:43] ah okay that makes sense, taking a look, also watching the metrics meeting in the background so my attention is a little split [18:20:56] (PS2) Ejegg: WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 [18:20:57] oh right, metrics! [18:21:07] well, there's the latest version ^^^ [18:21:12] still nowhere near passing tests [18:21:23] but the test config should eventually be a lot simpler [18:21:35] one generic global testing settings override with all the queues and dbs [18:21:53] then each set of provider tests can mock their own specific things [18:32:48] initialization order is messy [18:33:32] and I can't figure out the cleanest way to get the defaults from the global config into the providers [18:33:42] oh hey, wait, those should just be in another file [18:34:19] right, we shouldn't need to have a GlobalConfiguration object when we create a ProviderConfiguration [18:36:52] (CR) jerkins-bot: [V: -1] WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (owner: Ejegg) [19:02:11] Fundraising-Backlog: Fix visible code in donation form: ⧼donate_interface-amount-legend⧽ - https://phabricator.wikimedia.org/T166314#3292962 (MBeat33) Another donor encountered difficulty with this: they seem to be confused by the behavior of the Other field. I'm following up with them to determine whether t... [19:02:35] ejegg it looks like you're still working through this, want to hop on a call and talk any of it out? [19:02:43] sure! [19:03:13] one sec [19:04:33] ok mepps, I'm over in fr-tech-talk [19:08:09] Fundraising-Backlog: Fix visible code in donation form: ⧼donate_interface-amount-legend⧽ - https://phabricator.wikimedia.org/T166314#3292991 (MBeat33) p:Triage>Unbreak! [19:39:21] is there a way to save a draft in mediawiki? all i see is publish changes [19:46:59] fr-tech standup? [19:49:57] (PS3) Ejegg: WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 [20:06:55] Fundraising-Backlog, Wikimedia-Fundraising: Missing message "donate_interface-amount-legend" on donatewiki - https://phabricator.wikimedia.org/T166302#3293149 (Pcoombe) [20:06:58] Fundraising-Backlog: Fix visible code in donation form: ⧼donate_interface-amount-legend⧽ - https://phabricator.wikimedia.org/T166314#3293146 (Pcoombe) [20:10:05] (CR) jerkins-bot: [V: -1] WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (owner: Ejegg) [20:10:13] Fundraising-Backlog, Wikimedia-Fundraising: Missing interface messages on donatewiki - https://phabricator.wikimedia.org/T166302#3293153 (Pcoombe) p:Triage>Unbreak! [20:10:47] fr-tech: can someone look into the above donor-facing error pls? [20:11:10] Yep, we're on the case. Sorry for not commenting on the ticket. [20:11:24] cool, thanks! just wanted to make sure it had been seen [20:11:33] Yep, always good to check. [20:32:52] ejegg what was the channel name you joined--wikimedia-operations? I couldn't see [20:32:54] Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Missing interface messages on donatewiki - https://phabricator.wikimedia.org/T166302#3291517 (Ejegg) Sorry, totally our fault. We were changing field names in DonationInterface to match the names used in queue messages and Civi. At one po... [20:38:35] mepps yeah, it was #wikimedia-operations [20:39:36] thanks! [20:40:25] Oh hey, there are some channels that require a wikimedia cloak to join. More IRC arcana: https://meta.wikimedia.org/wiki/IRC/Cloaks#Obtaining_a_cloak [20:40:37] mepps but the ops team was really busy with some other problem [20:40:46] cool thanks yeah i have an application in for a cloak [20:40:52] so hopefully the SWAT team will just deploy the thing [20:40:59] ok, gonna afk for a bit. back before long! [20:42:55] Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Missing interface messages on donatewiki - https://phabricator.wikimedia.org/T166302#3293267 (Ejegg) Does donatewiki use any i18n keys that include currency_code? If so, those are renamed also, and are staying renamed. The new message key... [20:43:22] Fundraising-Backlog, Wikimedia-Fundraising, Patch-For-Review: Missing interface messages on donatewiki - https://phabricator.wikimedia.org/T166302#3293273 (Ejegg) Sorry for not coordinating this in advance [20:47:22] (PS4) Ejegg: WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 [20:48:19] (CR) jerkins-bot: [V: -1] WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (owner: Ejegg) [20:59:40] (PS5) Ejegg: WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 [21:00:34] (CR) jerkins-bot: [V: -1] WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (owner: Ejegg) [21:08:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: List of DonationInterface messages used in banners/donatewiki - https://phabricator.wikimedia.org/T166346#3293337 (Pcoombe) [21:10:58] Fundraising-Backlog, Wikimedia-Fundraising, MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)), Patch-For-Review: Missing interface messages on donatewiki - https://phabricator.wikimedia.org/T166302#3293356 (Pcoombe) Thanks for the prompt response @Ejegg ! We don't use any currency_cod... [22:29:52] ejegg|ish: So yea, looking at that patch and reading some backscroll: Seems like a pretty good direction to me, makese sense and seems plenty usable. I can't really think of a better way. [22:30:00] oops, [22:30:13] great! [22:30:20] got it closer to passing tests [22:30:26] will put up another WIP [22:30:38] It's gonna be a big one to review, but I don't think there's any helping that. [22:30:54] (PS6) Ejegg: WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 [22:31:18] actually getting to the payoff with a generic test config to mock all the queues and dbs [22:31:30] yeah, it's a pretty central class [22:31:47] (not necessarily a sign of good design :S ) [22:32:08] (CR) jerkins-bot: [V: -1] WIP actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (owner: Ejegg) [22:32:35] but hey, the queue stuff is only touching it in one place! [22:33:03] True that [22:34:05] ok, half hour till SWAT [22:34:11] going to get food first [22:56:00] fr-tech if you want to watch SWAT it's about to happen in -operations [22:56:14] Joining [23:23:24] (PS1) Ejegg: Allow old keys in session values [extensions/DonationInterface] (wmf/1.30.0-wmf.2) - https://gerrit.wikimedia.org/r/355728 (https://phabricator.wikimedia.org/T165818) [23:23:50] (CR) Ejegg: [C: 2] Allow old keys in session values [extensions/DonationInterface] (wmf/1.30.0-wmf.2) - https://gerrit.wikimedia.org/r/355728 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg) [23:27:18] (Merged) jenkins-bot: Allow old keys in session values [extensions/DonationInterface] (wmf/1.30.0-wmf.2) - https://gerrit.wikimedia.org/r/355728 (https://phabricator.wikimedia.org/T165818) (owner: Ejegg) [23:27:29] (PS1) Ejegg: Revert "Rename amount to gross" [extensions/DonationInterface] (wmf/1.30.0-wmf.2) - https://gerrit.wikimedia.org/r/355729 [23:27:39] (CR) Ejegg: [C: 2] Revert "Rename amount to gross" [extensions/DonationInterface] (wmf/1.30.0-wmf.2) - https://gerrit.wikimedia.org/r/355729 (owner: Ejegg) [23:28:32] (Merged) jenkins-bot: Revert "Rename amount to gross" [extensions/DonationInterface] (wmf/1.30.0-wmf.2) - https://gerrit.wikimedia.org/r/355729 (owner: Ejegg) [23:36:14] fr-tech are you learning from my mistakes? :) [23:36:40] ;-)