[01:07:40] PROBLEM - check_gcsip on payments1002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [01:07:42] PROBLEM - check_gcsip on payments1004 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [01:10:10] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.841 second response time [01:10:12] RECOVERY - check_gcsip on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.749 second response time [15:50:40] good morning all!! I'm back and (surprisingly) already caught up on emails [16:01:31] :) [16:18:27] dstrine: hey! [16:18:35] welcome back :) [16:22:17] dstrine: dunno if you saw, BS had to be delayed because an oojs update that we need hasn't gone out yet [16:28:26] AndyRussG: yeah I saw. whats the eta on the oojs stuff? [16:41:40] (PS1) Umherirrender: Add phpcs and make pass [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/356211 [16:45:41] dstrine: aaaarg hopefuly soon... [16:46:02] like this week or this quarter? [17:00:19] fr-tech: It is now 10 p.m. Do you know where Henry Kissinger is? [17:00:20] -- Elizabeth Carpenter [17:00:20] -- discuss. [17:07:22] (CR) Thiemo Mättig (WMDE): [C: 1] Add phpcs and make pass [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/356211 (owner: Umherirrender) [17:15:09] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3301120 (cwdent) @MNoorWMF glad to hear! Now you should have two files in ~/.ssh called id_rsa (the private key, do not distribute) and id_rsa.pub (the public key, distribute freely... [17:24:27] mepps / XenoRyet : I still haven't come up with a good way to sub in testing provider configurations without overcomplicating the normal use case. Any suggestions? [17:24:34] Or other things to talk through? [17:25:55] ejegg, no specific suggestions, but do you want to get on a video call and talk out what you've been thinking about it? [17:26:09] sure! [17:27:19] great, meet in fr-tech-talk? [17:27:52] yep, I'm there [17:28:01] XenoRyet1: join us? [17:28:21] Sure, I suppose I could jump on. [17:29:44] One sec, gotta find the headphones. [17:29:56] come on hangouts... [18:04:47] (PS9) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [18:04:49] (PS2) Ejegg: Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) [18:04:51] (PS1) Ejegg: Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 [18:05:02] mepps like that? ^^^ [18:05:21] well, I'll work that into the proof of concept DonationInterface patch using the stuff [18:08:09] (CR) Mepps: "Overall looks good! See one comment." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 (owner: Ejegg) [18:12:59] (CR) jerkins-bot: [V: -1] Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [18:22:36] (CR) Ejegg: "It's on this class, as a public property for testing convenience." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 (owner: Ejegg) [18:28:36] (PS10) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [18:28:38] (PS3) Ejegg: Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) [18:28:40] (PS2) Ejegg: Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 [18:32:08] AndyRussG: you free for a cps meeting? [18:33:53] dstrine: yes coming! [18:56:14] (CR) Mepps: [C: 2] "This looks good to me!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 (owner: Ejegg) [19:25:01] dstrine how come we only have standups scheduled through the end of June? [19:27:09] * dstrine rushes to extend a bunch of meetings [19:27:21] mepps: I don't know what you mean?!?!? [19:27:22] lol [19:27:50] dstrine huh for some reason they weren't showing up on my calendar but now they are... [19:28:02] um permanent meetings get really funky when you try to keep a room attached [19:28:16] I just extended a bunch of them [19:28:44] haha cool [19:28:45] no room has complained yet .... [19:33:47] AndyRussG: meeting? [19:35:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: List of DonationInterface messages used in banners/donatewiki - https://phabricator.wikimedia.org/T166346#3301866 (ggellerman) p:Triage>Normal [19:37:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: List of DonationInterface messages used in banners/donatewiki - https://phabricator.wikimedia.org/T166346#3301882 (Ejegg) [19:37:56] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, I18n: Some messages in the Donation extensions are outdated and should be removed - https://phabricator.wikimedia.org/T111677#3301881 (Ejegg) [19:38:25] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, I18n: Some messages in the Donation extensions are outdated and should be removed - https://phabricator.wikimedia.org/T111677#1613426 (Ejegg) Let's first write a unit test to ensure we don't delete any of the m... [19:39:20] Fundraising-Backlog, fundraising-tech-ops, Operations, Technical-Debt: Determine if benefactorevents.wikimedia.org should be hosted on the production cluster or still on Microsoft Azure - https://phabricator.wikimedia.org/T166240#3301898 (DStrine) @Dereckson thanks for mentioning this but fr-tech... [19:40:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Test coverage for generating payments-init and payments-antifraud queue messages - https://phabricator.wikimedia.org/T166182#3301908 (ggellerman) p:Triage>Normal [19:41:05] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Test coverage for generating payments-init and payments-antifraud queue messages - https://phabricator.wikimedia.org/T166182#3287714 (ggellerman) [19:51:49] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update DonationInterface code style for php5.5 - https://phabricator.wikimedia.org/T166613#3301952 (Ejegg) [20:24:00] ejegg do you know what was supposed to go here: https://www.mediawiki.org/wiki/Fundraising_tech#Communications [20:24:34] huh, nope! [20:25:20] Looks like it was added when the page was created [20:25:40] maybe just part of the tempate for 'Wikimedia engineering activity' [20:25:48] Feel free to delete it [20:26:02] ah gotcha, okay [20:26:33] oh hey, we need to add your name to that team list in the infobox! [20:28:00] back in a bit, getting some food [20:31:15] done! also updated the communications section [20:59:03] (PS2) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [21:02:15] Fundraising-Backlog: Whitelist new d*local IP address - https://phabricator.wikimedia.org/T166620#3302133 (Ejegg) [21:15:30] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [21:22:47] (PS3) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [21:25:32] (PS2) Ejegg: WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 [21:29:49] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [21:30:09] (CR) jerkins-bot: [V: -1] WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (owner: Ejegg) [22:00:45] (PS1) Ejegg: Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 [22:11:03] (CR) Krinkle: [C: -1] Purge banner content from front-end cache on banner save (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [22:36:15] (PS2) Ejegg: Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 [22:42:03] (PS3) Ejegg: WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) [22:43:47] (CR) jerkins-bot: [V: -1] WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [22:46:45] (PS1) Ejegg: Rename payments-init to payments-initial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356311 (https://phabricator.wikimedia.org/T95647) [22:52:05] (PS4) Ejegg: Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) [22:52:08] (PS6) Ejegg: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [22:52:09] (PS3) Ejegg: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) [22:52:13] (PS4) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [22:52:15] (PS4) Ejegg: WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) [22:54:05] (PS5) Ejegg: WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) [22:57:51] fr-tech still a bit rough around the edge, but all the tests pass when you use the SmashPig version noted in the comment ^^^^ [22:59:07] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [23:00:47] (CR) jerkins-bot: [V: -1] WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [23:01:01] fr-tech dstrine the fix we needed in oojs-core was just released, and is expected to ride the MW deploy train next week. So, it should hit Meta on Wednesday, June 6 [23:06:52] great news! [23:33:26] (PS3) Ejegg: Rename 'complete' queue to 'donations' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354559 (https://phabricator.wikimedia.org/T95647) [23:33:28] (PS5) Ejegg: Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) [23:33:30] (PS7) Ejegg: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [23:33:32] (PS4) Ejegg: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) [23:33:34] (PS5) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [23:33:36] (PS6) Ejegg: WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) [23:34:03] (Abandoned) Ejegg: Rename payments-init to payments-initial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356311 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [23:35:11] (PS1) Ejegg: Add config and test config for payments-init queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 [23:35:54] (CR) jerkins-bot: [V: -1] Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [23:36:01] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [23:36:06] (CR) jerkins-bot: [V: -1] WIP Use QueueWrapper [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355453 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [23:36:44] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [23:41:43] (CR) jerkins-bot: [V: -1] Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [23:48:25] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg)