[00:21:35] thanks for the update AndyRussG [00:35:25] dstrine: np :) thx to Krinkle for pushing it out :) [13:08:36] ยง Fundraising Sprint Beastie Boys: Mendes - https://phabricator.wikimedia.org/T166668#3303785 (SkimY-Musik) [13:58:54] Fundraising-Backlog, fundraising-tech-ops, Operations, Technical-Debt: Determine if benefactorevents.wikimedia.org should be hosted on the production cluster or still on Microsoft Azure - https://phabricator.wikimedia.org/T166240#3303995 (Jgreen) >>! In T166240#3301898, @DStrine wrote: > @Derecks... [14:49:50] (PS1) Umherirrender: Remove unused global [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/356400 [15:18:39] (PS1) Umherirrender: Remove unused global [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356408 [15:28:23] ejegg if you want to review my documentation draft, it's here: https://www.mediawiki.org/wiki/User:MEpps_(WMF)/donation_pipeline_setup [15:47:20] i also have some notes on deployment but wasn't sure if that was something we wanted to make available [15:47:36] or public is what i mean [15:55:46] there are these pages https://wikitech.wikimedia.org/wiki/Fundraising/tech/deployments, https://www.mediawiki.org/wiki/Fundraising_tech/Deployment but neither is particularly detailed [16:34:32] thanks mepps! I'll take a look [16:39:45] ejegg why was this patch abandoned: https://gerrit.wikimedia.org/r/#/c/356311/ [16:40:47] oh, i realized we weren't actually calling it -initial anywhere [16:41:38] ah okay [16:45:25] (CR) Mepps: "One naming question. Mostly looks good as it seems like less lines of code in DonationQueue :)." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:52:53] (CR) Ejegg: Update SmashPig, use SourceFields logic (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:54:53] (CR) Mepps: Update SmashPig, use SourceFields logic (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [17:00:11] (CR) Ejegg: "We could rename it, but the whole class disappears 4 patches later" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [17:00:19] fr-tech: If I could drop dead right now, I'd be the happiest man alive! [17:00:20] -- Samuel Goldwyn [17:00:20] -- discuss. [17:00:46] aaarg slander, really? [17:19:06] Question: are the fundraising/1.20 and fundraising/1.22 tags still needed in MW core? I dearly dearly hope the answer is no [17:31:11] fr-tech anything for scrum of scrums? [17:31:19] thank you for the update AndyRussG [17:31:30] None here [17:32:32] nope, thanks! [17:41:02] ejegg: thanks likewise :) [18:00:14] mepps: the pipeline install doc looks accurate! Thanks for that [18:01:27] I can add some more detail on Redis and the SmashPig job runners and IPN listeners once you move it out of draft [18:10:59] ejegg cool i can go ahead and do that [18:15:57] and moved [18:17:50] great! [18:22:44] ejegg i'm happy to +2 on this change but wasn't sure if you were still working on it or waiting for other commits to be merged first: https://gerrit.wikimedia.org/r/#/c/354559/ [18:23:22] mepps go right ahead! [18:23:35] (CR) Mepps: [C: 2] Rename 'complete' queue to 'donations' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354559 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [18:23:39] up through the 'Get rid of some more php-message-class' can be merged [18:23:51] past that depends on the SmashPig config stuff [18:24:52] (CR) Mepps: [C: 2] Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [18:25:42] cwd / Jeff_Green so we're inching closer to consolidating all the payment gateway configuration in SmashPig yaml files [18:25:56] but the code is still assuming we read stuff out of /etc [18:26:20] ok [18:26:21] (Merged) jenkins-bot: Rename 'complete' queue to 'donations' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354559 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [18:26:21] I changed it from /etc/fundraising/SmashPig.yaml to /etc/smashpig/**/*.yaml [18:26:39] because there will be a lot more settings in there eventually [18:26:57] that's so we can move it into localsettings? [18:28:38] (Merged) jenkins-bot: Update SmashPig, use SourceFields logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354566 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [18:28:52] suffers the same problem where it's slightly annoying to deploy /etc/ [18:38:13] (CR) Ejegg: "Oh hey, this doesn't actually need a LocalSettings change - the DonationsQueue code will just ignore the old 'complete' queue config which" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354559 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [18:41:14] (CR) Hashar: [C: 1] Remove unused global [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/356400 (owner: Umherirrender) [18:43:37] (CR) Hashar: [C: 1] Remove unused global [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356408 (owner: Umherirrender) [18:53:46] (PS1) Ejegg: Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T143831) [18:54:00] cwd ^^^ [19:02:28] looks right to me [19:02:34] quite a patch chain leading up to this though [19:02:52] yep [19:03:01] mostly innocuous, up till that one's direct parent [19:03:11] just don't want to make a mess with a floating c+2 [19:03:52] (PS2) Ejegg: Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T143831) [19:04:07] (README update) [19:35:11] (PS1) Ejegg: Fix currency_code parameter support [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356445 [19:35:28] fr-tech tiny update to review, but we should deploy it ASAP ^^^^ [19:35:43] Looking [19:36:10] (CR) XenoRyet: [C: 2] Fix currency_code parameter support [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356445 (owner: Ejegg) [19:36:33] thanks! [19:36:36] (CR) Mepps: [C: 2] "Pretty straightforward--looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356445 (owner: Ejegg) [19:37:03] haha just saw that XenoRyet +2'd before me :) [19:37:18] Double +2 never hurts [19:37:30] It's doublepluss good [19:37:35] heh [19:37:43] I'll just prep that deploy... [19:38:31] (Merged) jenkins-bot: Fix currency_code parameter support [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356445 (owner: Ejegg) [19:41:34] (PS1) Ejegg: Update SmashPig and dependencies [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/356447 [19:42:13] (CR) Ejegg: [V: 2 C: 2] Update SmashPig and dependencies [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/356447 (owner: Ejegg) [19:44:49] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/356448 [19:45:40] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/356448 (owner: Ejegg) [19:47:42] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/356448 (owner: Ejegg) [20:44:14] fr-tech anyone else seeing a message saying gerritt is down? [20:44:53] mepps: No down message, but it isn't loading for me either. [20:45:03] it just came back for me [20:45:15] Yea, same [20:45:47] It does that sometimes. [20:45:52] nope i'm getting new errors now [20:46:21] Oh yea. I haven't seen this one before. [20:46:27] In any case, it's not just you. [20:46:45] phew! i always worry the computers secretly hate me [20:49:59] Anyway, better actually go get some food before I forget entirely. [21:09:08] (PS1) Ejegg: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/356471 [21:10:08] (CR) Ejegg: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/356471 (owner: Ejegg) [21:19:10] (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/356471 (owner: Ejegg) [21:23:00] !log updated payments-wiki from 4786e7c223fe7bc61bc9d03b63d85a7eaee4c622 to d467d3ba2ee6be94d5654fa5fcff32b1e0e792c3 [21:23:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:37:35] !log reverted payments-wiki to 4786e7c223fe7bc61bc9d03b63d85a7eaee4c622 [21:37:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:00:50] (PS1) Ejegg: Restore accidentally deleted line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356487 [22:01:46] fr-tech found the issue with that deployment ^^^ [22:04:54] (CR) XenoRyet: [C: 2] Restore accidentally deleted line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356487 (owner: Ejegg) [22:07:43] ty XenoRyet [22:07:53] No worries [22:08:33] (Merged) jenkins-bot: Restore accidentally deleted line [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356487 (owner: Ejegg) [22:08:35] (PS1) Ejegg: Log User-Agent on dead session error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356491 [22:08:52] Heh, I was just about to write that one. [22:09:05] ah, word [22:09:27] Beat me to it, I'll just review real quick. [22:12:56] (CR) XenoRyet: [C: 2] Log User-Agent on dead session error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356491 (owner: Ejegg) [22:13:02] (Merged) jenkins-bot: Log User-Agent on dead session error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356491 (owner: Ejegg) [22:16:14] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/356494 [22:16:29] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/356494 (owner: Ejegg) [22:18:09] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/356494 (owner: Ejegg) [22:18:33] (PS1) Ejegg: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/356495 [22:18:49] (CR) Ejegg: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/356495 (owner: Ejegg) [22:32:57] guy in the hackerspace backyard is building a bicycle powered mobile tiki bar [22:33:33] (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/356495 (owner: Ejegg) [22:37:23] !log updated payments-wiki from 4786e7c223fe7bc61bc9d03b63d85a7eaee4c622 to 5edd788728e422fcbeba77cf1effb92c454f80df [22:37:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:52:39] (PS1) Ejegg: Fix retry link for disabled gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356497 (https://phabricator.wikimedia.org/T140314) [22:59:19] (PS1) Ejegg: When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 [23:03:21] !log disabled d*local payment methods [23:03:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:22:39] Fundraising-Backlog, FR-Adyen, FR-Ingenico, MediaWiki-extensions-DonationInterface, Patch-For-Review: Redirect loop when processor is disabled. - https://phabricator.wikimedia.org/T140314#3306324 (Ejegg) We seem to be allowing option 1 now [23:48:21] (PS1) Jforrester: ext.centralNotice.adminUi.bannerSequence: Switch from 'remove' to 'trash' icon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356509 (https://phabricator.wikimedia.org/T166749)