[00:43:10] (CR) Ejegg: [C: 2] Remove unused global [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/356400 (owner: Umherirrender) [00:44:48] (Merged) jenkins-bot: Remove unused global [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/356400 (owner: Umherirrender) [00:49:24] (CR) Ejegg: [C: 2] "Thank you! Nice to see modern syntax coming to the fundraising repos." [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/356211 (owner: Umherirrender) [00:53:03] (PS2) Ejegg: Remove unused global [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356408 (owner: Umherirrender) [00:53:20] (CR) Ejegg: [C: 2] "Thanks for the tidying up" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356408 (owner: Umherirrender) [00:54:56] (PS3) Ejegg: Add explict var visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/355767 (owner: Umherirrender) [00:55:07] (CR) Ejegg: [C: 2] Add explict var visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/355767 (owner: Umherirrender) [00:59:16] (PS5) Ejegg: Switch TestingAccessWrapper to librarized version [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/349092 (https://phabricator.wikimedia.org/T163434) (owner: Gergő Tisza) [01:01:40] (Merged) jenkins-bot: Add phpcs and make pass [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/356211 (owner: Umherirrender) [01:01:52] (CR) Ejegg: [C: 2] Switch TestingAccessWrapper to librarized version [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/349092 (https://phabricator.wikimedia.org/T163434) (owner: Gergő Tisza) [01:03:44] (Merged) jenkins-bot: Remove unused global [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356408 (owner: Umherirrender) [01:03:46] (Merged) jenkins-bot: Add explict var visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/355767 (owner: Umherirrender) [01:03:55] (Merged) jenkins-bot: Switch TestingAccessWrapper to librarized version [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/349092 (https://phabricator.wikimedia.org/T163434) (owner: Gergő Tisza) [13:24:22] (CR) Esanders: [C: 2] ext.centralNotice.adminUi.bannerSequence: Switch from 'remove' to 'trash' icon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356509 (https://phabricator.wikimedia.org/T166749) (owner: Jforrester) [13:30:12] (Merged) jenkins-bot: ext.centralNotice.adminUi.bannerSequence: Switch from 'remove' to 'trash' icon [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/356509 (https://phabricator.wikimedia.org/T166749) (owner: Jforrester) [13:42:58] (Abandoned) Mepps: Update queries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353062 (owner: Mepps) [14:42:33] (CR) Mepps: "This overall looks good. I'm curious why certain fields get deleted--are they now redundant?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [14:56:49] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update Mastercard logo - https://phabricator.wikimedia.org/T166795#3307789 (Pcoombe) [17:00:19] fr-tech: No character, however upright, is a match for [17:00:20] constantly reiterated attacks, however false. [17:00:20] -- Alexander Hamilton [17:00:20] -- discuss. [17:00:54] slander: ouch [18:02:59] ejegg this morning i reviewed some of your gerrits and got phpstorm's debugger up and running--anything that would be good for me to look at this afternoon? [18:03:49] thanks! Let me see... [18:04:06] Oh, I think that one with the regexes for ty letter generation would be good [18:05:24] jessicarobell has some other languages almost ready to update [18:07:31] oh, looks like you're deploying SmashPig too? [18:08:13] mepps which fields were you curious about deleting? [18:10:59] size here: https://gerrit.wikimedia.org/r/#/c/354605/7/gateway_common/DonationData.php and correlation id elsewhere and then currency_code was switched to currency (for some reason i thought we'd wanted to switch it the other way around but i think that's just wrong memory on my part) [18:11:43] (CR) Ejegg: "size was for t-shirt size, and we don't give those out any more" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [18:12:17] gotcha [18:12:25] heh, we did have to go back and forth on that currency one [18:12:49] do you have a link to the phabricator issue for the thank you letter regexes? i remember us discussing it but can't find it for some reason [18:12:55] but it's just 'currency' now [18:13:21] https://gerrit.wikimedia.org/r/353927 << TY letter REs [18:14:21] oh, here's a tiny one that will help people currently hitting the disabled Astropay form: https://gerrit.wikimedia.org/r/356498 [18:14:28] oh do you just need a +2 or should i continue work on this? [18:14:42] mepps for the regexes? [18:14:49] +2 on that would be great [18:15:12] those were enough to get the english translation updated without any manual massaging of the output [18:15:41] once we get the other translations we might find more quirks, but we can deal with those in another patch [18:16:09] oh hey, one other thing about the gerrit workflow [18:16:25] just to keep the commit history clean, it's nice to rebase patches before you +2 [18:16:44] the button in the gerrit UI usually does that without a hitch [18:16:57] (CR) Mepps: [C: 2] More horrifying regexps for ty letter template generation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353927 (owner: Ejegg) [18:17:53] (CR) Mepps: [C: 2] When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:18:18] ah gotcha [18:18:33] (CR) Mepps: When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:18:41] (PS2) Mepps: When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:18:59] (CR) Mepps: [C: 2] When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:19:12] (CR) Mepps: When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:19:27] (Abandoned) Ejegg: Fix retry link for disabled gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356497 (https://phabricator.wikimedia.org/T140314) (owner: Ejegg) [18:20:04] (CR) Mepps: [C: 2] When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:20:16] mepps: it just means the patch has a single entry in the commit history instead of the main entry plus a merge commit [18:20:40] okay that makes sense [18:20:41] (Merged) jenkins-bot: When requested GW is disabled, form chooser allows others [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356498 (owner: Ejegg) [18:22:03] (Merged) jenkins-bot: More horrifying regexps for ty letter template generation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353927 (owner: Ejegg) [18:24:23] the next stuff I'd love to get some feedback on is the chain of patches for the SmashPig configuration split [18:25:11] For the really big one, I'd be happy to screenshare and go through all the changes [18:26:01] so, those start with https://gerrit.wikimedia.org/r/355573 [18:27:10] just consolidating the static accessors so Context is the only place to register instances [18:38:52] (CR) Mepps: "Mostly looks good! See a couple small questions and I noticed that some of the changes seem possibly unrelated to the switch from Configur" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [18:39:08] cool ejegg, see comment [18:39:31] ty, will respond on gerrit [18:54:22] (CR) Ejegg: Route all config access through Context (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [18:54:28] mepps ^^^ [18:55:59] ejegg is this change also part of this larger move to context: https://gerrit.wikimedia.org/r/#/c/355573/1/PaymentProviders/Adyen/Tests/phpunit/PaymentCaptureActionTest.php [18:57:16] mepps oops, no, I just added those @group tags to make it easier to run a subset of tests [18:57:44] no functional change tho! [18:58:10] ejegg ah gotcha, what is the protocol? i only ask because in civi land unrelated changes were a big no on in case of git blame later [18:58:24] bit no-no was the phrase there [18:58:29] ahh [18:58:51] mepps i guess it's a good idea, but we haven't been especially strict. [18:58:57] lemme see, shouldn't be too hard [18:59:08] i don't mind +2ing with those changes in there personally [19:02:01] TPG-Engagements (Fundraising Ops: Mentoring Management of Workflows and Communication): Set deadline for sunsetting engagement - https://phabricator.wikimedia.org/T162384#3308855 (MBinder_WMF) Open>Resolved "Resolving" with the deprecation of #tpg-engagements (this particular engagement is still ongo... [19:02:08] TPG-Engagements (Fundraising Ops: Mentoring Management of Workflows and Communication): Help with creating a backlog and managing multiple workflows - https://phabricator.wikimedia.org/T162383#3308858 (MBinder_WMF) Open>Resolved "Resolving" with the deprecation of #tpg-engagements (this particular en... [19:02:30] (PS2) Ejegg: Route all config access through Context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) [19:03:56] (PS1) Ejegg: phpunit tags - @group Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356652 [19:04:13] k, split out ^^^ [19:05:57] (PS3) Ejegg: Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 [19:06:35] (PS2) Mepps: phpunit tags - @group Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356652 (owner: Ejegg) [19:06:53] (CR) Mepps: [C: 2] phpunit tags - @group Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356652 (owner: Ejegg) [19:07:58] (Merged) jenkins-bot: phpunit tags - @group Adyen [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356652 (owner: Ejegg) [19:08:08] (PS3) Mepps: Route all config access through Context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [19:08:15] (CR) Mepps: [C: 2] Route all config access through Context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [19:08:23] ejegg nice! [19:08:27] thanks! [19:09:03] so, we could deploy that one right now without needing ops help to change settings [19:09:07] (Merged) jenkins-bot: Route all config access through Context [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355573 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [19:09:33] i like to do a lot of little deploys to make it easier to pinpoint the source of problems [19:10:39] (PS4) Ejegg: Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 [19:12:30] oh cool, should we screen share? [19:13:14] for the deploy? [19:13:18] sure [19:13:50] i'm in the -talk hangout [19:24:29] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/356657 [19:25:09] (CR) Mepps: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/356657 (owner: Mepps) [19:26:25] (PS1) Umherirrender: Break long lines [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/356658 [19:26:32] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/356657 (owner: Mepps) [19:30:47] !log updated SmashPig from 4f84d88d3acaf8e54c5a18a7c76084ba78eb145b to d4458fa552d066f52a9324c09ff8871fcdb89864 [19:30:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:36:53] (PS5) Ejegg: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 [19:37:07] (PS11) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [20:11:39] ejegg just hopped in fr-tech-talk [20:11:43] mepps / XenoRyet want to do some live code review in 20 min? [20:11:54] oh cool [20:11:56] brt [20:20:53] XenoRyet: want to join us in -talk? [20:21:20] I was gonna try to catch up with peter, but if he doesn't respond in a minute or two I'll jump in. [20:50:02] XenoRyet: if you don't get a respnoce for Peter, he might still be down for a test early tomorrow morning. Emailing will definitely catch him. [20:50:23] Yea, I'm realizing he's probably after-hours right now. I'll email him in a bit. [21:11:56] (CR) Ejegg: Actually split out config classes (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [21:17:32] (PS12) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [21:18:21] (CR) jerkins-bot: [V: -1] Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [21:19:33] (PS1) Ejegg: Explicit include path for phpunit bootstrap [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356749 [21:21:12] (PS13) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [21:25:32] (PS4) Ejegg: Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) [21:25:34] (PS3) Ejegg: Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 [21:25:36] (PS3) Ejegg: Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 [21:25:38] (PS2) Ejegg: Add config and test config for payments-init queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 [21:27:14] (PS3) Ejegg: Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T143831) [21:28:48] (PS8) Ejegg: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) [21:29:03] (PS5) Ejegg: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) [21:29:57] (Abandoned) Ejegg: Tweak smashpig initialiazation order [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/350895 (https://phabricator.wikimedia.org/T128692) (owner: Ejegg) [22:25:36] dstrine: regarding the cps query for banner impressions ratios... Just thinking about what the best way to proceed is... The thing is it's really complicated and dicey [22:26:37] I've been trying to put an explanation of all the details and ways forward in the e-mail, as we said in the meeting [22:27:06] But I feel like it's too much detail and info that we need to hash through for e-mail to be the best medium [22:27:20] So I'm thinking of just putting a summary of the issues in the e-mail [22:28:26] And then going back to a task that I'd planned to do a while back, but that got lost along the way, which was putting on-wiki some notes about how to query impression ratios, based on the experience work on the outage in Ireland [22:29:01] How does that sound? If you think it makes sense, I could try to find the task for making those notes, or make one if it doesn't exist [22:29:46] I think that's the most time-efficient way forward to have CPS get good impression ratio data [22:42:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface forms should not need a reference to the gateway object - https://phabricator.wikimedia.org/T166842#3309459 (Ejegg) [22:43:58] (CR) Ejegg: "abandon?" [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/355210 (owner: Mepps) [22:50:43] (PS2) Ejegg: build: add parallel-lint [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/352780 (owner: Hashar) [22:56:39] (CR) Ejegg: [C: -2] "Stolen and merged here: I7bfed15daed194dbb6b5" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 (owner: Paladox) [23:00:11] (CR) Ejegg: [C: -2] "Thanks! Sorry to waste your time, though. That module was never enabled, and we got the functionality we needed in core CiviCRM. Module de" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273874 (owner: Paladox) [23:00:58] (Abandoned) Ejegg: Add SQL formatting library [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/257815 (owner: Ejegg) [23:08:51] XenoRyet: want to finish that code talk? [23:09:32] I've actually got some HR stuff I've gotta get done today. We can pick it up tomorrow though. [23:09:37] ok [23:13:39] (PS1) Ejegg: Get rid of redundant payment-provider/adyen path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 [23:14:34] (PS2) Ejegg: Get rid of redundant payment-provider/adyen path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 [23:19:22] (PS14) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [23:19:24] (PS5) Ejegg: Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) [23:19:26] (PS4) Ejegg: Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 [23:19:28] (PS4) Ejegg: Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 [23:19:30] (PS3) Ejegg: Add config and test config for payments-init queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 [23:22:01] (PS4) Ejegg: Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T143831)