[03:30:09] Fundraising-Backlog: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3331095 (Jseddon) [03:30:48] Fundraising-Backlog: Creation of a "Campaign" Wiki - https://phabricator.wikimedia.org/T167375#3331107 (Jseddon) [03:43:31] Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3331123 (Jseddon) [06:24:43] Fundraising Tech Backlog, FR-Astropay: Make sure d*local payment submethods are up to date - https://phabricator.wikimedia.org/T167378#3331248 (Ejegg) [06:42:26] Fundraising-Backlog, FR-Amazon: Reconcile 45 missing Amazon donations - https://phabricator.wikimedia.org/T167380#3331285 (Ejegg) [06:42:55] Fundraising-Backlog, FR-Astropay: Make sure d*local payment submethods are up to date - https://phabricator.wikimedia.org/T167378#3331297 (Ejegg) [16:12:11] (PS1) Ejegg: For multiple matching log lines, pick a consistent one [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357842 (https://phabricator.wikimedia.org/T167380) [16:13:07] Hi mepps ! [16:13:27] I'm still trying to clean up some leftovers from the Amazon mess I made on Friday [16:13:47] Some of the donors who saw an error message tried again with a different amount [16:14:08] and our audit processor doesn't currently handle that well [16:15:23] sorry, to back up: I deployed some logic to PaymentsWiki on Friday that caused a fatal error in the Amazon flow right before the donation data would be sent to the pending queue [16:18:10] the result was twofold: donors never saw the thank you page, and we didn't have info to stash the donations normally, only via the audit files [16:19:15] anyway, there's this little patch to let the audit processor pick the correct log line instead of just bailing out when an arbitrary one doesn't have the right amount: https://gerrit.wikimedia.org/r/357842 [16:50:44] OAOAOAOAOBOBOBOBOBOBOBOBOBOBOBOB/nick ejegg|afk [16:50:57] uhhh, huh? [17:00:19] fr-tech: I've enjoyed just about as much of this as I can stand. [17:00:19] -- discuss. [17:10:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3333075 (Pcoombe) [18:09:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: SSL Certificate expired - https://phabricator.wikimedia.org/T167455#3333515 (LeanneS) [18:24:03] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Israel (Jun 27 - Jul 25) - https://phabricator.wikimedia.org/T165526#3333550 (Pcoombe) [18:36:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: SSL Certificate expired - https://phabricator.wikimedia.org/T167455#3333515 (cwdent) Hi @LeanneS, I am traveling home from a team offsite right now but have a couple Civi certs to generate when I get there, just put yours on the list! [18:36:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: SSL Certificate expired - https://phabricator.wikimedia.org/T167455#3333571 (cwdent) a:Jgreen>cwdent [18:55:28] fr-tech does anyone have a moment to look at this patch? https://gerrit.wikimedia.org/r/357842 [18:56:24] hoping to deploy today to clean up the rest of the Amazon donations that aren't in Civi from last week's bug [18:57:09] ejegg|semi: is it something I could approve just by checking that the changes should work as announced, or would I need contextual knowledge? [18:57:36] might need some context [18:57:40] K :) [18:57:50] are you traveling by semi? [18:58:04] hehe, stowed away in a cargo container [18:58:08] ohnoes [18:58:19] (notreally) [18:58:23] ;p [18:58:29] but boy did they have a lot of those in Long Beach [18:58:29] plausible denial! [18:58:42] hmmm [18:58:46] on the beach? [18:58:54] Ah no you said in the beach [18:59:11] at the port in the beach? [19:00:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: SSL Certificate expired - https://phabricator.wikimedia.org/T167455#3333682 (LeanneS) Hi @cwdent thank you! Will you return before EOD Pacific time? [19:46:58] (CR) XenoRyet: [C: 2] For multiple matching log lines, pick a consistent one [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357842 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [19:47:32] (PS1) Ejegg: Primary name for special page is now LandingPage [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/357883 (https://phabricator.wikimedia.org/T167374) [19:47:53] (CR) jerkins-bot: [V: -1] For multiple matching log lines, pick a consistent one [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357842 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [22:09:25] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357842 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [22:14:21] (PS2) Ejegg: Put static after visibility in functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/357455 (owner: Umherirrender) [22:14:31] (CR) Ejegg: [C: 2] Put static after visibility in functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/357455 (owner: Umherirrender) [22:16:43] (Merged) jenkins-bot: Put static after visibility in functions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/357455 (owner: Umherirrender) [22:22:54] (PS2) Ejegg: Always use braces after if [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/357677 (owner: Umherirrender) [22:23:07] (CR) Ejegg: [C: 2] Always use braces after if [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/357677 (owner: Umherirrender) [22:26:35] (Merged) jenkins-bot: Always use braces after if [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/357677 (owner: Umherirrender) [22:28:56] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357842 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [22:29:21] (CR) Ejegg: [V: 2] For multiple matching log lines, pick a consistent one [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357842 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [22:31:07] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/357944 [22:31:45] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/357944 (owner: Ejegg) [22:33:03] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/357944 (owner: Ejegg) [22:36:19] !log updated civicrm from c70ae650bdf2e670d1dcb77f471b3ac9c5fb05f9 to 5a83ee18da383b8a2e4381c82307c7a50d4b973b [22:36:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:43:20] (PS1) Ejegg: Fix dumbness of last commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357948 [22:43:36] fr-tech anyone still around? [22:47:22] just got home [22:47:29] in the middle of generating some civi certs [22:47:34] u need CR? [22:48:52] cwd that would be awesome! [22:49:04] just the 'fix dumbness' one above [22:49:33] I was trying to make the audit parsers better at matching log lines [22:50:16] but I used an undefined variable instead of the transaction array I should have used [22:50:47] the parent (merged) patch is this, for context: https://gerrit.wikimedia.org/r/357842 [22:53:14] also, i realized that with the consistency check inside the get_log_data fn, it made no sense to throw that exception where it was [22:55:04] ejegg: cool, i will take a look in a sec, just gotta send this cert out [22:55:41] thanks! [22:58:28] hmm, what's up with this banner impressions loader? [23:00:05] dang, that's a lot of errors [23:00:22] UnboundLocalError: local variable 'k' referenced before assignment [23:02:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: SSL Certificate expired - https://phabricator.wikimedia.org/T167455#3334328 (cwdent) Open>Resolved Just got home and sent it over. [23:11:19] ejegg: commit lgtm, but no CI? [23:12:03] cwd ugh, more CI woes, huh? [23:12:17] lessee, looks like we need to clear out a dir or something? [23:12:32] is it all jammed up? [23:12:54] weird, zuul looks fine [23:12:55] hardly anything displaying in zuul [23:15:17] well, tests pass [23:15:36] if you want to C+2 it, i'm happy to mark it V+2 [23:15:36] (CR) Cdentinger: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357948 (owner: Ejegg) [23:15:50] i just pinged tyler [23:15:53] i think he did something [23:22:38] (CR) Cdentinger: [C: 2] Fix dumbness of last commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357948 (owner: Ejegg) [23:26:38] (Merged) jenkins-bot: Fix dumbness of last commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/357948 (owner: Ejegg) [23:33:08] thanks cwd! [23:33:23] np [23:33:24] will deploy that after a quick errand