[00:05:45] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/357959 [00:05:55] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/357959 (owner: Ejegg) [00:07:04] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/357959 (owner: Ejegg) [00:08:49] !log updated CiviCRM from 5a83ee18da383b8a2e4381c82307c7a50d4b973b to dfc26f058327bb6248af44ad39a9864b6c3a6581 [00:08:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:36:56] !log disabled banner impressions loader [00:37:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:38:00] Fundraising-Backlog: banner impressions loader crashing, maybe on missing project - https://phabricator.wikimedia.org/T167482#3334451 (Ejegg) [01:44:40] (CR) Jforrester: [C: 2] Add phpcs and make pass [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/357019 (owner: Umherirrender) [01:49:45] (Merged) jenkins-bot: Add phpcs and make pass [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/357019 (owner: Umherirrender) [06:52:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3333075 (Nikerabbit) Any info on Logstash? Do you know which Translate funct... [09:06:18] Fundraising-Backlog: "ecom" script error in frdev1001 - https://phabricator.wikimedia.org/T167497#3334877 (MNoorWMF) [13:38:47] Fundraising-Analysis, DBA: Consider installing pt-deadlock-logger - https://phabricator.wikimedia.org/T128011#3335261 (Marostegui) Open>declined a:Eileenmcnaughton>None I will close this for now as per your comment. We will reopen if this is needed in the future. Thanks for the suggestion... [14:56:49] (PS1) Umherirrender: Break long lines - includes / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358030 [14:56:51] (PS1) Umherirrender: Break long lines [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358031 [16:00:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3335618 (Pcoombe) I wasn't able to see anything that looked related in Logst... [16:04:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Investigate duplicate invoice ID failmail - https://phabricator.wikimedia.org/T167519#3335623 (Ejegg) [16:10:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Instead of failmail, record and flag duplicate donations. - https://phabricator.wikimedia.org/T167520#3335638 (Ejegg) [16:22:52] ejegg are you tackling the issue you just logged or do you want me to work on it? i'm already poking around [16:36:23] (PS1) Umherirrender: Make phpcs pass - includes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358043 [16:36:25] (PS1) Umherirrender: Make phpcs pass - special / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358044 [16:36:27] (PS1) Umherirrender: Add phpcs and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 [16:41:50] mepps hi! [16:42:06] hi ejegg! [16:42:10] if you'd like to take a look at it, please be my guest [16:42:27] sorry i wasn't around yesterday, recovering from red-eye/reconnecting with baby :) [16:42:47] I added MBeat as a watcher on that issue thinking that we should ask him if that sounds like the right approach [16:43:36] ejegg: hey! Which is the impressions loader that's failed? The funny python database thingy? (Don't see the the mentioned failmail, maybe my e-mail filters are too filtery) [16:44:02] AndyRussG: yeah, it was DjangoBannerStats [16:44:13] Now that I look again, it may have just been timing out [16:44:21] in the logs, though, there are a ton of exceptions [16:44:35] due to it not handling missing parameters nicely [16:44:45] well, I guess try/catch is some kind of handling [16:45:00] Hum [16:45:08] Doesn't sound right [16:49:25] (PS1) Umherirrender: Use short array syntax in alias file [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358048 [16:49:27] (PS1) Umherirrender: Use short array syntax - special [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358049 [16:49:29] (PS1) Umherirrender: Use short array syntax - includes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358050 [16:49:31] (PS1) Umherirrender: Use short array syntax - api / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358051 [16:49:33] (PS1) Umherirrender: Use short array syntax [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358052 [16:51:17] (PS2) Umherirrender: Use short array syntax in alias file [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358048 [16:51:32] (PS2) Umherirrender: Use short array syntax - special [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358049 [16:51:37] (PS3) Umherirrender: Use short array syntax - special [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358049 [16:51:57] (PS2) Umherirrender: Use short array syntax - includes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358050 [16:52:01] (PS3) Umherirrender: Use short array syntax - includes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358050 [16:52:16] (PS2) Umherirrender: Use short array syntax - api / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358051 [16:52:20] (PS3) Umherirrender: Use short array syntax - api / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358051 [16:52:36] (PS2) Umherirrender: Use short array syntax [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358052 [16:52:41] (PS3) Umherirrender: Use short array syntax [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358052 [17:00:19] fr-tech: (1) Alexander the Great was a great general. [17:00:19] (2) Great generals are forewarned. [17:00:19] (3) Forewarned is forearmed. [17:00:19] (4) Four is an even number. [17:00:19] (5) Four is certainly an odd number of arms for a man to have. [17:00:19] (6) The only number that is both even and odd is infinity. [17:00:19] Therefore, all horses are black. [17:00:20] -- discuss. [17:02:37] slander funny today [17:35:50] mepps: What's the best way to distinguish errors in Civi? [17:36:28] I notice that the ones for those duplicate invoice IDs all have an error_message that starts with '8002: ' [17:36:49] but is there another property with just the code, so we can avoid string parsing? [17:47:40] I'd like to avoid doing a search by invoice ID before every insert, but have specific handling for duplication errors as opposed to deadlocks or other db insert problems [17:53:35] ejegg: yikes that impressions loader log is really hairy... So you already dove into the code to conclude it's "not handling missing parameters" ^ ? [17:54:22] I didn't think that crashed it [17:55:54] Right, the project.id null ref happens on lines with no project parameter at all [17:56:33] And yeah, that bit is two 'try's deep, so it doesn't stop the whole thing [17:57:30] huh [17:57:53] ejegg[m]: got a quick file/line no ref? [18:07:26] Shoot, no... It was in the log [18:10:23] ejegg[m]: ah K yes, I have the log... sorry, thought u were talking about something further up in the (unavailable) call stack [18:11:30] ejegg hmm i'll take a look [18:15:47] ejegg yes it looks like the code is a separate property [18:17:53] hmm but what's strange is that the error that gets hit in queue2civicrm has an error code of 0 but then the drupal error has the 8002 code... [18:27:30] ooh, weird indeed! [18:35:22] Fundraising-Backlog: dLocal Colombia donation form: add missing PSE bank - https://phabricator.wikimedia.org/T167206#3336116 (MBeat33) Open>Resolved a:MBeat33 Per Javier: // Davivienda is not available for bank transfers in Colombia. // He attached documentation, dLocal Countries & Payments Over... [18:36:56] ejegg it's because the error object is coming from the api but the 8002 message you're seeing is in the trace [18:37:11] the problem is it makes it hard for us to catch [18:41:02] at least that's my current reading but trying to see if there is somewhere we can screen for the 8002 [18:46:31] weird, only in the trace? [18:54:21] yeah that's what it looks like because it's the underlying civi error but the error we're accessing the api error--i'm looking at docs to see if there's a way to access the civi error in the api error [18:58:43] hold on i read that wrong about it being in the trace and it looks like there is a property previous that holds the original exception in api errors [19:01:48] ejegg how do i run tests for wmf_civicrm? [19:06:57] mepps should just be able to run vendor/bin/phpunit [19:07:12] if you've done composer install [19:07:20] with the dev packages [19:22:45] ejegg i'm getting two failures, do you get that too? [19:33:47] mepps: ack, sorry so distracted, trying to fill out admin things. Let me run 'em and see [19:37:03] mepps: shoot, I get one failure and one segfault that just kills the whole test run! [19:37:19] Oh, I think I had been running these on an alternate db on the old machine [19:37:44] is one of the failures a refund mismatch? I remember seeing that when running locally [19:42:15] yes [19:55:00] ejegg joining standup? [20:03:45] Fundraising-Backlog: dLocal Colombia donation form: add missing PSE bank - https://phabricator.wikimedia.org/T167206#3336354 (Ejegg) Thanks @MBeat33 ! I'd be curious to see that PDF and check if it matches up with the codes at developers.astropay.com. I made another ticket ( T167378 ) to make sure all the d-... [20:12:53] Fundraising-Backlog: Access to ecom/statler data for Middle Seat, contractor - https://phabricator.wikimedia.org/T167548#3336384 (CCogdill_WMF) [20:13:37] Fundraising-Backlog: Access to ecom/statler data for Middle Seat, contractor - https://phabricator.wikimedia.org/T167548#3336397 (CCogdill_WMF) p:Triage>High [22:58:23] fr-tech any preferences re: BS deploy? Options: Monday 5 pm PDT vs. Tuesday 11 am PDT [22:58:36] (both are before the MW train) [22:58:42] https://wikitech.wikimedia.org/wiki/Deployments [23:12:10] (CR) Reedy: [C: 2] Break long lines - includes / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358030 (owner: Umherirrender) [23:19:43] AndyRussG: earlier in the day seems nice in general, but I'd be more available for the monday afternoon slot [23:26:09] (Merged) jenkins-bot: Break long lines - includes / tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358030 (owner: Umherirrender) [23:26:19] ejegg: K let's do Monday! It's a fine time fore me, and then colleagues in Europe will have access as of their morning :) [23:29:38] regarding the impression loader thing, I did find that yesterday someone was hammering on beacon/impression with empty params [23:31:41] but there were at least a few on other days, so not sure what the difference is [23:32:14] I guess I'll have to try the different files locally and see what gives [23:32:26] ejegg: ^ [23:48:17] ejegg: shall I include you on the deploy slot reservation? (also apologies for the repeated pings!)