[00:48:27] Reedy: pls go ahead :) master is spam-tolerant 8p [07:54:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3339269 (Nikerabbit) There isn't sufficient information here for me to start... [14:50:12] (CR) Mepps: Recover Amazon order IDs when txn captured at console (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [15:02:51] (CR) Mepps: "Overall looks good. Maybe we should walk through it later today though." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/358154 (https://phabricator.wikimedia.org/T167378) (owner: Ejegg) [15:04:03] (CR) Mepps: [C: 2] Add missing MXN to national currencies list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/358153 (owner: Ejegg) [15:05:13] (CR) Mepps: [C: 2] Primary name for special page is now LandingPage [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/357883 (https://phabricator.wikimedia.org/T167374) (owner: Ejegg) [15:06:40] (Merged) jenkins-bot: Add missing MXN to national currencies list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/358153 (owner: Ejegg) [15:07:41] (CR) Mepps: [C: 2] Batch cancel Amazon payments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356979 (owner: Ejegg) [15:09:06] (Merged) jenkins-bot: Primary name for special page is now LandingPage [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/357883 (https://phabricator.wikimedia.org/T167374) (owner: Ejegg) [15:10:53] Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, Patch-For-Review: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3340929 (CCogdill_WMF) We would need to update URLs in email, yes, but that's just a one-time inconvenience. Give... [15:21:54] (CR) Mepps: [C: 2] Maintenance script to batch capture Amazon payments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356974 (owner: Ejegg) [15:24:27] (Merged) jenkins-bot: Maintenance script to batch capture Amazon payments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356974 (owner: Ejegg) [15:24:29] (Merged) jenkins-bot: Batch cancel Amazon payments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356979 (owner: Ejegg) [15:46:29] (CR) Mepps: "Overall looks fine. I'm curious whether you considered Eileen's suggestion of guzzle, and I tried to rebase but I got a conflict message." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [15:48:08] (CR) Mepps: "Looks good but also couldn't be rebased." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T147503) (owner: Ejegg) [15:51:43] (CR) Mepps: "Also couldn't be rebased, how do we normally handle that?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 (owner: Ejegg) [15:51:48] ejegg: hey! it seems that the malformed beacon/impression calls have returned to a normal level. Maybe we should try running the django script manually to ingest the backlog and turn it on again? Do you know if the error prevents the rest of the file from ingesting, or just that line? [15:51:57] (I'm just getting it set up to run locally....) [16:03:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#3341172 (Nuria) [16:04:03] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Operations, and 2 others: Redo /beacon/impression system (formerly Special:RecordImpression) to remove extra round trips on all FR impressions (title was: S:RI should pyr... - https://phabricator.wikimedia.org/T45250#3341173 [16:04:07] Fundraising-Analysis, Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: Provide performant query access to banner show/hide numbers - https://phabricator.wikimedia.org/T90649#3341171 (Nuria) Open>Resolved [16:05:03] Fundraising-Analysis, Fundraising-Backlog, Analytics, MediaWiki-extensions-CentralNotice: Provide performant query access to banner show/hide numbers - https://phabricator.wikimedia.org/T90649#1064105 (Nuria) If newer banner dataset on druid needs more fields please file a task a to that extent [16:09:56] AndyRussG: Yeah, we should definitely turn it back on [16:10:07] The error should just affect one line [16:13:59] ejegg: It'll just pick up where it left off, right? I think can we see how far it got (to check that there aren't a lot of malformeds in the remaining files)? [16:14:20] I was thinking that since it might time out again, we might wish to run manually? [16:16:55] AndyRussG: i think we have to tweak the job to make it go back more than a day [16:18:06] i'm in meetings till the turn of the hour, but I can walk you through the new job runner stuff [16:19:41] ejegg: ohh yea that'd be excellent... most anytime this morning is good for me, except 11:30 - 12:00 PST [16:44:36] (PS2) Ejegg: Recover Amazon order IDs when txn captured at console [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) [16:45:39] (CR) Ejegg: "Thanks for looking at this, MEpps! Rebased and clarified the id search in the comment." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [16:47:57] (CR) Mepps: [C: 2] "Got another merge conflict but looks pretty straightforward." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 (owner: Ejegg) [16:48:26] (CR) Ejegg: "Thanks MEpps! Inability to rebase should be expected for this one - it depends on three as-yet-unmerged ancestor patches: I86dcee817afed41" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T147503) (owner: Ejegg) [16:54:35] (CR) Ejegg: "Merge conflict is just the same set of dependencies: I86dcee817afed41a9, I6009e97e9875f, and Ib5c810b0fd08e8c0" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 (owner: Ejegg) [17:00:19] fr-tech: A myth is a religion in which no-one any longer believes. [17:00:19] -- James Feibleman, "Understanding Philosophy" [17:00:19] -- discuss. [17:05:19] Fundraising Sprint Kickstopper, Fundraising-Backlog, Unplanned-Sprint-Work: Banner impression loader failing on malformed calls to beacon/impressions - https://phabricator.wikimedia.org/T167557#3341488 (DStrine) [17:34:46] ejegg: do you remember how to get rid of the "ImportError: No module named django_settings" error when setting up the DB for the Django script (I'm trying to run "python manage.py migrate")? Pretty sure I've had that message eons ago when I previously dug into this script [18:20:35] AndyRussG: sorry, looking into that [18:20:56] I think there was something with the wsgi file [18:23:26] ejegg should i be +2ing reviews with conflicts? wasn't sure about protocol [18:24:07] mepps: usually I try to review from the bottom of the stack [18:24:17] if there's a big chain of dependent patches [18:24:48] hmm okay i've just been going based on the earliest emails i got [18:25:38] oh, I think I added you as a reviewer after i submitted the patches initially [18:25:50] so the email order wouldn't correspond to dependencies [18:25:53] is there a good way to see them in order? [18:25:58] in gerrit, at the top right [18:26:14] a patch that depends on other unmerged ones will usually show the other patches [18:26:33] with the base patches at the bottom [18:26:52] and the ones that depend on them stacked on top [18:27:21] okay so start from the bottom? [18:27:30] yep! [18:28:13] (PS6) Mepps: Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 (owner: Ejegg) [18:28:23] (CR) Mepps: [C: 2] Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 (owner: Ejegg) [18:29:57] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3341944 (Aklapper) >>! In T164040#3301120, @cwdent wrote: > [...] > Cut and paste the big block of text that comes out into your public user page. This is just an extra check we do... [18:32:10] (Merged) jenkins-bot: Smashpig has a config directory, not just one big file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355506 (owner: Ejegg) [18:35:17] AndyRussG: Aha, try 'PYTHONPATH=~/.fundraising python manage.py blah' [18:35:38] (or set the PYTHONPATH to some other folder with a django_settings.py file in it) [18:44:07] (PS7) Mepps: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 (owner: Ejegg) [18:44:19] (CR) Mepps: [C: 2] "Looks good!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 (owner: Ejegg) [18:50:20] (Merged) jenkins-bot: Split provider configuration out of main [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 (owner: Ejegg) [18:51:04] AndyRussG: seeing some other things that have to change for modern django [18:57:42] (PS1) Ejegg: Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 [18:58:25] (PS1) Ejegg: Correct default log path, make TEMPLATE_DIRS an array [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 [18:58:33] AndyRussG: ^^^ should get it running, I think [18:58:58] hmpf, or maybe not [18:59:56] Fundraising-Backlog, fundraising-tech-ops: Civi & Server access for Moska Noor - https://phabricator.wikimedia.org/T164040#3342247 (cwdent) Open>Resolved @Aklapper thanks for the nudge! This is done. [19:00:10] ejegg: ah great, lemme try stuff (just finished a meeting)... thx!! [19:00:36] missing url.patterns... but we're not actually running this thing's web ui anyplace [19:02:04] lemme rip that stuff out [19:15:30] (PS1) Ejegg: Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 [19:15:52] AndyRussG: ok, that gets it at least running the migration on new django ^^^ [19:24:42] ejegg: K trying it out... [19:43:50] ejegg: so you have a file named django_settings.py somewhere? [19:44:10] AndyRussG: yep, I have mine in ~/.fundraising [19:44:27] and it just overrides the databases setting from fundraising/settings.py [19:44:34] K [19:44:35] oh, and the UDP_LOG_PATH [19:44:46] rrrrrright it's all coming back to me now rrrrg [19:44:53] errr, and the logging [19:46:10] rrrrg it's still not finding it [19:46:30] AndyRussG: did you run it with PYTHONPATH=~/.fundraising? [19:47:31] yea [19:47:41] standup, btw... [19:48:01] yep [20:25:12] Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3342731 (Pcoombe) Can we keep 'FundraiserLanding... [21:26:29] Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3331095 (Ejegg) Yep, it'll definitely stay aroun... [21:47:37] (PS1) Ejegg: Update LandingPage regex for new name [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358487 [22:25:49] Fundraising-Backlog: Access to ecom/statler data for Middle Seat, contractor - https://phabricator.wikimedia.org/T167548#3343145 (CCogdill_WMF) Open>declined Not customary to let contractors who aren't using a WMF computer have access to frdev, so we're going to send them the data ourselves. [23:29:27] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/358493 [23:30:00] ejegg|afk: fr-tech anyone interested in CN deploy, getting set here ^ [23:32:00] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/358493 (owner: AndyRussG) [23:34:32] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/358493 (owner: AndyRussG) [23:44:29] fr-tech core change: https://gerrit.wikimedia.org/r/358495 [23:56:28] thanks AndyRussG . Anything I can do to help?