[00:01:24] ejegg: just sent u the hangout link with Tyler too :) [02:29:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: improve view of campaign mixin admin UI controls for users without CN rights - https://phabricator.wikimedia.org/T167755#3343395 (AndyRussG) [03:09:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: improve campaign mixin admin UI controls for users without CN rights - https://phabricator.wikimedia.org/T167755#3343437 (AndyRussG) [11:57:51] (CR) Mepps: Split provider configuration out of main (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355552 (owner: Ejegg) [12:00:49] (PS1) Mepps: Quick Syntax Fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358576 (https://phabricator.wikimedia.org/T143831) [12:01:37] ejegg ^^ quick fix for tiny error i found in a commit i merged yesterday [12:02:19] (PS2) Mepps: Quick path name fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358576 (https://phabricator.wikimedia.org/T143831) [12:02:34] ^^ same commit just renamed for clarity [12:20:23] (CR) Mepps: "Working on reviewing these but curious--can global provider options be access from the provider config object?" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [14:21:33] anyone else have the experience where namely leaves reviews in "writing in progress" for an arbitrary number of hours after the writing has finished? [14:49:08] Fundraising-Backlog: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806#3344909 (Pcoombe) [16:24:12] (CR) Mepps: Actually split out config classes (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [16:28:16] hi mepps ! [16:28:25] hi ejegg! [16:28:33] sorry, I forgot to |away last night, just getting back on now [16:28:44] thanks for looking at that [16:28:51] no problem, just pinged you so you'd see it when you got up :) [16:28:57] did you see my gerrit review? [16:29:07] it's super small but just something i noticed this morning [16:29:16] (CR) Ejegg: [C: 2] Quick path name fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358576 (https://phabricator.wikimedia.org/T143831) (owner: Mepps) [16:29:30] good catch! [16:30:51] (Merged) jenkins-bot: Quick path name fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358576 (https://phabricator.wikimedia.org/T143831) (owner: Mepps) [16:40:24] (CR) Ejegg: "I thought it might be good to keep the provider config object independent of the global config object. I hope to keep routing all global c" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [16:40:48] thanks for the review, mepps! some responses ^^^ [16:43:38] cool ejegg, it mostly looked good, although i didn't go through every single test file [16:44:16] whew! [16:44:33] After that commit, everything else is a lot smaller [16:52:31] should i wait for you to resolve that last comment on reportdownloads before +2ing? [16:59:49] mepps oh sure, looks like it needs a manual rebase anyway! [17:00:19] fr-tech: Today is a good day for information-gathering. [17:00:19] Read someone else's mail file. [17:00:19] -- discuss. [17:03:07] (PS16) Ejegg: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) [17:03:21] ok, merge-able and without the ReportDownloader noise ^^^ [17:07:27] (PS1) Ejegg: Declare reportsClient property explicitly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358637 [17:15:25] (CR) Mepps: [C: 2] Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [17:15:54] (CR) Mepps: [C: 2] Declare reportsClient property explicitly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358637 (owner: Ejegg) [17:16:44] (Merged) jenkins-bot: Actually split out config classes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355577 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [17:17:06] (Merged) jenkins-bot: Declare reportsClient property explicitly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358637 (owner: Ejegg) [17:17:20] woohoo! [17:24:43] ejegg: hey... How should we proceed with backfilling and turning DjangoBannerStats back on? If you're busy I could also ask cwd for help w/ the new job running stuff... malformed calls remain at their normal low level btw [17:26:02] AndyRussG: not busy right now, want to vidchat? [17:27:04] ejegg: K :) [17:27:54] I'm in fr-tech-talk hangout [17:35:48] (PS7) Mepps: Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [17:36:04] (CR) Mepps: [C: 2] Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [17:37:15] (Merged) jenkins-bot: Always (re-)initialize logger when setting provider configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/355739 (https://phabricator.wikimedia.org/T143831) (owner: Ejegg) [17:39:25] (PS6) Mepps: Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 (owner: Ejegg) [17:39:28] (CR) Mepps: [V: 2 C: 2] Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 (owner: Ejegg) [17:40:45] (Merged) jenkins-bot: Add TestingContext for overriding ProviderConfigurations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356223 (owner: Ejegg) [17:53:32] (PS6) Mepps: Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 (owner: Ejegg) [17:53:38] (CR) Mepps: [C: 2] Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 (owner: Ejegg) [17:54:16] (CR) jerkins-bot: [V: -1] Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 (owner: Ejegg) [17:54:47] (Merged) jenkins-bot: Convenience functions to initialize test datastores [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356304 (owner: Ejegg) [17:55:20] (PS5) Mepps: Add config and test config for payments-init queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 (owner: Ejegg) [17:55:25] (CR) Mepps: [C: 2] Add config and test config for payments-init queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 (owner: Ejegg) [17:56:32] (Merged) jenkins-bot: Add config and test config for payments-init queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356318 (owner: Ejegg) [18:07:54] ejegg i think i made it through all the reviews? let me know if i missed any [18:08:35] thank you so much! [18:09:13] I'll have some more stuff in DonationInterface soon, using the SmashPig changes you just merged [18:10:36] Let me know if you want any consultation on the ticket you're working on [18:18:55] (PS1) Anomie: API: Split description messages into summary + additional text [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358666 [18:19:20] (PS1) Anomie: API: Split description messages into summary + additional text [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/358677 [18:19:26] (PS1) Anomie: API: Split description messages into summary + additional text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/358680 [18:37:43] (CR) Reedy: [C: 2] API: Split description messages into summary + additional text [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358666 (owner: Anomie) [18:49:38] (Merged) jenkins-bot: API: Split description messages into summary + additional text [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358666 (owner: Anomie) [18:56:52] (CR) jerkins-bot: [V: -1] API: Split description messages into summary + additional text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/358680 (owner: Anomie) [19:25:33] ejegg the smashpig tests aren't running for me--i thought i had them working last week but now i'm getting pdo exception for all tests. i assume this is a local problem of mine but not sure how to fix [19:26:16] hmm, i'll take a look in 15 min [19:26:40] and will show up to grooming just a little bit late) [19:33:43] cwd: ejegg|afk the backfill job for django banner stats didn't finish--seems to be hanging [19:34:26] uh oh [19:34:59] i missed most of this [19:35:10] Hmmm doesn't seem to be using cpu [19:35:28] cwd: yeah added a backfill job with ejegg|afk's help... [19:35:54] dstrine--is backlog grooming happening now or are we meeting at 12:45? [19:36:14] AndyRussG: i see it, will poke [19:36:18] oops [19:36:52] mepps: i forgot [19:36:55] lets meet now [19:37:15] i'm the only one there right now [19:37:37] mepps: maybe you're in a different call? [19:38:00] ah apparnetly i was [19:39:43] Fundraising-Backlog: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806#3345871 (DStrine) p:Triage>Normal [19:40:07] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 12 failures. Last run 5 minutes ago with 12 failures. Failed resources (up to 3 shown) [19:41:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: improve campaign mixin admin UI controls for users without CN rights - https://phabricator.wikimedia.org/T167755#3345879 (DStrine) p:Triage>Normal [19:42:52] dunno what's up with that puppet fail, just ran it on there fine [19:42:55] guessing network flap [19:44:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Instead of failmail, record and flag duplicate donations. - https://phabricator.wikimedia.org/T167520#3345907 (DStrine) p:Triage>Normal [19:44:47] Fundraising Sprint Kickstopper, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Instead of failmail, record and flag duplicate donations. - https://phabricator.wikimedia.org/T167520#3335638 (DStrine) [19:45:07] RECOVERY - check_puppetrun on pay-lvs2002 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:46:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: SPIKE: Investigate duplicate invoice ID failmail - https://phabricator.wikimedia.org/T167519#3345912 (DStrine) p:Triage>Normal [19:46:42] Fundraising-Backlog, fundraising-tech-ops: "ecom" script error in frdev1001 - https://phabricator.wikimedia.org/T167497#3345916 (DStrine) [19:46:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: SPIKE: Investigate root causes of duplicate invoice ID failmail - https://phabricator.wikimedia.org/T167519#3345919 (Ejegg) [19:48:49] Fundraising-Backlog: banner impressions loader crashing, maybe on missing project - https://phabricator.wikimedia.org/T167482#3345931 (DStrine) Open>declined [19:49:07] Fundraising-Backlog: banner impressions loader crashing, maybe on missing project - https://phabricator.wikimedia.org/T167482#3334451 (DStrine) duper of T167557 [19:50:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3345945 (DStrine) p:Triage>Normal [19:51:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3333075 (DStrine) @Pcoombe and @Jseddon is this affecting many people? do yo... [19:54:02] Fundraising-Backlog, FR-Astropay, Patch-For-Review: Make sure d*local payment submethods are up to date - https://phabricator.wikimedia.org/T167378#3345964 (DStrine) @MBeat33 are you seeing issues from donors trying to use Davivienda or any other processors? [19:54:55] Fundraising-Backlog: Creation of a "Campaign" Wiki - https://phabricator.wikimedia.org/T167375#3345977 (DStrine) @Jseddon this would be a task for the regular ops team (not even fr-tech ops) [19:55:51] Fundraising Sprint Kickstopper, Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3345990 (DStr... [19:56:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UKFC as Payment Instrument option for foreign check import - https://phabricator.wikimedia.org/T167355#3345999 (DStrine) p:Triage>Normal [19:57:44] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface forms should not need a reference to the gateway object - https://phabricator.wikimedia.org/T166842#3346004 (DStrine) p:Triage>Normal [19:58:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update Mastercard logo - https://phabricator.wikimedia.org/T166795#3346010 (DStrine) p:Triage>Normal [20:01:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update DonationInterface code style for php5.5 - https://phabricator.wikimedia.org/T166613#3346022 (DStrine) p:Triage>Normal [20:02:01] Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3346029 (DStrine) p:Triage>Normal [20:06:59] Wikimedia-Fundraising-CiviCRM, FR-Paypal, FR-WMF-Audit: Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3346054 (Ejegg) [20:07:22] Fundraising Sprint Kickstopper, Wikimedia-Fundraising-CiviCRM, FR-Paypal, FR-WMF-Audit: Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3346066 (Ejegg) p:Triage>Unbreak! a:Ejegg [20:13:36] (PS7) Ejegg: Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T147503) [20:13:44] (PS4) Ejegg: Get rid of redundant payment-provider/adyen path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 [20:16:37] Fundraising-Backlog, FR-Astropay, Patch-For-Review: Make sure d*local payment submethods are up to date - https://phabricator.wikimedia.org/T167378#3346126 (MBeat33) @DStrine yes, we're seeing donors who want to use Davivienda for PSE donations - roughly 10 so far. We have been explaining that we onl... [20:29:41] (Abandoned) Ejegg: Use non-deprecated PHPunit mock creator [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/350759 (owner: Ejegg) [20:31:06] (CR) Ejegg: "I don't think I'd heard of guzzle when I wrote that wrapper. Definitely worth looking into! This wrapper was based on the DonationInterfac" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [20:43:37] ejegg do you want to look at these tests with me? [21:06:01] mepps oh shoot, sorry! [21:06:09] can you email me any error you're getting? [21:06:56] ejegg emailed [21:07:01] thanks [21:25:21] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:30:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 30896 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 29 days 5 hours - memory use is 29.58M (peak 34.49M, 0.40% of max, fragmentation 1.12%), connected_slaves is 2, donations is 5, jobs is 0, jobs-adyen is 0, jobs-paypal is 16, payments-antifraud is 26, payments-init is 28, pending is 0, refund is 65, unsubscribe is 0 [21:30:31] PROBLEM - check_mysql on payments2001 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) [21:35:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 30896 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 29 days 5 hours - memory use is 29.58M (peak 34.49M, 0.41% of max, fragmentation 1.12%), connected_slaves is 2, donations is 6, jobs is 0, jobs-adyen is 0, jobs-paypal is 9, payments-antifraud is 18, payments-init is 14, pending is 32, refund is 65, unsubscribe is 0 [21:35:21] RECOVERY - check_mysql on payments2001 is OK: Uptime: 7010937 Threads: 4 Questions: 71966 Slow queries: 0 Opens: 29 Flush tables: 1 Open tables: 92 Queries per second avg: 0.010 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [21:40:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 30896 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 29 days 6 hours - memory use is 29.68M (peak 34.49M, 0.41% of max, fragmentation 1.12%), connected_slaves is 2, donations is 5, jobs is 0, jobs-adyen is 0, jobs-paypal is 15, payments-antifraud is 44, payments-init is 54, pending is 31, refund is 65, unsubscribe is 0 [21:45:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 21934 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 29 days 6 hours - memory use is 21.65M (peak 34.49M, 0.33% of max, fragmentation 1.25%), connected_slaves is 2, donations is 7, jobs is 0, jobs-adyen is 0, jobs-paypal is 8, payments-antifraud is 27, payments-init is 36, pending is 1, refund is 65, unsubscribe is 0 [21:50:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 21934 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 29 days 6 hours - memory use is 21.61M (peak 34.49M, 0.33% of max, fragmentation 1.26%), connected_slaves is 2, donations is 3, jobs is 0, jobs-adyen is 0, jobs-paypal is 14, payments-antifraud is 16, payments-init is 11, pending is 28, refund is 65, unsubscribe is 0 [21:55:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 21934 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 29 days 6 hours - memory use is 21.66M (peak 34.49M, 0.33% of max, fragmentation 1.25%), connected_slaves is 2, donations is 17, jobs is 0, jobs-adyen is 0, jobs-paypal is 7, payments-antifraud is 46, payments-init is 54, pending is 25, refund is 65, unsubscribe is 0 [22:00:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 21934 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 29 days 6 hours - memory use is 21.62M (peak 34.49M, 0.33% of max, fragmentation 1.26%), connected_slaves is 2, donations is 8, jobs is 0, jobs-adyen is 0, jobs-paypal is 11, payments-antifraud is 24, payments-init is 30, pending is 23, refund is 65, unsubscribe is 0 [22:00:14] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/358886 [22:00:21] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/358886 (owner: Ejegg) [22:00:43] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/358886 (owner: Ejegg) [22:05:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 12975 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 29 days 6 hours - memory use is 13.57M (peak 34.49M, 0.22% of max, fragmentation 1.31%), connected_slaves is 2, donations is 14, jobs is 0, jobs-adyen is 0, jobs-paypal is 15, payments-antifraud is 11, payments-init is 17, pending is 26, refund is 0, unsubscribe is 0 [22:06:17] !log updated fundraising tools from f2522cdabf1741a60b7b60ac8f7ead7afd50b054 to 585f546aa0c092ccd938a9a01b4bc3eb7662804d [22:06:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:10:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 12975 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 29 days 6 hours - memory use is 13.63M (peak 34.49M, 0.22% of max, fragmentation 1.31%), connected_slaves is 2, donations is 6, jobs is 0, jobs-adyen is 0, jobs-paypal is 15, payments-antifraud is 40, payments-init is 53, pending is 30, refund is 0, unsubscribe is 0 [22:13:32] ACKNOWLEDGEMENT - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 12975 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 7 keys, up 29 days 6 hours - memory use is 13.63M (peak 34.49M, 0.22% of max, fragmentation 1.31%), connected_slaves is 2, donations is 6, jobs is 0, jobs-adyen is 0, jobs-paypal is 15, payments-antifraud is 40, payments-init is 53, pending is 30, refund is 0, unsubscribe is 0 Ellio [22:13:51] cwd I think I just acknowledged that alert [22:13:59] let's see if it goes away [22:14:15] oh hey, there's the ack logged in chat [22:14:39] oh sweet [22:14:44] good thinking [22:15:56] fr-tech can anyone take a look at https://gerrit.wikimedia.org/r/356436 ? [22:16:17] We should probably merge that before we deploy the rest of the SmashPig configuration changeup [22:17:25] i'm going to have to spend some time with these perl scripts before i make any serious changes [22:17:45] ejegg: Yea, I'll take a look [22:17:47] i think this is probably a simple change i just need to feel sure [22:17:59] with jeff gone and what not [22:18:28] I'm starting some notes here https://etherpad.wikimedia.org/p/smashpig-config [22:18:38] great, thanks [22:18:40] feeling like this is a tomorrow thing at the earliest [22:19:02] yeah [22:19:16] I definitely want to think through how this works with the other projects using SmashPig as a library [22:20:01] I think they should be fine using the old config files to start out, so we should just not nuke the existing one right away [22:21:16] (CR) XenoRyet: [C: 2] Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T147503) (owner: Ejegg) [22:22:31] ejegg or cwd : I have a question about credentials. Silverpop will require us to store some credentials for accessing silverpop. So far I've just been passing them in but I'm sure we have a methodology around that [22:26:29] eileen1: yep i'm sure they'll fit into puppet somewhere [22:36:17] (Merged) jenkins-bot: Allow specifying configuration dir with environment vars [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356436 (https://phabricator.wikimedia.org/T147503) (owner: Ejegg) [22:36:31] woohoo [22:36:52] yeah, I should definitely bang on that locally a while, too [22:39:54] relocating... [22:41:05] cwd is there an example in the code drawing in vars from puppet?? Do they get declared as some sort of global? [22:42:19] eileen1: sure, let's see... [22:45:12] RECOVERY - check_redis on frqueue1001 is OK: OK: REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 6 keys, up 29 days 7 hours - memory use is 2.07M (peak 34.49M, 0.07% of max, fragmentation 2.91%), connected_slaves is 2, donations is 0, jobs is 0, jobs-adyen is 0, jobs-paypal is 6, payments-antifraud is 21, payments-init is 29, pending is 27, recurring is 0, refund is 61, unsubscribe is 0 [23:38:39] (PS14) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [23:49:26] (PS3) Ejegg: Recover Amazon order IDs when txn captured at console [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) [23:50:12] (PS5) Ejegg: Get rid of redundant payment-provider/adyen path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 [23:51:41] (CR) Ejegg: [C: 2] "Re-applying mepps's +2 to kick CI" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 (owner: Ejegg) [23:52:34] (Merged) jenkins-bot: Get rid of redundant payment-provider/adyen path [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356774 (owner: Ejegg)