[00:01:32] (CR) Jforrester: [C: 1] Use foreach instead of ResultWrapper::fetchRow [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358909 (owner: Umherirrender) [00:02:19] (CR) Jforrester: [C: 2] Use short array syntax [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358052 (owner: Umherirrender) [00:03:22] (CR) Jforrester: [C: 2] Use short array syntax - includes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358050 (owner: Umherirrender) [00:05:32] (Merged) jenkins-bot: Use short array syntax [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358052 (owner: Umherirrender) [00:07:14] (Merged) jenkins-bot: Use short array syntax - includes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358050 (owner: Umherirrender) [01:08:12] PROBLEM - check_gcsip on payments1002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [01:08:13] PROBLEM - check_gcsip on payments1004 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [01:08:15] PROBLEM - check_minfraud_secondary on payments1002 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [01:08:16] PROBLEM - check_minfraud_secondary on payments1004 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [01:10:12] RECOVERY - check_gcsip on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.123 second response time [01:10:13] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.159 second response time [01:10:14] RECOVERY - check_minfraud_secondary on payments1004 is OK: HTTP OK: Status line output matched 200,301,302 - 385 bytes in 0.271 second response time [01:10:15] RECOVERY - check_minfraud_secondary on payments1002 is OK: HTTP OK: Status line output matched 200,301,302 - 385 bytes in 0.242 second response time [01:14:04] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 5 others: retrieve the text/ html and statistics data for m... - https://phabricator.wikimedia.org/T161758#3142109 [02:02:40] Fundraising Sprint Kickstopper, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, FR-Email: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3350514 (Eileenmcnaughton) I now have the mailing recipient data on staging (in the civicrm_mailing... [06:24:20] (PS3) Umherirrender: Use foreach instead of ResultWrapper::fetchRow [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358909 [06:24:36] (CR) Umherirrender: "Patch Set 3: Rebased" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358909 (owner: Umherirrender) [06:45:33] (PS5) Umherirrender: Add phpcs and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 [06:46:11] (CR) Umherirrender: "Patch Set 5: Rebased" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [14:08:08] ejegg trying to figure out why my tests aren't working--what directory do you run them from? I'm running from crm using vendor/bin/phpunit [14:08:20] i mean they're working jsut getting errors [14:16:01] i kind of wonder if i should throw in the towel and download vagrant... [15:31:00] mepps yeah, I'm running them from the same directory [15:31:43] I'm actually not able to run them all either - the merge tests die b/c I've got so much test data in my civi db [15:32:29] so... I need to set up another civi db and have the settings file point to that when it can tell we're running under phpunit [15:32:34] doing that now [16:15:58] mepps ok, if I run the tests on a fresh database, I get all of them passing except for RefundTest::testLesserWrongCurrencyRefund [16:16:11] that one gives me an ExchangeRatesException: No conversion available for currency COP [16:16:21] which I think we should fix in the test setup [16:16:31] Want to go through the ones that are failing for you? [16:20:11] hmm let me try on a clean db as well--also i have to run in a minute because i managed to leave my computer charger in dc last night so i'm going to staples to get another one (since i needed backup anyways) [16:34:11] ejegg when you get a chance can you send me what you added to your settings for phpunit? [16:38:31] (PS1) Ejegg: Define a constant to allow switching dbs for phpunit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359174 [16:38:43] mepps I just added that ^^^ to the phpunit bootstrap [16:39:22] then in settings.php and civicrm.settings.php, I surrounded the db settings in if(defined('WMF_CRM_PHPUNIT')) and switched to the other db [16:39:37] hmm, though maybe I should have just defined another 'site' [16:40:07] haven't worked with multi-site drupal yet - do you know if that would be preferable? [16:40:43] this seems to work for tests without interfering with the web UI [16:41:02] but every time I drush updb I'll have to do it a second time with that constant defined somewhere [16:53:06] (PS1) Ejegg: Update doc link on paypal currency list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359185 [17:00:19] fr-tech: Andrea: Unhappy the land that has no heroes. [17:00:19] Galileo: No, unhappy the land that _n_e_e_d_s heroes. [17:00:19] -- Bertolt Brecht, "Life of Galileo" [17:00:19] -- discuss. [17:33:52] Fundraising-Backlog, fundraising-tech-ops: "ecom" script error in frdev1001 - https://phabricator.wikimedia.org/T167497#3352214 (CCogdill_WMF) p:Triage>Unbreak! I tested Moska's ecom command and it worked for me. I think she needs access to statler/ecom and does not have it. Changing the priorit... [17:39:43] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Resultswitchers: send straight to ty page on reload - https://phabricator.wikimedia.org/T167990#3352283 (Ejegg) [18:03:57] Fundraising-Backlog, fundraising-tech-ops: "ecom" script error in frdev1001 - https://phabricator.wikimedia.org/T167497#3352412 (DStrine) p:Unbreak!>High [18:05:48] Fundraising-Backlog, fundraising-tech-ops: "ecom" script error in frdev1001 - https://phabricator.wikimedia.org/T167497#3334877 (DStrine) Cw [18:08:49] Fundraising-Backlog: Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996#3352439 (Umherirrender) [18:24:43] (PS1) Ejegg: WIP send resultswitcher reloaders to TY page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359213 (https://phabricator.wikimedia.org/T167990) [18:25:30] Fundraising Sprint Kickstopper, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Patch-For-Review: Resultswitchers: send straight to ty page on reload - https://phabricator.wikimedia.org/T167990#3352541 (Ejegg) p:Triage>Normal a:Ejegg [18:28:20] Fundraising-Backlog, fundraising-tech-ops: "ecom" script error in frdev1001 - https://phabricator.wikimedia.org/T167497#3352584 (cwdent) Open>Resolved Had to hack .my.conf to work with python, pretty bizarre, going to start the /srv/br documentation today. [18:52:07] Fundraising-Backlog, MediaWiki-extensions-General, Documentation: Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996#3352672 (Umherirrender) [18:52:38] (PS2) Ejegg: WIP send resultswitcher reloaders to TY page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359213 (https://phabricator.wikimedia.org/T167990) [19:03:05] ejegg it looks like there's handling for unit tests in the civi settings, does it make any sense to use that? [19:03:19] oh really? [19:03:33] I didn't notice, but yeah, that would make sense [19:03:58] what are you seeing there? [19:04:53] if (CIVICRM_UF === 'UnitTests' && isset($GLOBALS['_CV']['TEST_DB_DSN'])) { [19:04:53] define('CIVICRM_DSN', $GLOBALS['_CV']['TEST_DB_DSN']); [19:04:53] } [19:05:13] oho [19:05:27] I'm not sure that'll work for us [19:05:42] we might need the UF to stay 'drupal' [19:06:02] since most of our modules are drupal modules rather than real civi extensions [19:06:49] I'm not sure you'll actually need a different set of dbs, though [19:07:12] i feel like there must be a convention for this [19:07:22] it might just be failing on the real db for me because I imported about a million rows of fake data when I was coding the dashboard [19:07:59] and running the merge tests just overwhelms mysql on a laptop [19:10:52] mepps can we look at the specific tests that are failing for you? [19:11:25] I bet some of them are just making assumptions about data that they shouldn't be making [19:12:17] sure [19:12:31] i'm in fr-tech-talk [19:14:22] Fundraising-Backlog: Ask GlobalCollect to let us cancel status 600 transactions - https://phabricator.wikimedia.org/T114205#3352757 (MBeat33) In January, Ingenico started applying a fee for Visa transactions that are stopped at status 600 but then neither canceled nor settled. The line item on our May Ingen... [19:41:00] (PS1) Ejegg: TEST: do we need the refresh? [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 [19:43:08] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 (owner: Ejegg) [19:44:11] (PS2) Ejegg: Test tidy ups, ensure data from failed run doesn not break test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [19:47:30] (CR) Paladox: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352746 (owner: Eileen) [19:48:46] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 (owner: Ejegg) [19:52:03] (PS1) Mepps: WIP Figuring out error codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 [19:56:44] (CR) jerkins-bot: [V: -1] WIP Figuring out error codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359235 (owner: Mepps) [20:28:47] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 (owner: Ejegg) [20:33:57] (PS2) Ejegg: TEST: do we need the refresh? [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 [20:55:16] fr-tech anyone want to take a look at this little regex change: https://gerrit.wikimedia.org/r/358487 [20:55:31] We need to deploy it soon to keep landing page statistics accurate [21:19:22] AndyRussG: ^^ ? [21:21:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM tests should pass without db superuser privs - https://phabricator.wikimedia.org/T168016#3353096 (Ejegg) [21:31:04] (CR) Mepps: [C: 2] Update LandingPage regex for new name [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358487 (owner: Ejegg) [21:33:06] thanks! [21:36:54] Fundraising-Backlog: help review new event management software - https://phabricator.wikimedia.org/T168017#3353162 (DStrine) [21:40:09] (PS3) Ejegg: Send resultswitcher reloaders to TY page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359213 (https://phabricator.wikimedia.org/T167990) [21:42:02] OK, I think that should work for Paypal resultswitcher reloaders ^^^ [21:42:50] Fundraising Sprint Kickstopper, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Patch-For-Review: Resultswitchers: send straight to ty page on reload - https://phabricator.wikimedia.org/T167990#3352283 (Ejegg) [21:42:52] Fundraising Sprint Kickstopper, Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal EC dead session error - https://phabricator.wikimedia.org/T167923#3353191 (Ejegg) [21:48:48] Fundraising-Backlog: help review new event management software - https://phabricator.wikimedia.org/T168017#3353234 (DStrine) for fr-tech: The file Jerry posted is a stripe export from our current system. She is going to see if she can run some test donations through a test version of impact flow to se how c... [22:19:04] ejegg: ah yes I was looking at the regex change, looked fine, just wanted to understand the context a wee bit more [22:19:12] But I could just +2, it looks totally kosher [22:24:18] AndyRussG: mepps beat you to it, but thanks! [22:24:38] (CR) Ejegg: [V: 2] Update LandingPage regex for new name [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358487 (owner: Ejegg) [22:25:22] I checked out the latest log files, and it looks like every request to FundraiserLandingPage is indeed followed by a request to just plain LandingPage [22:25:41] so I'll deploy the thing and let people know they can change links at their leisure [22:27:05] AndyRussG: if you want to look at the other DjangoBannerStats patches that are up, please go ahead! [22:27:41] The web UI has never been used, and didn't actually include much beyond hello world, so I deleted it [22:28:03] the other changes were just about the minimum I could do to make it run on Django past 1.7 [22:30:30] !log updated DjangoBannerStats from 9e6b11712851919e4318930e19bdf9c941d8ae38 to 5963e7c116f083ada28476c1c41ff1b46232d772 [22:30:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:33:45] (PS1) Ejegg: Add one more yahoo tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359361