[00:13:01] ejegg: gotcha, will do! [00:20:08] thanks AndyRussG! [00:20:16] heading out for the night, see everyone tomorrow [04:08:01] (PS4) Reedy: Use foreach instead of ResultWrapper::fetchRow [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358909 (owner: Umherirrender) [04:08:04] (CR) Reedy: [C: 2] Use foreach instead of ResultWrapper::fetchRow [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358909 (owner: Umherirrender) [04:10:24] (CR) Reedy: "https://stackoverflow.com/questions/1452934/what-is-the-meaning-of-xxx" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [04:10:45] (Merged) jenkins-bot: Use foreach instead of ResultWrapper::fetchRow [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358909 (owner: Umherirrender) [08:03:08] (CR) Umherirrender: Add phpcs and make pass (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [09:48:05] (CR) Thiemo Mättig (WMDE): [C: 1] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359361 (owner: Ejegg) [10:27:08] (CR) Thiemo Mättig (WMDE): [C: 2] Add phpcs and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [10:54:34] (PS6) Umherirrender: Add phpcs and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 [10:54:42] (CR) Umherirrender: [C: 2] "Resubmit" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [10:57:51] (CR) jerkins-bot: [V: -1] Add phpcs and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [11:03:56] (CR) Umherirrender: [C: 2] "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [11:07:09] (Merged) jenkins-bot: Add phpcs and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/358045 (owner: Umherirrender) [17:00:19] fr-tech: Beachhead, n.: [17:00:19] In marketing: A small piece of a market over which you gain [17:00:19] control and from which you go out to control other pieces of [17:00:19] the market. [17:00:19] In war: Where soldiers die. [17:00:19] -- discuss. [17:12:57] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 (owner: Ejegg) [17:22:06] (PS3) Ejegg: TEST: do we need the refresh? [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 [17:22:22] rrg, jenkins refuses to run CI on it ^^^ [17:25:27] (CR) Paladox: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359233 (owner: Ejegg) [19:15:58] Fundraising Sprint Kickstopper, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Reconsider minfraud failure mode - https://phabricator.wikimedia.org/T150072#3355759 (Ejegg) Open>Resolved [19:16:30] Fundraising Sprint Kickstopper, Fundraising-Backlog, MediaWiki-extensions-FundraiserLandingPage, MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review: Rename Special:FundraiserLandingpage to Special:LandingPage - https://phabricator.wikimedia.org/T167374#3331095 (Ejeg... [19:25:21] Fundraising Sprint Kickstopper, Wikimedia-Fundraising-CiviCRM, FR-Paypal, FR-WMF-Audit: Follow up with Paypal on audit regeneration, enable parser - https://phabricator.wikimedia.org/T167828#3355797 (Ejegg) Request for audit file regeneration was closed last time because I missed the follow-up qu... [19:26:06] !log re-enabled paypal audit download and parse job [19:26:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:00:11] Fundraising Sprint Kickstopper, Fundraising-Backlog, FR-Amazon, Patch-For-Review: Reconcile 45 missing Amazon donations - https://phabricator.wikimedia.org/T167380#3355872 (Ejegg) Open>Resolved a:Ejegg Just checked, and all of the batch-captured donations are in civi. [20:01:44] Fundraising Sprint Kickstopper, Fundraising-Backlog, FR-PayPal-ExpressCheckout, MediaWiki-extensions-DonationInterface: Deal with paypal EC error 11607, show thank you page - https://phabricator.wikimedia.org/T165635#3355893 (Ejegg) If we merge the patch in T167990, it'll probably keep us from ge... [20:02:42] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, and 2 others: Epic: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3355897 (Ejegg) [20:04:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Store recurring tokens in Civi's payment_token table - https://phabricator.wikimedia.org/T165695#3355901 (Ejegg) [20:04:54] Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Add payment session ID to pending & donations queue messages - https://phabricator.wikimedia.org/T165687#3355902 (Ejegg) [20:04:56] Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, and 2 others: Epic: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#3355900 (Ejegg) [20:07:15] Fundraising Sprint Kickstopper, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Instead of failmail, record and flag duplicate donations. - https://phabricator.wikimedia.org/T167520#3355907 (Ejegg) [20:07:17] Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3355906 (Ejegg) [20:08:23] Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3286918 (Ejegg) The work attached to this ticket solved th... [21:59:20] ejegg: am doing some work today, currently just clearing emails, but if any more thoughts have come up re the omnimail am here [21:59:57] cool. I've just been clearing out old tickets myself [22:00:16] but let me take one more look before I head out [22:07:49] ok great [22:28:03] oops, sorry if I'm making github spam you by posting a series of single comments. i bet there's a way to post as a set... [22:31:55] so, the SilverpopGuzzleConnector not yet using guzzle is just temporary [22:36:36] ejegg: the spam is fine [22:36:45] Yeah the guzzle one is temporary [22:36:56] hopefully your review on github will get some attention [22:37:19] (it might be worth name-checking wmf to get him enthused :-) [22:38:02] there was more difference in the guzzle one - until he merged my last set [22:39:38] heh, cool [22:45:32] got to head to dinner soon, but I'll keep reviewing on github! [22:46:16] ejegg: great - I see I need to go back & update some areas to changes I made later! [22:49:57] (PS1) Ejegg: Temporarily stop storing invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359630 (https://phabricator.wikimedia.org/T165918) [22:51:15] (CR) Ejegg: "mepps I think we should actually stop storing invoice ID till we can do it the right way with your patch. Seems like the missing Civi reco" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359630 (https://phabricator.wikimedia.org/T165918) (owner: Ejegg)