[02:04:08] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Chinese-Sites, Patch-For-Review: Offer contentlanguage targeting for CentralNotice banners - https://phabricator.wikimedia.org/T53475#577876 (Shizhao) and see T55641 [04:53:06] Fundraising-Backlog: PayPal recurring annual donation did not reach Civi - https://phabricator.wikimedia.org/T119518#1828348 (Ejegg) We really should be able to thank people for annual gifts (and put their names in our list). It would take a very small effort, as long as it's just for recurring donations whe... [04:53:38] Fundraising-Backlog: PayPal recurring annual donation did not reach Civi - https://phabricator.wikimedia.org/T119518#3361963 (Ejegg) duplicate>Open [07:10:10] (PS1) Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/360202 [12:44:21] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 3 others: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3363131 (Pcoombe) Than... [13:31:57] (PS3) Mepps: Add gateway_session_id to pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [13:32:05] (CR) Mepps: [C: 2] Add gateway_session_id to pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [13:33:43] (Merged) jenkins-bot: Add gateway_session_id to pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [13:37:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate: Adding translatable message to banner FR2015_translations takes a long time and shows error - https://phabricator.wikimedia.org/T167442#3363316 (Pcoombe) @DStrine Afaik it's only fundraising. It isn't a huge issu... [13:46:24] (CR) Ejegg: "Oops, sorry I left this just -1'ed. I should have abandoned it when I realized we probably don't need it. I'll submit a reversion" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/354266 (https://phabricator.wikimedia.org/T165687) (owner: Ejegg) [13:46:51] (PS1) Ejegg: Revert "Add gateway_session_id to pending table" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/360346 [13:52:27] (CR) Mepps: $correlationId -> $logId (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353758 (owner: Ejegg) [13:52:42] ejegg see this review ^^ i had a few questions [13:56:14] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 3 others: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3363384 (Ejegg) Good c... [13:58:35] (CR) Mepps: "ejegg looks like there's a merge conflict--is this still a priority?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354267 (owner: Ejegg) [14:02:00] (CR) Ejegg: "Nah, I can rewrite it later. Thanks for looking!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354267 (owner: Ejegg) [14:09:01] (PS2) Mepps: Delete some unused vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353603 (owner: Ejegg) [14:09:05] (CR) Mepps: [C: 2] Delete some unused vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353603 (owner: Ejegg) [14:09:52] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 3 others: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3363451 (Pcoombe) Ah y... [14:11:38] (CR) jerkins-bot: [V: -1] Delete some unused vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353603 (owner: Ejegg) [14:11:42] (PS2) Mepps: Guard against missing params in PP-EC return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [14:11:47] (CR) Mepps: [C: 2] Guard against missing params in PP-EC return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [14:11:51] (CR) jerkins-bot: [V: -1] Delete some unused vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353603 (owner: Ejegg) [14:13:39] (CR) jerkins-bot: [V: -1] Guard against missing params in PP-EC return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [14:13:52] (CR) Hashar: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [14:14:26] (CR) jerkins-bot: [V: -1] Guard against missing params in PP-EC return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [14:15:01] (CR) Hashar: "There is a race condition in CI when it reboots. That caused the jobs to not be found." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [15:01:26] (PS2) Mepps: Move CurrencyRates into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/352054 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:01:28] (CR) Mepps: [C: 2] Move CurrencyRates into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/352054 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:02:24] (PS2) Mepps: Move NationalCurrencies into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/352053 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:02:28] (Merged) jenkins-bot: Move CurrencyRates into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/352054 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:02:44] (CR) Mepps: [C: 2] "Approving this but I'm curious why we're hard coding it rather than putting it in the db?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/352053 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:02:54] ejegg notice comment on above ^^ [15:04:21] (Merged) jenkins-bot: Move NationalCurrencies into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/352053 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:19:35] mepps thanks! [15:19:53] I guess it's to reduce db load? [15:20:52] Good point, though. We could just cache it in memcache or something. I'm relying on you to question all the assumptions! [15:21:04] (PS2) Mepps: Specify output directory for make-exchange-refs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352052 (owner: Ejegg) [15:21:05] I've been here long enough that it all just seems normal [15:21:20] (CR) Mepps: [C: 2] "Do we need to update localsettings when this gets deployed?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352052 (owner: Ejegg) [15:23:33] (CR) Ejegg: "Nope, since this is just for the script that dumps exchange rates from a db to a static file. Again, though, it's worth asking the same qu" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352052 (owner: Ejegg) [15:24:14] (CR) Mepps: CurrencyRates template: add SmashPig namespace (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352047 (https://phabricator.wikimedia.org/T163868) (owner: Ejegg) [15:24:15] Thank you for the CR bonanza! [15:28:47] (Merged) jenkins-bot: Specify output directory for make-exchange-refs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/352052 (owner: Ejegg) [15:34:16] (CR) Ejegg: "Thanks mepps! Answers inline." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353758 (owner: Ejegg) [15:35:52] (CR) Ejegg: "Stomp is the protocol spoken by ActiveMQ, so any references to that are vestigal too." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353758 (owner: Ejegg) [15:37:58] (PS2) Mepps: $correlationId -> $logId [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353758 (owner: Ejegg) [15:38:03] (CR) Mepps: [C: 2] $correlationId -> $logId [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353758 (owner: Ejegg) [15:39:54] (PS2) Mepps: Bash autocompletion for job names [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/351745 (owner: Ejegg) [15:40:05] (CR) Mepps: [C: 2] Bash autocompletion for job names [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/351745 (owner: Ejegg) [15:40:27] woohoo, thanks for that one! My first time playing with autocompletion [15:40:48] now I need to add that to the deb packaging script [15:42:11] (Merged) jenkins-bot: $correlationId -> $logId [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/353758 (owner: Ejegg) [15:42:13] (Merged) jenkins-bot: Bash autocompletion for job names [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/351745 (owner: Ejegg) [15:46:46] Fundraising-Backlog: help review new event management software - https://phabricator.wikimedia.org/T168017#3363841 (DStrine) Open>declined [16:03:55] dang, 1.5 hr delay waiting for the crew to show up. good thing i had a 4 hr wait for the connection! [16:06:57] (Abandoned) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355281 (owner: Mepps) [16:07:10] (Abandoned) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355242 (owner: Mepps) [16:07:23] (Abandoned) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/355210 (owner: Mepps) [16:08:08] (PS2) Mepps: Get rid of the rest of the !important modifiers in forms.css [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330742 (owner: Ejegg) [16:08:13] (CR) Mepps: [C: 2] Get rid of the rest of the !important modifiers in forms.css [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330742 (owner: Ejegg) [16:09:00] (PS2) Mepps: Stop masking possible test failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356961 (owner: Ejegg) [16:09:04] (CR) Mepps: [C: 2] Stop masking possible test failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356961 (owner: Ejegg) [16:10:38] (Merged) jenkins-bot: Get rid of the rest of the !important modifiers in forms.css [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/330742 (owner: Ejegg) [16:11:30] (Merged) jenkins-bot: Stop masking possible test failure [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356961 (owner: Ejegg) [16:22:43] ejegg hopefully it takes off in time for your connection! [16:23:31] not too worried yet. just hoping for no further delay! [16:28:09] (PS4) Mepps: Add API test for Amazon [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356959 (owner: Ejegg) [16:28:13] (CR) Mepps: [C: 2] Add API test for Amazon [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356959 (owner: Ejegg) [16:28:31] (PS2) Mepps: Alert on Amazon message verification failure [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356970 (https://phabricator.wikimedia.org/T166087) (owner: Ejegg) [16:28:35] (CR) Mepps: [C: 2] Alert on Amazon message verification failure [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356970 (https://phabricator.wikimedia.org/T166087) (owner: Ejegg) [16:29:52] (PS9) Mepps: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:29:58] (CR) Mepps: [C: 2] Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:30:26] (Merged) jenkins-bot: Alert on Amazon message verification failure [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356970 (https://phabricator.wikimedia.org/T166087) (owner: Ejegg) [16:34:39] (Merged) jenkins-bot: Add API test for Amazon [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/356959 (owner: Ejegg) [16:34:41] (Merged) jenkins-bot: Consolidate queue message generation. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354605 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:38:29] (PS6) Mepps: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:38:34] (CR) Mepps: [C: 2] Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:52:47] (Merged) jenkins-bot: Get rid of some more php-message-class, WmfFramework::getHostname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355370 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [16:55:08] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Israel (Jul 5 - Aug 2) - https://phabricator.wikimedia.org/T165526#3364106 (Pcoombe) [17:00:19] fr-tech: It has just been discovered that research causes cancer in rats. [17:00:19] -- discuss. [17:10:01] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421#3364170 (awight) [17:10:27] Fundraising-Backlog: Revoke AWight's CiviCRM account - https://phabricator.wikimedia.org/T168423#3364193 (awight) [17:11:26] fundraising-tech-ops: Revoke AWight's frack ssh access - https://phabricator.wikimedia.org/T168424#3364207 (awight) [17:12:15] (PS1) Ejegg: Add missing national currencies, alphabetize [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/360384 [17:16:43] (PS8) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 (https://phabricator.wikimedia.org/T163868) [17:17:55] (Abandoned) Ejegg: Temporarily stop storing invoice id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/359630 (https://phabricator.wikimedia.org/T165918) (owner: Ejegg) [17:18:01] Fundraising-Backlog: Revoke centralnotice-admin for AWight (WMF) - https://phabricator.wikimedia.org/T168428#3364276 (awight) [17:18:38] Fundraising-Backlog: Transfer centralnotice-admin mailing list ownership from awight to agreen - https://phabricator.wikimedia.org/T168429#3364289 (awight) [17:20:59] fundraising-tech-ops: Revoke AWight's donatewiki account - https://phabricator.wikimedia.org/T168430#3364301 (awight) [17:21:24] fundraising-tech-ops: Unsubscribe AWight from fr-tech internal lists - https://phabricator.wikimedia.org/T168431#3364317 (awight) [17:23:50] Fundraising-Backlog: Transfer centralnotice-admin mailing list ownership from awight to Jseddon - https://phabricator.wikimedia.org/T168429#3364340 (DStrine) a:Jseddon [17:24:20] (PS3) Ejegg: Guard against missing params in PP-EC return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 [17:25:38] Fundraising-Backlog, Phabricator: Remove AWight from Phabricator "WMF FR" group - https://phabricator.wikimedia.org/T168432#3364345 (awight) [17:29:48] Fundraising-Backlog, Phabricator: Remove AWight from Phabricator "WMF FR" group - https://phabricator.wikimedia.org/T168432#3364345 (DStrine) you are no longer on this project [17:29:58] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421#3364393 (DStrine) [17:31:51] Fundraising-Backlog: Transfer centralnotice-admin mailing list ownership from awight to Jseddon - https://phabricator.wikimedia.org/T168429#3364412 (awight) Thanks for the note! I've made both agreen and jseddon shared list admins, in case they need the flexibility. [17:32:58] (PS6) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [17:35:10] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [17:47:26] (PS7) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [17:49:36] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [17:52:12] (PS8) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [17:53:35] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [17:57:42] (PS9) Ejegg: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 [17:59:10] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [18:02:31] (PS2) Mepps: Explicit include path for phpunit bootstrap [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356749 (owner: Ejegg) [18:02:34] (CR) Mepps: [C: 2] Explicit include path for phpunit bootstrap [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356749 (owner: Ejegg) [18:03:25] (Merged) jenkins-bot: Explicit include path for phpunit bootstrap [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/356749 (owner: Ejegg) [18:04:24] ejegg is this something you want merged: https://gerrit.wikimedia.org/r/#/c/334475/ [18:04:32] i ask only because it's described as a proof of concept [18:04:36] if so i'm good to +2 it! [18:04:50] mepps yeah, it would be nice to have that using the same fake cURL [18:05:07] though like you suggested, we should probably check out guzzle some time [18:05:15] (PS15) Ejegg: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 [18:05:29] (PS16) Mepps: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [18:05:34] (CR) Mepps: [C: 2] PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [18:06:03] mepps did you see I wanted to revert the gateway_session_id one? https://gerrit.wikimedia.org/r/360346 [18:06:25] turns out we should never need to select on that field, so it can stay in the message blob [18:06:27] (CR) jerkins-bot: [V: -1] PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [18:06:32] (CR) jerkins-bot: [V: -1] PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [18:06:34] (PS2) Mepps: Revert "Add gateway_session_id to pending table" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/360346 (owner: Ejegg) [18:06:37] (CR) Mepps: [C: 2] Revert "Add gateway_session_id to pending table" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/360346 (owner: Ejegg) [18:06:39] thanks! [18:07:14] ejegg i only just found the gerrit dashboard which is helping me know what to review now! [18:07:20] also, we recently discovered the NationalCurrencies was missing at least MXN, but we only fixed that in the version in DonationInterface - i didn't update the patch you just merged [18:07:27] mepps ohhhh, yeah, that is helpful [18:07:45] (PS4) Mepps: Recover Amazon order IDs when txn captured at console [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [18:08:01] (Merged) jenkins-bot: Revert "Add gateway_session_id to pending table" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/360346 (owner: Ejegg) [18:08:42] (CR) Mepps: [C: 2] Recover Amazon order IDs when txn captured at console [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [18:12:11] (Merged) jenkins-bot: Recover Amazon order IDs when txn captured at console [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/358155 (https://phabricator.wikimedia.org/T167380) (owner: Ejegg) [18:13:15] weird, that patch to use new SmashPig in DonationInterface is passing on my machine [18:29:29] ejegg frustrating! [18:31:15] Fundraising-Backlog, fundraising-tech-ops: Do something about shared passwords that AWight had access to? - https://phabricator.wikimedia.org/T168448#3364751 (awight) [18:37:36] (CR) Mepps: Script to update d*Local payment submethods (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/358154 (https://phabricator.wikimedia.org/T167378) (owner: Ejegg) [18:38:52] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421#3364813 (awight) [18:38:54] Fundraising-Backlog, fundraising-tech-ops: Do something about shared passwords that AWight had access to? - https://phabricator.wikimedia.org/T168448#3364812 (awight) [18:40:04] Fundraising-Backlog: Revoke AWight home IP from PSP whitelists - https://phabricator.wikimedia.org/T168451#3364818 (awight) [19:15:45] Fundraising-Backlog: Revoke centralnotice-admin for AWight (WMF) - https://phabricator.wikimedia.org/T168428#3365059 (DStrine) a:Jseddon [19:16:17] Fundraising-Backlog: Revoke AWight home IP from PSP whitelists - https://phabricator.wikimedia.org/T168451#3364818 (DStrine) p:Triage>Normal [19:16:53] Fundraising-Backlog, fundraising-tech-ops: Revoke AWight's CiviCRM account - https://phabricator.wikimedia.org/T168423#3365073 (DStrine) p:Triage>Normal [19:17:20] Fundraising-Backlog, fundraising-tech-ops: Revoke AWight's CiviCRM account - https://phabricator.wikimedia.org/T168423#3364193 (DStrine) [19:25:58] (PS2) Mepps: Revert "Allow specifying configuration dir with environment vars" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/359078 (owner: Ejegg) [19:26:01] (CR) Mepps: [C: 2] Revert "Allow specifying configuration dir with environment vars" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/359078 (owner: Ejegg) [19:26:51] (Merged) jenkins-bot: Revert "Allow specifying configuration dir with environment vars" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/359078 (owner: Ejegg) [19:33:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM tests should pass without db superuser privs - https://phabricator.wikimedia.org/T168016#3365147 (DStrine) p:Triage>Normal [19:49:10] Fundraising-Backlog, MediaWiki-extensions-General, Documentation: Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996#3365184 (DStrine) a:Jseddon [19:54:33] Fundraising-Backlog, fundraising-tech-ops: Revoke AWight's CiviCRM account and SSL cert - https://phabricator.wikimedia.org/T168423#3365192 (awight) [20:39:25] (CR) Umherirrender: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/360202 (owner: Legoktm) [20:50:55] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/360202 (owner: Legoktm) [21:38:07] ejegg|ish: I'm wondering about the QA timeline - ie. you are making good suggestions but I'm worried I can't address them all before you go [21:38:57] potentially if we are at the point where I can get the bulk merged I can work with mepps to hone it? [22:08:11] I'm sure mepps can give some great feeback too! [22:08:35] Also, I can take another look tomorrow morning. My flight to the jungle isn't till 2 pm [22:18:10] ejegg[m]: ok great - I'm just looking at how payum does the credentials to get some better ideas https://github.com/Payum/Payum/blob/master/docs/configure-gateway-in-backend.md - I've addressed your other comments [22:18:37] (I can put up against gerrit when you think it makes sense)