[00:00:13] PROBLEM - check_mysql on frdb1002 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) [00:07:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-2016-17-Q2-Campaign-Support: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#3373768 (AndyRussG) [00:08:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#1946773 (AndyRussG) [00:08:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, FR-2016-17-Q2-Campaign-Support: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455#2600270 (AndyRussG) [00:09:05] dstrine: filled out details on this: https://phabricator.wikimedia.org/T144455 [00:11:35] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice Out of Memory Error in Special:GlobalAllocation - https://phabricator.wikimedia.org/T55443#3373786 (AndyRussG) [00:14:03] dstrine: is there a place on the backlog board for epics _not_ in progress? I guess just unscheduled? [00:14:20] Also, opinions on closing any tasks in "Done"? [00:55:13] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 5634 Threads: 2 Questions: 81020 Slow queries: 6 Opens: 175 Flush tables: 1 Open tables: 211 Queries per second avg: 14.380 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [01:21:20] Fundraising-Backlog: GlobalCollect CC expiry errors - https://phabricator.wikimedia.org/T168698#3373878 (cwdent) [10:02:06] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add controls to purge banner content in Varnish for a specific language - https://phabricator.wikimedia.org/T168673#3374386 (Pcoombe) Thanks @AndyRussG. Yes, being able to purge a specific language other than my own would be an impor... [12:31:39] Fundraising-Backlog: GlobalCollect CC expiry errors - https://phabricator.wikimedia.org/T168698#3373878 (MBeat33) @cwd I checked the Ingenico transactions from the console for yesterday and today - I do see your attempt, 2526827708 from 2017-06-23 02:23, but their export does not show a bunch more of the nul... [13:09:14] (CR) Umherirrender: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/360674 (owner: Umherirrender) [13:13:39] (CR) Umherirrender: [C: 2] "resubmit" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353603 (owner: Ejegg) [13:14:10] (CR) Umherirrender: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [13:15:35] (Merged) jenkins-bot: Delete some unused vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353603 (owner: Ejegg) [13:15:59] (CR) jerkins-bot: [V: -1] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [13:21:19] (CR) Umherirrender: [C: 2] "Resubmit" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [13:22:57] (Merged) jenkins-bot: Guard against missing params in PP-EC return URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/353483 (owner: Ejegg) [14:29:03] Fundraising-Backlog: GlobalCollect CC expiry errors - https://phabricator.wikimedia.org/T168698#3374882 (cwdent) Open>Invalid @MBeat33 - I do indeed have javascript off. Thank you and sorry for the false alarm! [14:56:10] Wikimedia-Fundraising-Banners: Ensure fundraising banners work in right-to-left languages - https://phabricator.wikimedia.org/T165528#3374958 (Pcoombe) Open>Resolved All of the "current best" banners now have right-to-left support. [14:56:12] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Israel (Jul 5 - Aug 2) - https://phabricator.wikimedia.org/T165526#3374960 (Pcoombe) [17:00:32] fr-tech: LIBRA (Sep. 23 to Oct. 22) [17:00:32] Your desire for justice and truth will be overshadowed by your desire [17:00:32] for filthy lucre and a decent meal. Be gracious and polite. Someone [17:00:32] is watching you, so stop staring like that. [17:00:32] -- discuss. [17:01:05] dstrine: hey... lmk when you're about and have 1-2 min? thx!! :) [17:01:25] I'm on in the coffee talk but we'll be out in a few minutes [17:04:55] dstrine: ah right! K :) [17:17:18] AndyRussG ok back. Yeah I see your comments. Thanks for all that. I have a few questions 1 second... [17:18:40] AndyRussG: do you have enough information to give an estimate on the actual task for this: https://phabricator.wikimedia.org/T124969 [17:23:51] dstrine: I can think through some code details and give you an estimate on that one ^ in 5 min or so [17:24:39] dstrine: also I have a bunch of other possible tasks to suggest... Do you want to discuss in standup, or here, or should I send them someotherhow? [17:28:57] dstrine: re: fallback, it doesn't look like a lot of code, but let's call it a 4 just in case, because the logic for choosing a campaign is complex, and runs on almost every pageview on almost every single wiki, so I wouldn't want to mess up any changes there [17:29:18] Also because of the foregoing we should do unit tests [17:29:46] The campaign choosing code already has tests, so it'd be a question of adding to those [17:30:31] ok do you mind if I add your last comments to the task and changed it from a "spike" to an actual task ticket? [17:30:41] K [17:30:44] ok cool [17:30:49] I also have a few non-technical concerns [17:31:08] One actually [17:31:42] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969#3375279 (DStrine) @AndyRussG ha... [17:32:03] That it could lead to banner flood followed by banner drought, if impression diet settings for overlapping campaigns are not coordinated [17:32:03] Fundraising Sprint Jabberwock Slaying, Fundraising Sprint Killing Time, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969#3375281 (DStrine) [17:32:40] dstrine: ^ [17:32:51] I guess I should write that in the task [17:33:28] That might also make the allocation page adaptation more important--to be able to coordinate how campaigns interact for a segment of users, it's nice to be able to see them [17:36:24] AndyRussG: when you say "allocation page adaptation " to me that is a very open ended topic and probably not appropriate for right now. We'll just have to keep that in mind in the conversation on Monday. [17:36:55] if it really becomes an issue then it might mean we don't work on T124969 [17:36:55] T124969: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969 [17:38:50] dstrine: I just mean T144455 ... I don't think it'd be a blocker, but probably a "quite nice to have"... I guess stakeholders would be the ones to say :) [17:38:50] T144455: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455 [17:44:48] AndyRussG: I yeah I feel like I'd want some UI help on T144455. I'd want to graphically show the sequences of banners in some sort of tree or flowchart sort of way [17:44:49] T144455: CentralNotice banner sequence: adapt Special:BannerAllocation - https://phabricator.wikimedia.org/T144455 [17:45:02] Yeah exactly [17:45:28] I' betting that's not going to be the 2 points you have on the task [17:47:18] Mmm OK yeah... I guess the original idea of that task was to make some minor tweaks to prevent the page from showing actually wrong data, or some warnings or something, for campaigns with banner sequence [17:47:45] But then when I filled out the description, the scope blossomed [17:48:11] So maybe even a different task for the UI investigation [17:48:16] and design [17:48:41] Or, we could just do a bare-bones quick fix, as I guess we had considered before [18:03:36] Wikimedia-Fundraising-Banners, Accessibility: Examine accessibility of fundraising banners - https://phabricator.wikimedia.org/T108342#3375364 (Pcoombe) We have now added improved accessibility features to our standard desktop banners, including: - consistent focus states - all interactive elements are... [18:05:03] AndyRussG: this is a theme that has been part of a theme that has been coming up in the CN interviews. We'll definitely be including it in longer term plans. However, the allocation data has been messed up for a while. We might choose T124969 ahead of it because it actually affects users right now [18:05:03] T124969: Can we allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969 [18:06:09] I'm trying to think of thinks you might want to delve into for the rest of the day. do you want to spend any more time on clone campaign: https://phabricator.wikimedia.org/T91078 ? [18:07:25] dstrine: sure! [18:08:06] ok cool. I have a feeling it might be a tie between the fallback and clone ones [18:08:55] I'm going to run and get some lunch. see you all at standup [19:37:03] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Clone button for CN campaigns - https://phabricator.wikimedia.org/T91078#1073823 (AndyRussG) The cloned campaign should also have all the same banners already added, correct? (This isn't technically necessary, but would be required to cop... [19:41:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Clone button for CN campaigns - https://phabricator.wikimedia.org/T91078#3375629 (spatton) Sure @AndyRussG, I think it'd be fine to copy added banners along w/ the campaign settings. Awesome to see discussion around this, it'd be a big ti... [21:34:22] (PS1) Umherirrender: Use short array syntax in alias file [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/361182