[11:32:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use numeric keyboard on mobile for zip code input - https://phabricator.wikimedia.org/T169205#3390418 (Pcoombe) [11:40:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use numeric keyboard on mobile for credit card number and security code - https://phabricator.wikimedia.org/T169207#3390446 (Pcoombe) [13:23:21] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Hide 'continue' button when opening CC iframe - https://phabricator.wikimedia.org/T149366#3390691 (Pcoombe) p:Normal>High Raising priority on this, it's weird behaviour and potentially confusing for donors. [13:50:55] Wikimedia-Fundraising: Explore a membership program - https://phabricator.wikimedia.org/T85830#3390770 (Pcoombe) Open>declined Closing this, as mentioned we already hide banners for those who have recently donated and for anyone logged in. We don't have any broader plans for "membership programs", i... [13:51:45] Fundraising-Backlog, Wikimedia-Fundraising, Recurring-Donations: Make it easier to cancel recurring giving - https://phabricator.wikimedia.org/T94530#3390772 (Pcoombe) [13:52:35] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising: Special:GlobalCollectGateway without any parameters throws an internal error - https://phabricator.wikimedia.org/T42961#3390775 (Pcoombe) Open>Resolved a:Pcoombe This appears to be fixed. [14:10:30] hey ejegg! [14:10:45] hi mepps! [14:10:53] welcome back [14:10:59] thanks [14:11:03] how has it been going? [14:12:05] loose lego carpeting, huh? ouch! [14:12:17] it's been okay--i finally got all the tests passing in my local setup! [14:12:24] oh, nice! [14:12:29] but that was after going down a rabbit hole of trying to get vagrant working [14:12:50] it turned out i didn't have sqlite instlaled [14:12:53] from a glance at email, it doesn't look like there were any big emergencies to deal with [14:12:56] ahhh [14:12:57] which is why i was getting a pdo error [14:13:05] oh right, that would do it [14:13:21] yeah i didn't realize it used sqlite until i printed out the config object [14:13:48] yeah, with sqlite you can do the whole unit test with an in-memory db [14:14:09] and not really take a performance hit from using a db [14:14:40] any time I've tried to fully mock db access it gets really tedious [14:15:00] so I like this way a lot better [14:15:17] that makes sense [14:15:23] only issue is you have to make sure everyone's sharing the same PDO object [14:15:28] i'll add it to my hard way documentation [14:15:33] thanks! [14:16:07] sup ejegg [14:16:09] how was the jungle? [14:17:08] hi cwd! [14:17:13] it was pretty great [14:17:29] ejegg did you get that school set up with offline wikipedia? [14:17:48] mepps I did, but that whole setup is still pretty rough around the edges [14:18:22] I showed the local tech guy and the owner of a hostel how it works [14:18:45] but there was a national teacher strike the two days I was in town [14:19:03] including that tiny village [14:19:11] so I didn't get to show it off to them [14:19:26] oh wow yeah sounds like they had more important things going on [14:19:40] hehe, I guess they've been without a contract for a year [14:19:46] yikes! [14:19:55] but it sounds like they're going to get the raises they want [14:20:01] oh good [14:20:06] and now they'll have wikipedia :) [14:20:11] yep! [14:22:37] cwd, my thoughts are turning to smashpig deployments [14:23:18] i've got a WIP that uses a /etc config setting to specify the directory for the provider-specific configs [14:24:06] though I'm still not super-satisfied with how it looks - mepps, maybe you have some ideas how this could be improved: https://gerrit.wikimedia.org/r/359079 [14:24:16] oh hey, needs manual rebase [14:24:23] lemme do that for starters [14:25:15] (PS2) Ejegg: WIP get provider config dir from global config [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/359079 (https://phabricator.wikimedia.org/T147503) [14:42:54] hmm yeah ejegg it feels a little clunky to have pass in the global config just to get this one value [14:49:44] yeah... but i don't want the things that use smashpig as a library to have to know about the config innards [14:54:11] hmm that makes sense [14:57:29] huh, so i guess a lot of other libraries do leave the storage up to the application, and just expect to be given a config object [14:59:44] can you give me an example? [15:03:18] in mediawiki, the monolog config is part of localsettings.php [15:03:47] and there is mw code to read that and instatiate monolog configuration [15:04:35] oh, but it also can read its own config from a file [15:09:42] maybe the context object should take care of all the config instantiation? [15:10:13] that would make sense to me [15:10:30] ok, i'll see how that looks [15:11:02] in the meantime, do you want me to review anything? [15:17:10] no unfortunately most of the last week was me getting stuck and vagrant and looking at the inscrutable paypal bug :( [15:17:21] stuck on vagrant i meant [15:17:57] i was able to review some of the smashpig code though--i'm curious, the current ingenico code, is that working and is it up to date with the newest ingenico library? [15:18:05] or api i mean [15:19:30] ejegg want to do a video call to checkin? [15:20:34] mepps yep, it's working amd up to date [15:20:54] let me relocate to someplace with wifi for the video call [15:35:41] ok mepps, i'll be in -talk in a sec [15:55:08] https://gerrit.wikimedia.org/r/359213 [15:58:54] (PS4) Mepps: Send resultswitcher reloaders to TY page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359213 (https://phabricator.wikimedia.org/T167990) (owner: Ejegg) [15:59:04] (CR) Mepps: [C: 2] Send resultswitcher reloaders to TY page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359213 (https://phabricator.wikimedia.org/T167990) (owner: Ejegg) [16:01:18] (Merged) jenkins-bot: Send resultswitcher reloaders to TY page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359213 (https://phabricator.wikimedia.org/T167990) (owner: Ejegg) [16:05:46] Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising-Backlog, and 2 others: deal with duplicates in the 'invoice ID' column - https://phabricator.wikimedia.org/T166159#3391455 (mepps) [16:05:48] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Instead of failmail, record and flag duplicate donations. - https://phabricator.wikimedia.org/T167520#3391454 (mepps) Open>Resolved [16:06:16] https://phabricator.wikimedia.org/T150467 [16:07:35] https://phabricator.wikimedia.org/T163946 [16:15:21] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362231 [16:15:32] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362231 (owner: Ejegg) [16:17:51] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362231 (owner: Ejegg) [16:32:05] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 4 others: WMF rebranding, logos and font - https://phabricator.wikimedia.org/T141921#3391536 (Ejegg) Ope... [16:32:17] ejegg: hey you around? we're about to talk about the mobile form [16:54:16] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Hide 'continue' button when opening CC iframe - https://phabricator.wikimedia.org/T149366#3391641 (Ejegg) @Pcoombe and @MeganHernandez_WMF - which would you prefer when opening the iframe? - just hide the continue button - hide all the persona... [16:59:54] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Hide 'continue' button when opening CC iframe - https://phabricator.wikimedia.org/T149366#3391679 (Ejegg) Feedback from meeting: @Pcoombe : hiding all the info would be a big change to the flow @Nirzar : good first step would be just hiding the... [17:00:32] fr-tech: If it wasn't for Newton, we wouldn't have to eat bruised apples. [17:00:32] -- discuss. [17:13:27] YES, Jasper is in the office, somewhere [17:14:02] would pet [17:15:19] it's an invisible dog so far, which would look odd to pet [17:17:31] sources tell me mushroom kingom [17:21:06] awight: ^ what ejegg said [17:25:33] dstrine had better count his puppies when he leaves tonight. [17:26:26] * dstrine glares at awight [17:26:36] I can count to 1 pretty well [17:36:28] A few hairs count as a small fraction? [18:06:32] yay dstrine seddon!! congrats <3 [18:06:43] thanks for sticking with us :P [18:11:25] Fundraising-Backlog, fundraising-tech-ops: migrate fundraising.wikimedia.org off of the civicrm webserver - https://phabricator.wikimedia.org/T152106#3392023 (Jgreen) [18:12:15] Fundraising-Backlog, fundraising-tech-ops: migrate fundraising.wikimedia.org off of the civicrm webserver - https://phabricator.wikimedia.org/T152106#2838575 (Jgreen) Open>Resolved - puppet config changes completed - DNS updated - firewall ACLs and NAT updated - tested to work as intended [18:29:35] (PS11) AndyRussG: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) [18:39:18] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/362262 [18:39:22] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/362262 (owner: Ejegg) [18:47:22] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/362262 (owner: Ejegg) [18:56:33] fr-tech: deploying some smallish DonationInterface updates [18:57:56] fundraising-tech-ops, Mail, Operations: (re)move problemsdonating aliases - https://phabricator.wikimedia.org/T127488#3392245 (Jgreen) Resolved>Open p:Normal>Low The ZenDesk task is #13464, haven't heard back yet. I'll reopen this task as a reminder to clean up the privateexim entries. [18:58:13] !log updated payments-wiki from 8bdd7061a3ceb46969050c15e723b4638e762a59 to 102a5d32f2bd48e916e71c53a10f7884ceade769 [18:58:54] fundraising-tech-ops, Mail, Operations: (re)move problemsdonating aliases - https://phabricator.wikimedia.org/T127488#3392252 (Jgreen) a:Jgreen>None [19:04:35] dang, missing payment_method fields in messages. rolling back [19:05:16] !log rolled back payments-wiki to 8bdd7061a3ceb46969050c15e723b4638e762a59 [19:06:12] ejegg, hmm why did that happen? [19:06:49] has to have something to do with that queue consolidation code [19:07:01] but i thought I'd put some good tests around it :( [19:47:19] AndyRussG: meeting? [19:47:31] dstrine: aaaaahhrrrgg oops coming! [20:23:38] (PS1) Ejegg: Add tests around payments-antifraud messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 [20:25:54] (CR) jerkins-bot: [V: -1] Add tests around payments-antifraud messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 (owner: Ejegg) [20:27:25] weird [20:29:20] (PS1) Ejegg: Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362294 [20:32:02] (CR) Ejegg: [C: 2] Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362294 (owner: Ejegg) [20:32:08] (PS1) Ejegg: Send resultswitcher reloaders to TY page [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362295 (https://phabricator.wikimedia.org/T167990) [20:32:33] (Merged) jenkins-bot: Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362294 (owner: Ejegg) [20:32:45] mepps ok, that paypal session fix really does look independent of all the stuff in the failed deploy. [20:33:19] ejegg that's good, were you able to pull it out? [20:33:19] I think we're ok to just deploy that cherry-pick [20:33:36] https://gerrit.wikimedia.org/r/362295 is the standalone version [20:34:11] cool, want me to handle that? [20:34:27] oh hey, if you'd like to, please go ahead! [20:34:39] I'll just lurk in the logs [20:35:44] one difference this time: [20:36:09] mepps, since the last time I ran fundraising_code_update I specified payments-wiki=rollback [20:36:20] the revision is locked to the rollback rev [20:36:46] so to unlock it, you'll use fundraising_code_update -p payments-wiki=HEAD [20:36:54] the rest is as usual [20:37:27] (CR) Ejegg: [C: 2] Send resultswitcher reloaders to TY page [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362295 (https://phabricator.wikimedia.org/T167990) (owner: Ejegg) [20:38:34] (Merged) jenkins-bot: Send resultswitcher reloaders to TY page [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362295 (https://phabricator.wikimedia.org/T167990) (owner: Ejegg) [20:40:47] (PS1) Mepps: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/362296 [20:40:59] mepps: o/ I've started the process to cancel my YUL-JFK flight, let the road trip playlist curation begin! [20:41:17] awight--awesome!! [20:41:31] mepps - oh, I already did the cherry-pick to deployment [20:41:36] thanks for the offer, it's a beautiful drive anyway [20:43:18] ejegg ah gotcha [20:44:07] awight yeah i'm glad this worked out--john and i have been trying to figure out how to make this trip work for a while [20:44:41] carpool dummy is more often than not the correct answer. [20:46:06] ejegg running fundraising_code_update [20:46:22] cool mepps [20:47:39] ejegg i'm getting a long list of changed files--i assume that's the revert? [20:47:58] yeah [20:48:38] if you do a git diff c615ad97..f8314476c2d [20:48:44] it should be blank [20:49:09] (c615 was the previously-deployed version) [20:49:32] mepps oh wait! [20:49:50] ejegg waiting [20:50:07] need to update the DonationInterface submodule in the mediawiki repo [20:51:09] sorry, the changed files should have actually just been the cherry-picked patch, if we had updated the mediawiki pointer [20:54:09] gotcha, i'm forgetting the workflow there--is there a deployment branch for fundraising/REL1_27? [20:54:29] nope, just that fundraising/REL1_27 branch [20:56:46] dang, that's not in the deploy doc on collab! [20:56:51] is it on mw.o ? [20:57:10] and ejegg do i do a pr or jsut directly commit? [20:57:40] mepps you still need to git-review it [20:57:46] but you can self-merge [20:57:53] ooh, at least I hope you can [20:58:15] it's core, but I think all of fr-tech has C+2 access on that branch [20:58:37] huh, we have this, but it's out of date: https://www.mediawiki.org/wiki/Fundraising_tech/Deployment [20:58:49] I swear I saw the instructions on wiki someplace [20:59:55] oh wow, there's some hilariously outdated doc on officewiki, of all places: https://office.wikimedia.org/wiki/Payments_deployment [21:00:02] i'mma just nuke that [21:00:20] hehe [21:00:42] aww, "Before you even begin to *think* about deployment, make sure that your code is thoroughly tested and working. The best place to do this is on test-payments.tesla.usability.wikimedia.org." [21:01:12] haha [21:01:17] i have never heard of 3/5 of that url [21:03:44] wow yeah [21:06:24] ejegg okay now it's merging in: https://gerrit.wikimedia.org/r/#/c/362300/1 [21:07:02] looks good mepps [21:11:08] ejegg is it supposed to merge now? fundraising_code_update is still returning that long list of files [21:11:47] sorry i'm still getting used to gerrit, on github if you make a commit on a branch you can just push it with a pr and merge [21:13:41] ejegg, you available for quick video? [21:14:27] i realized i might be updating the wrong package [21:16:55] mepps sorry, yes I'm available [21:16:57] queenmary? [21:17:02] sure [21:17:28] i'm there [22:09:00] (PS3) Ejegg: Fix antifraud messages, add tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 [22:12:34] (CR) jerkins-bot: [V: -1] Fix antifraud messages, add tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 (owner: Ejegg) [22:33:42] (PS4) Ejegg: Fix antifraud messages, add tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 [22:33:44] (PS1) Ejegg: Move fraud filter config to TestConfiguration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362313 [22:55:38] have a good evening, folks!