[13:14:47] (Restored) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324066 (owner: Hashar) [13:45:00] (CR) Hashar: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/324066 (owner: Hashar) [14:15:21] (CR) Mepps: [C: 2] Move fraud filter config to TestConfiguration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362313 (owner: Ejegg) [14:17:51] (Merged) jenkins-bot: Move fraud filter config to TestConfiguration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362313 (owner: Ejegg) [14:35:53] thanks mepps! [14:38:51] ejegg looking at this file right now: https://gerrit.wikimedia.org/r/#/c/362284/4/gateway_common/gateway.adapter.php [14:39:11] why did payment_method need to be moved from keys? (just trying to understand for my own reference) [14:47:15] (CR) Mepps: [C: 2] Fix antifraud messages, add tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 (owner: Ejegg) [14:48:34] mepps i thought it was redundant to be in both places, but i guess i wasn't thinking about the usage in the fraud filters when i removed it earlier [14:49:17] now that it's back in addStandardFields, it doesn't need yo be in the other fn [14:49:28] (CR) Mepps: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 (owner: Ejegg) [14:49:44] though it wouldn't hurt to leave it [14:50:08] (Merged) jenkins-bot: Fix antifraud messages, add tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362284 (owner: Ejegg) [14:52:00] (CR) jerkins-bot: [V: -1] Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 (owner: Ejegg) [14:57:20] ejegg if i'm understanding correctly, the first function pulls the specific key into the transaction object but the second function is just to designate a status for logs? [15:08:08] mepps sendFinalStatusMessage both writes to logs and sends to the payments_init queue [15:08:36] ah okay ejegg and is the payments_init queue where the fraud filtering hapens? [15:14:19] also did you mean for these tests not to pass ejegg? https://gerrit.wikimedia.org/r/#/c/362307/ [15:19:09] payments_init is just a log of all the payment attempts [15:19:30] sorry, table [15:19:38] and payments-antifraud is a table of all the fraud scores [15:19:47] hmm, I thought I had all the tests passing [15:20:42] weird, let me see why that doesn't work in CI. Definitely passed locally [15:20:55] i hope that wasn't read as snarky by the way--i was curious if you were trying to write the test first then separately write the code to pass it! [15:21:04] :) [15:22:44] heh, no snark detected [15:23:07] the change from protected to public SHOULD have been enough to make that pass [15:23:57] but somehow it's not logging the same cURL attempts it does for me [15:24:05] oops, left in a debugging line too [15:25:23] (PS2) Ejegg: Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 [15:27:13] (CR) jerkins-bot: [V: -1] Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 (owner: Ejegg) [15:27:39] huh, let's get it to dump the log lines [15:29:02] (PS3) Ejegg: DIAGNOSTIC: Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 [15:31:44] (CR) jerkins-bot: [V: -1] DIAGNOSTIC: Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 (owner: Ejegg) [15:32:31] aha, disabled gateway! [15:32:55] oho--good catch! [15:34:27] Maybe we should just enable all of them in TestConfiguration [15:34:34] but for now, I'll just do it for that test [15:35:11] (PS4) Ejegg: Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 [15:39:19] oops, that location check needs an assert [15:40:50] (PS5) Ejegg: Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 [15:41:35] OK mepps, as long as that PS5 doesn't fail for some reason it should be ready for review [15:48:40] (PS1) Ejegg: Test cleanup - closures can use $this, fix PP test assert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362431 [15:49:45] (PS1) Ejegg: One more bit of $that = $this cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362432 [15:51:13] So, I'm not really liking the look of Context instantiating all the Configuration objects, either. [15:51:28] (CR) jerkins-bot: [V: -1] Test cleanup - closures can use $this, fix PP test assert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362431 (owner: Ejegg) [15:51:49] (CR) jerkins-bot: [V: -1] One more bit of $that = $this cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362432 (owner: Ejegg) [15:55:01] just because of all the different ways we instantiate them with overrides [16:07:12] (PS2) Ejegg: Test cleanup - closures can use $this, fix PP test assert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362431 [16:07:13] (PS2) Ejegg: One more bit of $that = $this cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362432 [16:08:33] (CR) Mepps: [C: 2] Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 (owner: Ejegg) [16:10:20] ejegg: want to jump on a call after my lunch to discuss? [16:10:30] (Merged) jenkins-bot: Fix function visibility in default getRequestProcessId [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362307 (owner: Ejegg) [16:22:17] mepps sure, sounds great! [17:00:32] fr-tech: Real Users find the one combination of bizarre input values that shuts [17:00:32] down the system for days. [17:00:32] -- discuss. [17:35:17] mepps: are you free for a meeting? [17:37:37] Yes be there in 1! [17:45:00] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface, Technical-Debt: Finish porting GlobalCollect result switcher page to use handleResultRequest - https://phabricator.wikimedia.org/T112602#3395690 (Ejegg) Open>Resolved a:Ejegg Oh hey, this is done! [17:50:11] Fundraising-Backlog, FR-Ingenico: Create script to migrate existing GlobalCollect recurring payments to Connect tokens - https://phabricator.wikimedia.org/T169357#3395697 (Ejegg) [18:04:08] Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising Sprint Kickstopper, and 3 others: break out Ingenico reintegration work - https://phabricator.wikimedia.org/T162840#3395784 (DStrine) https://etherpad.wi... [18:08:49] mepps I've gotta grab some food too. Would an hour from now be good for a video chat? [18:13:36] ejegg: yup! [18:59:20] hey ejegg we've rolled back all deploys right? i'm getting an error on the donate wiki page where it's saying it can't determine my country [18:59:52] huh but not in a private browser [18:59:58] mepps yeah, we have. What link are you using? [19:00:15] i just went to wikimediafoundation.org and clicked donate [19:00:32] huh, ok [19:00:34] let me tru [19:00:37] *try [19:00:41] weird it just stopped happening [19:01:06] okay i'm not seeing it anymore, just happened once [19:01:06] oh, donatewiki, not paymentswiki? [19:01:23] yeah i guess so [19:02:03] it has stopped happening [19:02:07] the primary thing that should set the geoIP cookie is the cache server [19:02:46] maybe because a while ago i tried going to the country=mx url? [19:03:14] the servers are using 'Varnish', which I think is an improvement over 'Squid', but I couldn't tell you the reasons [19:03:32] mepps I wouldn't think the country=mx url would mess you up [19:04:03] so, the varnish servers look up your IP address in a geolocation database and add a set-cookie header to the response [19:04:38] they may even add a faked-up cookie to the request so the server can do geolocated things [19:05:01] I think the logic on donatewiki is mostly in JS though [19:05:28] It'll take the country= param in the QS first [19:05:41] and then look for the GeoIP cookie if that doesn't exist [19:06:16] ah gotcha [19:07:11] ooh, but it would explain your problem only happening once if the logic were server side, and if varnish /isn't/ simulating a request cookie for the server [19:08:50] responsibility for donatewiki is shared between a bunch of teams [19:09:00] ahh okay [19:10:00] it's not on the payments cluster, so the foundation-wide ops team takes care of the (virtual?) hardware / OS / mediawiki install [19:10:44] it does run a couple of mediawiki extensions which fr-tech coded up long ago and have barely touched in the past year [19:11:13] but the cool stuff it does is mostly thanks to pcoombe [19:11:28] so what we handle is all the stuff after they select an amount and processor? [19:11:57] who has written a bunch of JS to show different amounts, currencies, and methods based on a lot of factors [19:12:07] oh nice [19:12:30] yeah, once they click the method on donatewiki, they bounce over to paymentswiki and fr-tech takes it from there [19:12:41] gotcha [19:13:05] donatewiki is the initial landing page for all of the email campaigns [19:14:17] and for links from the wikipedia sidebar or foundationwiki [19:14:21] some of the banners go through donatewiki, but I think these days they mostly have their own amount and currency logic so they can send the user directly to paymentswiki [19:22:18] did you want to check in ejegg? [19:22:48] oh yeah! [19:22:50] queenmary? [19:25:50] sure! [20:06:02] ejegg: mepps sorry this place totally turned into a mad house :P [20:06:26] everything is under control [20:16:53] Fundraising-Backlog: Can we add recurring information to TY email? - https://phabricator.wikimedia.org/T169364#3396006 (DStrine) [20:17:59] Fundraising-Backlog, FR-Email: Can we add recurring information to TY email? - https://phabricator.wikimedia.org/T169364#3396018 (DStrine) [20:23:36] mepps: oh hey, it still says WIP! https://gerrit.wikimedia.org/r/359079 [20:23:54] Will get rid of that title and rebase [20:24:00] ejegg okay cool [20:58:15] (PS1) Ejegg: Allow CUIT for Argentina [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362468 [20:58:54] mepps: sorry for the distraction, but ^^^ is blocking some would-be donors in Argentina, and is just changing the max digits from 10 to 11 [21:05:28] (CR) Mepps: [C: 2] Allow CUIT for Argentina [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362468 (owner: Ejegg) [21:08:29] (Merged) jenkins-bot: Allow CUIT for Argentina [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/362468 (owner: Ejegg) [21:09:24] thanks! [22:28:08] fundraising-tech-ops, Mail, Operations, Patch-For-Review, Security: Make donate.wikimedia.org SPF more strict - https://phabricator.wikimedia.org/T167704#3396400 (Reedy) [22:28:11] fundraising-tech-ops, Mail, Operations, Security: Make donate.wikimedia.org SPF more strict - https://phabricator.wikimedia.org/T167704#3341636 (Reedy) [22:45:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Integrate thank-you module with CiviCRM receipt feature - https://phabricator.wikimedia.org/T115662#3396433 (Ejegg) [22:45:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Send Receipt? check box - review and filter what info it generates, or disable - https://phabricator.wikimedia.org/T108088#3396430 (Ejegg) Open>Resolved a:Ejegg This feature has been fleshed out and the template has been updated to matc... [23:07:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Port SimpleTest modules to PHPUnit - https://phabricator.wikimedia.org/T91894#3396504 (Ejegg) Open>Resolved a:Ejegg The old ones turned out to be totally obsolete, and have been deleted [23:08:23] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure, Scrum-of-Scrums, and 2 others: Continuous integration - CiviCRM - https://phabricator.wikimedia.org/T78100#3396507 (Ejegg) [23:28:08] Wikimedia-Fundraising: Update WMF logo on email unsubscribe page - https://phabricator.wikimedia.org/T168660#3396549 (CCogdill_WMF) Open>Resolved This is done! [23:32:15] I'm going to run. have a good weekend all