[00:04:25] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [00:10:37] (PS34) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [00:17:55] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [00:23:57] (PS35) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [00:25:28] (PS36) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [00:32:17] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [00:35:05] (PS37) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [00:42:00] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [00:46:20] (PS38) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [00:54:42] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [01:09:33] (PS39) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [01:17:50] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [01:24:35] (PS40) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [01:32:31] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [01:38:31] (PS41) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [01:45:52] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [01:49:41] (PS42) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [01:57:15] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [02:19:28] (PS43) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [02:27:00] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [02:30:34] (PS44) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [02:38:20] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [02:56:22] (PS45) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [03:12:20] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [03:21:00] (PS46) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [03:32:55] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [03:36:52] (PS47) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [03:41:04] (PS1) Ejegg: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 [03:45:03] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [03:45:10] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [04:01:03] (PS48) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [04:02:31] (CR) Ejegg: "I tried to think this through a bit more and put some comments inline and on https://www.mediawiki.org/wiki/Topic:Ttw1em63qkw7vhh5" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363458 (https://phabricator.wikimedia.org/T163946) (owner: Mepps) [04:10:25] (PS2) Ejegg: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 [04:10:56] (CR) jerkins-bot: [V: -1] Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [04:14:16] (PS49) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [04:14:29] ejegg[m]: I got a pass !!! https://gerrit.wikimedia.org/r/#/c/360610/ [04:14:47] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [04:15:22] woohoo! [04:52:18] (PS50) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [06:58:41] fundraising-tech-ops, Operations: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#2987822 (Joe) This thing is alerting since 4 days as it's apparently using the default azure ssl cert. I am RADICALLY AGAINST monitoring such certificates/hosts if we're not... [13:15:29] Fundraising-Backlog, Operations, Technical-Debt: Determine if benefactorevents.wikimedia.org should be hosted on the production cluster or still on Microsoft Azure - https://phabricator.wikimedia.org/T166240#3420540 (Jgreen) [13:30:25] fundraising-tech-ops, Operations: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#3420588 (Jgreen) >>! In T156850#3419411, @Joe wrote: > This thing is alerting since 4 days as it's apparently using the default azure ssl cert. > > I am RADICALLY AGAINST mo... [14:50:51] Wikimedia-Fundraising-Campaigns (FY Q4 Apr-Jun 2017), Wikimedia-CentralNotice-Administration (Q2-2017): WMF Fundraising - 2016-17 - Latin America 1 (Jun 6 - Jul 9) - https://phabricator.wikimedia.org/T162287#3420958 (Pcoombe) Open>Resolved a:Pcoombe [15:12:17] (PS12) AndyRussG: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) [15:21:58] (CR) Ejegg: [C: 2] Add composer-merge-plugin [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364130 (owner: Eileen) [15:26:52] (Merged) jenkins-bot: Add composer-merge-plugin [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364130 (owner: Eileen) [16:03:15] hi fr-tech! [16:03:56] I'm about to deploy this DonationInterface stuff: https://gerrit.wikimedia.org/r/363972 [16:04:00] any objections? [16:04:22] or anyone else want to test it locally first? [16:04:52] fundraising-tech-ops, Operations, netops, ops-codfw: codfw: rack frack refresh equipment - https://phabricator.wikimedia.org/T169643#3421371 (Papaul) Racking and cabling in progress [16:05:16] This will re-deploy the stuff I put out on 6/28 but had to pull, along with fixes for the problems [16:05:39] fundraising-tech-ops, Operations, Patch-For-Review: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#3421372 (Dzahn) >>! In T156850#3420588, @Jgreen wrote: Trilogy shut down the site on Friday (fr-tech/fr-tech-ops didn't get advanced notice) and the ic... [16:07:24] (CR) Ejegg: [C: 2] Revert "Revert "Merge branch 'master' into deployment"" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/363971 (owner: Ejegg) [16:07:31] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/363972 (owner: Ejegg) [16:15:37] (Merged) jenkins-bot: Revert "Revert "Merge branch 'master' into deployment"" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/363971 (owner: Ejegg) [16:15:39] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/363972 (owner: Ejegg) [16:18:20] (PS13) AndyRussG: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) [16:23:00] sounds good ejegg! [16:27:40] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/364238 [16:27:53] ejegg: will you be able to join the tech priorities and standup meeting in the next hour? I have 2 topics you might want to talk about: #1 should we do another paypal test? #2 whats the status on amazon IP whitelisting? [16:29:43] dstrine: sure thing [16:38:06] hey ho fr-tech, just a good-morning-ping, I'm around if u need me :) [16:40:05] hi AndyRussG! [16:40:23] I was just about to +2 that cache purge before you dropped PS13 [16:41:01] ejegg: heh glad I got there in time, yeah just a tweak to make things cleaner for the next patch (controls for specific language purge) [16:41:18] thx.... Hopefully that'll be it for that one [16:43:38] Hmmm lemme re-smoke-test, too 8p [16:45:44] ejegg: ^ oops one sec, somethingz amiss infact [16:46:39] aaaarg [16:47:29] (CR) AndyRussG: [C: -2] "Rrrrg PS13 is borked, fixing..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [16:54:38] ejegg i've been looking at the patch you started but for some reason the tests are totally erroring out for me, always with some version of this error but in different tests: PHP Fatal error: Uncaught MWException: IngenicoFormLoadTest::tearDown() must call parent::tearDown() in /var/www/fr-tech/mediawiki_payments/tests/phpunit/MediaWikiTestCase.php:107 [16:55:04] if i try to add that back in it still errors out [16:55:08] fundraising-tech-ops, Operations, Patch-For-Review: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#3421576 (Jgreen) >>! In T156850#3421372, @Dzahn wrote: >>>! In T156850#3420588, @Jgreen wrote: >>Trilogy shut down the site on Friday (fr-tech/fr-tech-o... [16:58:29] (PS14) AndyRussG: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) [16:59:58] (CR) AndyRussG: "PS14 should be OK now... ;p" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [17:00:32] fr-tech: No excellent soul is exempt from a mixture of madness. [17:00:32] -- Aristotle [17:00:32] -- discuss. [17:00:40] mepps oh yeah, those tests are totally not going to work yet [17:00:58] I just copied all the GlobalCollect tests and did some search-n-replace [17:01:03] ahh okay [17:01:13] aspirational... [17:01:28] that 'tearDown' messages [17:01:33] *message [17:01:36] is a red herring [17:02:09] ah okay [17:02:15] phpunit will throw that when a test breaks hard (like a php fatal error) and doesn't even make it to the cleanup phase [17:03:12] popping into fr-all standup, in case anyone else wants to join in [17:08:59] fundraising-tech-ops, Operations, netops, ops-codfw: codfw: rack frack refresh equipment - https://phabricator.wikimedia.org/T169643#3421623 (ayounsi) About naming, the "issue" is that the devices are stacked, so logically seen as a single device. It happen when two stacked/clustered devices are... [17:11:34] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/364238 (owner: Ejegg) [17:16:42] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/364238 (owner: Ejegg) [17:25:12] ok, actually deploying ^^^ [17:35:29] !log updated payments-wiki from 8bdd7061a3ceb46969050c15e723b4638e762a59 to f935c06b566aa7c54c74a1e41c31c9e669eb0c9b [17:35:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:01:53] hnrrrrrggggg [18:02:25] The background call to purge banner from the front-end cache should be handled by an API call, not the same special page that the controls are on [18:02:43] * AndyRussG 's head and wall clash [18:03:05] where has my brain gone? [18:22:27] ejegg: ^ before I delve in, got an opinion on this one? I feel silly that I didn't think of it before... The patch to purge Varnish via controls (not yet in Gerrit) currently makes a background call to the same special page, to request the purge. But really it should be an API module. This makes sense, yes? Thx in advance [18:22:31] fundraising-tech-ops, Operations, Patch-For-Review: set up SSL cert monitoring for benefactorevents.wm.o - https://phabricator.wikimedia.org/T156850#3422035 (Dzahn) >>! In T156850#3421576, @Jgreen wrote: > I just assumed I didn't get notified because fr-tech-ops wasn't included in the notification co... [18:31:18] AndyRussG: yeah, if something's being done via an AJAX call it should be available via API. But you've already put most of the logic into the cacheUpdate class, so it shouldn't be too crazy to add an API call in the following patch, right? [18:31:38] the current patch looks great for doing the cache clear on save [18:33:46] AndyRussG: were you thinking of changing the patch that's up now? [18:35:30] ejegg: no, the patch that's up now is good [18:35:55] I was just about to send up the one that adds special controls to the banner edit page so you can click to purge for the lang of ur choice [18:36:04] That's the one that does the background call [18:36:30] And I made it call Special:CentralNoticeBanners/purgecdn/BannerName in the background [18:36:33] silly me [18:36:48] Yeah it'll be fast to API-ize.... [18:36:51] thx!!!!! :) [18:39:14] ah, cool! [18:41:08] Great example of how tech-talking through a design, even a simple one, can save time, I guess [18:47:47] Fundraising-Backlog: SQL challenge: Mailing and donation data - https://phabricator.wikimedia.org/T169591#3422193 (Ejegg) So this oughtta work for tier 1: ```lang=sql SELECT COUNT(DISTINCT m.contact_id) FROM civicrm_mailing_provider_data m LEFT JOIN civicrm_mailing_provider_data m1 ON m1.email = m.email AN... [18:49:38] ejegg what php version does this ci server: https://integration.wikimedia.org/ci/job/mwext-donationinterfacecore-REL1_27-zend56-jessie/8/console use? is it 5.6? i'm trying to get the same error messages locally instead of the tearDown() error but on 5.6 the tests won't even run for me [18:52:15] mepps yep, it's 5.6 [18:52:17] https://integration.wikimedia.org/ci/job/mwext-donationinterfacecore-REL1_27-zend56-jessie/8/consoleFull [18:52:31] at the top of the full console log it shows the php version [18:53:18] ooh, same error for almost all tests, lemme just add that one variable [18:55:55] (PS15) Ejegg: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [18:56:01] (CR) Ejegg: [C: 2] "This looks great! Reusable cache clear for the next task, and well-documented linkage between the two functions that need to coordinate" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [18:56:28] i get this on 5.6: PHP Fatal error: Class 'Wikimedia\TestingAccessWrapper' not found [18:56:36] yeah i just added and couldn't test if it worked [18:57:46] mepps oh, that TestingAccessWrapper is coming in via composer now [18:57:50] (CR) jerkins-bot: [V: -1] Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [18:58:04] probably just need to composer install [18:58:06] (Merged) jenkins-bot: Purge banner content from front-end cache on banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/336237 (https://phabricator.wikimedia.org/T154954) (owner: AndyRussG) [18:58:12] (without the --no-dev option) [18:58:22] Erk - what just happened there? [18:59:01] oh, it's that sill qunit failure [18:59:37] randomly happens due to the randomized cleanup, I think [18:59:49] do you know about this warning? Warning: Ambiguous class resolution, "SmashPig\PaymentProviders\Adyen\WSDL\Type" was found in both "/var/www/fr-tech/mediawiki_payments/extensions/DonationInterface/vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Notification.php" and "/var/www/fr-tech/mediawiki_payments/extensions/DonationInterface/vendor/wikimedia/smash-pig/PaymentProviders/Adyen/WSDL/Payment.php", [18:59:49] the first will be used. [19:01:13] nothing to worry about [19:01:31] that dang SOAP stuff is using some generated code [19:01:38] which generates the same class in two places [19:01:47] but it doesn't matter which gets used [19:04:46] (PS3) Ejegg: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 [19:04:59] OK, ^^^ at least gets some more interesting test failures [19:05:10] Oh, right... how are you running the tests locally? [19:06:27] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [19:17:09] ejegg now i'm getting the same errors as the ci server--progress! [19:40:23] fundraising-tech-ops: un-integrate Trilogy events management service - https://phabricator.wikimedia.org/T170191#3422422 (Jgreen) [19:42:00] fundraising-tech-ops, Operations: remove eventdonations.wikimedia.org CNAME - https://phabricator.wikimedia.org/T170192#3422435 (Jgreen) [19:45:20] nice~ [19:45:21] ! [19:49:48] fundraising-tech-ops, Operations: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3422468 (Jgreen) [20:20:56] Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3422568 (Ejegg) Hi @CCogdill_WMF, There are a couple of things blocking us from using tracking pixels in the TY emails: # we can't use tracking pixels on ANY civi emails because the... [20:25:02] mepps: so would it make sense to call the hosted payment method with an array after all? [20:25:45] that makes sense to me ejegg! [20:25:49] Cool! [20:25:56] Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3422611 (CCogdill_WMF) Hey @Ejegg that makes sense, thanks. Do we get any deliverability stats, like unsubscribes or mail blocks? [20:26:15] I'll update that patch to do the var_map stuff on the DonationInterface side [20:26:23] ejegg i'm working on adding to your gerrit patch to get tests passing, just making sure you're not also working on this [20:26:24] the logic is all there in buildNameValueString [20:26:51] oh sure, if you'd like to do that work, please go ahead! [20:27:14] i can share what I was planning to do for the var_map stuff if you want [20:28:02] that would be great--i haven't gotten far but i figured this was good for both my learning of the code base [20:28:09] cool! [20:28:23] Ah, the function is called 'buildRequestNameValueString' [20:29:47] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/4c4fdbe6056228b7e77ccd381516fa9794858a85/gateway_common/gateway.adapter.php#L744 [20:30:02] mepps so I was just going to break that into two functions [20:30:34] moving all but the http_build_query into a buildRequestArray or something [20:31:01] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3422630 (Peachey88) [20:31:12] fundraising-tech-ops, Domains, Operations, Traffic: remove eventdonations.wikimedia.org CNAME - https://phabricator.wikimedia.org/T170192#3422631 (Peachey88) [20:31:33] then change the new adapter's getCommunicationType to return 'array' [20:31:44] that makes sense [20:32:17] and add a new case here: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/4c4fdbe6056228b7e77ccd381516fa9794858a85/gateway_common/gateway.adapter.php#L1007 [20:32:22] you mean getTransactionRequestStructure()? [20:32:46] mepps: ah, nope, I was going to leave that alone [20:32:56] and just add the structure the way the other adapters do [20:33:01] in defineTransactions [20:33:12] The last PS had it returning an empty array [20:33:38] but if you add a 'request' element with an array of the fields you need [20:34:10] and add the fields to var_map, the buildRequestArray function should do the field name mapping for you [20:34:40] oops, late for K4 [20:35:10] okay [20:35:24] orr, maybe she's not 1:1-ing today after all [20:36:40] Hmm, some of those tests are definitely not applicable to the new adapter [20:36:52] all that buildRequestXML stuff [20:39:27] i'm starting with just creating the classes needed to get the tests running and then i'll look at this other stuff tomorrow, or i can commit the classes i create (just copying global collect for now) and you can keep working on it tonight then hand off tomorrow depending on your preference ejegg [20:40:06] mepps I'd be happy to do the relay race if you want to check in your progress and any instructions at end of day! [20:40:50] awesome! today won't be crazy productive because of the test issues but i like the idea of working this way on this! [20:41:04] me too :) [20:44:10] oh hmm, I just realized that adding the new things to var_map might mean the new adapter needs a little more independence from its parent class [20:45:05] if you want to make it use its own config directory instead of the one in globalcollect_adapter, you can just override the getBasedir function [20:45:17] fundraising-tech-ops: un-integrate Trilogy events management service - https://phabricator.wikimedia.org/T170191#3422717 (Jgreen) [20:45:38] it's actually a cut-n-paste override, but it includes the magic code-file-relative __DIR__ [20:45:56] then add a config directory [20:45:57] (PS1) Eileen: CRM-20759 enable Primary as an import location type. Upstream Prs https://github.com/civicrm/civicrm-core/pull/10594 https://github.com/civicrm/civicrm-core/pull/10565 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364311 [20:46:27] and copy (or symlink!) everything from globalcollect_gateway/config except for var_map.yaml [20:46:56] I just pushed up the patch ^^ to help wtih Leanne's import by allowing her to choose to import to 'primary' address - this is now merged upstream [20:47:51] (PS2) Eileen: CRM-20759 enable Primary as an import location type. Upstream Prs https://github.com/civicrm/civicrm-core/pull/10594 https://github.com/civicrm/civicrm-core/pull/10565 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364311 (https://phabricator.wikimedia.org/T169025) [20:48:01] mepps comments about var_map above ^^^ [20:53:38] ejegg do i do a separate commit on top of yours? not sure how git commit --amend works here with git review [20:54:51] if you want a separate commit just don't include the --amend [20:55:08] no worries on how the stuff looks for now, we can always squash it later [20:56:03] gerrit distinguishes one Change from another by Change-Id [21:01:40] (PS4) Mepps: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [21:02:41] ejegg, cool i just amended for simplicity--see above ^^ let me know where you get and i'll try to pick it up tomorrow! new errors now! [21:02:53] so our thanks! [21:03:00] derp [21:03:02] thanks! [21:03:54] ...i don't ususally refer to myself with the royal 'we', I swear [21:09:31] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [22:23:04] (PS5) Ejegg: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 [22:24:47] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [22:40:51] gotta afk a bit [23:15:19] (PS1) Ejegg: buildRequestArray handles recursion, used for name/value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 [23:15:57] (PS6) Ejegg: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 [23:16:44] (CR) jerkins-bot: [V: -1] buildRequestArray handles recursion, used for name/value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 (owner: Ejegg) [23:17:30] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [23:18:26] hmm? [23:21:06] (PS2) Ejegg: buildRequestArray handles recursion, used for name/value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 [23:22:28] (CR) jerkins-bot: [V: -1] buildRequestArray handles recursion, used for name/value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 (owner: Ejegg) [23:24:37] (PS3) Ejegg: buildRequestArray handles recursion, used for name/value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 [23:54:02] (PS7) Ejegg: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 [23:54:42] (PS1) Ejegg: base ingenico test case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364345 [23:55:55] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [23:57:26] (CR) jerkins-bot: [V: -1] base ingenico test case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364345 (owner: Ejegg)