[00:06:49] (CR) Ejegg: "So, we can make this really simple for now, and leave all the staging, var_map and array structure building in DonationInterface." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363458 (https://phabricator.wikimedia.org/T163946) (owner: Mepps) [01:06:34] PROBLEM - check_minfraud_secondary on payments1004 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [01:06:36] PROBLEM - check_minfraud_secondary on payments1002 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [01:10:14] RECOVERY - check_minfraud_secondary on payments1002 is OK: HTTP OK: Status line output matched 200,301,302 - 385 bytes in 0.271 second response time [01:10:15] RECOVERY - check_minfraud_secondary on payments1004 is OK: HTTP OK: Status line output matched 200,301,302 - 385 bytes in 0.247 second response time [04:28:31] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: New GeoIP service endpoint that returns JSON, not JSONP - https://phabricator.wikimedia.org/T134845#3423652 (Krinkle) Open>declined Closing, as this task seems obsolete. See also: * {T100902} * {T143271} * {58fd6c3135387538fd17eae1ee27240b... [04:30:36] (PS1) Eileen: Do not add id if the field does not exist [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364362 [04:30:56] (CR) jerkins-bot: [V: -1] Do not add id if the field does not exist [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364362 (owner: Eileen) [04:33:37] Fundraising-Backlog, Wikimedia-Site-requests, Easy: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#3423658 (Krinkle) Per @Reedy, the reason the global isn't set is because CentralNotice is disabled on `fishbowl` wikis by default (which wikimediafoundat... [04:35:35] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 8 others: Get CI working on Omnimail - https://phabricator.wikimedia.org/T169593#3402888 (Eileenmcnaughton) [04:35:38] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 8 others: Get CRM CI php version the same as live - https://phabricator.wikimedia.org/T169806#3423665 (Eilee... [04:35:40] Fundraising-Backlog, Easy: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#3423668 (Krinkle) [04:36:00] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3142140 (Eileenmcnaughton) [04:36:02] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 4 others: Add index 'name' to civicrm_campaign table - https://phabricator.wikimedia.org/T168499#3423669 (Eileenmcnaughton) Open>Resolved [04:36:31] Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, and 7 others: Excluded vendor directory from lint tests when it... - https://phabricator.wikimedia.org/T168597#3369431 [04:38:30] (PS2) Eileen: Do not add id if the field does not exist [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364362 [04:39:34] (PS1) Eileen: Omnimail, enable view tab into mailing events. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364363 [04:43:53] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3423675 (Eileenmcnaughton) @CCogdill_WMF I managed not to s... [04:58:25] (CR) jerkins-bot: [V: -1] Omnimail, enable view tab into mailing events. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364363 (owner: Eileen) [10:39:17] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Brazil (1 August - 29 August) - https://phabricator.wikimedia.org/T170252#3424389 (Pcoombe) [10:41:53] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Malaysia (8 August - 5 September) - https://phabricator.wikimedia.org/T170253#3424405 (Pcoombe) [10:57:47] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - South Africa (8 August - 5 September) - https://phabricator.wikimedia.org/T170254#3424440 (Pcoombe) [11:00:10] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Japan (5 September - 3 October) - https://phabricator.wikimedia.org/T170255#3424463 (Pcoombe) [11:01:27] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-Paypal, Epic: Paypal Express checkout campaign ready - https://phabricator.wikimedia.org/T131817#3424487 (Pcoombe) [11:01:29] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Japan (5 September - 3 October) - https://phabricator.wikimedia.org/T170255#3424486 (Pcoombe) [11:03:21] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Belgium (19 September - 17 October) - https://phabricator.wikimedia.org/T170256#3424499 (Pcoombe) [11:03:38] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Israel (Jul 5 - Aug 2) - https://phabricator.wikimedia.org/T165526#3424513 (Pcoombe) a:Pcoombe [11:03:45] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Ukraine (Jul 18 - Aug 15) - https://phabricator.wikimedia.org/T169092#3424514 (Pcoombe) a:Pcoombe [11:04:06] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Ukraine (Jul 18 - Aug 15) - https://phabricator.wikimedia.org/T169092#3386857 (Pcoombe) a:Pcoombe>None [11:04:09] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Portugal (Jul 18 - Aug 15) - https://phabricator.wikimedia.org/T169093#3424517 (Pcoombe) a:Pcoombe [11:04:11] Wikimedia-Fundraising-Campaigns (FY Q1 Jul-Sep 2017), Wikimedia-CentralNotice-Administration (Q3-2017): WMF Fundraising 2017-18 - Ukraine (Jul 18 - Aug 15) - https://phabricator.wikimedia.org/T169092#3386857 (Pcoombe) a:Pcoombe [11:14:20] Wikimedia-Fundraising-Campaigns (FY Q2 Oct-Dec 2017), Wikimedia-CentralNotice-Administration (Q4-2017): WMF Fundraising 2017-18 - France (dates tbc) - https://phabricator.wikimedia.org/T170259#3424573 (Pcoombe) [11:18:03] Wikimedia-Fundraising-Campaigns (FY Q2 Oct-Dec 2017), Wikimedia-CentralNotice-Administration (Q4-2017): WMF Fundraising 2017-18 - Big English - https://phabricator.wikimedia.org/T170260#3424592 (Pcoombe) [11:20:22] Wikimedia-Fundraising-Campaigns: Fundraise in Ukraine - https://phabricator.wikimedia.org/T94285#3424613 (Pcoombe) Open>Resolved a:Pcoombe Closing, we do this now (although using Adyen for credit card) [12:25:36] Fundraising-Backlog, FR-Amazon, Recurring-Donations, Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#3424726 (Pcoombe) [12:25:59] Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising-Backlog, FR-Amazon: Parse Amazon last name data differently (or: review the way we receive Amazon name data) - https://phabricator.wikimedia.org/T86720#3424727 (Pcoombe) [12:30:03] Wikimedia-Fundraising-Campaigns: Fundraise in Japan - https://phabricator.wikimedia.org/T116072#3424736 (Pcoombe) Open>Resolved a:Pcoombe Closing this since we do Japan already. If there's a desire to expand Amazon to other countries including Japan, that should probably be its own task. [13:58:44] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3425017 (CCogdill_WMF) @Eileenmcnaughton I think the only o... [14:05:06] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 9 minutes ago with 3 failures. Failed resources (up to 3 shown): File[/usr/local/bin/risky_package_updater],File[/usr/lib/nagios/plugins/check_ssl],File[/usr/lib/nagios/plugins/check_puppetrun_sudo] [14:10:15] RECOVERY - check_puppetrun on americium is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [14:12:06] (CR) Mepps: [C: 2] Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [14:13:36] (CR) Mepps: [C: 2] "Nice tests!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 (owner: Ejegg) [14:13:57] (Merged) jenkins-bot: Use new SmashPig global/provider configuration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/355872 (owner: Ejegg) [14:15:26] (Merged) jenkins-bot: buildRequestArray handles recursion, used for name/value [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364339 (owner: Ejegg) [14:56:23] thanks for the CR meppsODODODODODOD, [14:56:27] ??? [14:56:59] have some keycodes! [15:09:38] anyway... does the direction I was going in yesterday seem sensible? [15:10:28] it is pretty close to just building the adapter in DonationInterface [15:11:17] and means we do things like defining the transaction structures twice [15:12:16] well, once now, and again later when we finally push all that stuff down to SmashPig [15:14:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Import email-only contacts from 'remind me later' links into CiviCRM - https://phabricator.wikimedia.org/T160949#3425322 (CCogdill_WMF) @Eileenmcnaughton hmm, those don't look right. I slightly modified the query by adding another paramete... [16:03:18] hey ejegg i just saw these posts--because of the extra key strokes i wasn't notified! [16:03:42] yeah i think so re:direction, currently integrating the new config structure [16:06:39] ah, cool [16:06:56] integrating it where? [16:09:21] mepps oh man, I just spent 15 minutes trying to reinstall my unit testing civi db and wondering why my credentials didn't work :P [16:09:27] * ejegg pulls down mepps's fix [16:09:44] ahhh [16:09:53] ejegg into your wip patch [16:10:23] ah cool, right on! [16:10:57] (CR) Ejegg: [C: 2] Add null port to fix install requirements [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/363717 (owner: Mepps) [16:11:00] ejegg spent 15 minutes wondering why my test failures were different from the ci server again though before i was like, oh...because i merged in this new config patch [16:11:15] so working on that :) [16:11:37] hehheh, yep, that would do it! [16:12:55] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425597 (RobH) If the old certificate was not compromised, it is a lot cleaner to simply let it expire. Revokcation, as I understanding... [16:15:29] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425617 (BBlack) I think in this case we should revoke unless the expiry is already very close (it might be!). This is private key that... [16:16:47] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425630 (BBlack) Ah I missed the part above where it stated that it expired in a week or two. In that case, there's little point for this... [16:17:37] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3422468 (faidon) Looks like it expires in September: ``` Validity Not Before: Jul 18 18:16:03 2016 GMT No... [16:19:21] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425657 (RobH) I only advised against revokcation since that was my understanding from @bblack, I'm not trying to block this. In fact, I... [16:22:00] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425669 (RobH) a:RobH Chatted in irc, I'll revoke this shortly. [16:23:58] fundraising-tech-ops: un-integrate Trilogy events management service - https://phabricator.wikimedia.org/T170191#3425703 (Jgreen) [16:24:35] (Merged) jenkins-bot: Add null port to fix install requirements [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/363717 (owner: Mepps) [16:28:20] fundraising-tech-ops, Domains, Operations, Traffic, Patch-For-Review: remove eventdonations.wikimedia.org CNAME - https://phabricator.wikimedia.org/T170192#3425724 (RobH) [16:28:24] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425722 (RobH) Open>stalled Certificate Status: Revoke Processing on Globalsign's systems. I'm going to move this to stalled, a... [16:28:41] fundraising-tech-ops, Domains, Operations, Traffic: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425727 (RobH) p:Triage>Normal [16:33:26] fundraising-tech-ops: un-integrate Trilogy events management service - https://phabricator.wikimedia.org/T170191#3425771 (RobH) [16:33:30] fundraising-tech-ops, Domains, Operations, Traffic, Patch-For-Review: remove eventdonations.wikimedia.org CNAME - https://phabricator.wikimedia.org/T170192#3425768 (RobH) Open>Resolved a:RobH dns removed [16:47:09] fundraising-tech-ops, Domains, Operations, Traffic, Patch-For-Review: remove eventdonations.wikimedia.org CNAME - https://phabricator.wikimedia.org/T170192#3425918 (RobH) [16:47:12] fundraising-tech-ops, Domains, Operations, Traffic, Patch-For-Review: revoke eventdonations.wikimedia.org SSL cert if there is one... - https://phabricator.wikimedia.org/T170193#3425916 (RobH) stalled>Resolved Revocation Request Completed for eventdonations.wikimedia.org [17:03:36] fundraising-tech-ops: un-integrate Trilogy events management service - https://phabricator.wikimedia.org/T170191#3425992 (Dzahn) [17:04:25] fundraising-tech-ops, DNS, Operations, Traffic: remove benefactorevents.wikimedia.org cname from DNS - https://phabricator.wikimedia.org/T170295#3425995 (Jgreen) [17:05:25] fundraising-tech-ops: un-integrate Trilogy events management service - https://phabricator.wikimedia.org/T170191#3422422 (Jgreen) [17:05:28] fundraising-tech-ops, DNS, Operations, Traffic: remove benefactorevents.wikimedia.org cname from DNS - https://phabricator.wikimedia.org/T170295#3426010 (Jgreen) Open>Resolved p:Triage>Normal a:RobH [17:06:38] (PS8) Mepps: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [17:12:24] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [17:12:45] fundraising-tech-ops, Operations, netops, ops-codfw: codfw: rack frack refresh equipment - https://phabricator.wikimedia.org/T169643#3426077 (Papaul) Racking complete [17:23:01] (PS9) Mepps: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [17:23:18] ejegg tests no longer error out! [17:23:51] now we can start figuring out which ones should be skipped [17:24:38] oh except i see your note about the test adapter, i [17:24:41] ll work on that [17:24:50] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [17:25:05] whoa! [17:25:29] mepps oh, mocking the smashpig library stiuff? [17:26:01] ejegg yeah looking at this right now: https://gerrit.wikimedia.org/r/#/c/364345/1/tests/phpunit/BaseIngenicoTestCase.php [17:28:25] oh right [17:28:39] I think we need the class defined in order to mock it [17:29:10] maybe a good time to work on the SmashPig patch? [17:30:03] with its reduced responsibilities, I bet we could get that done pretty quick [17:33:32] sure, want to hop on a video call in 15 to discuss? [17:35:57] sure, sounds good [17:46:22] (PS2) Mepps: base ingenico test case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364345 (owner: Ejegg) [17:46:29] (CR) Mepps: [C: 2] base ingenico test case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364345 (owner: Ejegg) [17:48:19] (CR) jerkins-bot: [V: -1] base ingenico test case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364345 (owner: Ejegg) [17:52:36] ejegg umm does this make no sense to you: https://integration.wikimedia.org/ci/job/mwext-donationinterfacecore-REL1_27-zend56-jessie/22/console is it because the topic is ingenico that it has the wip code in there? [17:53:11] also i'm ready when you are [17:54:10] ok, hopping in the hangout [17:55:34] mepps it's 'cause the commit that was submitted has the other ingenico stuff as a parent [18:10:52] mepps I think I'll deploy the latest DonationInterface code, just so's we don't deploy much else along with the big SmashPig update [18:29:41] ejegg sounds good [18:33:03] hmm,getting a little bit of logspam with the smashpig initialization in the registerExtension method [18:33:24] I guess that's called on every request, not just the ones where we need to use SmashPig [18:33:49] Not a big deal for right now, but maybe I'll change that [18:34:16] so it only initializes SmashPig at the three entry points which currently set the provider config [18:35:26] (CR) Ejegg: "This is looking great so far! I'll just test it a bit more locally." (10 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [18:38:42] (PS1) Ejegg: Update SmashPig for split configuration [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/364492 [18:39:01] (CR) Ejegg: [C: 2] Update SmashPig for split configuration [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/364492 (owner: Ejegg) [18:44:38] (CR) Ejegg: [V: 2 C: 2] Update SmashPig for split configuration [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/364492 (owner: Ejegg) [18:47:07] (PS10) Mepps: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [18:48:15] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [18:52:31] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/364495 [18:52:54] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/364495 (owner: Ejegg) [18:53:52] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/364495 (owner: Ejegg) [19:03:19] (PS11) Mepps: WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [19:05:05] (CR) jerkins-bot: [V: -1] WIP Ingenico gateway mimics GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (owner: Ejegg) [19:05:28] Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3426634 (Ejegg) @CCogdill_WMF we should be getting bounce statistics when we have 'create CiviMail records' activated. When we create a CiviMail record for a thank you email, we also... [19:07:05] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/364498 [19:08:36] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/364498 (owner: Ejegg) [19:08:49] Fundraising-Backlog: Can we A/B test the TY email & get access to TY email stats? - https://phabricator.wikimedia.org/T166135#3426644 (CCogdill_WMF) Makes sense. If I wanted insight into blocks or unsubscribes from the TY email over time, could I access that data? Also, re: TY unsubscribes, see Michael's la... [19:13:48] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/364498 (owner: Ejegg) [19:14:53] (PS2) Mepps: WIP: Implement HostedCheckout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363458 (https://phabricator.wikimedia.org/T163946) [19:15:46] (CR) jerkins-bot: [V: -1] WIP: Implement HostedCheckout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363458 (https://phabricator.wikimedia.org/T163946) (owner: Mepps) [19:17:02] !log updated payments-wiki from f935c06b566aa7c54c74a1e41c31c9e669eb0c9b to bdc52265d78c55cfc6a732f14519f5f79c9d2d94 [19:17:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:21:00] mepps sorry I lost track of time! [19:21:02] ejegg: mepps: are we doing grooming sans dstrine? [19:21:06] want to do 10 minutes of pairing? [19:21:17] AndyRussG: sure, I bet we can knock out the backlog column [19:21:22] K [19:21:25] ejegg sure! [19:21:44] i'm in queenmary [19:37:40] (PS3) Mepps: WIP: Implement HostedCheckout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363458 (https://phabricator.wikimedia.org/T163946) [19:38:29] (CR) jerkins-bot: [V: -1] WIP: Implement HostedCheckout [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363458 (https://phabricator.wikimedia.org/T163946) (owner: Mepps) [19:40:34] Fundraising-Backlog: Add phpcs to FundraisingEmailUnsubscribe - https://phabricator.wikimedia.org/T170311#3426840 (Umherirrender) [19:41:19] Fundraising Sprint Loose Lego Carpeting, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Restore all of the Saved Field Mappings list to Civi - https://phabricator.wikimedia.org/T169886#3411577 (Ejegg) Open>Resolved a:Ejegg Thanks for noticing this @MBeat33 ! It... [19:46:26] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Inconsistent order of payment field errors - https://phabricator.wikimedia.org/T169797#3426913 (Ejegg) We should definitely do something about this! It might be part of getting the whole form template away from table layout. fr-tech would defi... [19:49:27] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, Accessibility: Labels for payments form fields - https://phabricator.wikimedia.org/T169795#3408809 (Ejegg) p:Normal>High [19:50:08] Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog: SQL challenge: Mailing and donation data - https://phabricator.wikimedia.org/T169591#3426949 (Ejegg) @CCogdill_WMF do those queries get the answers you want? [19:54:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Silverpop db should know about donations as soon as possible. - https://phabricator.wikimedia.org/T169583#3426965 (Ejegg) p:Triage>Normal [19:56:53] Fundraising-Backlog, FR-Email: Can we add recurring information to TY email? - https://phabricator.wikimedia.org/T169364#3426986 (Ejegg) As discussed in standup: The difficulty with repeat donors is that we don't de-duplicate before sending the TY letter. There's a ticket someplace to pass the contact ID... [19:59:32] Fundraising-Backlog, FR-Ingenico: Create script to migrate existing GlobalCollect recurring payments to Connect tokens - https://phabricator.wikimedia.org/T169357#3426998 (Ejegg) p:Triage>Normal [20:01:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use numeric keyboard on mobile for credit card number and security code - https://phabricator.wikimedia.org/T169207#3427023 (Ejegg) Definitely would be an improvement! Unfortunately not something we can do, even for the processors who let us in... [20:04:05] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use numeric keyboard on mobile for zip code input - https://phabricator.wikimedia.org/T169205#3427053 (Ejegg) p:Triage>Normal We're doing country-dependent validation for LatAm fiscal numbers now, so we've got the groundwork in place. [20:15:29] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320#3427168 (Jgreen) [20:17:57] fundraising-tech-ops: encrypt fundraising mysql client->server communication - https://phabricator.wikimedia.org/T170321#3427197 (Jgreen) [20:18:09] Fundraising-Analysis, Fundraising-Backlog: error when running rsync - https://phabricator.wikimedia.org/T169028#3427212 (Ejegg) We've got code to generate the file in a different directory now, but I can't delete the existing one. @cwdent can you delete this file on the Civi server? [20:20:03] https://www.catedraldesal.gov.co/ [20:21:29] fundraising-tech-ops: encrypt fundraising redis communications - https://phabricator.wikimedia.org/T170323#3427252 (Jgreen) [20:24:50] fundraising-tech-ops: encrypt email traffic between fundraising servers - https://phabricator.wikimedia.org/T170324#3427277 (Jgreen) [20:29:37] fundraising-tech-ops: encrypt fundraising nfs traffic - https://phabricator.wikimedia.org/T170326#3427330 (Jgreen) [20:34:20] fundraising-tech-ops: (re)establish offsite backups for fundraising - https://phabricator.wikimedia.org/T170327#3427354 (Jgreen) [20:36:21] fundraising-tech-ops: encrypt fundraising backups stored on logger/backup machines - https://phabricator.wikimedia.org/T170328#3427376 (Jgreen) [20:38:42] fundraising-tech-ops: (re)establish offsite backups for fundraising - https://phabricator.wikimedia.org/T170327#3427455 (Jgreen) [20:38:44] fundraising-tech-ops: encrypt fundraising backups stored on logger/backup machines - https://phabricator.wikimedia.org/T170328#3427454 (Jgreen) [20:38:46] fundraising-tech-ops: encrypt email traffic between fundraising servers - https://phabricator.wikimedia.org/T170324#3427457 (Jgreen) [20:38:48] fundraising-tech-ops: encrypt fundraising nfs traffic - https://phabricator.wikimedia.org/T170326#3427456 (Jgreen) [20:38:50] fundraising-tech-ops: encrypt fundraising redis communications - https://phabricator.wikimedia.org/T170323#3427458 (Jgreen) [20:38:52] fundraising-tech-ops: encrypt fundraising mysql client->server communication - https://phabricator.wikimedia.org/T170321#3427459 (Jgreen) [20:38:54] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320#3427460 (Jgreen) [20:40:34] (PS1) Ejegg: Some notes on pushing gateway classes down to SmashPig [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364531 [20:45:57] (PS3) Ejegg: Allow getRequiredFields before unstagedData is set [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323254 (https://phabricator.wikimedia.org/T151411) [20:47:39] (PS4) Ejegg: Log client-side errors on payments forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259795 (https://phabricator.wikimedia.org/T121800) [20:52:42] Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#3427612 (Jgreen) [20:53:03] Fundraising-Backlog, fundraising-tech-ops: Adjust modsecurity rules to work for us - https://phabricator.wikimedia.org/T110227#1572640 (Jgreen) a:Jgreen>None [20:53:53] fundraising-tech-ops, monitoring: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#3427624 (Jgreen) a:Jgreen>None [20:54:24] fundraising-tech-ops: encrypt fundraising kafka collector traffic - https://phabricator.wikimedia.org/T142993#3427628 (Jgreen) [21:02:05] (PS6) Ejegg: Better message when geoIP lookup fails [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/323242 (https://phabricator.wikimedia.org/T151411) [21:03:21] Fundraising-Backlog, Operations, Technical-Debt: Determine if benefactorevents.wikimedia.org should be hosted on the production cluster or still on Microsoft Azure - https://phabricator.wikimedia.org/T166240#3427675 (Jgreen) Open>Resolved a:Jgreen Closing this task because we are no longe... [21:05:13] Fundraising-Analysis, Fundraising-Backlog: error when running rsync - https://phabricator.wikimedia.org/T169028#3427704 (cwdent) Open>Resolved a:cwdent Deleted [21:05:30] fundraising-tech-ops: encrypt fundraising kafka collector traffic - https://phabricator.wikimedia.org/T142993#3427707 (Jgreen) a:Jgreen>None [21:05:43] Fundraising-Backlog, Operations, Technical-Debt: Determine if benefactorevents.wikimedia.org should be hosted on the production cluster or still on Microsoft Azure - https://phabricator.wikimedia.org/T166240#3427711 (Dereckson) Thanks for the update. [21:07:43] fundraising-tech-ops: fix freeradius vs libpam-yubico too many open files bug - https://phabricator.wikimedia.org/T148863#3427720 (Jgreen) a:Jgreen>None [21:11:45] fundraising-tech-ops: fix fundraising_code_update process-control git revision reporting bug - https://phabricator.wikimedia.org/T170341#3427730 (Jgreen) [21:12:20] (PS7) Ejegg: WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 [21:14:01] (CR) jerkins-bot: [V: -1] WIP fraud points for email address at nonexistant tld [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/290615 (owner: Ejegg) [21:15:01] fundraising-tech-ops: fix aiderator bug around initializing a new host - https://phabricator.wikimedia.org/T170342#3427747 (Jgreen) [21:16:37] fundraising-tech-ops: fix frack puppet's motd adjuster for jessie hosts - https://phabricator.wikimedia.org/T170343#3427763 (Jgreen) [21:17:56] (PS51) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [21:18:11] (PS2) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [21:18:37] (Abandoned) Ejegg: Mark some more deprecated donationData fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/354267 (owner: Ejegg) [21:19:54] (CR) jerkins-bot: [V: -1] WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) (owner: Ejegg) [21:21:06] (PS52) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [21:31:39] (PS53) Eileen: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) [21:34:15] (CR) Eileen: "All good comments - have pushed up some further changes - note there are some more fixes in https://gerrit.wikimedia.org/r/#/c/364363/ but" (10 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [21:50:15] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3427973 (Eileenmcnaughton) So on_hold is set on the email r... [21:52:31] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reset on_hold in wmf_civicrm_message_email_update - https://phabricator.wikimedia.org/T170350#3427980 (Eileenmcnaughton) [21:53:57] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3427997 (CCogdill_WMF) I don't think we want on_hold to be... [22:37:44] (PS1) Ejegg: Restore unsubscribe tag replacement [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364616 (https://phabricator.wikimedia.org/T170302) [22:40:49] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3428235 (Eileenmcnaughton) OK - I'm happy with nothing at t... [22:46:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate if there is a problem with on_hold usage for Silverpop - https://phabricator.wikimedia.org/T170357#3428280 (Eileenmcnaughton) [22:47:53] Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, WMF-NDA: Amazon (aaaaaargh!) audit report downloads failing, something about an IP address - https://phabricator.wikimedia.org/T169805#3428295 (Ejegg) p:Triage>High [22:47:59] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising-Backlog, and 3 others: Reflect all unsubscribes via Silverpop in CiviCRM - https://phabricator.wikimedia.org/T161760#3428296 (CCogdill_WMF) Cool, sounds good to me! [23:07:21] (CR) Ejegg: [C: 2] "Looking great - let's try it live!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [23:09:55] ejegg[m]: OMG! [23:10:07] Nice work! [23:10:37] ejegg[m]: I need to put spop creds into civicrm.settings.php - are you OK with me using my own username & password there? - I will make change now & getyou to check [23:10:41] oh, I should figure out where to put that extensionsDir settings file entry [23:12:33] ejegg: for live / stagint it is in civicrm.settings.php [23:14:58] (Merged) jenkins-bot: Initial commit, omnimail extension & extendedmailingreport [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/360610 (https://phabricator.wikimedia.org/T169593) (owner: Eileen) [23:17:42] eileen: I mean where to set that up for CI - those echo statements hacked into install.sh aren't the right way [23:18:05] ah right - hmm - I'm too excited about live deploy right now :-) [23:19:12] Can we move it from install.sh to the wmf install script - we can merge into that upstream [23:23:25] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/364619 [23:23:57] (CR) Eileen: [C: 2] "self approving merge to deploy" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/364619 (owner: Eileen) [23:24:45] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/364619 (owner: Eileen) [23:25:55] !update CiviCRM from d26886c71ee6e124d74080c735096a66987aefb0 to 0aa0f8fb45e161ba2e3a2e2353075cf6bdc67f6c [23:27:49] (CR) Ejegg: "Code looks good and it works locally. Maybe we want the type to default to Primary, though? It's defaulting to 'Billing', the first alphab" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364311 (https://phabricator.wikimedia.org/T169025) (owner: Eileen) [23:28:26] enjoy the email wrangling! I'm outta here for the evening. [23:28:43] ejegg[m]: cool - thanks [23:30:24] (CR) Eileen: "Hmm - I'm not sure - I kind of left the default behaviour as unchanged as possible - would need to discuss with upstream folks. For Tsmart" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/364311 (https://phabricator.wikimedia.org/T169025) (owner: Eileen) [23:53:52] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/364622