[02:11:26] (PS1) Eileen: Submodule commit CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/366777 [02:13:42] (CR) Eileen: [C: 2] Submodule commit CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/366777 (owner: Eileen) [02:21:09] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366778 [02:21:49] (CR) Eileen: [C: 2] CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366778 (owner: Eileen) [02:22:03] (PS1) Eileen: Submodule commit CiviCRM [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366779 [02:22:15] (CR) Eileen: [C: 2] Submodule commit CiviCRM [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366779 (owner: Eileen) [02:22:54] (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366778 (owner: Eileen) [02:23:11] (Merged) jenkins-bot: Submodule commit CiviCRM [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366779 (owner: Eileen) [02:24:39] !log update CiviCRM from 2de7f2a242b5def74a745995efae57fd626c688c to 74f95881f23300b0d84ca95f57b9c088f33213d9 [02:24:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:42:43] (PS1) Eileen: Change CiviMailing create command to use is_completed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/366781 (https://phabricator.wikimedia.org/T161758) [07:16:40] Fundraising-Backlog, MediaWiki-General-or-Unknown, MediaWiki-extensions-CentralNotice, Mobile, Reading-Web-Backlog (Tracking): Provide a way to show notifications to mobile users comparable to Sitenotice/annonnotice - https://phabricator.wikimedia.org/T138572#3459345 (MotokoCK) We are seeing... [09:54:31] (CR) Thiemo Mättig (WMDE): [C: 1] "Full review done. I think the patch is fine as it is right now, and should be merged. But it's quite big, and I would love to have one of " (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/364039 (owner: Umherirrender) [10:16:55] Fundraising-Backlog, fundraising-tech-ops, Operations: reports.frdev.wm.o -- still in use? - https://phabricator.wikimedia.org/T170640#3459810 (fgiunchedi) p:Triage>Normal [11:20:31] Fundraising-Backlog: Revoke AWight's donatewiki account - https://phabricator.wikimedia.org/T168430#3460077 (Pcoombe) I've blocked him. However we should also remove his admin rights, as technically an administrator can unblock themselves. It needs a "bureaucrat" to change admin rights, and the only one cur... [13:05:18] (PS4) Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/364039 [13:05:23] (CR) Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0 (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/364039 (owner: Umherirrender) [13:08:09] (CR) Mepps: [C: 2] Change CiviMailing create command to use is_completed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/366781 (https://phabricator.wikimedia.org/T161758) (owner: Eileen) [13:12:08] (PS5) Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/364039 [13:14:25] (Merged) jenkins-bot: Change CiviMailing create command to use is_completed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/366781 (https://phabricator.wikimedia.org/T161758) (owner: Eileen) [14:22:17] hi fr-tech! [14:22:23] hi ejegg! [14:23:00] how's it all going? [14:23:38] it's okay i have two smashpig patches for review [14:23:45] cool! [14:23:49] but no headway on di failures [14:25:20] aw man, there's got to be some more debugging we can add around that [14:26:22] i was wondering if it was the global variables set in the localsettings? [14:26:55] hmm? [14:27:20] oh snap, are we not giving Ingenico its own gateway variable prefix? [14:28:47] derp, yep, that's it [14:28:48] // For now, use the globals from the GlobalCollect adapter [14:28:59] (ingenico adapter line 8) [14:29:43] ahh [14:30:41] right, 'cause it seemed like a pain to duplicate all the settings from ingenico [14:30:44] hmmm [14:31:04] that getGlobal function is static [14:31:46] * ejegg tries to remember something about php and late static binding [14:32:41] http://php.net/manual/en/language.oop5.late-static-bindings.php [14:32:59] ok, php is actually preventing me from adding a horrible hack [14:33:09] the language is a good influence for once! [14:33:42] mepps: I was thinking about overriding getGlobal in the Ingenico adapter to give it a third layer of fallback [14:33:59] haha [14:34:07] so it looks for $wgIngenicoGateway... first, then $wgGlobalCollectGateway... [14:34:14] then $wgDonationInterface... [14:34:34] but that won't work, so I'll just duplicate the GlobalCollect global vars [14:35:01] we could also just set the global collect vars on test setup [14:35:21] hmm, I suppose we could [14:35:42] nah, let's not make this more confusing [14:36:16] OK, so for the payment accept call, it looks like we will need different parameters for different types of payments [14:36:31] For instance, I see directDebitSpecificInput in your code [14:37:08] and I can't imagine they want us to send that along with credit card captures [14:37:39] also, the 'token' param is going to be useful for recurring payments [14:38:14] oh hey, we will need to implement direct debit at some point! [14:38:28] and bank transfer [14:40:08] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Implement Ingenico Connect API call to create direct debit payment - https://phabricator.wikimedia.org/T171309#3460545 (Ejegg) [14:40:34] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Implement Ingenico Connect API call to create bank transfer payment - https://phabricator.wikimedia.org/T171311#3460569 (Ejegg) [14:42:21] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Implement Ingenico Connect API call to create direct debit payment - https://phabricator.wikimedia.org/T171309#3460584 (Ejegg) p:Triage>Normal [14:44:10] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Create mustache forms for online bank transfer - https://phabricator.wikimedia.org/T171312#3460586 (Ejegg) [14:44:23] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Create mustache forms for online bank transfer - https://phabricator.wikimedia.org/T171312#3460599 (Ejegg) p:Triage>Normal [14:45:05] hmm, guessing we also need to finish the new audit parsing for Connect [14:47:53] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Implement Ingenico Connect API call to create bank transfer payment - https://phabricator.wikimedia.org/T171311#3460616 (Ejegg) p:Triage>Normal [14:49:02] mepps: ah, we should look into the distinction between the 'approve' and 'capture' calls too [14:54:00] (PS3) Mepps: WIP Approve and Cancel payment [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366565 (https://phabricator.wikimedia.org/T163952) [14:56:32] ejegg okay [15:06:59] (PS28) Ejegg: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) [15:08:53] ejegg Note that the PENDING_APPROVAL status is used for payments that only allow a single capture. Such a capture will update the status of the payment. The similar PENDING_CAPTURE status is used for payments that allow multiple captures. These captures can be done using the capture payment API and result in a new Capture object. [15:09:16] hmm, ok [15:09:57] maybe we need to do some testing in the sandbox with hosted checkout payments to see what status they end up in [15:10:13] I've been able to make the thing appear, but I don't know what test card data to use to make it pass [15:10:47] there's a 16 digit number that passes the Luhn check (CC number checksum) which I always use, but it seems to fail [15:10:57] that's 4111 1111 1111 1111, for future reference [15:11:28] mepps: did you get your console account activated? [15:11:59] no i'll do that now [15:12:28] (CR) jerkins-bot: [V: -1] Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) (owner: Ejegg) [15:13:10] mepps you might have to email the guy again, I think the link he sent had a really short expiry [15:13:17] oh gotcha [15:15:22] ejegg hmm he just sent me a password and not an expiring link but i'm getting this: [15:15:22] You are not allowed to login from this IP address [15:15:43] mepps ooh, try full VPN [15:23:38] ejegg hmm i had the vpn working but it's having issues, shouldn't it authenticate with my yubikey? [15:23:57] mepps yeah, it's weird, though [15:24:12] you have to type your LDAP password, then press the yubikey button [15:24:17] appending that whole string [15:24:38] ahh [15:25:25] okay that finally worked [15:27:32] woohoo [15:27:44] and i got into the console [15:57:07] (PS2) Ejegg: Temporary WMF fix on CRM-20905 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/366502 (https://phabricator.wikimedia.org/T170900) (owner: Eileen) [15:57:16] (CR) Ejegg: [C: 2] Temporary WMF fix on CRM-20905 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/366502 (https://phabricator.wikimedia.org/T170900) (owner: Eileen) [16:01:01] Caminando por el bosque, una base de código enredada me encontré [16:01:09] Como no tenía nombre, CentralNotice le pondré [16:01:32] (to the tune of "Oh Susannah") [16:03:08] hehe, you should compose more songs! [16:03:42] mmm children's ditties for programmer parents? [16:04:41] (who are quickly losing their marbles?) [16:05:05] * AndyRussG stares at grindstone, grindstone stares back [16:09:34] (PS29) Ejegg: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) [16:12:14] (Merged) jenkins-bot: Temporary WMF fix on CRM-20905 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/366502 (https://phabricator.wikimedia.org/T170900) (owner: Eileen) [16:19:29] Fundraising Sprint Murphy's Lawyer, Fundraising Sprint Navel Warfare, Fundraising-Backlog, FR-PayPal-ExpressCheckout, and 2 others: Stop using kludgy workaround for PayPal EC recurring - https://phabricator.wikimedia.org/T170478#3460911 (Ejegg) Clarification from PayPal on the phase out of the ol... [16:53:55] (PS1) Ejegg: PayPal EC recurring: initial donation is async [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366870 (https://phabricator.wikimedia.org/T170478) [17:22:40] mepps: I'm about to get lunch, but I found the digits to use for testing the hosted checkout: [17:22:48] https://epayments.developer-ingenico.com/documentation/testcases/ [17:23:47] also, there's a little PayPal patch ready for review, which just stops us sending broken messages to the donations queue for recurring [17:23:52] https://gerrit.wikimedia.org/r/366870 [17:34:58] ejegg great! [17:36:23] (CR) Mepps: [C: 2] PayPal EC recurring: initial donation is async [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366870 (https://phabricator.wikimedia.org/T170478) (owner: Ejegg) [17:38:20] (Merged) jenkins-bot: PayPal EC recurring: initial donation is async [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366870 (https://phabricator.wikimedia.org/T170478) (owner: Ejegg) [18:15:37] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/366886 [18:24:03] ejegg trying to test the integration locally but so far just getting an error message [18:58:03] (PS30) Ejegg: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) [19:00:06] (CR) jerkins-bot: [V: -1] Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) (owner: Ejegg) [19:17:22] (PS31) Mepps: Add Ingenico Connect gateway based on GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/364143 (https://phabricator.wikimedia.org/T163946) (owner: Ejegg) [19:41:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Retry transaction after lock contention - https://phabricator.wikimedia.org/T111130#3461683 (Ejegg) I'm regularly checking on the damaged db to re-queue these things manually. Would be nice not to have to do that (and not to get so many failmails). [19:42:17] Multiple people (https://lists.wikimedia.org/pipermail/wikimedia-ru/2017-July/003927.html and online) are reporting that there are either emails being sent out to Russian donators or some donation popups/notices. This shouldn't be happening since donations can't be received from Russia (https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=RU). [19:42:40] stjn: oh shoot, really? [19:43:29] we should definitely do something about that! [19:44:30] I'll make a phab task and figure out who should be looking at it [19:44:39] Link to lists.wikimedia.org tells something like ‘in OTRS there's a message that Foundation emails recurring donators from Russia but does not give an option to make a donation’. [19:45:24] Ah, it's in OTRS? [19:45:46] MBeat: what's the procedure for OTRS tickets that might pertain to your team? [19:46:57] Also some apparently Crimean (which is recognised as Ukraine, yes, but it should be very limited in options for donating either way?) visitor asked in an online chat whether there are other methods other than PayPal and banking card. [19:47:03] If you send the the OTRS # I can move it to the wm-donations queue ejegg [19:47:09] 2017072010006724 [19:47:30] RU is an unaccepted country, alas [19:48:16] (backscrolling) [19:50:00] stjn thanks so much for bringing this to our attention! [19:51:41] hmm, I don’t have permission to access this ticket in it’s current state; stjn could you Move this one the the wm-donations queue? [19:52:10] I am not an OTRS agent and I am merely translating the discussion from WMRU mailing list, sorry. [19:54:00] ah, ok, i will ping someone [19:54:49] and thank you [20:01:45] No problem, it’s only better that people won’t be misled about whether they can help or not. [20:08:19] agreed, stjn - it might be a combination of geolocation errors and past Russian donors who donated while in Ukraine, we’ll review. Also, cards & PayPal are the main methods, though offline bank transfer in EUR would also be an option [20:18:28] Fundraising-Backlog, Fr-Ingenico-integration_17_18: Customize Ingenico hosted checkouts iframe - https://phabricator.wikimedia.org/T171346#3461789 (Ejegg) [20:54:42] Fundraising-Backlog: Are we losing transactions witih repeated ct_id? - https://phabricator.wikimedia.org/T171349#3461897 (Ejegg) [20:54:52] Fundraising-Backlog: Are we losing transactions witih repeated ct_id? - https://phabricator.wikimedia.org/T171349#3461909 (Ejegg) p:Triage>High [20:56:41] Fundraising-Backlog: Are we losing transactions witih repeated ct_id? - https://phabricator.wikimedia.org/T171349#3461897 (Ejegg) Donations queue log is donations_queue_consume-20170712-231301.log.bz2 [21:32:13] (PS1) Ejegg: Log more and catch errors on duplicate invoice ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/366964 (https://phabricator.wikimedia.org/T171349) [21:53:35] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Are PayPal refunds for recurring donations incorrectly being tagged as EC? - https://phabricator.wikimedia.org/T171351#3462035 (Ejegg) [21:58:21] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Are PayPal refunds for recurring donations incorrectly being tagged as EC or vice versa? - https://phabricator.wikimedia.org/T171351#3462051 (Ejegg) p:Triage>High [22:18:52] ejegg: ok to deploy 5647648693b8bd09843db2870a91622030a03b87 Resurrecting hashar's original composer json linter [22:19:19] eileen: yep, shouldn't affect anything outside of tests [22:19:52] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366974 [22:20:02] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/366974 (owner: Eileen) [22:20:18] 50th time lucky then - can I get my mail data now [22:21:34] !log civicrm updated from 74f95881f23300b0d84ca95f57b9c088f33213d9 to 38f246df7da2d7b40144d8deb2ca571d797e1402 [22:21:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:35:59] (PS1) Ejegg: WIP Tag refunds with correct paypal gateway [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) [22:36:28] good luck eileen! I'm heading out for the weekend. Have a good one [22:36:51] (CR) jerkins-bot: [V: -1] WIP Tag refunds with correct paypal gateway [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg)