[00:48:22] ejegg you're probably at the party but i'm working on getting this phpcs patch done! :) [01:15:53] (PS1) Mepps: WIP Add phpcs script but times out on test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/371770 (https://phabricator.wikimedia.org/T170314) [01:17:57] (CR) jerkins-bot: [V: -1] WIP Add phpcs script but times out on test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/371770 (https://phabricator.wikimedia.org/T170314) (owner: Mepps) [01:34:55] (PS2) Mepps: WIP Add phpcs script but times out on test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/371770 (https://phabricator.wikimedia.org/T170314) [02:36:55] (CR) Legoktm: [C: -1] "You probably want to use the latest version (0.11.0) instead of a older, and likely buggier version." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/371770 (https://phabricator.wikimedia.org/T170314) (owner: Mepps) [15:39:22] i don't even have any idea what happened at wikimania involving goats [15:39:27] but it looks out of control [16:15:56] hi all! [16:16:03] oops, sorry for no away nick [16:29:38] cwd goats are the new cats or so I've been told [16:32:47] interesting [16:33:10] balancing on precarious things is the new pushing stuff off the table [17:04:11] ejegg cwd hi! ejegg how's la belle province? [17:06:55] AndyRussG: I've already left [17:07:11] visiting the folks near boston [17:08:05] Fundraising Sprint Outie Inverter, Fundraising-Backlog: MY users getting express checkout at some times - https://phabricator.wikimedia.org/T173334#3524465 (DStrine) [17:09:38] ejegg: ah cool! hope that's fun! [17:23:46] AndyRussG: bet it will be. Bout to meet my mom for lunch! [19:46:49] dstrine fr-tech hey, just send an e-mail about missing or at least late for standup because bureaucracy... :( Apologies and thx!! [19:47:14] mepps: are you on today? [19:48:05] Dstrine nope I'm on the road--it should be on the calendar--off today and tomorrow [19:48:45] mepps: it's cool. safe travels [20:12:17] cwd re: ops coordination, the only thing I'd have to talk about is the Amazon IP address stuff, and I've just sent off some questions on that front [20:12:23] you have anything else? [20:12:34] not atm [20:12:45] just wondering about that IP stuff as well [20:13:15] when you say the listener might be a problem, do you mean the origin of the hits to the listener, or requests the listener itself makes? [20:26:52] cwd both [20:27:15] the notifications all come in with a verification cert URL [20:27:24] and we have to be able to fetch that [20:28:17] do we find that getting blocked often? [20:30:51] cwd I think it has in the past... not sure [20:31:00] i am probably missing something but doesn't that not actually add security unless you know the verification cert URL beforehand? [20:31:28] hah, right? [20:31:29] or are incidentally white listing its IP [20:31:44] but that's more like us bandaiding their security [20:32:03] I think their sdk does enforce the domain [20:33:04] well either way their proxy thing sounds nice [20:33:10] i like fixes where we don't have to do anything [20:33:21] srsly! [20:34:15] and the listener going down is not going to stop us completing 99% of transactions [20:34:36] it's just a few orphan-type things that the listener actually needs to capture [20:35:52] yeah, good stuff [20:44:38] message missing currency_code? What did I break.... [20:45:40] amount 0? how did that even get sent to payments-init? [20:46:41] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Message with blank payment_method and amount0 sent to payments-init - https://phabricator.wikimedia.org/T173347#3525049 (Ejegg) [20:55:53] ejegg: that ws a GC100 bank rejection, fwiw [20:56:23] MBeat: oh cool, thanks for letting me know! [20:56:37] We should certainly be recording that differently... [20:59:43] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Message with blank payment_method and amount0 sent to payments-init - https://phabricator.wikimedia.org/T173347#3525069 (Ejegg) From MBeat: this was a GC100 bank rejection [21:00:45] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Message with blank payment_method and amount = 0 sent to payments-init - https://phabricator.wikimedia.org/T173347#3525070 (Ejegg) p:Triage>Normal [21:11:23] (CR) Hashar: [C: -1] "You would need a phpcs.xml file :)" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/371770 (https://phabricator.wikimedia.org/T170314) (owner: Mepps) [22:16:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: Postal address database? - https://phabricator.wikimedia.org/T173353#3525171 (Ejegg) [22:17:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: Postal address database? - https://phabricator.wikimedia.org/T173353#3525183 (Ejegg) p:Triage>Low [22:28:04] (PS9) Ejegg: Enable PHPCS, but only with rules phpcbf could fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (https://phabricator.wikimedia.org/T133576) (owner: Awight) [22:36:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Direct Mail Appeal not reflecting in contribution records for event - https://phabricator.wikimedia.org/T171794#3525212 (DStrine) thanks all. I'm going to close this. [22:36:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Direct Mail Appeal not reflecting in contribution records for event - https://phabricator.wikimedia.org/T171794#3525213 (DStrine) Open>Resolved [22:40:58] (PS10) Ejegg: Enable PHPCS, but only with rules phpcbf could fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (https://phabricator.wikimedia.org/T133576) (owner: Awight)