[13:38:43] (CR) Mepps: [C: 2] Support srcset for card logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373112 (https://phabricator.wikimedia.org/T166795) (owner: Ejegg) [13:38:51] (CR) jerkins-bot: [V: -1] Support srcset for card logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373112 (https://phabricator.wikimedia.org/T166795) (owner: Ejegg) [13:39:10] (PS2) Mepps: Support srcset for card logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373112 (https://phabricator.wikimedia.org/T166795) (owner: Ejegg) [13:50:42] (CR) Mepps: [C: 2] Return inserted IDs for pending and payments_init [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373347 (owner: Ejegg) [13:51:35] (Merged) jenkins-bot: Return inserted IDs for pending and payments_init [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373347 (owner: Ejegg) [14:12:32] (CR) Mepps: "Eileen, are these changes also going in the upstream core code?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [15:11:43] hi all! [15:11:51] thanks for the CR, mepps! [15:12:08] I was looking at the DonationInterface side of the orphan rectifier [15:12:37] and started thinking that rectifyOrphan could just be abstract [15:12:51] since most of the logic does depend on the gateway [15:13:32] for example, paypal doesn't actually need to check anything about the transaction to decide to go on with it [15:14:07] okay [15:14:13] and then different adapters use different methods to confirm [15:14:35] finally, I think different adapters even use different methods to determine whether something really was rectified [15:15:14] hmm, or maybe the confirm() method should return a standard PaymentResult [15:15:24] and we could still use common logic in rectifyOrphan [15:16:45] ok, I should deploy that DI stuff and get the deployment branch back in sync with the actual deployed code [15:19:30] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373112 (https://phabricator.wikimedia.org/T166795) (owner: Ejegg) [15:24:58] (CR) Ejegg: [C: 2] "re-applying mepps's +2 to nudge jenkins-bot" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373112 (https://phabricator.wikimedia.org/T166795) (owner: Ejegg) [15:28:57] (Merged) jenkins-bot: Support srcset for card logos [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373112 (https://phabricator.wikimedia.org/T166795) (owner: Ejegg) [15:32:32] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/373565 [15:32:35] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/373565 (owner: Ejegg) [15:33:25] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/373565 (owner: Ejegg) [15:41:49] (PS11) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [15:50:24] ejegg i'm leaving it as is for now based on your latter comments--all tests are passing [15:52:11] ok, cool [15:52:42] ejegg still pretty sick, considering taking the afternoon off, just a heads up [15:52:54] mepps aww, that's a bummer [15:53:01] hope you fight it off today [15:53:13] yeah seeing how much i can do, but this cough is pretty rough :/ [15:53:20] hmm, we will want to check more than just $result->getCommunicationStatus() [15:54:18] hmm that was pulled from globalcollect, do others use something different? [15:54:22] I think in doPayment we usually figure out the 'final status' [15:54:34] oh huh [15:54:59] getCommunicationStatus is SUPPOSED to mean just that the API call made it to the processor [15:55:11] and didn't come back with a 4xx or 5xx error [15:55:32] not whether the payment itself succeeded [15:56:03] there's that list of processor status codes mapped to results [15:57:54] hm i actually find the globalcollect rectifier code confusing [15:58:15] because if getCommunicationStatus is false it still looks through the message for a bunch of strings [15:58:16] gc code confusing??!?!?! [15:58:24] couldn't be... [15:58:25] :P [15:58:27] :):):) [15:58:44] yeah, that's probably the ugliest stuff in our code base [15:59:43] so ejegg if things were standard, how would we know if the rectifying had completed successfully? [16:00:29] let's see [16:05:35] mepps take a look at the doPayment methods [16:08:21] let's see, so the do_transaction methods generally run a 'finalizeInternalStatus' when the transaction is a payment confirmation [16:08:39] then doPayment generally returns a PaymentResult [16:08:53] so maybe confirm() should also return one of those [16:09:11] hmm so confirm() will just be a wrapper for do_transaction [16:09:17] at least that's what i was thinking [16:09:30] ah yeah [16:09:33] since each adapter will have a different confirmation transaction [16:09:48] actually, then it doesn't really need to create the PaymentResult [16:10:02] that block of code is repeated in all the doPayment implementations [16:10:22] 'return PaymentResult::fromResults( $resultData, $this->getFinalStatus() ); [16:11:03] it looks like doPayment doesn't have a parent in gatewayadapter [16:11:06] so the confirm function could keep returning the PaymentTransactionResponse like you're doing [16:11:13] mepps right it's abstract [16:11:21] or rather it's part of the interface [16:11:57] ah i see, i see gatewaytype [16:12:12] anyway, so you'd want to check $this->getFinalStatus() up in rectifyOrphan [16:12:29] either that, or return the PaymentResult from rectifyOrphan [16:12:48] might be more interesting for the drush script [16:12:59] to be able to read out a list of errors, not just a boolean [16:14:19] (PS12) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [16:14:27] okay see what you think of that update [16:18:47] oops wait [16:18:54] k [16:19:20] (PS13) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [16:19:29] okay ^^ also see fixme question [16:22:25] mepps let's keep all the interaction with the pending database in the drush wrapper [16:22:43] and yep, we should delete the message whether or not the confirmation succeeds [16:23:19] (PS14) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [16:23:27] okay, forgot we decided that [16:29:48] (CR) Ejegg: WIP rectify orphan function (8 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [16:30:33] oops, those are all attached to PS13 [16:37:54] (PS15) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [16:44:11] (PS1) Ejegg: Update DonationInterface extension [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/373601 [16:44:33] (CR) Ejegg: [C: 2] Update DonationInterface extension [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/373601 (owner: Ejegg) [16:50:15] (Merged) jenkins-bot: Update DonationInterface extension [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/373601 (owner: Ejegg) [16:51:31] (PS16) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [16:51:51] (CR) Ejegg: WIP rectify orphan function (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [16:52:26] heh, another set of comments on the previous PS ^^ [16:52:30] (CR) Mepps: "Ejegg latest patch addresses most of your comments and see reply." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [17:07:31] (PS17) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [17:08:22] okay ejegg updated patch [17:08:49] (PS14) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [17:13:19] cool, looking! [17:28:11] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [17:37:45] (PS20) Mepps: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [17:37:53] (CR) Mepps: [C: 2] PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [17:38:10] ejegg did you still want that +2ed? ^^ [17:38:45] (Merged) jenkins-bot: PayPal verification uses OutboundRequest [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334475 (owner: Ejegg) [17:41:39] thanks mepps! [17:44:03] (PS2) Mepps: Fix and note for Amazon manual IPN test harness [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363361 (owner: Ejegg) [17:44:07] (CR) Mepps: [C: 2] Fix and note for Amazon manual IPN test harness [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363361 (owner: Ejegg) [17:44:26] (CR) Ejegg: "Nice, this is really shaping up!" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [17:44:55] (Merged) jenkins-bot: Fix and note for Amazon manual IPN test harness [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/363361 (owner: Ejegg) [17:47:36] gonna grab some food [17:48:02] (CR) Mepps: WIP rectify orphan function (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [17:56:33] (PS18) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [17:58:36] (PS19) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [17:59:57] (CR) jerkins-bot: [V: -1] WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [18:01:16] (PS20) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [18:13:09] (PS2) XenoRyet: Tag refunds and chargebacks with correct paypal gateway [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg) [18:38:46] !log updated payments-wiki from bd9f7305d7c46f2afab79b0f4d72ca528747878b to 58d33b837167f14dc9388c8d3acc0281b012932f [18:38:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:55:04] (CR) Ejegg: "Oh right, let's not delete all the existing orphan code just yet! If you want to flesh out and test the paypal implementation of confim() " (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [18:56:19] (PS1) Ejegg: Fix PaymentResult::newEmpty() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373661 [19:17:29] (PS1) Ejegg: Set dummy response codes statically [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373671 [19:17:52] mepps: those last two might patches might come in handy for you ^^^ [19:20:07] haha ejegg was just fixing that newEmpty function locally [19:20:22] (CR) Mepps: [C: 2] Fix PaymentResult::newEmpty() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373661 (owner: Ejegg) [19:25:39] (Merged) jenkins-bot: Fix PaymentResult::newEmpty() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373661 (owner: Ejegg) [19:40:37] Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Paypal EC - send orphan-y donors to TY page - https://phabricator.wikimedia.org/T173456#3550447 (Ejegg) Open>Resolved p:Triage>Normal a:Ejegg [19:40:50] Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Update Mastercard logo - https://phabricator.wikimedia.org/T166795#3550453 (Ejegg) Open>Resolved [19:41:00] Fundraising Sprint Prank Seatbelt, Fundraising-Backlog: dress rehearsal for MG event - https://phabricator.wikimedia.org/T173458#3550462 (Ejegg) Open>Resolved p:Triage>Normal [19:41:37] Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, and 2 others: Ingenico WX audit parser: refunds missing gateway_txn_id - https://phabricator.wikimedia.org/T173457#3528972 (Ejegg) Open>Resolved [19:50:53] mepps: This is the one https://gerrit.wikimedia.org/r/#/c/366976/ [19:55:10] (CR) Mepps: "Mostly looks good but see comments on the structure. There's a lot of if/else loops there and I wonder if we can't simplify." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg) [20:02:18] (PS21) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [20:02:26] (CR) jerkins-bot: [V: -1] WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [20:08:03] (PS22) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [20:31:31] (PS1) Ejegg: Thank you generator fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373681 [20:33:27] (PS1) Ejegg: Update ja and pt-br thank you letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373683 (https://phabricator.wikimedia.org/T173809) [20:33:52] (PS1) Ejegg: TY generator: add another replacement pattern for $date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373684 [20:34:18] OK fr-tech, ty letter stuff is ready for review ^^^ [20:49:26] (PS11) Ejegg: Enable PHPCS, but only with rules phpcbf could fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (https://phabricator.wikimedia.org/T133576) (owner: Awight) [20:51:00] (PS10) Ejegg: Move FinalStatus enum to SmashPig, add ValidationAction [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/317653 (https://phabricator.wikimedia.org/T163868) [20:51:55] (PS5) Ejegg: Push PaymentResult down into SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/333152 (https://phabricator.wikimedia.org/T163868) [20:52:44] (PS5) Ejegg: WIP add PaymentParameters and PaymentProvider interface [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/334709 [21:04:09] (PS1) Ejegg: Clean up duplicate curlWrapper stuff [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373690 [21:14:05] (CR) Eileen: "Eventually. The other patch is open as a PR but this one I wanted to tie in with extensionising a lot of the dedupe code (still ship with " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [21:44:07] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3551109 (cwdent) a:cwdent Hi @fgiunchedi - prometheus is now running on pay-lvs*:9090 They are only watching themselves and one eqiad host, which also has the mysqld exporter. Wondering... [21:46:04] (CR) XenoRyet: [C: 2] Update ja and pt-br thank you letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373683 (https://phabricator.wikimedia.org/T173809) (owner: Ejegg) [21:46:13] (CR) XenoRyet: [C: 2] Thank you generator fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373681 (owner: Ejegg) [21:46:30] (CR) XenoRyet: [C: 2] TY generator: add another replacement pattern for $date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373684 (owner: Ejegg) [21:52:28] (Merged) jenkins-bot: Update ja and pt-br thank you letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373683 (https://phabricator.wikimedia.org/T173809) (owner: Ejegg) [21:55:57] (Merged) jenkins-bot: Thank you generator fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373681 (owner: Ejegg) [21:58:47] (Merged) jenkins-bot: TY generator: add another replacement pattern for $date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373684 (owner: Ejegg) [22:01:56] (PS1) Ejegg: WX audit files: get at least date from sparse refunds [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373702 (https://phabricator.wikimedia.org/T173875) [22:04:05] (PS4) Ejegg: Update DonationInterface lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/368848 (https://phabricator.wikimedia.org/T95647) [22:05:12] XenoRyet: ^^^ is a little more than just the lib update - needed a couple things changed to work with some new bits. If you have time for some CR I'd be grateful [22:05:30] In the meantime, I'll deploy that thank you letter. [22:06:21] Sure, I'll take a look [22:07:16] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/373703 [22:07:26] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/373703 (owner: Ejegg) [22:07:42] (PS1) Pcoombe: Don't select a submethod if there are errors in personal info [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) [22:08:17] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/373703 (owner: Ejegg) [22:11:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Hide 'continue' button when opening CC iframe - https://phabricator.wikimedia.org/T149366#3551223 (Pcoombe) @Ejegg The above patch adopts approach 3: "when you click a card type and validation fails, card type stays unsele... [22:19:06] (CR) XenoRyet: [C: 2] Update DonationInterface lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/368848 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [22:24:32] !log updated civicrm from fa882f2af13f690ec4a4f0f5ce5475ec79d8516a to c30ec135395d952c3a1ce5b2320f5a2a40367b2d (pt-br and ja thank you letters) [22:24:40] (Merged) jenkins-bot: Update DonationInterface lib [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/368848 (https://phabricator.wikimedia.org/T95647) (owner: Ejegg) [22:24:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:31:18] Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Deploy pt-br and ja thank you letter - https://phabricator.wikimedia.org/T173809#3540472 (Ejegg) OK @jrobell, the new thank you letters have been deployed and look good as far as I can tell (no broken... [22:47:07] (CR) Ejegg: [C: 1] "This looks good for the general use case! If you want to deal with users who reload the page with a method already selected, you can clear" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) (owner: Pcoombe)