[02:27:20] (CR) Ejegg: WIP rectify orphan function (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [08:15:46] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3551920 (fgiunchedi) >>! In T152562#3551109, @cwdent wrote: > Hi @fgiunchedi - prometheus is now running on pay-lvs*:9090 > > They are only watching themselves and one eqiad host, which also... [13:47:00] (PS23) Mepps: WIP rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [14:00:08] (CR) Mepps: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364790 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [14:02:42] (CR) Mepps: "Looks good ejegg but I don't know this repo at all, want to go over this and your other changes here?" [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) (owner: Ejegg) [14:04:39] (CR) Mepps: "Looks pretty straightforward but let me know if there's a reason not to +2 it yet" [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 (owner: Ejegg) [14:06:05] (CR) jerkins-bot: [V: -1] Cache result of template loads, including language fallback lookups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364790 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [14:07:11] (CR) Mepps: "Looks pretty straightforward, see one comment." (1 comment) [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 (owner: Ejegg) [14:15:23] (CR) Mepps: [C: 1] "Looks pretty good to me, not sure if ejegg wants to take a look." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373173 (owner: Eileen) [14:18:28] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3553072 (cwdent) Thanks @fgiunchedi, I had assumed we'd be using the latter "federated" approach so I did make those firewall holes already (but would still need to tweak iptables). Puppet co... [14:36:49] (CR) Mepps: [C: 1] "This code mostly looks good, though not sure if we have tests for it? I ask about upstreaming it because I'm curious how we're handling cu" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [15:01:02] hi mepps! [15:01:09] hi ejegg! [15:01:22] I see some CR above... taking a look [15:01:49] (CR) Ejegg: "oh yeah, I think I should be caching just the file, not the compiled template" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364790 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [15:02:44] mepps want to chat about DjangoBannerStats ? [15:03:48] Have you worked with Django at all? [15:03:58] It's like rails for python [15:04:04] but maybe a little less magic [15:09:56] want to give me a call ejegg? i'm up in the mountains :) [15:10:07] oh yeah, sure thing [15:22:02] https://stackoverflow.com/questions/27628152/django-db-transaction-set-autocommit-and-conn-max-age [15:24:55] (CR) Mepps: [C: 2] Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) (owner: Ejegg) [15:25:13] (CR) Mepps: Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) (owner: Ejegg) [15:25:33] (PS3) Mepps: Correct default log path, make TEMPLATE_DIRS an array [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 (owner: Ejegg) [15:35:40] (PS3) Ejegg: Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) [15:35:42] (PS4) Ejegg: Correct default log path, make TEMPLATE_DIRS an array [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 [15:35:44] (PS3) Ejegg: Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 [15:35:58] ah, lemme get some sample data and try running that locally with the new txn stuff [15:42:35] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3553297 (fgiunchedi) I see as two different use cases mostly, accessing directly from grafana will let you access all metrics and datapoints that Prometheus server is collecting and retaining.... [15:56:00] mepps oh dang, found another bit of deprecation to work around: AttributeError: type object 'BaseCommand' has no attribute 'option_list' [15:59:58] hey ejegg, just curious but it looks like the decorator may work for atomic: https://docs.djangoproject.com/en/1.11/topics/db/transactions/#controlling-transactions-explicitly [16:00:58] (CR) Mepps: [C: 2] Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 (owner: Ejegg) [16:02:09] other than comment above, the atomic fix is good to go--just wanted to be clear on why we weren't using a decorator [16:04:28] mepps oh hey, thanks! [16:04:30] I'll try that [16:04:45] Just have to fix one more thing with the argument parsing before it'll work locally [16:05:12] hmm, lemme see which version of django we have in prod [16:08:58] ok, prod is 1.7 [16:11:10] well durn, it doesn't support the new way of adding arguments to commands [16:11:31] lessee if we can do this backwards-compatibly [16:25:37] (PS1) Ejegg: Update option parsing for Django 1.10+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373924 [16:28:59] mepps: hmm, looks like 'atomic' actually does its own transaction management [16:29:40] https://docs.djangoproject.com/en/1.7/topics/db/transactions/ [16:29:53] 'Avoid catching exceptions inside atomic!' [16:29:54] etc [16:30:10] looks like we can use that, it'll just mean a slightly bigger code change [16:32:04] ah! or we could possibly just put the atomic code into the try clause? [16:32:12] as in the code example ejegg? [16:32:13] hrm [16:32:35] but... we're catching mysql warnings to ignore them and commit [16:32:53] while later catching actual mysql errors to roll back and log [16:33:02] phooey [16:33:13] I think I'm going to go back to the set_autocommit approach [16:33:26] and just set it back to true at all the fn exits [16:33:41] we can do a bigger rewrite later [16:34:11] ejegg sounds good, can you use a finally block? [16:43:31] mepps yeah, I'll put it in 'finally' where that's the last thing in a function [16:43:38] and before all the return statements [16:48:28] Cool [16:53:15] (PS4) Ejegg: Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) [16:53:17] (PS5) Ejegg: Correct default log path, make TEMPLATE_DIRS an array [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 [16:53:22] (PS4) Ejegg: Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 [16:53:22] (PS2) Ejegg: Update option parsing for Django 1.10+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373924 [16:53:40] ok mepps, that stuff is all working in local tests! ^^^ [16:53:53] I'm pretty sure it should all still work in 1.7 [16:55:41] (CR) Mepps: [C: 2] Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) (owner: Ejegg) [16:56:07] (CR) Mepps: [C: 2] Correct default log path, make TEMPLATE_DIRS an array [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 (owner: Ejegg) [16:56:32] (CR) Mepps: [V: 2 C: 2] Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 (owner: Ejegg) [16:56:46] (CR) Mepps: [C: 2] Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 (owner: Ejegg) [16:57:22] woohoo, thanks! [16:58:00] (CR) Mepps: [C: 2] Update option parsing for Django 1.10+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373924 (owner: Ejegg) [16:58:14] yup that was fun ejegg! [16:58:35] hmm, does that repo even have jenkins-bot giving v+2? [16:58:44] we might have to manually v+2/submit [16:58:51] TODO:... [16:59:23] ok, looking at the latest orphan stuffs [17:00:18] oh hey: T121723 [17:00:20] T121723: Continuous integration: wikimedia/fundraising/tools/DjangoBannerStats needs V+2 jobs - https://phabricator.wikimedia.org/T121723 [17:00:22] hmm ejegg, should we have one more person verify then? maybe xenoryet? [17:00:28] ahh [17:01:14] Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, Patch-For-Review: Replace deprecated transaction.commit_manually in DjangoBannerLoader - https://phabricator.wikimedia.org/T162504#3553537 (Ejegg) a:Ejegg [17:01:21] https://gerrit.wikimedia.org/r/#/c/252709/3/README.md,unified [17:02:24] heh, we're not quite that obsolete... [17:03:13] but that's much more useful than than the old readme [17:03:32] why did awight -2 that? [17:04:30] hmm, pyflakes or something shouldn't be too hard to set up [17:13:09] mepps: I'm adding tox/flake8 [17:13:26] but I'd rather not waste time fixing errors in the removed web code [17:13:47] and rebasing those 4 fixes around the whitespace changes [17:14:19] so I'm going to do it after all those [17:14:29] and we'll still have to manually V+2 them [17:26:29] (PS1) Ejegg: Use print function from __future__ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373930 [17:28:04] (PS1) Ejegg: Fix whitespace and 'not' order [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373931 [17:31:40] Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising-Backlog: MY users getting express checkout at some times - https://phabricator.wikimedia.org/T173334#3553610 (XenoRyet) a:XenoRyet [17:50:12] (PS1) Ejegg: Be explicit with imports [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373936 [17:50:14] (PS1) Ejegg: Add tox.ini with flake8 config [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373937 [17:50:16] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 7 minutes ago with 1 failures. Failed resources (up to 3 shown): File[/var/www/cgi/yubicollect] [17:50:59] mepps: OK, with those patches, we should be able to add a CI job to at least check code sytax and style ^^^ [17:53:37] o_O [17:55:07] RECOVERY - check_puppetrun on frdev1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [17:55:28] (PS3) Ejegg: Add Spanish translations for missing fiscal numbers [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/363386 [17:55:57] (PS4) Ejegg: Use SmashPig version of Currency classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/363744 (https://phabricator.wikimedia.org/T163868) [17:58:37] (PS6) Ejegg: Log client-side errors on payments forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259795 (https://phabricator.wikimedia.org/T121800) [18:00:16] Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, Continuous-Integration-Config: Continuous integration: wikimedia/fundraising/tools/DjangoBannerStats needs V+2 jobs - https://phabricator.wikimedia.org/T121723#3553714 (Ejegg) a:Ejegg [18:01:19] (PS2) Ejegg: Use print function from __future__ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373930 (https://phabricator.wikimedia.org/T121723) [18:01:21] (PS2) Ejegg: Fix whitespace and 'not' order [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373931 (https://phabricator.wikimedia.org/T121723) [18:01:23] (PS2) Ejegg: Be explicit with imports [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373936 (https://phabricator.wikimedia.org/T121723) [18:01:25] (PS2) Ejegg: Add tox.ini with flake8 config [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373937 (https://phabricator.wikimedia.org/T121723) [18:04:48] (CR) Mepps: [C: 2] Add tox.ini with flake8 config [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373937 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [18:04:49] XenoRyet: are you able to do some local verification of those DjangoBannerStats patches to add a V+2 to mepps's C+2 ? [18:05:25] (CR) Mepps: [C: 2] Be explicit with imports [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373936 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [18:06:03] ejegg: Give me a few minutes, finishing up another thing. [18:06:12] k, thanks! [18:07:03] (CR) Mepps: [C: 2] Fix whitespace and 'not' order [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373931 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [18:07:33] (CR) Mepps: [C: 2] Use print function from __future__ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373930 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [18:08:56] (PS3) XenoRyet: Tag refunds and chargebacks with correct paypal gateway [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg) [18:15:21] (CR) Ejegg: "This is looking about ready to un-WIP!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [18:15:37] gonna grab some lunch [18:20:50] Fundraising-Backlog: Convert all encoded HTML name data for JP to UTF-8 - https://phabricator.wikimedia.org/T174190#3553820 (CCogdill_WMF) [18:21:04] Fundraising-Backlog: Convert all encoded HTML name data for JP to UTF-8 - https://phabricator.wikimedia.org/T174190#3553832 (CCogdill_WMF) p:Triage>High [18:38:04] Fundraising-Backlog: Convert all encoded HTML name data for JP to UTF-8 - https://phabricator.wikimedia.org/T174190#3553820 (Ejegg) Can you give an example contact ID or two? [18:41:27] ejegg|food: mepps: I've not done anything with DjangoBannerStats before, and don't even have it set up locally. Any docs around for getting it set up? Or maybe Andy already has it and could do a quick V+2. [18:56:02] Fundraising-Backlog: Convert all encoded HTML name data for JP to UTF-8 - https://phabricator.wikimedia.org/T174190#3553982 (CCogdill_WMF) 2176320, 2166633, 2169090 [18:57:23] XenoRyet: want to do a call? [18:57:47] Few mins maybe. Talking to Katie right now. [18:57:49] you'll need to at least install python-django [18:58:32] i'm using the deb packaged version [18:58:50] but you could get it from pip if you prefer [18:58:59] I'm assuming it needs to talk to other things, so we'll have to set it up on my vagrant VM [18:59:09] nah, it's pretty self-contained [18:59:20] ah, that makes it easier then. [19:18:14] Ok, got django installed and cloned the repo [19:18:18] What's next? [19:46:13] (PS1) Ejegg: Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) [19:46:19] Can someone call me in fr-tech? [19:50:28] Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising-Backlog: MY users getting express checkout at some times - https://phabricator.wikimedia.org/T173334#3554124 (DStrine) Open>declined [19:50:50] Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising-Backlog: MY users getting express checkout at some times - https://phabricator.wikimedia.org/T173334#3524465 (DStrine) We don't think we have anything actionable here. [20:00:33] (CR) jerkins-bot: [V: -1] Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [20:11:03] (PS4) Mepps: Tag refunds and chargebacks with correct paypal gateway [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg) [20:11:10] (CR) Mepps: [C: 2] Tag refunds and chargebacks with correct paypal gateway (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg) [20:12:04] (Merged) jenkins-bot: Tag refunds and chargebacks with correct paypal gateway [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/366976 (https://phabricator.wikimedia.org/T171351) (owner: Ejegg) [20:15:46] hey ejegg i just realized i drafted but never saved a comment here: https://gerrit.wikimedia.org/r/#/c/369996/20/paypal_gateway/express_checkout/paypal_express.adapter.php [20:16:02] basically i was curious if we should just call processDonorReturn instead of confirm() [20:17:49] mepps that seems possible... we'd have to fake up the payerID though [20:18:04] hmm, that doesn't seem to actually go anywhere [20:20:22] what do you mean ejegg? [20:21:31] processDonorReturn expects the two things that paypal appends to the querystring [20:21:46] we've got ec_token from the gateway_session_id in the message [20:22:02] but we wouldn't have a payerID [20:22:54] yeah do we need that for $this->do_transaction( 'GetExpressCheckoutDetails' ); [20:22:59] ? [20:23:11] i meant what do you mean by that doesn't go anywhere [20:23:19] XenoRyet|food: Just noticed your message earlier. ping me when you're back from lunch and we can maybe do a call to get you set up [20:23:36] mepps yeah, we only need the token for the express checkout details [20:24:08] oh hey, just thought of one reason not to rectify a paypal orphan [20:24:14] ha~ [20:24:16] yes? [20:24:25] if the session is too old, it'll be expired and we might as well not bother [20:26:01] but yeah, it would make a lot of sense to re-use the donorReturn logic [20:27:12] ha, when does the session expire? [20:27:26] not sure, we'll have to look that up in the docs [20:30:26] haha [20:30:43] sorry wrong buffer :( [20:30:51] i have some super lag going on [20:31:50] fundraising-tech-ops: Investigate decommissioning two eqiad-frack vlans - https://phabricator.wikimedia.org/T174203#3554256 (ayounsi) [20:33:01] XenoRyet did you ever come across data on when paypal ec sessions expire? [20:37:30] ejegg xenoryet why is payer_id required for processdonorreturn? [20:37:45] mepps no idea! [20:38:24] It would be an interesting thing to store, if we wanted to update donor records when their paypal data changes [20:38:26] ejegg if i made it optional then this would be easier--is the token then saved in the pending db? [20:38:30] but we're not storing it now [20:38:35] true [20:38:43] mepps yep, the token is saved as gateway_session_id [20:38:54] ejegg cool [20:39:03] same field as we'll use to hold the hostedCheckoutId for ingenico connect [20:39:56] gotcha [20:49:44] (PS2) Ejegg: Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) [20:50:39] (PS24) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [20:50:55] OK, that one's still going to fail, but it should work after https://gerrit.wikimedia.org/r/373702 merges [20:52:10] (CR) jerkins-bot: [V: -1] Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [20:54:33] (PS25) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [20:55:55] (CR) jerkins-bot: [V: -1] Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [20:56:04] (CR) jerkins-bot: [V: -1] Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [20:57:21] fundraising-tech-ops: Investigate decommissioning two eqiad-frack vlans - https://phabricator.wikimedia.org/T174203#3554374 (Jgreen) Sounds like frack-external1-c-eqiad serves no purpose anymore and we should remove it. DMZ1 has samarium in it, which is a public-reporting webserver. Since we're using host-b... [20:57:32] (PS26) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [20:58:01] okay ejegg and xenoryet, take a look at that ^^ [21:06:34] mepps interesting! We're losing the $result variable, though [21:06:57] let's see what processDonorReturn gives us [21:07:32] ah, it gives us the PaymentResult [21:08:02] so you can get rid of lines 3756-7 [21:09:11] also, feel free to add an isSuccess() method to PaymentResult [21:09:23] hmm [21:10:01] just wondering how we'll use the return value of rectifyOrphan up in the drush script [21:10:46] does it need to be able to distinguish between skipped, successfully rectified, and rectification failures? [21:22:18] (PS5) Ejegg: Cache result of template loads, including language fallback lookups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364790 (https://phabricator.wikimedia.org/T170435) [21:23:32] mepps, here's a though: [21:24:07] how about processDonorReturn assumes that all the parameters have been normalized on the way in? [21:24:45] We should have something in var_map for all of the querystring parameters we care about [21:29:43] (CR) Eileen: [C: -1] "There is actually still a bug in this when I try on staging so giving it a minus 1:-(" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [21:32:02] ejegg: I'm ready to mess around with DjangoBannerStats some more. Mind if we do it in text mode? Baby is sleeping in the next room. I'll be slain if I wake her up with talking. [21:32:52] XenoRyet: sure thing! [21:33:15] So, you can copy fundraising/settings.py to a file called django_settings.py in the base directory [21:33:33] then fill out the database info in django_settings.py [21:33:43] ls [21:33:46] I've got a local db named pgehres, just like prod [21:34:01] hehe, I was saying earlier I want a unix command filter for my IRC client [21:34:29] right? [21:36:34] so, you can create that db [21:36:55] then run the script in sql/create.sql [21:43:25] when you've got some test files, run python2 manage.py LoadBannerImpressions --verbose --recent [21:43:38] and python2 manage.py LoadLPImpressions --verbose --recent [21:43:44] and see what happens [21:44:03] good times [22:07:19] XenoRyet: any luck? [22:07:27] I'mma head out fairly soon [22:08:12] Yea, getting there. Had an issue with the template dirs setting, fixed that. [22:08:23] XenoRyet: oh shoot, right [22:08:32] you'll need those patches to make it actually run [22:08:43] Oh, heh. [22:08:49] Ok, I'll pull them down. [22:09:06] https://gerrit.wikimedia.org/r/358424 should get it working [22:09:17] then there are a bunch of style cleanups on top of it [22:09:24] Cool [22:10:41] (PS6) Ejegg: Cache result of template loads, including language fallback lookups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/364790 (https://phabricator.wikimedia.org/T170435) [22:10:43] (PS1) Ejegg: Add test for Templating [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373974 [22:12:37] (PS1) Ejegg: Delete 'oneoffs' module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373975 [22:22:29] (PS1) Ejegg: Delete wmf_communication\Job stuff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373976 [22:24:32] ejegg: It's still giving me an error 'BaseCommand' has no attribute 'option_list' [22:24:37] That one ring any bells for you? [22:25:06] XenoRyet: oops, one more patch down the line: [22:25:14] Ah, cool [22:25:18] https://gerrit.wikimedia.org/r/373924 [22:26:21] ok, I'mma head out. good luck, and have a great weekend! [22:26:30] You too. See ya monday. [22:30:55] (PS1) Ejegg: Delete half-baked Silverpop import code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 [23:23:47] (CR) XenoRyet: [V: 2] Update transactions for django 1.6+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358419 (https://phabricator.wikimedia.org/T162504) (owner: Ejegg) [23:23:55] (CR) XenoRyet: [V: 2] Correct default log path, make TEMPLATE_DIRS an array [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358420 (owner: Ejegg) [23:24:07] (CR) XenoRyet: [V: 2] Update option parsing for Django 1.10+ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373924 (owner: Ejegg) [23:24:13] (CR) XenoRyet: [V: 2] Use print function from __future__ [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373930 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [23:24:18] (CR) XenoRyet: [V: 2] Fix whitespace and 'not' order [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373931 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [23:24:22] (CR) XenoRyet: [V: 2] Be explicit with imports [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373936 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg) [23:24:33] (CR) XenoRyet: [V: 2] Add tox.ini with flake8 config [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/373937 (https://phabricator.wikimedia.org/T121723) (owner: Ejegg)