[08:14:04] fundraising-tech-ops, Wikimedia-General-or-Unknown, Performance: 2017 USA banners take 1-2 seconds to load - https://phabricator.wikimedia.org/T174267#3557655 (Aklapper) @Zoranzoki21: Please explain //how// you tested something (what?) and what your result was. Otherwise such comments are too vague a... [14:45:27] (CR) Mepps: [C: 2] "XenoRyet, can you merge this patch too? I did it by accident the other day which is why i removed it." [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 (owner: Ejegg) [14:53:34] mornin fr-tech! [14:53:44] morning ejegg! [14:54:09] I see a few more patch sets on that orphan rectifier function. reviewing now! [14:54:55] also, want to push through those phpcs patches today? [14:55:01] Would be nice to have in CI [14:55:20] and they're the kind of thing that'll get stale quick without an organized effort [14:55:42] ejegg okay will work on that, it turned out to be pretty dense but let m esee what i can do [14:55:52] looked like you had it passing [14:56:12] just that the reviewer asked you to split out the short array syntax? [14:56:30] I can take a stab at reviewing it as is [15:03:26] (CR) Ejegg: [C: -1] "A few little things to fix. The 'createReturnParameters' approach looks fine for now, but later we might invert the sense, so the results " (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [15:04:22] mepps sorry to distract with the phpcs suggestion - let's definitely consider that lower priority than the stuff we've acutally got in sprint... [15:13:45] (PS27) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [15:14:29] ejegg sorry just realized i had updated the rectify orphan patch on friday but never posted [15:14:53] ah cool [15:15:09] looks like that knocks out a few of those comments at least! [15:22:41] mepps do you want me to re-review patch 27, or are you working on ps28 with the last set of comments? [15:22:54] ejegg updating the patch [15:23:02] rockin [15:25:04] (PS28) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [15:25:11] okay ejegg take a look now [15:25:30] looking [15:26:24] paypal bit looks good [15:27:08] (CR) jerkins-bot: [V: -1] Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [15:27:20] hmm hang on [15:27:47] oh cool, fn calls in strings DO work, as long as the interpolated bit starts with {$ [15:38:02] (PS29) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [15:48:00] (CR) Ejegg: [C: 1] "This oughtta work! A few suggestions for polish." (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [15:52:02] (PS30) Mepps: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 [15:56:57] looking good mepps! [15:57:06] (PS31) Ejegg: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [15:57:53] (CR) Ejegg: [C: 2] "Looking forward to seeing this in action under drush!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [16:01:08] mepps I've got a couple small patches for the WX audit parser [16:01:17] the SmashPig one is ready for review: [16:01:35] https://gerrit.wikimedia.org/r/373702 [16:01:51] the CRM one will need to pull in the lib update once that's merged [16:03:46] (PS2) Mepps: WX audit files: get at least date from sparse refunds [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373702 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [16:03:49] (CR) Mepps: [C: 2] WX audit files: get at least date from sparse refunds [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373702 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [16:03:54] thanks! [16:04:03] I'll get the CRM one prepped asap [16:04:06] cool [16:04:45] (Merged) jenkins-bot: WX audit files: get at least date from sparse refunds [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/373702 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [16:06:00] (Merged) jenkins-bot: Rectify orphan function [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/369996 (owner: Mepps) [16:17:01] (PS3) Ejegg: Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) [16:17:06] ok, i think that'll pass [16:23:31] fr-tech I'm going to deploy a CRM update with just the DonationInterface library changes [16:24:07] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374346 [16:25:00] (CR) jerkins-bot: [V: -1] Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [16:25:27] hmm [16:28:32] (PS1) Ejegg: Update Donation Interface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/374347 [16:28:41] (CR) Ejegg: [C: 2] Update Donation Interface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/374347 (owner: Ejegg) [16:29:17] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374346 [16:31:46] (PS4) Ejegg: Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) [16:34:19] hi XenoRyet! [16:34:24] bye... [16:34:30] Hi XenoRyet! [16:34:36] Hi [16:34:53] how was the weekend? [16:35:05] Not too bad. Been pretty hot here. [16:36:42] Thanks for the CR on that python stuff. No problems getting it running? [16:37:18] Nope, once I got the config and the test data sorted, it ran fine. [16:37:29] rockin! [16:37:30] (Merged) jenkins-bot: Update Donation Interface library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/374347 (owner: Ejegg) [16:37:48] Yep, good times. [16:37:56] XenoRyet: looks like the they might need the 'submit' button pushed still... [16:38:14] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374346 (owner: Ejegg) [16:39:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374346 (owner: Ejegg) [16:40:53] (CR) XenoRyet: [V: 2] Remove web app bits of DjangoBannerStats [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/358424 (owner: Ejegg) [16:41:13] There we go. All submitted. [16:42:12] thanks! [16:42:39] now we can see about getting the CI box running tox and merging for us... [16:50:25] (PS2) Ejegg: Set dummy response codes statically [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373671 [16:50:47] mepps lmk if you find that one useful for writing drush tests ^^^ [16:52:14] also, the CRM part of the WX fix is passing tests: https://gerrit.wikimedia.org/r/373958 [17:49:09] ok, gonna step out for lunch, then I'll actually do that crm deploy [18:10:30] (CR) Mepps: [C: 2] Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [18:16:10] (Merged) jenkins-bot: Deal with sparse refund records in WX files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373958 (https://phabricator.wikimedia.org/T173875) (owner: Ejegg) [18:30:44] !log updated CiviCRM from c30ec135395d952c3a1ce5b2320f5a2a40367b2d to 200f34ba512a8160860cb434b5e7373f2f98a1c9 [18:30:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:41:41] Fundraising-Backlog: Convert all encoded HTML name data for JP to UTF-8 - https://phabricator.wikimedia.org/T174190#3559614 (Ejegg) OK, looks like there's no way to do this right in the database, so it'll have to be a batch job reading out the names, converting them, and writing them back in. Let's also try... [18:46:42] drat, ingenico recurring needs a lil fix [18:52:54] (PS1) Ejegg: Ensure civicrm_initialize() called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374377 [18:53:16] fr-tech ^^^ my 'Oh, by the way...' fix seems to have been a bit off [18:59:08] XenoRyet: you up for another quick CR? [18:59:26] (CR) Mepps: [C: 2] Ensure civicrm_initialize() called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374377 (owner: Ejegg) [18:59:26] Sure, that one you just posted? [18:59:29] trying to unbreak that thing from last week that I just deployed [18:59:35] ah, thanks mepps! [19:00:26] Beat me to it. [19:01:34] hehe, there's this stuff if you've whetted your appetite for CR: [19:01:46] https://gerrit.wikimedia.org/r/373974 (tests for templating) [19:02:11] https://gerrit.wikimedia.org/r/364790 (cache template loads) [19:02:52] and a string of deletions: https://gerrit.wikimedia.org/r/373975 , https://gerrit.wikimedia.org/r/373976 , https://gerrit.wikimedia.org/r/373977 [19:02:57] Sure, I could take a look at that one. I had also started taking a look at https://gerrit.wikimedia.org/r/#/c/372157/2 and/or https://gerrit.wikimedia.org/r/#/c/363744/ from the review backlog [19:02:57] (CR) Mepps: [C: 2] Set dummy response codes statically [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373671 (owner: Ejegg) [19:03:19] But yea, I'm happy to work through some CR for this stuff. [19:03:31] Feels like a CR kind of day. [19:03:32] oh cool, I'd love feedback on those too [19:03:50] XenoRyet: there's one thing I can't figure out in the iframe positioning [19:04:03] Yea? [19:04:06] if you're in the frame and you tab past the pay button a couple time [19:04:18] it scrolls all the way down to show a privacy policy link [19:04:31] and hides the rest of the iframe [19:04:41] super unhelpful, especially with the scroll bars hidden [19:04:51] (Merged) jenkins-bot: Set dummy response codes statically [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373671 (owner: Ejegg) [19:04:57] I kept trying to catch the scroll event on the enclosing div and stop it [19:05:05] or reset the div position [19:05:07] (Merged) jenkins-bot: Ensure civicrm_initialize() called [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374377 (owner: Ejegg) [19:05:10] but nothing seemed to work [19:05:14] hmm [19:05:34] would love to hear any suggestions [19:05:40] Yea, I'll see if I can figure anything out on that. [19:06:15] ok, lemme get that fix out, along with the WX audit update [19:09:38] (PS1) Ejegg: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/374391 [19:11:26] (CR) Ejegg: [C: 2] Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/374391 (owner: Ejegg) [19:11:55] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374392 [19:12:01] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374392 (owner: Ejegg) [19:23:09] (Merged) jenkins-bot: Update SmashPig library [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/374391 (owner: Ejegg) [19:23:12] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/374392 (owner: Ejegg) [19:24:59] !log updated CiviCRM from 200f34ba512a8160860cb434b5e7373f2f98a1c9 to 7dfea0dd7677d1389975d9b3cf369981b7bdb38b [19:25:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:28:04] well, neither recurring globalcollect charge not orphan rectifier are blowing up on launch [19:28:12] but neither one has any data ready, either [19:33:11] (CR) Mepps: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:33:18] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:34:06] (PS15) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [19:35:20] XenoRyet: let me know if you plan to deploy that SmashPig change - there's another bit in the pipeline I'd like to watch when it goes out [19:36:26] Ah yea, hadn't thought about deploying that yet, but I suppose it would be good to get out. [19:36:56] Maybe later this afternoon, or tomorrow morning. [19:36:59] k [19:39:40] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:43:53] ejegg we need to paypal to the donationinterface settings for crm: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/4865/console [19:46:20] mepps oh shoot, guess so [19:46:28] lessee where that stuff comes from [19:53:40] ejegg looks like it's in settings.php [19:54:00] in local-settings [20:13:05] cwd or Jeff_Green : fr-tech is in the hangout if y'all want to discuss anything [20:13:45] i'm just working on prometheus at this point but happy to hop on if y'all got a topic? [20:14:40] ejegg: what I'd be inclined to discuss if people want to discuss is query activity, but that's not urgent and probably better suited to an IRC conversation [20:14:59] ok, cool [20:59:11] woot, this wx audit stuff seems to be working, though [21:00:00] gonna run it again with the log directory pointing at the old indium files - there are a random scattering of super old transactions showing up [21:01:09] hmm, might need to recreate the globalcollect audit's 'alternate log directory' feature if those are going to keep coming in [21:06:41] !log switched nightly Ingenico audit from wr1 to wx file parsing [21:06:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:30:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Drop IDs on cache tables - https://phabricator.wikimedia.org/T174404#3560636 (Ejegg) Regarding @Jgreen's concern about innodb performance without primary keys: https://blog.jcole.us/2013/05/02/how-does-innodb-behave-without-a-primary-key/ All three hav... [22:50:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create lists of CiviCRM groups to allow MG & DS to review with a view to tidy up - https://phabricator.wikimedia.org/T174407#3560690 (Eileenmcnaughton) [22:51:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review reducing smartGroupCache clearing per https://issues.civicrm.org/jira/browse/CRM-21109 - https://phabricator.wikimedia.org/T174408#3560702 (Eileenmcnaughton) [22:56:10] !log turned fundraising orphan rectifier back on [22:56:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:00:53] k, i'm heading out for the night [23:01:19] i've left the recurring donation processor off, but I've got like 5 reminders in my calender to slow-start it tomorrow [23:13:57] !log re-enabled dedupe jobs [23:14:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log