[00:02:10] (PS5) Ejegg: Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 [00:06:37] (PS3) Ejegg: Show watchdog messages on failed tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374910 [00:07:41] (PS6) Ejegg: Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 [00:07:43] (CR) jerkins-bot: [V: -1] Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 (owner: Ejegg) [00:13:24] (PS7) Ejegg: Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 [00:13:32] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Restore Live CiviCRM data to staging - https://phabricator.wikimedia.org/T174636#3568640 (Eileenmcnaughton) [00:14:05] (PS2) Ejegg: TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 [00:20:09] (CR) jerkins-bot: [V: -1] TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [00:20:15] grr [00:20:49] oic [00:22:21] (PS3) Ejegg: TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 [00:23:20] (PS4) Ejegg: TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 [00:28:51] (CR) jerkins-bot: [V: -1] TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [00:34:16] (PS5) Ejegg: WIP TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 [00:35:17] * ejegg|away is doing a bad job of being |away [00:39:51] (CR) jerkins-bot: [V: -1] WIP TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [00:41:34] (PS6) Ejegg: WIP TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 [00:47:05] (CR) jerkins-bot: [V: -1] WIP TY mailer: skip extra queries to look up custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [00:53:17] hrmph... contribution API is all kinds of janky in v3 [01:13:39] (PS7) Ejegg: TY mailer: skip extra queries to look up contact and custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 [01:17:37] (PS4) Ejegg: Show watchdog messages on failed tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374910 [01:57:15] (PS5) Ejegg: Show watchdog messages on failed tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374910 [02:01:29] (PS8) Ejegg: Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 [05:42:43] (PS14) Eileen: Add ability to find duplicates for selected contacts. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) [05:49:41] (PS15) Eileen: Add ability to find duplicates for selected contacts. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) [05:51:46] (PS16) Eileen: Add ability to find duplicates for selected contacts. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) [05:57:08] Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi dedupe: offer dedupe option in a regular search - https://phabricator.wikimedia.org/T151270#2812756 (Eileenmcnaughton) This is on staging now & seems to work ok - eg. searc... [05:57:53] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create lists of CiviCRM groups to allow MG & DS to review with a view to tidy up - https://phabricator.wikimedia.org/T174407#3568907 (Eileenmcnaughton) a:Eileenmcnaughton [05:58:35] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, Patch-For-Review: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (Marostegui) Hi, Just to make sure I am getting this right, centralnotice database means metawiki databas... [06:03:56] Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi dedupe: offer dedupe option in a regular search - https://phabricator.wikimedia.org/T151270#3568910 (Eileenmcnaughton) a:Eileenmcnaughton [06:04:17] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review reducing smartGroupCache clearing per https://issues.civicrm.org/jira/browse/CRM-21109 - https://phabricator.wikimedia.org/T174408#3560702 (Eileenmcnaughton) a:Eileenmcnaughton [06:05:56] Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, Fundraising-Analysis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Probably cause of failmail deadlocks - soft credit search pain - https://phabricator.wikimedia.org/T130068#2124330 (Eileenmcnaughton) a:Eileenmcnaug... [06:53:38] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Deal with diacritic conflicts on name checks - https://phabricator.wikimedia.org/T149763#3568964 (Eileenmcnaughton) [07:44:24] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, Patch-For-Review: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (Reedy) >>! In T135405#3568908, @Marostegui wrote: > Hi, > > Just to make sure I am getting this right, c... [07:48:30] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, and 2 others: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#3569045 (Marostegui) >>! In T135405#3569043, @Reedy wrote: >>>! In T135405#3568908, @Marostegui wrote: >> Hi, >> >> Just... [07:51:38] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, and 2 others: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#3569059 (Reedy) >>! In T135405#2553819, @AndyRussG wrote: >>>! In T135405#2374114, @Base wrote: >> The tables in the desc l... [07:59:23] (PS1) Eileen: Resolve diacritic merge conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) [13:40:57] (CR) Mepps: [C: 2] CiviMailStore: stop using deprecated Civi fn [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374902 (owner: Ejegg) [13:42:08] (CR) Mepps: [C: 2] Show watchdog messages on failed tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374910 (owner: Ejegg) [13:44:54] Thanks, mepps! [13:45:15] no problem ejegg! you're on early [13:45:17] that one really helped debugging the thank you tests on jenkins [13:45:37] yeah, I'll be popping back out to bike up to the office in a bit [13:45:49] cool [13:47:49] (Merged) jenkins-bot: CiviMailStore: stop using deprecated Civi fn [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374902 (owner: Ejegg) [13:49:05] (Merged) jenkins-bot: Show watchdog messages on failed tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374910 (owner: Ejegg) [14:25:02] (CR) Mepps: [C: 2] Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 (owner: Ejegg) [14:29:11] thanks again! I do want to add a bunch more of those, for other currencies, some of the tags, no_thank_you, etc. [14:30:27] (Merged) jenkins-bot: Add unit tests for Thank You mailer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374903 (owner: Ejegg) [14:30:37] mepps: also, it looks like apiv3 doesn't allow you to join to other entities from Contribution [14:30:44] (see note at bottom of https://docs.civicrm.org/dev/en/stable/api/joins/ ) [14:31:13] which is why I swapped out the API calls for a DAO::executeQuery in the followup to try to make TY info gathering faster [14:33:37] gotcha ejegg, that makes sense [14:33:52] (PS8) Mepps: TY mailer: skip extra queries to look up contact and custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [14:33:55] (CR) Mepps: [C: 2] TY mailer: skip extra queries to look up contact and custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [14:34:47] thanks again! Heading up to the co-working space [14:40:05] (Merged) jenkins-bot: TY mailer: skip extra queries to look up contact and custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374915 (owner: Ejegg) [14:59:39] ejegg what's the require_once path for donationinterfacetestcase? what i tried returned not found [15:04:49] mepps it would have a lot of ../../, then vendor/wikimedia/donation-interface/Tests/DonationInterfaceTestCase.php [15:07:44] I'm going to try that ty mail stuff in production... [15:08:32] then I should really review some of eileen's stuff [15:10:54] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/375009 [15:10:56] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/375009 (owner: Ejegg) [15:12:00] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/375009 (owner: Ejegg) [15:13:14] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/375010 [15:13:21] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/375010 (owner: Ejegg) [15:14:09] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/375010 (owner: Ejegg) [15:19:23] !log turned off donation queue consumer and thank you job [15:19:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:20:51] !log updated SmashPig from 8f4388d407f313c1083cf96ed106efcc5d5a29f7 to 8eb98c10ff1129ea65dd81559656001c819cc12f [15:21:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:25:18] !log updated civicrm from f00611d9aa3ae4a1ffbff70dcca90c7ae07b6c68 to 820bd98c7c23a851c38a75111c8c1532c781e198 [15:25:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:46:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scripts with a time limit should use real process elapsed time - https://phabricator.wikimedia.org/T174690#3570307 (Ejegg) [15:51:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Epic: DonationInterface should not be a dependency of our CiviCRM install - https://phabricator.wikimedia.org/T174691#3570327 (Ejegg) [15:52:05] Fundraising-Backlog: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806#3570340 (Ejegg) [15:52:20] Fundraising-Backlog: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806#3344909 (Ejegg) Let's start on this by creating the subject page in metawiki! [16:02:07] Fundraising-Backlog: Thank you email subject and body should be translated in same place - https://phabricator.wikimedia.org/T167806#3570376 (Ejegg) Hmm, that could be a fun API script exercise [16:03:14] dstrine: are you getting 'the call isn't available right now' from hangouts? [16:04:32] ejegg: Same here [16:09:02] ejegg there's a new link in email now [16:09:13] thanks mepps ! [16:09:47] Fundraising-Backlog: Fix LandingCheck language fallback - https://phabricator.wikimedia.org/T174693#3570428 (Ejegg) [16:35:47] !log re-enabled donation queue consumer and thank you mail sender [16:36:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:56:06] Well that was a nice result! [16:56:11] mepps, that patch you +2ed this morning got us from 230 TY emails per 40 second run to 455 TY emails in 30 seconds [16:56:50] Maybe we can even turn CiviMail record creation on [16:58:42] Awesome! [17:12:15] (PS1) Ejegg: Resolve ty batch start timestamp in PHP [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375027 (https://phabricator.wikimedia.org/T149745) [17:12:59] Fundraising Sprint Quill Pencil, Fundraising-Analysis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Recurring slow query (around 10 secs) from thank you job - https://phabricator.wikimedia.org/T149745#3570733 (Ejegg) a:Ejegg [17:26:27] (PS1) Ejegg: Donation consumer: account for drush startup time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375030 (https://phabricator.wikimedia.org/T174690) [17:27:40] (PS1) Ejegg: Thank you mailer: use process elapsed time to limit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375032 (https://phabricator.wikimedia.org/T174690) [17:28:07] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Scripts with a time limit should use real process elapsed time - https://phabricator.wikimedia.org/T174690#3570785 (Ejegg) p:Triage>Normal a:Ejegg [17:29:37] ok, i'm doing that thing again [17:30:02] * ejegg will work on tasks in sprint... [17:30:09] ...after lunch [17:35:53] (PS2) Ejegg: Donation consumer: account for drush startup time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375030 (https://phabricator.wikimedia.org/T174690) [17:35:55] (PS2) Ejegg: Thank you mailer: use process elapsed time to limit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375032 (https://phabricator.wikimedia.org/T174690) [18:07:51] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create lists of CiviCRM groups to allow MG & DS to review with a view to tidy up - https://phabricator.wikimedia.org/T174407#3570932 (CaitVirtue) Danny is OOO until 9/6 [18:51:38] Fundraising-Backlog: Revoke AWight's donatewiki account - https://phabricator.wikimedia.org/T168430#3571128 (K4-713) I have removed @awight 's admin privs on donate wiki. [18:57:02] Fundraising-Backlog: Revoke AWight's donatewiki account - https://phabricator.wikimedia.org/T168430#3571135 (K4-713) I have also granted admin to @Ejegg, and bureaucrat to @Pcoombe on donate wiki. Done. [18:59:54] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421#3571144 (Pcoombe) [18:59:56] Fundraising-Backlog: Revoke AWight's donatewiki account - https://phabricator.wikimedia.org/T168430#3571143 (Pcoombe) Open>Resolved [19:24:18] (PS1) Mepps: Wrap setDummyGatewayResponseCode for TestingGlobalCollectAdapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375060 [19:25:03] ejegg, take a look at above--might that solve the issue in the broken crm tests if i called that as a static on testing global collect adapter [19:25:06] ? [19:31:16] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3571236 (Jgreen) We started testing on mintaka, here's what changed: 1) @ayounsi enabled ge-0/0/11 and added description mintaka:eth1 2) @jgreen did (by... [19:33:17] mepps shoot, that'll still need to find DonationInterfaceTestcase [19:33:20] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3571237 (Jgreen) @ayounsi also enabled and labeled frdb2001/eth1's switch port. [19:33:36] ejegg ahh [19:33:59] mepps: we could revive awight's testing traits task [19:34:09] but then we'd need to make sure the trait file was being autoloaded [19:34:31] for now, I think the easiest is to require_once the DonationInterfaceTestCase, maybe in the bootstrap file [19:34:39] lemme see if i can make that work [19:38:02] (PS2) Mepps: Update composer and fix currency rates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374852 [19:38:13] okay ejegg, work off that updated patch ^ [19:39:36] (PS1) Ejegg: Require DI testing stuff in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 [19:40:38] (PS2) Ejegg: Require DI testing stuff in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 [19:41:36] (CR) jerkins-bot: [V: -1] Update composer and fix currency rates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374852 (owner: Mepps) [19:41:49] (PS3) Ejegg: Require DI testing stuff in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 [19:42:46] mepps ah, just saw your comment. will rebase! [19:43:46] (CR) jerkins-bot: [V: -1] Require DI testing stuff in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 (owner: Ejegg) [19:43:56] huh [19:44:27] aargh, MediaWikiTestCase dependency.... [19:44:47] ok, we do need to fix the testing stuff in DonationInterface [19:45:02] awight's patch with traits is probably the way to go [19:45:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigate email: BH data storage/transfer issue for iPad donations - https://phabricator.wikimedia.org/T174719#3571255 (DStrine) [19:47:46] AndyRussG: are you available for a meeting? [20:00:13] Fundraising Sprint Quill Pencil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, and 2 others: WMDE banners failing to save - Timing out on save - https://phabricator.wikimedia.org/T170591#3436052 (DStrine) [20:35:41] ejegg in terms of the tab scrolling bug, the only reliable fix i came up with was greatly increasing the height of the iframe div, of course it pushes everything down and doesn't fit the asthetic [20:36:03] yeah, annoying, huh? [20:36:04] i also found if i decreased the height of the iframe it at least scrolled less far if i tabbed too far [20:36:08] yup! [20:36:13] very [20:36:47] hmm, maybe increase the height but give it a negative bottom margin so the stuff below it overlaps instead? [20:36:49] i kind of wonder if we could absolutely position the items below on top of that div [20:37:12] that sounds like a similar idea to what i just proposed [20:37:15] abs position wouldn't work because different forms have different numbers of fields [20:37:58] jeez, this traits thing isn't working quite as well as I thought it would [20:40:14] :( ejegg that's proven to be tricky! [20:40:19] both of these in fact [20:42:07] so far no luck with margin-bottom [20:47:48] aargh, looks like traits can't override the parent methods [20:50:04] or... can they? [21:13:06] woot, down to one failure... [21:16:47] (PS3) Ejegg: Use traits to consolidate TestingAdapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299150 (owner: Awight) [21:16:47] ok mepps, ^^^ should get us back to where we started with the testing adapters, just with the code de-duplicated [21:16:49] (PS1) Ejegg: Revert "Set dummy response codes statically" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375082 [21:17:07] so now I'mma do one more patch to make that stuff static [21:18:51] (CR) jerkins-bot: [V: -1] Use traits to consolidate TestingAdapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299150 (owner: Awight) [21:29:36] aw man, it worked on my machine [21:30:30] oh, sill composer hash mismatch [21:33:34] and wrong version... [21:34:08] (PS4) Ejegg: Use traits to consolidate TestingAdapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299150 (owner: Awight) [21:51:38] (PS1) Ejegg: Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 [21:52:39] fr-tech OK, those ^^^ should get us back to being able to use the test adapters in CRM test cases [21:53:03] (CR) jerkins-bot: [V: -1] Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 (owner: Ejegg) [21:55:59] (PS2) Ejegg: Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 [21:56:10] phew, think that should do it [21:56:35] AndyRussG: Abouts? [21:56:48] Or, anyone else that's reasonably familiar with centralnotice? [21:58:02] (CR) jerkins-bot: [V: -1] Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 (owner: Ejegg) [21:59:34] Reedy: I'm mildly familiar with it. What's up? [22:00:02] Just wanted a sanity check on the schema [22:00:03] https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/CentralNotice.sql [22:00:12] For https://phabricator.wikimedia.org/T135405#2553819 [22:00:22] There's no actual private data stored in it, is there? [22:01:12] Reedy: nope, that should all be visible! [22:01:17] perfect, thanks :D [22:01:52] Reedy: and thank you for looking into that labs replication! [22:02:19] ejegg: np [22:02:29] Would you mind just commenting on the task for the audit trail? :) [22:02:39] (PS3) Ejegg: Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 [22:02:48] sure thing [22:04:25] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, and 2 others: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (Ejegg) Yes, everything in the CentralNotice schema can be visible to the public. Most of it is already visible via... [22:05:01] ejegg: Reedy: ^ :) thx! [22:05:26] woo, open data [22:07:59] XenoRyet: if you have time today, mind reviewing those DonationInterface testing patches? Hoping to get a usable set of testing adapters to mepps for tomorrow morning [22:08:17] Yea, I'll try to get to it in a bit here. [22:09:45] thanks! [22:10:25] so are you anonymizing a menagerie of different refund IPNs? [22:11:08] (PS3) XenoRyet: Fix PayPal Gateway Tagging [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/374913 (https://phabricator.wikimedia.org/T171351) [22:13:27] (CR) Ejegg: "Let's put those subscr_ids into new refund_recurring... files. Also, can you add anonymised versions of the messages that you found to bre" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/374913 (https://phabricator.wikimedia.org/T171351) (owner: XenoRyet) [22:16:15] (CR) Ejegg: [C: 2] "Sorry to take so long reviewing this. Seems to function identically, but with less code. Woo!" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373173 (owner: Eileen) [22:22:20] (Merged) jenkins-bot: Towards CRM-20155 clean up form code in order to consolidate function use. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373173 (owner: Eileen) [22:27:32] (CR) Ejegg: [C: -2] "I need to totally revert that other patch to get rid of the dependency on MediaWikiTestCase... See I7d6321a3ef67 and its two parent patche" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375060 (owner: Mepps) [22:33:20] (CR) XenoRyet: [C: 2] Revert "Set dummy response codes statically" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375082 (owner: Ejegg) [22:34:02] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, and 2 others: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#2297843 (madhuvishy) @Marostegui @Reedy Merged and ran maintain-views in all the labs replicas (1001/3/9/10/11) [22:34:09] (CR) XenoRyet: [C: 2] Use traits to consolidate TestingAdapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299150 (owner: Awight) [22:34:23] (CR) XenoRyet: [C: 2] Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 (owner: Ejegg) [22:34:45] undead patch lives! [22:34:53] muah ha ha ha ha [22:35:10] (Merged) jenkins-bot: Revert "Set dummy response codes statically" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375082 (owner: Ejegg) [22:36:03] (Merged) jenkins-bot: Use traits to consolidate TestingAdapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/299150 (owner: Awight) [22:36:15] (Merged) jenkins-bot: Set dummy response codes statically, round 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375086 (owner: Ejegg) [22:49:03] (CR) Ejegg: "Code looks good, but having trouble making it work locally. Once I got 'Smarty error: unable to read resource: "CRM/Contact/Form/Task/Find" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [22:51:59] (PS4) Ejegg: Require DI testing stuff in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 [22:53:23] (CR) Ejegg: "mepps, XenoRyet merged the DonationInterface testing fixes and I updated the package on packagist. Want to update again, and maybe squash " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374852 (owner: Mepps) [22:54:12] (CR) jerkins-bot: [V: -1] Require DI testing stuff in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 (owner: Ejegg) [23:22:40] Fundraising-Backlog, DBA, Data-Services, MediaWiki-extensions-CentralNotice, and 2 others: Replicate CentralNotice tables to Labs - https://phabricator.wikimedia.org/T135405#3571951 (madhuvishy) Open>Resolved a:madhuvishy I'm closing this as resolved since running the maintain-views s...