[01:03:02] (CR) Eileen: "hmm there have been quite a few iterations of this patch! There is some risk you have a cached version of that file - since I think it's w" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [01:07:56] (CR) Eileen: Towards CRM-20155 clean up form code in order to consolidate function use. (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373173 (owner: Eileen) [04:46:04] (PS1) Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/375151 [04:47:57] (PS1) Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/375168 [04:49:48] (PS1) Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/375192 [04:50:00] (PS1) Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/375193 [04:52:23] (PS1) Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/375224 [06:18:14] (CR) Niharika29: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/375151 (owner: Libraryupgrader) [06:27:58] (CR) MaxSem: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/375168 (owner: Libraryupgrader) [06:28:19] (CR) MaxSem: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/375192 (owner: Libraryupgrader) [06:28:33] (CR) MaxSem: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/375193 (owner: Libraryupgrader) [06:29:46] (CR) MaxSem: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/375224 (owner: Libraryupgrader) [08:06:32] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/375151 (owner: Libraryupgrader) [08:53:19] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/375168 (owner: Libraryupgrader) [08:53:23] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/375192 (owner: Libraryupgrader) [08:53:25] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/375193 (owner: Libraryupgrader) [09:01:23] (Merged) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/375224 (owner: Libraryupgrader) [13:22:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: Banner Editting History Integrated within CentralNotice - https://phabricator.wikimedia.org/T174787#3573059 (Jseddon) [13:23:53] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Tracking: CentralNotice should detect edit conflicts - https://phabricator.wikimedia.org/T174788#3573074 (Jseddon) [13:47:01] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3573128 (Jgreen) a:Jgreen [13:48:04] fundraising-tech-ops, Operations, netops: bonded/redundant network connections for fundraising hosts - https://phabricator.wikimedia.org/T171962#3481495 (Jgreen) @jgreen configured active-backup for frdb2001. I stopped mysql first, and the reconfigure seemed to go smoothly without a reboot this time [14:01:26] ejegg i'm seeing file not found errors on your patch above [14:10:39] just saw your note on the patch [14:16:57] (PS5) Mepps: Require DI testing in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 (owner: Ejegg) [14:28:22] yay! build succeeded! not sure if i can +2 that myself though ejegg/XynoRyet [14:53:49] mepps, want to squash that patch in with the parent patch? [14:54:11] Just 'cause the parent patch won't merge as is? [14:55:43] we can actually abandon the parent patch, or i can go back and use that change id and update the commit message [14:56:34] (PS3) Mepps: Require DI testing in phpunit bootstrap, update composer, fix currency rates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374852 [14:56:36] oh, we still need the wmf_civicrm and RecurringGlobalCollectTest fixes, though [14:56:42] right? [15:05:24] we don't need the recurringglobalcollect stuff because the traits fix handles it [15:05:30] but we do need the currency rates [15:09:04] k, cool. [15:09:19] (Abandoned) Mepps: Require DI testing in phpunit bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375066 (owner: Ejegg) [15:09:32] we just need to merge thsi one: https://gerrit.wikimedia.org/r/#/c/374852/3 [15:10:13] next i need to deal with the Title class not being found [15:11:56] (CR) Ejegg: [C: 2] Require DI testing in phpunit bootstrap, update composer, fix currency rates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374852 (owner: Mepps) [15:12:21] mepps that's something we'll need to fix in the PaypalExpressAdapter [15:12:30] ejegg yup [15:13:32] So, we'll just want to move the code setting that value to where we know we're making that particular API call [15:17:13] (Merged) jenkins-bot: Require DI testing in phpunit bootstrap, update composer, fix currency rates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374852 (owner: Mepps) [15:19:28] so from what i'm seeing that means re-implementing stageData in the paypalexpressadapter and saying only use the ReturnUrl transformation if transaction is RETURNURL? [15:23:31] mepps hmm, lemme see [15:25:29] mepps, how about we take PaypalExpressReturnUrl out of the transformers.yaml [15:25:57] and then add it back in doPayment [15:26:30] (we'd add it to $this->config['transformers']) there [15:36:58] (PS1) Mepps: Only use Title class on doPayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375396 [15:37:07] ejegg ^^ [15:42:57] (CR) Ejegg: "Code looks good, just some WS and a stray 't'" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375396 (owner: Mepps) [15:54:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner under zh-min-nan language is broken - https://phabricator.wikimedia.org/T174768#3573478 (DStrine) [16:04:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: CentralNotice banner under zh-min-nan language is broken - https://phabricator.wikimedia.org/T174768#3573507 (Jseddon) Open>Resolved a:Jseddon 9 years this has been broken it would seem. Bet... [16:35:09] (CR) Ejegg: [C: 2] "This works great after fixing my test data! Some of my contacts had NULL contact_type. Couple of tiny things to fix later." (4 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [16:44:04] (Merged) jenkins-bot: Add ability to find duplicates for selected contacts. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373155 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [16:44:06] (CR) Ejegg: [C: -1] "Looks like this particular patch was abandoned upstream in favor of https://github.com/civicrm/civicrm-core/pull/10405 ." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373176 (https://phabricator.wikimedia.org/T160571) (owner: Eileen) [16:46:29] (PS4) Ejegg: CRM-21125 permit class assignment on reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374719 (owner: Eileen) [16:46:41] (CR) Ejegg: [C: 2] CRM-21125 permit class assignment on reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374719 (owner: Eileen) [16:57:10] (Merged) jenkins-bot: CRM-21125 permit class assignment on reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374719 (owner: Eileen) [17:11:55] (PS1) Ejegg: Update pt-br and ja Thank You letters [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/375403 (https://phabricator.wikimedia.org/T173809) [17:25:52] (PS2) Mepps: Only use Title class on doPayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375396 [17:26:06] updated ejegg ^^ [17:27:20] (PS3) Ejegg: Only use Title class on doPayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375396 (owner: Mepps) [17:27:28] (CR) Ejegg: [C: 2] Only use Title class on doPayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375396 (owner: Mepps) [17:27:36] good stuff! [17:27:53] i'll update on packagist [17:28:24] and thanks! [17:29:23] (Merged) jenkins-bot: Only use Title class on doPayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375396 (owner: Mepps) [17:30:33] (PS2) Pcoombe: Fix double continue button situations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) [17:32:19] (CR) jerkins-bot: [V: -1] Fix double continue button situations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) (owner: Pcoombe) [17:35:27] (PS3) Pcoombe: Fix double continue button situations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) [17:36:53] Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Campaign-Support: Periodically run Civi contact import performance tests, note trends - https://phabricator.wikimedia.org/T146338#3573748 (Ejegg) Thank you let... [17:40:52] yay ejegg! finally getting errors actually related to the work i'm doing :) [17:41:28] (CR) Ejegg: Actually cache fallback language templates (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374583 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [17:46:00] (CR) Ejegg: "if you look in e.g. process-control/20170831/thank_you_mail_send-20170831-165021.log.bz2 you can see it's still repeatedly showing message" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374583 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [17:49:20] mepps: woo progress! [17:57:31] (PS2) Ejegg: Actually cache fallback language templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374583 (https://phabricator.wikimedia.org/T170435) [17:57:54] (PS3) Ejegg: Actually cache fallback language templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374583 (https://phabricator.wikimedia.org/T170435) [18:13:30] (PS1) Ejegg: Update RecurringGlobalCollectTest for static traits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375413 [18:16:05] (PS2) Ejegg: Update RecurringGlobalCollectTest for static traits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375413 [18:16:37] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, Recurring-Donations: Don't retry recurring donations after expired card or fraud flag errors - https://phabricator.wikimedia.org/T174450#3562413 (Ejegg) a:Ejegg [18:18:46] (CR) Ejegg: Resolve diacritic merge conflicts. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) (owner: Eileen) [18:21:04] (PS17) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [18:21:22] ejegg can you take a look at the patch above and let me know how you think testing should be handled [18:21:35] we're getting an error when it tries to do the second transaction in process donor return [18:23:57] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [18:28:40] mepps sure, one sec! [18:37:58] mepps looks like there's a validation error stopping it from actually trying the (fake) transaction, trying to figure out which field [18:38:59] mepps oh shoot, the orphan slayer needs to map one field from the message to the gateway parameters [18:39:07] it should change 'gross' to 'amount' [18:39:55] the test should or the slayer code should ejegg? [18:40:16] the slayer itself [18:40:23] before it creates the adapter [18:41:54] (PS18) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [18:43:30] (PS19) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [18:46:19] okay ejegg still seeing the same error [18:46:21] mepps oh, gateway is failing validation [18:46:43] we should set $wgDonationInterfaceGatewayAdapters['paypal_ec'] instead of 'paypal' [18:46:52] oh, and the orphan message should match [18:48:59] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [18:51:34] still seeing the same error ejegg and now it's in CI too ^^ [18:53:29] ejegg i'm not seeing validation errors in there but maybe i'm missing something? [18:53:33] mepps, do you need to update composer.lock again? [18:53:44] just did ejegg [18:53:57] ah, cool! [18:54:16] pulling down latest to check locally [18:54:26] I'm setting a break point deep inside the di lib [18:54:52] DataValidator.php line 241 [18:55:16] so, before it tries to curl_transaction, it validates the data and bails if there are issues [18:55:39] which will lead to getCommunicationStatus returning false [18:58:08] mepps oh, you still need to update all the 'paypal' strings in OrphanSlayerTest to read 'paypal_ec' [18:58:35] lines 28, 44, 45, 52 [18:58:37] oh ejegg sorry, did that locally but didn't push [18:58:47] still getting the error luckily with ath change [18:58:58] (PS20) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [18:59:46] oops, except for the payment_method - that one should stay [18:59:49] 'paypal' [19:04:26] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:12:40] (PS21) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [19:18:23] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:28:55] okay i tried debugging in that file with these changes and it doesn't look like it's going there [19:29:11] but i couldn't get it to run correctly in phpstorm, just did a print_r die statement [19:36:47] shoot, still an error on amount [19:36:56] ohh, do we need to set the min and max? [19:37:12] in the DonationInterface globals [19:37:16] ahh [19:38:47] is that pricefloor and priceceiling? [19:42:26] mepps: you need to map 'gross' to 'amount' before you create the adapter [19:43:09] also yep, those are the ones [19:43:52] hmm, that bootstrap file should probably just include the test settings from DonationInterface [19:44:47] want to add another require_once line with donation-interface/tests/phpunit/TestConfiguration.php ? [19:45:04] That'll save us having to set all that stuff in every test [19:45:56] oop, standup time [20:05:48] (PS1) Mepps: Fix missing status variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375432 [20:13:58] (PS22) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [20:14:20] ejegg see that donation interface patch, just fixed a bug that's a blocker to the crm work [20:16:42] it's close ejegg, only issue now is that it's trying to use the orphanslayertest object as $this in pending database [20:16:45] i find that strange [20:17:12] .PHP Fatal error: Call to undefined method OrphanSlayerTest::prepareAndExecute() [20:19:02] hrm? [20:20:02] that almost seems like a phpunit version conflict - system vs vendor [20:20:34] (CR) Ejegg: [C: 2] Fix missing status variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375432 (owner: Mepps) [20:20:44] (CR) jerkins-bot: [V: -1] WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [20:21:29] okay i'll try deleting vendor and reinstalling [20:21:55] mepps shouldn't need to do that! [20:22:18] just if you have phpunit in vendor, make sure you're calling the one in vendor/bin rather than your system one [20:22:54] oh yeah i am [20:23:17] oh wait, now that I think about it, that's not at all the kind of error a phpunit version conflict would give [20:23:27] that is really weird... [20:23:34] lemme see [20:23:41] yeah... [20:24:15] mepps ooh, line 58 [20:24:26] should be ::get()->fetchMessage [20:24:37] (Merged) jenkins-bot: Fix missing status variable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375432 (owner: Mepps) [20:24:41] ahh [20:24:45] that makes sense [20:24:45] it's so weird that php even lets you call the function like that... [20:25:17] yeah seriously [20:29:42] (PS23) Mepps: WIP Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [20:34:31] tests are passing locally so hoping that works ^ [20:35:10] (CR) Ejegg: WIP Orphan Slayer Module, getting expected error message (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [20:42:29] (PS24) Mepps: Orphan Slayer Module, getting expected error message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [20:52:28] ooh, passing tests! [21:32:00] (CR) Ejegg: "This looks great! Only problem is I can't seem to run the old orphan-rectify drush command any more. Maybe don't move the old drush file i" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [21:40:39] XenoRyet: need any help with those IPN messages? [21:41:07] (PS2) Ejegg: CRM-21124 fix overlong cacheKey when deduping by criteria [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374677 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [21:41:17] (CR) Ejegg: [C: 2] CRM-21124 fix overlong cacheKey when deduping by criteria [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374677 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [21:41:40] Na, I've got 'em handled. Just procrastinating a bit because it's the tedious part and not worth a Friday deploy anyway. [21:41:44] I'll have 'em done soon though. [21:41:50] k. [21:42:10] plenty of CR available to distract yourself with... [21:42:15] Kinda got sucked into reading about scrummastering [21:43:09] But yea, point me at some CR and I could do that too. [21:43:45] the review column for the sprint has a bunch [21:43:54] let's see what's easy... [21:44:15] Yea, if you want to just sort the column or something I could just run down the list. [21:45:31] k, I put a few of the smaller ones on top of the column [21:45:37] should all be linked up to their patches [21:45:54] Good times [21:48:04] (CR) XenoRyet: [C: 2] Update pt-br and ja Thank You letters [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/375403 (https://phabricator.wikimedia.org/T173809) (owner: Ejegg) [21:52:03] (Merged) jenkins-bot: CRM-21124 fix overlong cacheKey when deduping by criteria [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374677 (https://phabricator.wikimedia.org/T151270) (owner: Eileen) [21:52:07] (Merged) jenkins-bot: Update pt-br and ja Thank You letters [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/375403 (https://phabricator.wikimedia.org/T173809) (owner: Ejegg) [22:05:14] (PS1) Ejegg: Cancel subscription on red-flag declined [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375449 (https://phabricator.wikimedia.org/T174450) [22:07:39] (PS3) Ejegg: Drop autoincrement ID on group_contact_cache [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374588 (https://phabricator.wikimedia.org/T174404) [22:10:29] (PS3) Ejegg: WIP Send more Minfraud params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) [22:10:48] (CR) XenoRyet: [C: 2] Actually cache fallback language templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374583 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [22:15:58] (Merged) jenkins-bot: Actually cache fallback language templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374583 (https://phabricator.wikimedia.org/T170435) (owner: Ejegg) [22:22:44] (CR) XenoRyet: [C: 2] Resolve ty batch start timestamp in PHP [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375027 (https://phabricator.wikimedia.org/T149745) (owner: Ejegg) [22:23:31] Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-2016-17-Q2-Campaign-Support: Periodically run Civi contact import performance tests, note trends - https://phabricator.wikimedia.org/T146338#3574475 (Eileenmcnaughton) Ni... [22:24:51] (PS4) Ejegg: Send more Minfraud params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) [22:25:14] Fundraising Sprint Quill Pencil, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Send more parameters to Maxmind minfraud service - https://phabricator.wikimedia.org/T128902#3574478 (Ejegg) [22:25:47] Fundraising Sprint Quill Pencil, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Send more parameters to Maxmind minfraud service - https://phabricator.wikimedia.org/T128902#2089698 (Ejegg) [22:27:22] Fundraising Sprint Quill Pencil, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Send more parameters to Maxmind minfraud service - https://phabricator.wikimedia.org/T128902#3574484 (Ejegg) [22:27:24] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Patch-For-Review: Try new minfraud features - https://phabricator.wikimedia.org/T173876#3574487 (Ejegg) [22:27:26] Fundraising-Backlog, Spike: spike: New email risk scoring enhancements - https://phabricator.wikimedia.org/T172310#3574488 (Ejegg) [22:27:55] (Merged) jenkins-bot: Resolve ty batch start timestamp in PHP [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375027 (https://phabricator.wikimedia.org/T149745) (owner: Ejegg) [22:39:29] (PS1) Ejegg: WIP upgrade to new Minfraud Composer package [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/375454 (https://phabricator.wikimedia.org/T128902) [22:56:26] (CR) XenoRyet: [C: 2] Donation consumer: account for drush startup time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375030 (https://phabricator.wikimedia.org/T174690) (owner: Ejegg) [22:56:51] (CR) XenoRyet: [C: 2] Thank you mailer: use process elapsed time to limit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375032 (https://phabricator.wikimedia.org/T174690) (owner: Ejegg) [23:01:49] (Merged) jenkins-bot: Donation consumer: account for drush startup time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375030 (https://phabricator.wikimedia.org/T174690) (owner: Ejegg) [23:02:10] (Merged) jenkins-bot: Thank you mailer: use process elapsed time to limit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375032 (https://phabricator.wikimedia.org/T174690) (owner: Ejegg) [23:30:55] (CR) XenoRyet: [C: 2] PayPal audit: check for existing recurring donations [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/370520 (https://phabricator.wikimedia.org/T172723) (owner: Ejegg) [23:31:23] (Merged) jenkins-bot: PayPal audit: check for existing recurring donations [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/370520 (https://phabricator.wikimedia.org/T172723) (owner: Ejegg)