[00:28:10] (CR) Eileen: "Should we also try without the foreign key contraints? Or perhaps as a separate test? Guess we have a meeting time to discuss" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374588 (https://phabricator.wikimedia.org/T174404) (owner: Ejegg) [00:37:05] (CR) Eileen: [C: 1] "I agree with this change - makes sense & looks like it does what it says it does." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375449 (https://phabricator.wikimedia.org/T174450) (owner: Ejegg) [02:35:09] (PS2) Eileen: Resolve diacritic merge conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) [02:54:21] (PS3) Eileen: Resolve diacritic merge conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) [02:56:58] (CR) Eileen: "I have updated in response. I also found some alternate functions which do more matching, but have not switched over. The place in the cod" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) (owner: Eileen) [03:01:43] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Update wmf_civicrm to set city to NULL when it is ‘0’ or ‘City/Town’ or ‘NoCity’ - https://phabricator.wikimedia.org/T174980#3578715 (Eileenmcnaughton) [03:01:51] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Update wmf_civicrm to set city to NULL when it is ‘0’ or ‘City/Town’ or ‘NoCity’ - https://phabricator.wikimedia.org/T174980#3578715 (Eileenmcnaughton) [03:49:52] (PS1) Eileen: Do not save 0 or other invalid values to city field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375945 (https://phabricator.wikimedia.org/T174980) [03:51:00] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Update wmf_civicrm import normalisation to set city to NULL when it is ‘0’ or ‘City/Town’ or ‘NoCity’ - https://phabricator.wikimedia.org/T174980#3578715 (Eileenm... [04:07:58] (PS3) Eileen: [merged upstream] CRM-19612 Dedupe: dodge problems introduced by query union [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373176 (https://phabricator.wikimedia.org/T160571) [04:09:11] (CR) Eileen: "I had been kinda ignoring that because the differences were fairly trival. However, now swapped out for upstream version" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/373176 (https://phabricator.wikimedia.org/T160571) (owner: Eileen) [04:09:32] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, and 9 others: Errors in CiviCRM dedupe screen - https://phabricator.wikimedia.org/T160571#3578802 (Eileenmcnaughton) [04:09:42] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising Sprint Homebrew Hadron Collider, Fundraising Sprint Ivory Tower Defense Games, and 9 others: Errors in CiviCRM dedupe screen - https://phabricator.wikimedia.org/T160571#3103876 (Eileenmcnaughton) [04:47:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174984#3578818 (Eileenmcnaughton) [04:47:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174985#3578832 (Eileenmcnaughton) [04:48:12] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174985#3578832 (Eileenmcnaughton) a:Eileenmcnaughton [04:54:10] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174985#3578866 (Eileenmcnaughton) [05:04:53] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174985#3578894 (Eileenmcnaughton) [05:11:18] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174985#3578930 (Eileenmcnaughton) [05:23:13] (PS2) Eileen: Do not save 0 or other invalid values to city field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375945 (https://phabricator.wikimedia.org/T174980) [05:23:15] (PS1) Eileen: Remove void data from city field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375948 (https://phabricator.wikimedia.org/T174985) [05:30:57] (CR) Eileen: "Although I re-used the batching this took only about a minute to run on staging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375948 (https://phabricator.wikimedia.org/T174985) (owner: Eileen) [07:30:04] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review reducing smartGroupCache clearing per https://issues.civicrm.org/jira/browse/CRM-21109 - https://phabricator.wikimedia.org/T174408#3579073 (Eileenmcnaughton) I have done some investigations - documented here h... [08:30:26] (CR) Eileen: [C: 2] FIXMEs regarding processor_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370285 (owner: Ejegg) [08:36:04] (Merged) jenkins-bot: FIXMEs regarding processor_id column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370285 (owner: Ejegg) [12:07:04] fundraising-tech-ops, Performance-Team, Wikimedia-General-or-Unknown, Performance: 2017 USA banners take 1-2 seconds to load - https://phabricator.wikimedia.org/T174267#3579667 (Gilles) This assessment is misleading, the difference is actually 200ms or less for displaying the article. Look at the... [15:50:36] (CR) Ejegg: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/368809 (owner: Ejegg) [16:09:47] (PS4) Ejegg: Fix double continue button situations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) (owner: Pcoombe) [16:19:32] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Restore Live CiviCRM data to staging - https://phabricator.wikimedia.org/T174636#3580571 (Jgreen) Starting this now, should be done late this afternoon eastern US time. [16:19:41] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Restore Live CiviCRM data to staging - https://phabricator.wikimedia.org/T174636#3580572 (Jgreen) a:Jgreen [16:23:57] (CR) Ejegg: [C: 2] Fix double continue button situations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) (owner: Pcoombe) [16:26:51] (Merged) jenkins-bot: Fix double continue button situations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/373704 (https://phabricator.wikimedia.org/T149366) (owner: Pcoombe) [16:44:06] Thanks for the review ejegg! [16:44:29] Thanks for writing the code! [16:44:36] I can deploy that later today [16:44:47] sweet [17:12:33] fundraising-tech-ops: refactor collect_frqueue_redis_via_gmetric to prometheus - https://phabricator.wikimedia.org/T175044#3580876 (Jgreen) [17:32:04] dstrine: hi! is there a task for the iPad BH issue? [18:05:16] AndyRussG: yes it's in the sprint. Please edit as you see fit: https://phabricator.wikimedia.org/T174719 [18:06:34] XenoRyet: hi! [18:06:46] I'm about to re-download and re-process a ton of old PayPal audit files [18:07:03] If we had this one deployed, it would be a lot less disruptive: [18:07:21] Hi [18:07:28] oh hey [18:07:35] looks like you merged it already [18:07:36] thanks! [18:07:55] hehe, a bunch of stuff is ready for deployment [18:08:15] My paypal patch is ready for another look too. [18:08:34] If it looks good, we could get that one out as well. [18:08:57] https://gerrit.wikimedia.org/r/#/c/374913/ [18:08:58] That one [18:09:52] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/376064 [18:10:12] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/376064 (owner: Ejegg) [18:10:25] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/376064 (owner: Ejegg) [18:10:31] k, I'll take a look once I get those things reprocessing [18:11:54] !log updated fundraising tools from 95542299ac1d06c6292cdfce22431ab615a77bf5 to 8d39806da4e9a50fcfa24326d74f48f6e9c418a7 [18:12:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:34:16] ah crap, I forgot to rsync_blaster the tools before running [18:34:29] sorry, we're going to get some queue bloat warnings too [18:34:36] standing by to ack the alerts [18:36:19] ACKNOWLEDGEMENT - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 25805 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 4 keys, up 61 days 19 hours - memory use is 25.25M (peak 25.49M, 0.36% of max, fragmentation 1.17%), connected_slaves is 2, donations is 228, jobs is 0, jobs-adyen is 0, jobs-paypal is 0, payments-antifraud is 0, payments-init is 0, pending is 0, refund is 15, unsubscribe is 0 [18:36:19] pected queue bloat - reprocessed audit files [19:07:40] dstrine: thx! [19:08:25] (CR) Legoktm: [C: 2] Use CommentStore to access core comment fields when available [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/374858 (https://phabricator.wikimedia.org/T166732) (owner: Anomie) [19:12:02] (Merged) jenkins-bot: Use CommentStore to access core comment fields when available [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/374858 (https://phabricator.wikimedia.org/T166732) (owner: Anomie) [19:31:15] (PS1) Ejegg: Update pt-br and ja Thank You letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/376080 (https://phabricator.wikimedia.org/T173809) [19:31:51] (CR) Ejegg: [C: 2] "Oops, merged this one to deployment first! Cherry-picking back on to master." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/376080 (https://phabricator.wikimedia.org/T173809) (owner: Ejegg) [19:33:24] AndyRussG: meeting? [19:38:08] (Merged) jenkins-bot: Update pt-br and ja Thank You letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/376080 (https://phabricator.wikimedia.org/T173809) (owner: Ejegg) [19:38:34] Fundraising-Backlog: Fix LandingCheck language fallback - https://phabricator.wikimedia.org/T174693#3581638 (DStrine) p:Triage>Normal [19:40:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, MediaWiki-extensions-DonationInterface: Epic: DonationInterface should not be a dependency of our CiviCRM install - https://phabricator.wikimedia.org/T174691#3581651 (DStrine) [19:41:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: PayPal IPN messages have '0' for some address fields. Don't use them. - https://phabricator.wikimedia.org/T174628#3568335 (DStrine) p:Triage>Normal [19:46:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174984#3581716 (Ejegg) [19:46:57] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, and 2 others: Remove invalid City data from DB - https://phabricator.wikimedia.org/T174985#3581718 (Ejegg) [19:54:06] Fundraising Sprint Quill Pencil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Restore Live CiviCRM data to staging - https://phabricator.wikimedia.org/T174636#3581765 (Eileenmcnaughton) thanks! [20:04:13] (CR) Ejegg: [C: -1] "I found a refund in today's logs where the street_address rule doesn't seem to hold - look for the gateway_txn_id of contribution 44564141" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/374913 (https://phabricator.wikimedia.org/T171351) (owner: XenoRyet) [20:16:56] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376090 [20:17:11] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376090 (owner: Ejegg) [20:18:04] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376090 (owner: Ejegg) [20:20:01] oops, that needs a vendor update [20:25:17] (PS1) Ejegg: Update CRM dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/376095 [20:25:54] (CR) Ejegg: [C: 2] Update CRM dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/376095 (owner: Ejegg) [20:26:21] (PS1) Ejegg: Update vendor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376096 [20:26:31] (CR) Ejegg: [C: 2] Update vendor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376096 (owner: Ejegg) [20:28:45] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/376097 [20:28:52] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/376097 (owner: Ejegg) [20:30:52] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/376097 (owner: Ejegg) [20:34:25] (Merged) jenkins-bot: Update CRM dependencies [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/376095 (owner: Ejegg) [20:34:28] (Merged) jenkins-bot: Update vendor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376096 (owner: Ejegg) [20:37:27] !log disabled Donation queue consumer and thank-you mail sender [20:37:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:39:38] (PS13) Ejegg: Enable PHPCS, but only with rules phpcbf could fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (https://phabricator.wikimedia.org/T133576) (owner: Awight) [20:40:06] !log updated civicrm from 820bd98c7c23a851c38a75111c8c1532c781e198 to f9c373ec42f0a7b078a3eb7b31385183dab79bdf [20:40:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:48:38] !log re-enabled donation queue consumer and thank you mailer [20:48:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:49:44] Fundraising Sprint Quill Pencil, Fundraising-Analysis, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Recurring slow query (around 10 secs) from thank you job - https://phabricator.wikimedia.org/T149745#2761436 (Ejegg) Open>Resolved Query is now returning in les... [21:01:21] (PS1) Ejegg: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/376125 [21:01:51] (CR) Ejegg: [C: 2] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/376125 (owner: Ejegg) [21:02:49] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/376128 [21:02:53] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/376128 (owner: Ejegg) [21:06:44] (Merged) jenkins-bot: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/376125 (owner: Ejegg) [21:07:42] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/376128 (owner: Ejegg) [21:15:52] Fundraising Sprint Murphy's Lawyer, Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, and 5 others: Optimize filesystem access in thank_you email job - https://phabricator.wikimedia.org/T170435#3582166 (Ejegg) Open>Resolved p:Triage... [21:16:24] Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, Fundraising-Backlog, Patch-For-Review, Unplanned-Sprint-Work: Deploy pt-br and ja thank you letter - https://phabricator.wikimedia.org/T173809#3582168 (Ejegg) @jrobell the latest updates have been deployed. [21:22:29] (CR) Ejegg: [C: 1] "This looks fine to merge. Does the fact that we're already pulling in forceutf8 change your mind about how to handle this?" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) (owner: Eileen) [21:28:15] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Quill Pencil, Fundraising-Backlog, and 2 others: Deal with paypal EC error 11607, show thank you page - https://phabricator.wikimedia.org/T165635#3582205 (Ejegg) Darn, we're getting a lot of these lately d... [21:40:35] (PS4) Eileen: Resolve diacritic merge conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) [21:41:46] (CR) Eileen: "I think I'm still inclined to try this & test it & see how many it catches. My take is the other might catch more & it might make sense to" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) (owner: Eileen) [21:42:13] ejegg: I'm conscious you have a bunch of things needing review [21:42:45] eileen: lemme see what's actually important [21:43:02] I know a bunch of my CRM patches are just deleting stale code [21:43:29] ok - Iooked at a couple of things & could just about approve but felt I needed to ask questions [21:43:54] sure! want to ask em via IRC or hangouts? [21:44:25] (CR) Eileen: [C: 2] "Looks like we support drupal 5 tho" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374568 (owner: Ejegg) [21:44:49] so this one https://gerrit.wikimedia.org/r/#/c/375449/ [21:45:01] yep [21:45:07] looks sensible & safe to me - I just felt like I should double check the list of codes maybe [21:45:35] (CR) jerkins-bot: [V: -1] Resolve diacritic merge conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) (owner: Eileen) [21:45:43] ah, I actually just copied that over from the DonationInterface code dealing with those cases [21:45:51] lemme see where we originally got that [21:46:37] shoot, the original task would have been in Mingle [21:48:34] (CR) Eileen: [C: 2] Delete half-baked Silverpop import code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 (owner: Ejegg) [21:49:43] well, I found the mingle ticket! [21:50:02] (Merged) jenkins-bot: Fix third param of watchdog() calls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374568 (owner: Ejegg) [21:50:30] looks like it's referencing an email, but I can't find the original [21:50:40] I'll paste the mingle text into an email eileen [21:51:51] OK sure - I'm looking at error_map.yml in Donation Interface [21:52:20] but not seeing 430260 [21:52:56] Ah found it [21:53:09] TRANSACTION_CANNOT_BE_COMPLETED_VIOLATION_OF_LAW (EXTERMINATE!) [21:55:10] (PS5) Eileen: Resolve diacritic merge conflicts. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374951 (https://phabricator.wikimedia.org/T149763) [21:57:08] ejegg: ok I compared them & I'm ok with it - I would kind of prefer to see the codes in one place & a shared function - but I don't know this needs to be held up over that [21:58:01] (CR) Eileen: [C: 2] "Ok - checked with Elliott & was able to compare these with globalcollectadapter & they are the same." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/375449 (https://phabricator.wikimedia.org/T174450) (owner: Ejegg) [22:07:43] ejegg: the slow query on thank yo job where you bypassed the api - was the slow part to do with cross credits? [22:08:01] (I would like to fix the api query) [22:08:37] eileen shoot, I didn't dig deep enough into the API query to tell exactly what it was [22:09:00] I just noticed it was returning a bunch of stuff we didn't need, and I couldn't get it to join in all the stuff we did want on a single query [22:09:07] ok [22:09:13] well I'll leave it for another time [22:21:33] (CR) Eileen: [C: 2] "Agree with this, even though it makes me sad we can't have more standardisation between this & our Civi codebase & drupal codebase. I gues" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (https://phabricator.wikimedia.org/T133576) (owner: Awight) [22:24:10] (CR) Eileen: [C: 2] "Looks like this really deals with a single one-off that happened 4 years ago so makes sense to ditch it now. I suspect if we had to send a" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373975 (owner: Ejegg) [22:25:15] (Abandoned) Eileen: [WIP] Random fix to deprecated Civi code [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/340917 (owner: Awight) [22:25:57] (Merged) jenkins-bot: Enable PHPCS, but only with rules phpcbf could fix [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/285228 (https://phabricator.wikimedia.org/T133576) (owner: Awight) [22:26:14] ejegg: is there anything else you would like to point me to? I'm kind of tempted to abandon all the ones by awight prior to 2017 [22:26:46] +1 ! [22:26:52] * awight eats children [22:27:43] awight: you happy if I just go ahead & do that then? I'm not sure how it filters what I see - but there are 9 from you in 2016 in my display & one from Jan 2017 [22:28:08] LOL, backscroll [22:28:13] hell yeah kill away [22:28:14] ty! [22:28:22] 2017 one is against Zuul https://gerrit.wikimedia.org/r/#/c/299185/ [22:28:34] but it's conflicted so I suspect something else happened in between [22:29:45] (Abandoned) Eileen: WIP initial port of the dedupe review UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/133404 (owner: Awight) [22:30:27] (Abandoned) Eileen: Make the generic error message human-readable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259186 (https://phabricator.wikimedia.org/T117872) (owner: Awight) [22:31:15] (Abandoned) Eileen: WIP (FR #807) Recurring contributions keep the original contribution's gateway account name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/96675 (owner: Awight) [22:32:19] I wonder if we should be opening a ticket to track this against i case we wish to revive later https://gerrit.wikimedia.org/r/#/c/143249/ [22:32:53] (Abandoned) Eileen: WIP Expose parsing without side-effects [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/143249 (owner: Awight) [22:33:29] this one too [22:33:30] https://gerrit.wikimedia.org/r/#/c/210279/ [22:36:50] Fundraising-Backlog: Determine whether we should raise any phab tickets to track old unmerged code by Adam - https://phabricator.wikimedia.org/T175091#3582493 (Eileenmcnaughton) [22:37:48] (Abandoned) Eileen: Test message injection takes URL directly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/210279 (owner: Awight) [22:38:43] (Abandoned) Eileen: WIP tests for the orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211065 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [22:39:15] Fundraising-Backlog: Determine whether we should raise any phab tickets to track old unmerged code by Adam - https://phabricator.wikimedia.org/T175091#3582510 (Eileenmcnaughton) [22:39:40] (Abandoned) Eileen: Make it harder to keep session data when in batch mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234718 (owner: Awight) [22:40:31] (Abandoned) Eileen: Add a country selector, links to OWTG [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260228 (https://phabricator.wikimedia.org/T96047) (owner: Awight) [22:40:52] (Abandoned) Eileen: [DO NOT MERGE] New fetch by primary id plus offset, for incomplete consumption [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/300463 (https://phabricator.wikimedia.org/T131275) (owner: Awight) [22:42:01] * awight sheds clothes and plunges into the sea :D [22:42:53] :-) [22:57:50] (CR) Eileen: [C: 2] "I couldn't find anywhere outside removed code that called this stuff." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373976 (owner: Ejegg) [23:03:47] (CR) jerkins-bot: [V: -1] Delete wmf_communication\Job stuff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373976 (owner: Ejegg) [23:03:49] (CR) jerkins-bot: [V: -1] Delete half-baked Silverpop import code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 (owner: Ejegg) [23:05:17] thanks eileen! [23:05:24] lemme see what's holding those up [23:06:23] huh? [23:06:34] how does that depend on something that hasn't been submitted? [23:06:54] I was confused! [23:07:07] (PS2) Ejegg: Delete 'oneoffs' module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373975 [23:07:36] Looking at the code removal (silverpop) & the dedupe gerrit of Adam's I just abandoned - I'm not sure if I ever appreciated how much work had previously been done on those projects [23:09:30] just looking at the use of this http://www.raymondhill.net/finediff/viewdiff.php in the old dedupe gerrit [23:09:46] interesting [23:10:28] heh, the silverpop stuff wasn't going to benefit anybody else done that way [23:11:11] ooh, getting late here... [23:13:43] good evening all! [23:14:30] (PS2) Ejegg: Delete wmf_communication\Job stuff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373976 [23:14:37] (PS2) Ejegg: Delete half-baked Silverpop import code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 [23:14:44] (CR) Eileen: [C: 2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 (owner: Ejegg) [23:14:56] (CR) jerkins-bot: [V: -1] Delete half-baked Silverpop import code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 (owner: Ejegg) [23:19:43] (PS1) Eileen: Submodule update for CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/376153 [23:20:02] (CR) Eileen: [C: 2] "self-merging, submodule update" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/376153 (owner: Eileen) [23:21:27] (CR) Eileen: [C: 2] "I was totally sure this was merged - maybe it was upstream only" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374830 (owner: Mepps) [23:25:48] (Merged) jenkins-bot: Delete wmf_communication\Job stuff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373976 (owner: Ejegg) [23:25:50] (CR) jerkins-bot: [V: -1] Delete half-baked Silverpop import code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/373977 (owner: Ejegg) [23:31:04] (Merged) jenkins-bot: Submodule update for CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/376153 (owner: Eileen) [23:33:43] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376154 [23:34:36] (Merged) jenkins-bot: Remove auto limit of 25 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/374830 (owner: Mepps) [23:34:59] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376154 (owner: Eileen) [23:35:43] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/376154 (owner: Eileen)