[08:33:12] fundraising-tech-ops, Operations: Long term storage for frack prometheus data - https://phabricator.wikimedia.org/T175738#3609855 (fgiunchedi) Sounds awesome! re: indefinite storage, the `global` instance of Prometheus now has 1yr retention, likely to be moved to 2yrs. [08:36:39] Fundraising-Backlog, fundraising-tech-ops, Operations, Spike: Spike: Enumerate remaining unported stats - https://phabricator.wikimedia.org/T175850#3609857 (fgiunchedi) One way would be to generate grafana dashboards' JSON from python and a list of metrics, namely with sth like `grafanalib` as ou... [09:52:57] (CR) Thiemo Mättig (WMDE): [C: 2] Update doc link on paypal currency list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359185 (owner: Ejegg) [09:54:18] (CR) Thiemo Mättig (WMDE): [C: 2] Fix PHPCS style issues in minfraud files [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/377825 (owner: Ejegg) [09:57:11] (Merged) jenkins-bot: Update doc link on paypal currency list [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359185 (owner: Ejegg) [15:14:56] (CR) Mepps: "I think we can remove WIP now?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366167 (https://phabricator.wikimedia.org/T163948) (owner: Ejegg) [15:16:39] (PS10) Ejegg: Ingenico Connect: getHostedCheckoutStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366167 (https://phabricator.wikimedia.org/T163948) [15:16:46] un-WIP-ed! [15:17:48] ejegg yay! [15:24:35] (CR) Mepps: [C: 2] "Awesome!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366167 (https://phabricator.wikimedia.org/T163948) (owner: Ejegg) [15:26:32] (Merged) jenkins-bot: Ingenico Connect: getHostedCheckoutStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/366167 (https://phabricator.wikimedia.org/T163948) (owner: Ejegg) [15:28:01] any stumbling blocks on the testing front mepps? [15:28:27] ejegg currently making progress! just making a testingingenicoadapter [15:28:37] mepps why do you need one? [15:28:54] for setDummyResponseCode [15:29:05] Shouldn't we be able to feed mock cURL responses to the SmashPig library object? [15:29:44] or better yet, just mock the hostedCheckoutProvider itself? [15:30:03] like in testGatewaySessionRetrieval ? [15:32:23] looking at that ejegg [15:33:47] BaseIngenicoTestCase sets up a mock object to be returned from getPaymentProvider() [15:44:24] (Abandoned) Ejegg: WIP / DO NOT MERGE: d*local methods from API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/359003 (https://phabricator.wikimedia.org/T167378) (owner: Ejegg) [15:58:44] (PS1) Mepps: Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 [15:59:08] checking it out... [15:59:38] (PS2) Mepps: Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 [16:01:22] (CR) jerkins-bot: [V: -1] Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [16:13:02] they aren't passing but i'm not sure if it's the tests or the code [16:13:13] but they all have the same point of failure [16:13:48] mepps you need to put in $mock->method()->willReturn() in the test [16:13:57] for it to give anything back [16:14:25] well, probably with an ->expects() test too [16:14:44] see line 82 of IngenicoTest.php [16:18:21] mepps - now I'm itching to get the approvePayment / cancelPayment stuff into DonationInterface too. [16:18:49] though... I guess we should wrap up the PayPal orphan adapter first. Will take a look at that [16:36:54] how are you feeling XenoRyet? [16:53:07] ejegg do you know a flag to pass to phpunit to not list skipped tests? [16:53:32] i haven't found one in documentation so far but it's tough scrolling through all the skipped ones i don't care about [16:54:32] Hey mepps. Not 100%, but better enough to stop slacking off. [16:54:44] was sleep better last night? [16:54:59] Yea, the kids were more merciful than they have been the past two days. [16:55:03] Dunno what got into them. [16:55:21] oof, both of them? that's rough [16:55:41] our first six months with James were pretty brutal [16:55:58] then we sleep trained and got *some* sanity [16:56:13] mepps no, I don't [16:56:25] maybe we should just comment them out? [16:56:30] Yea, usually M just sleeps through it when D wakes up. Past couple of days she would wake up, then about an hour later he would too. Seemed like nightmares or something. [16:56:59] yikes, that sounds pretty awful for you guys! [16:57:53] Not gonna lie, it was rough. Seems to have passed for now though. [17:29:16] (CR) Ejegg: [C: -1] "OrphanSlayer class looks pretty good, but drush wrapper needs some fixes." (8 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [17:51:32] mepps do you mind if I pick up your 'Try out approvePayment' patch? [17:52:25] XenoRyet: did you se that 'MISSING_PREDECESSOR' paypal refund failmail from yesterday? [17:52:57] Did we get another one of those? I've been looking at failmail, but haden't gotten to that one yet. [17:53:20] yeah, mind taking a look at what happened there? [17:53:32] Yea, I'll look into it. [17:53:44] cool [17:54:02] should be simple to find the txn if it's actually in civi [17:54:12] Yea [17:54:25] wmf_contribution_extra has columns for both gateway_txn_id (in the message) and gateway [18:15:28] Nope ejegg! [18:15:37] k, cool! [18:44:22] (PS2) Ejegg: WIP Try out approvePayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/370656 (owner: Mepps) [18:55:27] (PS3) Ejegg: WIP Try out approvePayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/370656 (owner: Mepps) [18:58:41] XenoRyet: was it in Civi? [19:09:13] (CR) Mepps: Orphan Slayer Module (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:10:19] (CR) Mepps: "Also I don't see any comments in the drush wrapper, just the module. Were there also changes in the drush wrapper needed?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:11:44] (CR) Ejegg: [C: -1] "Ah right, mostly need fixes to .module. There's one variable name mismatch in the drush wrapper too, though - $options should by $time, wh" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:15:42] (PS27) Mepps: Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [19:18:04] (PS28) Mepps: Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [19:21:17] (PS29) Mepps: Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [19:21:45] (CR) Mepps: "Ejegg I figured out why the orphan rectify drush command wasn't working and fixed it. Try it locally to confirm." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:29:25] (PS3) Mepps: Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 [19:32:52] (CR) jerkins-bot: [V: -1] Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [19:34:08] (CR) Ejegg: "Thanks, the old orphan rectifier runs again! Couple fixes still needed in .module, some suggestions for .drush.inc" (7 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [19:38:45] (CR) Ejegg: [C: -1] "Those mock responses should probably be full nested arrays like we'd get back from the decoded json." (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [19:48:15] dstrine: You coming to standup? [20:04:10] (PS30) Mepps: Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [20:41:44] (CR) Ejegg: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/377538 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [21:31:26] (CR) Ejegg: "This is looking good! Just a few comments." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:03:28] (CR) Ejegg: [C: 2] Update omnimail to validate dates & silverpop package to validate returning xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/377958 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [22:09:43] (Merged) jenkins-bot: Update omnimail to validate dates & silverpop package to validate returning xml [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/377958 (https://phabricator.wikimedia.org/T175394) (owner: Eileen) [23:17:45] (PS1) Ejegg: Better language fallback for unsupported locales [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/378356 (https://phabricator.wikimedia.org/T174693) [23:20:45] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Patch-For-Review: Fix LandingCheck language fallback - https://phabricator.wikimedia.org/T174693#3611531 (Ejegg) a:Ejegg [23:26:52] well, I'm heading out for the weekend. Have a good one! [23:54:19] (CR) Mepps: Orphan Slayer Module (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [23:57:12] (PS31) Mepps: Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 [23:58:50] (CR) jerkins-bot: [V: -1] Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps)