[12:52:47] (CR) Mepps: "ejegg not sure why this is failing to build because of omnimail" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [14:41:44] (CR) Mepps: Batch look up order status for Ingenico (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/328858 (owner: Ejegg) [14:43:49] (CR) Mepps: [C: 1] "Mostly looks good, with one comment about white spacing. I'm ready to +2 though." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) (owner: Ejegg) [14:45:24] (CR) Mepps: Standardize case of ext.donationInterface (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/377899 (owner: Ejegg) [15:08:25] (CR) Mepps: [C: 1] "Looks good to me, but maybe XenoRyet wants to take a quick look too?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259795 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [15:28:29] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Impressions in Japan FR campaign - https://phabricator.wikimedia.org/T176146#3614996 (DStrine) [15:32:41] thanks for all the CR mepps! I'll have some adjustments up in a few [15:58:29] Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint RadioActivewear, Fundraising-Backlog, and 2 others: Deal with recurring donations stuck in 'In Progress' status - https://phabricator.wikimedia.org/T171868#3478795 (Ejegg) Open>Resolved [16:03:11] Fundraising-Backlog, FR-Paypal: PayPal IPN processing jobs: undefined index subscr_id - https://phabricator.wikimedia.org/T176152#3615140 (Ejegg) [16:03:19] Fundraising-Backlog, FR-Paypal: PayPal IPN processing jobs: undefined index subscr_id - https://phabricator.wikimedia.org/T176152#3615152 (Ejegg) p:Triage>High [16:23:49] (CR) Ejegg: Optionally send more Minfraud parameters (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) (owner: Ejegg) [16:48:42] fundraising-tech-ops: Sync 'variants' directory from settings repo in f_c_u -p payments-wiki - https://phabricator.wikimedia.org/T175871#3615309 (Jgreen) a:Jgreen [16:59:23] Fundraising-Backlog, FR-Paypal: PayPal IPN processing jobs: undefined index subscr_id - https://phabricator.wikimedia.org/T176152#3615372 (Ejegg) [17:26:05] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [17:27:01] (CR) Ejegg: "Well dang, we had gotten a few of those mystery failures on unrelated crm patches last week. I just deleted the dir on the CI server, so l" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [17:28:31] ejegg where is this now in terms of WIPness: https://gerrit.wikimedia.org/r/#/c/370656/ [17:32:17] mepps oh hey, it seems to work [17:32:25] I'd just like to put some tests on it [17:32:30] speaking of tests.... [17:32:51] i bet I should be looking at the getStatus tests, huh? [17:34:29] ah, lmk when I should review that again [17:36:53] fundraising-tech-ops: Sync 'variants' directory from settings repo in f_c_u -p payments-wiki - https://phabricator.wikimedia.org/T175871#3615554 (Ejegg) Open>declined Looks like this is a bit more complicated than the SmashPig directories, since we're asking for arbitrary dirs under 'variant'. Will d... [17:39:32] argh, CI is still failing CRM patches with 'cannot find extension' [17:42:06] (PS1) Ejegg: Add GC form variant with no city and state [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/378746 (https://phabricator.wikimedia.org/T151769) [17:46:06] fr-tech anyone want to double-check that? ^^^ [17:47:19] (CR) Mepps: [C: 2] "This looks fine but would love to learn why this in core and not DI for the future!" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/378746 (https://phabricator.wikimedia.org/T151769) (owner: Ejegg) [17:52:13] (Merged) jenkins-bot: Add GC form variant with no city and state [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/378746 (https://phabricator.wikimedia.org/T151769) (owner: Ejegg) [17:57:11] mepps: https://github.com/civicrm/civicrm-buildkit/pull/354 [17:57:25] apparently we'd been depending on some local file mods on the CI server [17:57:33] and they finally got wiped out [18:02:42] (CR) Ejegg: "Partly, I wanted the config override folder at the same level as LocalSettings.php." [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/378746 (https://phabricator.wikimedia.org/T151769) (owner: Ejegg) [18:12:27] (CR) Ejegg: "mepps, explanation inline for temporarily preserving the old module names" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/377899 (owner: Ejegg) [18:12:58] (PS2) Mepps: Standardize case of ext.donationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/377899 (owner: Ejegg) [18:13:00] mepps, the comment at 14:02 IRC time is also for you [18:13:08] (CR) Mepps: [C: 2] "Sounds good ejegg!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/377899 (owner: Ejegg) [18:13:33] (CR) jerkins-bot: [V: -1] Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [18:16:20] ejegg i wonder if down the road the variants directory should be named something indicating it's part of DI/Payments? [18:16:25] like form-variants? [18:17:05] although form-variants doesn't do that, but just variants at the root level is a little confusing about what the variants are for [18:17:15] well, that branch is only for deployment to payments-wiki [18:17:20] in the short-term i can +2 this though [18:17:52] but sure, we could change the name [18:17:57] yeah ejegg even so, if i was new to this codebase and just saw variants in the root directory, i wouldn't connecct it to payment forms [18:18:30] k, I can change it to form-variants [18:18:48] (CR) Mepps: "It looks like I don't have +2 rights on this." [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/378746 (https://phabricator.wikimedia.org/T151769) (owner: Ejegg) [18:19:07] (Merged) jenkins-bot: Standardize case of ext.donationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/377899 (owner: Ejegg) [18:20:43] mepps heh, looks like you already +2ed it [18:20:48] I'll just move it in a new patch [18:20:53] ahh gotcha [18:22:28] (PS1) Ejegg: Rename 'variants' to 'form_variants' [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/378761 [18:25:15] PROBLEM - check_puppetrun on payments1003 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [18:28:57] (PS4) Mepps: Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 [18:30:03] (PS1) Ejegg: Try to set extension dir right in build [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378762 [18:30:15] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [18:30:15] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [18:30:16] RECOVERY - check_puppetrun on payments1003 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [18:30:16] PROBLEM - check_puppetrun on payments2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [18:30:42] mepps maybe https://gerrit.wikimedia.org/r/378762 is all we need to get that extensionsDir setting [18:31:12] going by https://github.com/civicrm/civicrm-buildkit/blob/master/src/civibuild.lib.sh#L595 [18:31:24] though I haven't worked the whole thing out [18:32:06] bah, nope [18:34:35] ejegg i updated the status tests with a full though they're still not passing, and it seems like the response isn't being read correctly [18:34:57] k, lemme see [18:35:10] ugh, what's up with the donation queue failmail [18:35:15] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [18:35:16] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [18:35:16] PROBLEM - check_puppetrun on payments2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [18:39:23] (CR) Ejegg: "Ah, looks like the library fn call is actually named 'getHostedPaymentStatus'" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [18:40:15] RECOVERY - check_puppetrun on americium is OK: OK: Puppet is currently enabled, last run 52 seconds ago with 0 failures [18:40:25] RECOVERY - check_puppetrun on payments2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [18:47:46] (PS2) Ejegg: Try to set extension dir right in build [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378762 [18:49:46] oops, that's building on a host with the hacks in place [18:49:54] need to reset 1001 too [18:50:33] guess i'll let jenkins finish the test before I pull the dir out from under it [18:54:09] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation Queue consumer should stop trying to hit ganglia - https://phabricator.wikimedia.org/T176167#3615829 (Ejegg) [18:54:23] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation Queue consumer should stop trying to hit ganglia - https://phabricator.wikimedia.org/T176167#3615853 (Ejegg) p:Triage>Unbreak! [19:00:49] (PS1) Ejegg: Donations QC: don't call ganglia module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378765 (https://phabricator.wikimedia.org/T176167) [19:01:12] fr-tech if we can get CRM builds working, I think ^^^ will stop the failmails [19:25:03] (CR) jerkins-bot: [V: -1] Try to set extension dir right in build [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378762 (owner: Ejegg) [19:32:12] (CR) jerkins-bot: [V: -1] Donations QC: don't call ganglia module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378765 (https://phabricator.wikimedia.org/T176167) (owner: Ejegg) [19:33:35] PROBLEM - Host frdb2001 is DOWN: PING CRITICAL - Packet loss = 100% [19:34:35] PROBLEM - Host pay-lvs2001 is DOWN: PING CRITICAL - Packet loss = 100% [19:34:36] PROBLEM - Host payments2002 is DOWN: PING CRITICAL - Packet loss = 100% [19:34:36] PROBLEM - Host payments2001 is DOWN: PING CRITICAL - Packet loss = 100% [19:34:37] PROBLEM - Host payments2003 is DOWN: PING CRITICAL - Packet loss = 100% [19:34:37] PROBLEM - Host pay-lvs2002 is DOWN: PING CRITICAL - Packet loss = 100% [19:34:38] PROBLEM - Host rigel is DOWN: PING CRITICAL - Packet loss = 100% [19:34:38] PROBLEM - Host saiph is DOWN: PING CRITICAL - Packet loss = 100% [19:35:05] PROBLEM - Host alnitak is DOWN: PING CRITICAL - Packet loss = 100% [19:35:31] i believe there was just a firewall restart [19:36:09] (CR) jerkins-bot: [V: -1] Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [19:36:45] PROBLEM - Host frbackup2001 is DOWN: PING CRITICAL - Packet loss = 100% [19:36:55] PROBLEM - Host bellatrix is DOWN: PING CRITICAL - Packet loss = 100% [19:36:56] PROBLEM - Host betelgeuse is DOWN: PING CRITICAL - Packet loss = 100% [19:36:56] PROBLEM - Host heka is DOWN: PING CRITICAL - Packet loss = 100% [19:36:57] PROBLEM - Host mintaka is DOWN: PING CRITICAL - Packet loss = 100% [19:37:25] PROBLEM - Host alnilam is DOWN: PING CRITICAL - Packet loss = 100% [19:46:45] RECOVERY - Host payments2003 is UP: PING OK - Packet loss = 0%, RTA = 36.17 ms [19:46:45] RECOVERY - Host payments2001 is UP: PING OK - Packet loss = 0%, RTA = 36.19 ms [19:46:46] RECOVERY - Host payments2002 is UP: PING OK - Packet loss = 0%, RTA = 36.18 ms [19:47:16] RECOVERY - Host frbackup2001 is UP: PING OK - Packet loss = 0%, RTA = 36.15 ms [19:47:25] RECOVERY - Host bellatrix is UP: PING OK - Packet loss = 0%, RTA = 36.16 ms [19:47:26] RECOVERY - Host betelgeuse is UP: PING OK - Packet loss = 0%, RTA = 36.14 ms [19:47:26] RECOVERY - Host heka is UP: PING OK - Packet loss = 0%, RTA = 36.17 ms [19:47:27] RECOVERY - Host mintaka is UP: PING OK - Packet loss = 0%, RTA = 36.14 ms [19:47:56] RECOVERY - Host alnilam is UP: PING OK - Packet loss = 0%, RTA = 36.75 ms [19:48:04] (PS1) Ejegg: Fix composer version dependencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378778 [19:48:40] XenoRyet: meeting? [19:49:25] RECOVERY - Host frdb2001 is UP: PING OK - Packet loss = 0%, RTA = 36.17 ms [19:50:15] RECOVERY - Host pay-lvs2001 is UP: PING OK - Packet loss = 0%, RTA = 36.22 ms [19:50:16] RECOVERY - Host pay-lvs2002 is UP: PING OK - Packet loss = 0%, RTA = 36.41 ms [19:50:17] RECOVERY - Host rigel is UP: PING OK - Packet loss = 0%, RTA = 36.19 ms [19:50:18] RECOVERY - Host alnitak is UP: PING OK - Packet loss = 0%, RTA = 36.18 ms [19:50:18] RECOVERY - Host saiph is UP: PING OK - Packet loss = 0%, RTA = 36.18 ms [19:55:15] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 21 failures. Last run 8 minutes ago with 21 failures. Failed resources (up to 3 shown): File[/etc/pam_script/pam_script_auth],File[/etc/motd.tail],File[/usr/bin/check-raid.py],File[/etc/rssh.conf] [19:55:15] PROBLEM - check_puppetrun on payments2002 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 8 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/etc/pam_script/pam_script_auth],File[/etc/network/if-up.d/wikimedia-lvs-realserver],File[/etc/motd.tail],File[/usr/bin/check-raid.py] [19:55:44] Fundraising-Backlog: Persistent colors for labels in Grafana - https://phabricator.wikimedia.org/T176173#3616043 (mepps) [19:58:29] Fundraising-Backlog: Clean up Damaged queue - https://phabricator.wikimedia.org/T175862#3616060 (DStrine) p:Triage>High [20:00:15] RECOVERY - check_puppetrun on frbackup2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [20:00:25] RECOVERY - check_puppetrun on payments2002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [20:03:50] (CR) jerkins-bot: [V: -1] Fix composer version dependencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378778 (owner: Ejegg) [20:12:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Impressions in Japan FR campaign - https://phabricator.wikimedia.org/T176146#3614996 (AndyRussG) Using Pivot to look at several days of impression rates in Japan for both mobile and desktop campaigns, I'm seeing normal impression rates everywhere e... [20:17:49] fundraising-tech-ops, Operations, netops, ops-codfw: connect second ethernet interface for fundraising codfw hosts - https://phabricator.wikimedia.org/T176175#3616118 (Jgreen) [20:20:52] (PS1) Ejegg: Try also setting CIVI_EXT_URL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378790 [20:25:14] (CR) jerkins-bot: [V: -1] Try also setting CIVI_EXT_URL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378790 (owner: Ejegg) [20:29:42] ejegg so frustrating! how did the build come to break in the first place since it was working before? [20:30:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Impressions in Japan FR campaign - https://phabricator.wikimedia.org/T176146#3616147 (AndyRussG) Regarding large vs. small banners, it seems that a significant percentage of users went directly to small banners, especially on Mobile (android, iphon... [20:30:06] I think they finally cleared out the directories [20:30:17] and we hadn't actually upstreamed the fixes [20:30:35] anyway, I see most of the other build configs set CIVI_EXT_DIR / URL [20:30:57] but ci-populate-dbs is too early, since it gets clobbered by the defaults [20:31:06] will update the pull request after my 1:1 with k4 [20:36:54] Fundraising-Backlog: Get Kaitlin Thaney access to CiviCRM - https://phabricator.wikimedia.org/T176177#3616165 (MBrent) [20:37:19] Fundraising-Backlog: Get Kaitlin Thaney access to CiviCRM - https://phabricator.wikimedia.org/T176177#3616181 (MBrent) p:Triage>High [20:48:09] so my calendar says stand up time is now? [20:50:08] (PS5) Mepps: Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 [20:50:24] mepps / eileen: https://github.com/civicrm/civicrm-buildkit/pull/355 [20:50:41] eileen: is it kiwi daylight savings switchover? [20:51:44] ejegg: no next week but in my calendar it is changed. I actually set the alarm for 7.45 standup (I don't normally set it but I had bad sleep) & woke up, looked at my calendar & it said it is at 8.45 (which is now) [20:52:01] oh weird [20:52:30] there's a bug to be filed here somewhere! [20:52:38] google calendar? [20:52:42] ejegg tests closer ^^ but i'm not sure about that review versus process, part of my learning curve with minfraud and the ingenico switchover [20:54:04] yep - I actually had some notes for stand up - mostly because I'm not quite sure what to focus on [20:54:31] I was trying to do replag related stuff last week but after Friday conversation I'm not feeling like I'm contributing to a solution on it [20:54:47] since it seems that most of the paths I've been following are red-herrings [20:55:09] but there are a few things I could do - there is still some stuff in group_contact_cache that could be improved [20:55:35] +∞ [20:55:41] or I could improve batching / extend the csv placeholder to recipient get [20:55:41] eileen: so, you added the API call params to suppress cache recalculation [20:55:42] re: red herrings [20:56:02] ejegg: yeah I added those in part - but we could use them more agressively [20:56:19] right, it didn't look like we were actually using them yet [20:56:21] the thing is it they really are red herrings am I better to go back to dedupe? [20:56:36] oh, I guess the dedupe is called as a cli api call [20:56:49] so it would be using the new API params already [20:57:00] well yeah but there is another thing in mysql that civi partially uses which is of interest here [20:57:11] but yeah, should we add them in the queue consumer job? [20:57:20] there is a process lock - which would lock an action across multiple php threads [20:57:21] oh, what's the other thing? [20:57:37] oh weird, I've never heard of that [20:57:43] so it would mean that if one thing (dedupe script) is locking group cache clearing then another won't try [20:57:48] i am pretty much convinced that whatever tf is going on with frdb2001 is more of a system or network issue than anything application related [20:57:55] *however* [20:57:58] ALSO, we are actually throwing away our group cache immediately [20:58:12] that doesn't do anything to explain all the other weird lag we've seen across the db boxen [20:58:18] this is the lock http://techblog.procurios.nl/k/news/view/41405/14863/mysql-get_lock()-explained.html [20:58:43] Fundraising-Backlog: Get Kaitlin Thaney access to CiviCRM - https://phabricator.wikimedia.org/T176177#3616249 (DStrine) Does shoe already have access to civi? What else would she need? [20:58:53] but ejegg all of that adds up to 'there are more avenues I can follow but if cwd doesn't think it is helping should I go back to dedupe focus (dstrine) [20:59:51] eileen: that is my opinion, i would however love to keep you on retainer for when it crops up again :) [21:00:06] :- [21:00:26] mfw i have no face [21:01:25] see I'm glad I looked up what MFW means because MF had me guessing at what the W might be [21:01:45] I'd like to try adding the new API param to our queue consumer, but I'll make a phab task to prioritize [21:02:36] hahaha [21:04:06] ejegg: :-) [21:05:52] ejegg: yeah I'd like to work on it too - although I think the getLock might be better once we delve in - the consolidation I merged makes it so more paths use the same code - so we actually did get less cache clearing because there are static vars in use which some paths bypassed [21:08:40] ahh nice, I didn't realize we got that bonus too [21:09:04] I'm always happy to eliminate function-scoped statics though [21:10:11] :-) [21:10:28] The add to group & remove from group functions were bypassing the other mechanisms [21:11:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Use new cache-recalculation-suppression API params in more jobs - https://phabricator.wikimedia.org/T176180#3616278 (Ejegg) [21:12:26] (CR) jerkins-bot: [V: -1] Adding getStatus tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [21:19:55] fundraising-tech-ops, Operations, netops, ops-codfw: connect second ethernet interface for fundraising codfw hosts - https://phabricator.wikimedia.org/T176175#3616118 (faidon) All of them? Wasn't the plan to only do it for the few hosts that are important SPOFs? Again, I fear that this gives a fa... [21:35:45] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [21:40:44] (Abandoned) Ejegg: Fix composer version dependencies [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378778 (owner: Ejegg) [21:40:56] (Abandoned) Ejegg: Try also setting CIVI_EXT_URL [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378790 (owner: Ejegg) [21:41:08] (Abandoned) Ejegg: Try to set extension dir right in build [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378762 (owner: Ejegg) [21:49:43] (CR) jerkins-bot: [V: -1] Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [21:50:22] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [21:54:35] (CR) jerkins-bot: [V: -1] Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:01:00] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:06:25] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising-Backlog, Patch-For-Review: Establish methodology for creating load to replicate replag - https://phabricator.wikimedia.org/T175665#3599281 (Eileenmcnaughton) [22:07:16] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising-Backlog, Patch-For-Review: Establish methodology for creating load to replicate replag - https://phabricator.wikimedia.org/T175665#3599281 (Eileenmcnaughton) I'm closing this - it didn't fully work as it seemed to wo... [22:07:41] (CR) jerkins-bot: [V: -1] Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:08:11] dstrine are you about? [22:09:53] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:12:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update CiviCRM ganglia bits to point to Prometheus - https://phabricator.wikimedia.org/T171524#3616429 (Ejegg) PHP client library: https://github.com/Jimdo/prometheus_client_php Metric types: https://prometheus.io/docs/concepts/metric_types/ All we're... [22:12:58] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation Queue consumer should stop trying to hit ganglia - https://phabricator.wikimedia.org/T176167#3616431 (Ejegg) [22:13:00] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3616435 (Ejegg) [22:13:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update CiviCRM ganglia bits to point to Prometheus - https://phabricator.wikimedia.org/T171524#3616437 (Ejegg) [22:13:44] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#2852630 (Ejegg) [22:14:05] fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#2852630 (Ejegg) For CiviCRM code: PHP client library: https://github.com/Jimdo/prometheus_client_php Metric types: https://prometheus.io/docs/concepts/metric_types/ All we're using it for is... [22:15:03] Fundraising-Backlog, fundraising-tech-ops, Operations: Port fundraising stats off Ganglia - https://phabricator.wikimedia.org/T152562#3616441 (Ejegg) [22:15:13] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378808 [22:17:55] (CR) jerkins-bot: [V: -1] Orphan Slayer Module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:18:36] (CR) Ejegg: "OK, looks like it's just an issue with the composer package versions now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/370225 (owner: Mepps) [22:18:59] (CR) Eileen: [C: 2] "merge to deployment" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378808 (owner: Eileen) [22:19:13] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/378809 [22:20:52] meeting mystery solved - I was looking at next week [22:21:23] eileen: Hi yeah I'm around. [22:21:45] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378808 (owner: Eileen) [22:21:49] (PS2) Eileen: mrmarkfrench/silverpop-php-connector update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/378809 [22:22:18] dstrine: I was just discussing with cwd & ejegg (above) whether I can add value to replag given where they think the issue is now [22:22:32] & feeling seems to be I should go back to dedupe focus [22:22:51] btw sorry about missing standup - confusion at my end [22:23:22] eileen: re standup it's cool. yeah I saw the replag stuff. can you check in with K4 first and then we'll discuss? [22:23:26] eileen I think that failure is due to the recent de-dev-master-ing of smash-pig and php-queue [22:23:57] (CR) Eileen: [C: 2] "composer update - change reviewed previously" [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/378809 (owner: Eileen) [22:24:06] ejegg: sure [22:24:07] (PS1) Ejegg: Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378812 [22:24:11] (CR) jerkins-bot: [V: -1] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378808 (owner: Eileen) [22:25:34] fundraising-tech-ops, Operations, netops, ops-codfw: connect second ethernet interface for fundraising codfw hosts - https://phabricator.wikimedia.org/T176175#3616465 (Jgreen) >>! In T176175#3616318, @faidon wrote: > All of them? Wasn't the plan to only do it for the few hosts that are important... [22:25:44] (CR) jerkins-bot: [V: -1] mrmarkfrench/silverpop-php-connector update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/378809 (owner: Eileen) [22:26:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Use new cache-recalculation-suppression API params in more jobs - https://phabricator.wikimedia.org/T176180#3616466 (Eileenmcnaughton) Re the mysql lock method - here is some explanation http://techblog.procurios.nl/k/news/view/41405/14863/mysql-get_lo... [22:26:51] eileen: I'll fold that silverpop-connector update in [22:27:06] oh wait, that's the vendor repo [22:27:19] ejegg: I see it failed on the install.sh [22:27:32] oh shoot [22:27:39] (CR) jerkins-bot: [V: -1] Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378812 (owner: Ejegg) [22:27:42] oops, lemme revert that [22:28:24] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/378809 (owner: Eileen) [22:33:04] fundraising-tech-ops, Operations, netops, ops-codfw: connect second ethernet interface for fundraising codfw hosts - https://phabricator.wikimedia.org/T176175#3616476 (faidon) >>! In T176175#3616465, @Jgreen wrote: >> Again, I fear that this gives a false sense of redundancy > > This does not co... [22:42:04] (PS1) Ejegg: Add CVV map variable for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378813 [22:48:39] (CR) Ejegg: "Looking good, just got to tweak the test data a tiny bit" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [22:51:14] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378812 (owner: Ejegg) [22:57:17] (CR) Ejegg: "Oops, we have a stupid function-name-based hook type thing in play here. You also need to change the function name on line 236 of ingenico" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/378257 (owner: Mepps) [23:04:35] dstrine: hey [23:05:06] so talking to Katie - I'm not sure any of the performance stuff I've been doing is going the right way - but I think what I can do that is useful is [23:05:30] a) put together a list of jobs that we run (what & when) [23:05:48] b) try to trawl multiple git repos & put together some sort of change timeline [23:08:49] eileen: Yeah K4 just said basically the same thing in gchat. sounds good! Any info we can get by wednesday would be great [23:09:49] yeah - I'll see what I can do [23:10:11] (PS1) Eileen: Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 [23:10:23] (CR) Eileen: [C: 2] Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 (owner: Eileen) [23:10:45] (CR) jerkins-bot: [V: -1] Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 (owner: Eileen) [23:11:00] (CR) jerkins-bot: [V: -1] Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 (owner: Eileen) [23:15:28] ejegg: can you see what is happening here? https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php56-jessie/555/console [23:16:03] the composer change didn't change that much [23:16:04] https://gerrit.wikimedia.org/r/#/c/378809/2/composer/installed.json [23:17:08] eileen right, that's 'cause the newest version of donation-interface depends on numbered released of php-queue and smash-pig rather than dev-master [23:17:21] this should fix it: [23:17:29] https://gerrit.wikimedia.org/r/378812 [23:19:17] ah nice - does that need code review? [23:20:01] sure thing [23:20:29] i've gotta head out, but I'll be pingable this evening [23:20:32] see ya! [23:20:36] I'm just trying to understand what review is needed on it [23:20:48] because I guess the smash pig changes were already reviewed [23:21:00] eileen: sorry, shouldn't need more than a +2 - there wasn't much change [23:21:10] between the previous dev-master and those numbered releases [23:21:40] ok [23:22:09] (CR) Eileen: [C: 2] "smash pig change would have been reviewed elsewhere" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378812 (owner: Ejegg) [23:29:49] (Merged) jenkins-bot: Update composer packages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/378812 (owner: Ejegg) [23:33:03] (PS2) Eileen: Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 [23:33:28] (CR) Eileen: [C: 2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 (owner: Eileen) [23:33:39] (CR) jerkins-bot: [V: -1] Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 (owner: Eileen) [23:35:15] (CR) jerkins-bot: [V: -1] Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815 (owner: Eileen) [23:36:41] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378808 (owner: Eileen) [23:36:53] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378820 [23:58:07] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378820 (owner: Eileen) [23:58:45] (PS3) Eileen: Vendor udpate, silverpop-php-connector [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/378815