[00:00:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11784 [00:02:38] (PS1) Ejegg: When no form is found, retry without gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379443 (https://phabricator.wikimedia.org/T176356) [00:05:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11912 [00:10:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12050 [00:15:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11623 [00:20:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11724 [00:25:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11874 [00:30:07] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12014 [00:35:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12135 [00:35:45] (PS1) Eileen: Update vendor for Omnimail offset fix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/379453 [00:36:47] (CR) Eileen: [C: 2] Update vendor for Omnimail offset fix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/379453 (owner: Eileen) [00:37:34] (Merged) jenkins-bot: Update vendor for Omnimail offset fix [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/379453 (owner: Eileen) [00:40:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12251 [00:41:56] !log update civicrm from da833ac561f7586a0b64fbef2cdf2963bc4055c3 to fc56901efd386ca725bde971ae000d798e1e2fca [00:42:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:45:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12368 [00:50:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12480 [00:55:07] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12534 [01:00:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 12492 [01:05:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 11092 [01:10:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 9413 [01:15:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 6413 [01:20:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4301 [01:25:17] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2079 [01:35:17] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 1680492 Threads: 4 Questions: 74908436 Slow queries: 119919 Opens: 13947 Flush tables: 2 Open tables: 474 Queries per second avg: 44.575 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [01:48:57] (PS1) Eileen: Omnimail recipient job: Follow up fix on suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379456 (https://phabricator.wikimedia.org/T176255) [02:02:43] (PS1) Eileen: Omnimail recipient - further fixes to batching. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379457 (https://phabricator.wikimedia.org/T176255) [02:06:20] (CR) jerkins-bot: [V: -1] Omnimail recipient - further fixes to batching. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379457 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [02:33:48] (PS2) Eileen: Omnimail recipient - further fixes to batching. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379457 (https://phabricator.wikimedia.org/T176255) [02:37:19] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email, Patch-For-Review: Omnimail recipient load (silently) broken - https://phabricator.wikimedia.org/T175394#3592379 (Eileenmcnaughton) This is fixed. However I need to look at backfilling. Data is d... [03:40:35] (PS1) Eileen: The big group clean up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379463 (https://phabricator.wikimedia.org/T174407) [04:03:59] (PS2) Eileen: The big group clean up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379463 (https://phabricator.wikimedia.org/T174407) [04:17:34] (PS3) Eileen: The big group clean up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379463 (https://phabricator.wikimedia.org/T174407) [04:50:49] (PS1) Eileen: Group follow up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379465 (https://phabricator.wikimedia.org/T174407) [04:52:31] (PS2) Eileen: Group follow up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379465 (https://phabricator.wikimedia.org/T174407) [05:19:53] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Manage groups page seems to be refreshing groups when it shouldn't - https://phabricator.wikimedia.org/T176258#3623574 (Eileenmcnaughton) I've dug into what is happening here - the first 25 groups are resolved to... [05:20:11] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Manage groups page seems to be refreshing groups when it shouldn't - https://phabricator.wikimedia.org/T176258#3619122 (Eileenmcnaughton) [05:35:08] Fundraising Sprint RadioActivewear, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Reset on_hold in wmf_civicrm_message_email_update - https://phabricator.wikimedia.org/T170350#3623580 (Eileenmcnaughton) @Ejegg just wanted to get your thoughts on this. The issue is that when an imp... [05:40:54] (PS1) Eileen: When updating an email return early on email match & set on_hold otherwise. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) [05:48:05] (CR) jerkins-bot: [V: -1] When updating an email return early on email match & set on_hold otherwise. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [14:21:36] (CR) Mepps: [C: 2] "Pretty straightforward!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379443 (https://phabricator.wikimedia.org/T176356) (owner: Ejegg) [14:25:25] (CR) Zoranzoki21: [C: 1] When no form is found, retry without gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379443 (https://phabricator.wikimedia.org/T176356) (owner: Ejegg) [14:25:42] (Merged) jenkins-bot: When no form is found, retry without gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379443 (https://phabricator.wikimedia.org/T176356) (owner: Ejegg) [14:26:42] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Form chooser short term fix: retry without 'gateway' param - https://phabricator.wikimedia.org/T176356#3624508 (Zoranzoki21) Open>Resolved a:Ejegg [14:30:42] (PS7) Mepps: WIP Try out approvePayment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/370656 [14:30:44] (PS2) Mepps: WIP approvePayment tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379292 [14:33:56] (CR) Mepps: "Should we be dropping these from all languages?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/288527 (owner: Ejegg) [14:34:58] (PS6) Mepps: Undo 'require' debug mode hack [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319259 (owner: Ejegg) [14:35:03] (CR) Mepps: [C: 2] Undo 'require' debug mode hack [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319259 (owner: Ejegg) [14:35:32] mepps: thanks! ^ :) [14:36:22] oh AndyRussG, oops! but that looked pretty straightforward [14:38:44] Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Credit card type logos can overflow boxes on mobile - https://phabricator.wikimedia.org/T176419#3624541 (Pcoombe) [14:39:01] (Merged) jenkins-bot: Undo 'require' debug mode hack [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/319259 (owner: Ejegg) [14:48:18] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface: Adyen credit card fields not styled correctly on iOS devices - https://phabricator.wikimedia.org/T176420#3624576 (Pcoombe) [14:51:37] mepps: but why "oops"? [14:51:42] All good :) [14:52:43] Really excellent that you looked at it, I should have taken care of it eons ago ;p very much appreciated :) [14:53:12] Also a great place to start to get your feet wet with CN! [15:14:57] mepps: infact if you feel like more centralnoticing, I'm a bit stumped on a bug here... [15:15:08] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1768 processes [15:15:11] https://phabricator.wikimedia.org/T175358 [15:16:35] https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/includes/CNChoiceDataResourceLoaderModule.php#L19-L41 [15:17:56] Somehow that method under certain conditions is returning an object, like {"1":"foo","2":"zoo","4":"boo"}, rather than a normal array [15:18:27] That happens when PHP tries to encode in JSON a PHP array with numeric keys that are not quite in order [15:18:32] or with gaps [15:20:17] However, the data comes from a method that always puts the data through a "usort" function [15:20:18] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1220 processes [15:20:19] https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/includes/ChoiceDataProvider.php#L330 [15:20:38] And usort is supposed to always create new keys that are in order [15:20:59] http://php.net/manual/en/function.usort.php [15:21:17] "Note: This function assigns new keys to the elements in array. It will remove any existing keys that may have been assigned, rather than just reordering the keys." [15:22:31] Now trying to find if it might not be a bug in HHVM [15:26:18] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 4 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3624676 (mepps) @ejegg can we move this to done? [15:30:18] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1134 processes [15:35:18] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1127 processes [15:49:22] Ooooh wait I found it bwahahahaha! [15:49:25] Silly me [15:52:11] It's actually not coming directly through ChoiceDataProvider::fetchChoices(), but rather through ChoiceDataProvider::getChoices() which deals with PHP-side caching [15:53:01] https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/includes/ChoiceDataProvider.php#L71-L72 [16:00:17] wow it's failmail city today [16:01:17] Yea, noticing that. Gotta clear up one minor kid related emergency, then I'm on it. [16:05:16] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 251 processes [16:09:23] fundraising-tech-ops, Operations, Pybal, Traffic: pybal vs firewall failover - BGP session down - https://phabricator.wikimedia.org/T173028#3624822 (ema) p:Triage>Normal [16:10:27] Wikimedia-Fundraising: Store link on thank you page in US/CA - https://phabricator.wikimedia.org/T176342#3624827 (Pcoombe) Open>Resolved Yep, needed to make sure `mw.util` was loaded. Fixed with https://wikimediafoundation.org/w/index.php?title=MediaWiki:Common.js&diff=111990&oldid=105873 [16:11:48] fundraising-tech-ops, Operations, Pybal, Traffic: pybal vs firewall failover - BGP session down - https://phabricator.wikimedia.org/T173028#3624832 (ema) I've just seen this bug while testing the BGP interactions between pybal-test2001 and quagga, the assertion can be removed as being in ST_IDLE... [16:43:26] fundraising-tech-ops, Operations, netops, ops-codfw: unrack/decom pfw1-codfw and pfw2-codfw - https://phabricator.wikimedia.org/T176427#3624959 (ayounsi) [17:05:54] XenoRyet: hope everything's OK! [17:06:28] AndyRussG: Oh yea, just a little thing. Marek forgot to put his lunch in the car before they left for school, so I had to run it down there real quick. [17:06:36] School is just around the block, so no big deal. [17:06:42] Ahh heheh been there, many times! [17:06:49] Yep, it happens. [17:06:51] Once it happened to me two days in a row! [17:07:00] Heh, I can see it. [17:07:04] And both days I'd made like the best lunch that I was so proud of [17:07:16] Also just think of the difference in the two warning systems, kid vs. fr emergency [17:07:26] Can you get a lunch-forgotten-faiilmail? [17:07:43] Hehe, that'd be a handy system to have. [17:07:48] Indeed [17:07:58] Embed wearable gps tracker in lunchbox [17:18:24] (PS1) AndyRussG: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/379576 (https://phabricator.wikimedia.org/T175358) [17:21:05] Aaarg the satisfaction of catching a silly mistake... almost as good as the satisfaction of not having made one [17:21:17] Also, aaarg PHP [17:33:36] ooh, numbergap problems? [17:39:56] ejegg: yeah array_filter numbergaps on the sly [17:40:30] It's code that was added with the caching changes to ChoiceDataProvider [17:40:58] Then when you json_encode it ends up as a JS object rather than an array [17:41:21] Just making sure I can reproduce locally and that the fix fixes [17:44:56] wow, subtle stuff! [17:45:09] Woohoo reproduced locally. What you need is another campaign that comes after the one that's been array_filtered in the array, to ensure the gap [17:45:23] It's the PHP challenge [17:46:00] How many gotchas can you include in built-in functions of a language? [17:55:56] haha [18:04:07] It's not funny!!!!! [18:04:09] OK, maybe it is [18:04:35] What's that text-mode emoji of laughing and crying at the same time? [18:23:49] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: CN Campaign Suppression prior to scheduled start time - https://phabricator.wikimedia.org/T175358#3625263 (AndyRussG) K, reproduced locally and smoke tested... [18:49:47] (CR) AndyRussG: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/377538 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [18:52:26] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising-Backlog, and 2 others: CentralNotice: JS selection widgets no longer work in interface to add a campaign - https://phabricator.wikimedia.org/T172023#3625327 (AndyRussG) @Ejegg no, s... [19:11:47] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Hide 'continue' button when opening CC iframe - https://phabricator.wikimedia.org/T149366#3625353 (Pcoombe) Open>Resolved a:Pcoombe [19:17:31] AndyRussG glad I could help! ;) [19:46:25] (PS1) Ejegg: WIP Use permissions hook to prevent unlimited dedupe [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379601 (https://phabricator.wikimedia.org/T175382) [19:46:36] mepps ^^^ works to block that query [19:46:53] I just probably have to add a few more checks so it doesn't block extra stuff [19:47:41] ejegg: AndyRussG meeting? [19:48:02] (CR) Mepps: [C: 2] WIP Use permissions hook to prevent unlimited dedupe [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379601 (https://phabricator.wikimedia.org/T175382) (owner: Ejegg) [19:50:58] dstrine: oops, be right there! [19:57:05] Fundraising Sprint RadioActivewear, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3625415 (DStrine) [20:11:29] fundraising-tech-ops, Operations, hardware-requests, netops, ops-codfw: unrack/decom pfw1-codfw and pfw2-codfw - https://phabricator.wikimedia.org/T176427#3625467 (RobH) [20:13:28] (PS2) Ejegg: Use permissions hook to prevent unlimited dedupe [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379601 (https://phabricator.wikimedia.org/T175382) [20:13:45] mepps OK, I think that's narrow enough ^^^ [20:15:01] (CR) Mepps: [C: 2] Use permissions hook to prevent unlimited dedupe (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379601 (https://phabricator.wikimedia.org/T175382) (owner: Ejegg) [20:16:57] fundraising-tech-ops, Operations, hardware-requests, netops, ops-codfw: unrack/decom pfw1-codfw and pfw2-codfw - https://phabricator.wikimedia.org/T176427#3625517 (ayounsi) a:ayounsi>Papaul thanks Rob! [20:18:34] (Merged) jenkins-bot: Use permissions hook to prevent unlimited dedupe [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379601 (https://phabricator.wikimedia.org/T175382) (owner: Ejegg) [20:21:53] fundraising-tech-ops, Operations, hardware-requests, netops, ops-codfw: unrack/decom pfw1-codfw and pfw2-codfw - https://phabricator.wikimedia.org/T176427#3625550 (ayounsi) [20:26:04] fundraising-tech-ops, Operations, hardware-requests, netops, ops-codfw: unrack/decom pfw1-codfw and pfw2-codfw - https://phabricator.wikimedia.org/T176427#3625559 (ayounsi) [20:33:06] ok, I'm going to do a civi deploy [20:34:53] fundraising-tech-ops: build & deploy latest pybal for frack - https://phabricator.wikimedia.org/T176260#3625580 (Jgreen) The production packge (source https://gerrit.wikimedia.org/r/operations/debs/pybal right?) appears to be at 1.13.11 with several patches since 1.13.2, although it looks like there's anothe... [20:35:07] ejegg hang on one sec [20:35:31] sure mepps [20:35:38] problems with that last one? [20:37:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage seeing warning message when editing in Civi. - https://phabricator.wikimedia.org/T176371#3623036 (Ejegg) Ah, I wonder if this has to do with the dedupe query logging - I had a bad watchdog line in there which omitted the context array. About to d... [20:38:25] (PS1) Mepps: Add default limit [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/379628 [20:38:43] ejegg ^^ i think this is how we could ensure a limit in the redirect [20:38:59] it doesn't have to be 500, we could also use the setting if it exists [20:40:37] let me know what you think [20:43:37] mepps that seems fine locally [20:43:53] were you planning to try to upstream that too? [20:43:58] i'm not sure ejegg [20:44:34] i can but i'm not sure in that case what to set as the default limit [20:45:05] also this is more something i want to discuss in general i notice some of our civi code is upstreamed and some isn't--have we ever talked about conventions for custom code? [20:45:22] as in pulling it into separate overwrite files if its' not upstreamed [20:46:48] mepps we have a set of patches that we re-apply to new versions [20:46:59] and we've been steadily cutting down that list [20:47:16] do we have those listed somewhere? [20:47:19] errrr [20:47:23] that's good ejegg [20:47:41] cutting down the list i mean [20:47:45] shoot, I know eileen's been keeping track of them [20:48:09] (CR) Ejegg: [C: 2] Add default limit [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/379628 (owner: Mepps) [20:48:42] 3bbac063c Remove unnecessary trigger refresh [20:48:43] 0ca9c3be3 Retry deadlocked inserts, take two [20:48:44] re: upstreaming, this is a quick fix and i'll be at the codesprint next week so i can get a sense of whether this is something that would be worth pushing up [20:48:47] 77c0722c8 Use permissions hook to prevent unlimited dedupe [20:48:55] ack, middleclick spam [20:49:00] ahh [20:49:10] fundraising-tech-ops, Operations, netops, ops-codfw: connect second ethernet interface for fundraising codfw hosts - https://phabricator.wikimedia.org/T176175#3625620 (Jgreen) @ayounsi ports are connected! When you have some time let's start setting them up? [20:50:32] (PS1) Ejegg: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379648 [20:50:39] (CR) Ejegg: [C: 2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379648 (owner: Ejegg) [20:51:37] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/379650 [20:51:47] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/379650 (owner: Ejegg) [20:51:49] (Merged) jenkins-bot: Add default limit [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/379628 (owner: Mepps) [20:52:01] ^^ jumped the queue like crazy there, let's see if that works out [20:52:25] fingers crossed! [20:57:14] (Merged) jenkins-bot: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379648 (owner: Ejegg) [20:57:16] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/379650 (owner: Ejegg) [21:04:04] !log updated CiviCRM from fc56901efd386ca725bde971ae000d798e1e2fca to 45c56cf1afb40c812fd45fff3f2e030226ba85ea [21:04:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:11:36] (PS1) Pcoombe: Fix Adyen iframe field styles on iOS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379665 (https://phabricator.wikimedia.org/T176420) [21:16:37] Fundraising-Backlog, FR-Adyen, MediaWiki-extensions-DonationInterface, Patch-For-Review: Adyen credit card fields not styled correctly on iOS devices - https://phabricator.wikimedia.org/T176420#3625714 (Pcoombe) This is actually somewhat urgent, as it affects France and we saw notably lower conve... [21:17:23] dstrine: If someone from tech could take a look at the above, it would be much appreciated :) [21:17:32] pcoombe: looking! [21:17:46] cool, thanks ejegg [21:17:49] we do in fact need to send the update to adyen [21:18:18] they've got a 'skinCode' param we could potentially use to a/b test variations [21:18:46] but this looks like a thing to just apply now [21:19:28] yah... invisible inputs are bad [21:19:29] yeah I think this just needs fixing [21:20:16] pcoombe what is -webkit-appearance: none ? [21:22:19] ejegg: That makes sure they get the shadows we have defined. Otherwise there is no shadow to act as border, and it's still quite indistinct [21:22:42] k, thanks! [21:22:49] We can define a border, but then it looks weird on other browsers to have a border and the shadows as well [21:23:14] ah, it's like "don't use the native styles" [21:23:25] Exactly [21:23:32] nice to have! [21:24:01] (CR) Ejegg: [C: 2] Fix Adyen iframe field styles on iOS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379665 (https://phabricator.wikimedia.org/T176420) (owner: Pcoombe) [21:24:11] ok, i'll get that up to adyen asap [21:24:41] Wonderful, thanks! [21:25:22] (CR) Zoranzoki21: [C: 1] Fix Adyen iframe field styles on iOS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379665 (https://phabricator.wikimedia.org/T176420) (owner: Pcoombe) [21:26:38] I've got a more extensive cleanup/redesign for this and the Ingenico CSS in the pipeline btw. But that probably won't be ready for another week or two. [21:29:53] (Merged) jenkins-bot: Fix Adyen iframe field styles on iOS [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379665 (https://phabricator.wikimedia.org/T176420) (owner: Pcoombe) [21:31:47] pcoombe: I just saw the emails from phab. Thanks for helping ejegg [21:33:55] No problem dstrine. Was actually helpful for me, I learned how to debug stuff on the iPad better in the process. [21:34:06] cool! [21:38:52] pcoombe: ok, I think that should be live! [21:39:00] also, iPad debugging.... ooooh [21:39:32] do you need a mac and xcode just to interact with the ipad debug tools? [21:44:40] Looks good, thanks ejegg! [21:44:59] And the iPad debugging is this: https://developer.apple.com/library/content/documentation/AppleApplications/Conceptual/Safari_Developer_Guide/GettingStarted/GettingStarted.html [21:48:11] ah, so you do need safari on a desktop, but not necessarily xcode [21:48:22] thanks pcoombe [21:51:07] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/379675 [21:51:39] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/379675 (owner: Ejegg) [21:54:05] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/379675 (owner: Ejegg) [21:59:29] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/379678 [22:00:55] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/379678 (owner: Ejegg) [22:01:27] (CR) Ejegg: [C: 2] "Ah, that makes sense. Thanks for the explanation!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/377538 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [22:05:35] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/379678 (owner: Ejegg) [22:05:37] (Merged) jenkins-bot: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/377538 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [22:06:58] (PS2) Ejegg: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/379576 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [22:07:15] (CR) Ejegg: [C: 2] "Very subtle. Good find!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/379576 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [22:10:14] (Merged) jenkins-bot: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/379576 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [22:10:51] !log updated payments-wiki from 9da84823ff4ac3071d218ec211fb59c054de9e15 to 7ed72430d771361efe053d60a127827e7c917823 [22:11:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:11:51] XenoRyet|brb: did you have a chance to look at the MinFraud patch at all? [22:12:35] oops, forgot to change back. [22:13:13] ejegg: Yea, looks good, just one comment in there. [22:14:09] thanks, good catch! [22:14:23] No worries, that's what CR is for. [22:17:10] (PS14) Ejegg: Optionally send more Minfraud parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) [22:17:18] (PS3) Ejegg: Don't send empty or '0' address fields to minFraud [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379120 [22:18:50] (PS2) Ejegg: Omnimail recipient job: Follow up fix on suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379456 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [22:18:59] (CR) Ejegg: [C: 2] Omnimail recipient job: Follow up fix on suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379456 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [22:20:12] (CR) XenoRyet: [C: 2] Optionally send more Minfraud parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) (owner: Ejegg) [22:22:42] (Merged) jenkins-bot: Omnimail recipient job: Follow up fix on suffix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379456 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [22:25:23] (Merged) jenkins-bot: Optionally send more Minfraud parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275043 (https://phabricator.wikimedia.org/T128902) (owner: Ejegg) [22:29:04] (Merged) jenkins-bot: Don't send empty or '0' address fields to minFraud [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/379120 (owner: Ejegg) [22:36:22] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Send more parameters to Maxmind minfraud service - https://phabricator.wikimedia.org/T128902#3625889 (Ejegg) [22:41:36] Fundraising-Backlog, FR-Adyen, FR-Ingenico, MediaWiki-extensions-DonationInterface, Patch-For-Review: Redirect loop when processor is disabled. - https://phabricator.wikimedia.org/T140314#3625895 (Ejegg) Open>Resolved a:Ejegg Seems to be fixed [22:58:44] Fundraising-Backlog, JavaScript: jQuery is not defined on page on wmf wiki - https://phabricator.wikimedia.org/T138700#3625951 (Ejegg) Open>Resolved a:Ejegg Wow, that page is even trying to insert contribution tracking records from foundationwiki! I added a notice to the top of the 2011 templ... [23:40:24] (PS3) Ejegg: Omnimail recipient - further fixes to batching. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379457 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [23:40:32] (CR) Ejegg: [C: 2] Omnimail recipient - further fixes to batching. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379457 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [23:43:05] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/379691 [23:43:08] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/379691 (owner: Ejegg) [23:44:10] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/379692 [23:44:13] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/379692 (owner: Ejegg) [23:46:30] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/379691 (owner: Ejegg) [23:47:07] (Merged) jenkins-bot: Omnimail recipient - further fixes to batching. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379457 (https://phabricator.wikimedia.org/T176255) (owner: Eileen) [23:48:34] (CR) Eileen: [C: -1] "More feedback in from Caitlin, will adjust this based on that" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379465 (https://phabricator.wikimedia.org/T174407) (owner: Eileen) [23:48:35] XenoRyet: so does it look like we need to make more PayPal fixes? [23:48:54] We at least need the other two reason codes [23:49:02] but that's already on the docket. [23:49:08] (CR) Eileen: [C: -1] "-1 pending me processing Caitlin V's response" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379463 (https://phabricator.wikimedia.org/T174407) (owner: Eileen) [23:49:28] oh, is that all the problem was? [23:50:07] One of 'em. Others seem like legitimate failures from PayPal that we can't recover from, but I'm still trying to convince myself that's all of it. [23:50:58] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What should we do to fix data where blank addresses have overwritten valid addresses - https://phabricator.wikimedia.org/T153917#2894976 (Ejegg) @Eileenmcnaught... [23:53:08] Anyway, I gotta go get this kid. School's closing early today so it's a hard out at 5:00. I'll see you folks tomorrow. [23:54:20] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/379692 (owner: Ejegg) [23:56:58] !log updated payments-wiki from 7ed72430d771361efe053d60a127827e7c917823 to d2ce6970a761829de86d62919bca8ebd821f41f1 [23:57:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:58:04] q [23:58:10] derp