[00:02:08] yep! [00:02:25] I think the code base smells of fear [00:02:41] too many people scared to make too big a change just keep added extra magic params [00:20:38] one drawback of the open source / volunteer model [03:26:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Prevent showing CentralNotice on History/Diff pages to partially resolve banner-bump issues - https://phabricator.wikimedia.org/T176656#3638391 (Quiddity) [06:57:44] (CR) Thiemo Mättig (WMDE): Fix test to meet php standard. (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380668 (owner: Eileen) [07:17:13] (CR) Eileen: "Regarding the space - this is in the drupal part of the codebase & drupal whitespace standards would dictate no spaces should be there. Th" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380668 (owner: Eileen) [14:40:10] fundraising-tech-ops: rsyslog hung after firewall switch - https://phabricator.wikimedia.org/T176821#3637573 (Jgreen) Rsyslog is somewhat configurable in terms of retries: http://www.rsyslog.com/doc/rsconf1_actionresumeinterval.html We set this in the central log filter, which I think is supposed to make i... [15:17:31] (PS1) Ejegg: WmfDatabase: Rollback all if Civi txn marked for rollback [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381004 [15:42:36] (PS1) Ejegg: Add 'first_donation_date' column to Silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) [15:43:17] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, FR-Email, Patch-For-Review: Add field to Silverpop export: first donation date - https://phabricator.wikimedia.org/T150467#3640056 (Ejegg) a:Ejegg [15:49:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: update civi record whit actual audit USD totals when we get them - https://phabricator.wikimedia.org/T152249#3640065 (Ejegg) Wait, we need to avoid weather control satellites destroying Colombia's coffee crop? I'm on board! [16:13:23] Fundraising Sprint RadioActivewear, Fundraising-Backlog: Deploy French thank you email - https://phabricator.wikimedia.org/T176585#3640148 (jrobell) Thank you very much @Ejegg ! The TY letter looks good to me! [16:31:51] (PS2) Ejegg: WmfDatabase: Rollback all if Civi txn marked for rollback [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381004 (https://phabricator.wikimedia.org/T171349) [16:59:18] (PS1) Ejegg: Unstage street_address, removing dummy data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/381037 (https://phabricator.wikimedia.org/T128902) [16:59:29] Mornin XenoRyet! [16:59:41] Mornin' [17:00:05] I turned on the extra minFraud fields yesterday [17:00:17] Yea, I saw that email. [17:00:24] Everything going as expected so far? [17:00:24] and realized we're sending the staged dummy data for street_address and postal_code [17:00:44] we really only want to send those to CC processors for AVS validation [17:00:48] (so the lore goes) [17:01:09] So I just wrote that unstaging patch ^^^ [17:01:17] Cool. I'll take a look. [17:01:27] It'll also stop us sending those dummy values down the pipe to Civi [17:01:49] Yea, that also makes sense. No reason for them to be there at that stage. [17:01:53] oh hey, there's a little bug in the CA postal staging, lemme fix that right quick [17:02:02] 10-4 [17:02:14] I'll do it in a different patch, no need to wait [17:03:02] (PS1) Ejegg: Fix CA postal code staging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/381038 [17:05:15] * ejegg tunelessly sings "All the cops in the donut shops say 'ay oh ay oh, ay oh ay oh'" [17:05:37] (CR) XenoRyet: [C: 2] Unstage street_address, removing dummy data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/381037 (https://phabricator.wikimedia.org/T128902) (owner: Ejegg) [17:07:01] (CR) XenoRyet: [C: 2] "What you did there... I see it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/381038 (owner: Ejegg) [17:07:57] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: email address validation not clearing error on blur - https://phabricator.wikimedia.org/T176501#3640336 (XenoRyet) a:XenoRyet [17:10:21] (Merged) jenkins-bot: Unstage street_address, removing dummy data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/381037 (https://phabricator.wikimedia.org/T128902) (owner: Ejegg) [17:12:07] (Merged) jenkins-bot: Fix CA postal code staging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/381038 (owner: Ejegg) [17:32:25] fr-tech any news for scrum of scrums? [17:32:40] None here [17:33:27] nope, ty [17:40:03] (PS1) AndyRussG: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381047 (https://phabricator.wikimedia.org/T174719) [17:40:05] (PS1) AndyRussG: Add ext.centralNotice.adminUi module back to campaign list view [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381048 (https://phabricator.wikimedia.org/T172023) [17:40:07] (PS1) AndyRussG: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381049 (https://phabricator.wikimedia.org/T175358) [17:40:56] !log updated SmashPig Adyen settings [17:41:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:41:38] (Abandoned) AndyRussG: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381049 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [17:41:45] (Abandoned) AndyRussG: Add ext.centralNotice.adminUi module back to campaign list view [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381048 (https://phabricator.wikimedia.org/T172023) (owner: AndyRussG) [17:41:50] (Abandoned) AndyRussG: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381047 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [17:45:07] (Restored) AndyRussG: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381049 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [17:45:18] (Restored) AndyRussG: Add ext.centralNotice.adminUi module back to campaign list view [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381048 (https://phabricator.wikimedia.org/T172023) (owner: AndyRussG) [17:45:26] (Restored) AndyRussG: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381047 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [17:45:33] (PS2) AndyRussG: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381047 (https://phabricator.wikimedia.org/T174719) [17:45:35] (PS2) AndyRussG: Add ext.centralNotice.adminUi module back to campaign list view [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381048 (https://phabricator.wikimedia.org/T172023) [17:45:37] (PS2) AndyRussG: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381049 (https://phabricator.wikimedia.org/T175358) [17:46:55] (CR) AndyRussG: [C: 2] BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381047 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [17:47:10] (CR) AndyRussG: [C: 2] Add ext.centralNotice.adminUi module back to campaign list view [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381048 (https://phabricator.wikimedia.org/T172023) (owner: AndyRussG) [17:47:20] (CR) AndyRussG: [C: 2] Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381049 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [17:49:47] (Merged) jenkins-bot: BannerHistoryLogger: Fix ajax options for when sendBeacon is not available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381047 (https://phabricator.wikimedia.org/T174719) (owner: AndyRussG) [17:49:49] (Merged) jenkins-bot: Add ext.centralNotice.adminUi module back to campaign list view [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381048 (https://phabricator.wikimedia.org/T172023) (owner: AndyRussG) [17:52:09] (Merged) jenkins-bot: Ensure numeric keys without gaps in ChoiceDataProvider::getChoices() [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/381049 (https://phabricator.wikimedia.org/T175358) (owner: AndyRussG) [17:55:00] fr-tech CN SWAT deloy coming up! [17:55:18] Good times [17:57:31] Yurp! [18:03:13] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/381054 [18:03:19] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/381054 (owner: Ejegg) [18:05:29] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Update CiviCRM ganglia bits to point to Prometheus - https://phabricator.wikimedia.org/T171524#3640534 (Ejegg) OK, the new file queue2civicrm.pr... [18:06:34] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/381054 (owner: Ejegg) [18:13:28] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/381056 [18:13:33] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/381056 (owner: Ejegg) [18:19:41] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/381056 (owner: Ejegg) [18:21:11] !log updated payments-wiki from 6104e3dea7a7051305c7d76f1e913b2410cbfcbf to c2a3d434d1234c3ae62b6b0359d69f302bca3bd6 [18:21:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:27:03] fr-tech K deploy is done! [18:27:17] Great! [18:27:32] need any help verifying stuff? [18:28:56] ejegg: everything looks fine so far... As in, banners appear still up, and the admin controls that broke are fix't [18:29:09] Rockin! [18:29:21] with a bit of time we should try to recreate the suppression bug, but that can be a bit later [18:30:59] ejegg: I did test that the iPad BH bug is fixed via the beta cluster [19:14:47] (CR) Ejegg: "I'm having second thoughts about setting on_hold when it matches another email address in the database. The on_hold setting is used in con" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [19:22:51] Heh well, wiki's still up [19:47:58] mepps: meeting? [19:48:10] oops nevermind [19:48:22] ignore me [19:55:11] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review: Fix LandingCheck language fallback - https://phabricator.wikimedia.org/T174693#3640936 (Ejegg) Open>Resolv... [19:57:15] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, and 4 others: Send more parameters to Maxmind minfraud service - https://phabricator.wikimedia.org/T128902#3640957 (Ejegg) Open>Resolved Sending them! And n... [20:11:23] ejegg: wanna discuss this one briefly https://gerrit.wikimedia.org/r/#/c/379467/3 [20:11:32] sure eileen [20:11:49] I'm thinking just delete the check for a matching address [20:12:07] so currently leaning to dropping the if from 1439 [20:12:14] unless we know exactly how that on_hold / reset_date stuff is going to work [20:12:28] yeah, exactly [20:12:40] right - yeah I was pretty undecided about that part [20:12:42] if it's changed, reset on_hold to 0 [20:13:35] I still can't find exactly where Civi should be routinely setting on_hold back to 0 - does it actually do that ever? [20:13:39] yep [20:13:44] Or is on_hold basically permament? [20:13:54] on hold usually means it is bouncing [20:14:01] & no good [20:14:15] normally orgs who care would see that & ask for a new email I guess [20:14:25] depending on the value of the customer [20:14:29] there are some reasons, like mailbox full or away, that we'd want to retry eventually [20:14:49] right - Civimail normally tries a certain number of times before marking on_hold [20:14:50] but i guess they just have higher thresholds for setting the on_hold flag [20:15:02] yep - dependent on the bounce type [20:15:18] k, got it. In that case, let's definitely reset on_hold to 0 on change [20:15:33] the mailing_bounce_pattern table relates [20:15:43] so, you think we should just ALWAYS set to 0 [20:15:55] (cheapest performance) [20:16:10] err, like you said, just delete the 3 lines from 1439 [20:16:17] OK [20:16:18] so, not reset to 0 if there's no change [20:16:44] Note that I suspect silverpop will not unset its hold status on an email - but that's ok [20:16:49] I'll remove those lines [20:16:58] cool [20:17:23] yeah, i think silverpop is loath to take anything off the suppression list once we've added it [20:18:21] and our export actually ORs the do not email / on hold status of all the copies of one email address to add it to the unsubscribe list [20:18:41] so for silverpop purposes we don't need those 3 lines [20:18:55] (PS4) Eileen: When updating an email return early on email match, set on_hold to 0 if email is not on hold in DB already. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) [20:19:30] (CR) Eileen: "OK those lines are gone now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [20:19:47] (PS5) Ejegg: When updating an email return early on email match, set on_hold to 0 if email is not on hold in DB already. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [20:19:54] yeah Silverpop does not listen to us :-) [20:19:56] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [20:23:29] (CR) jerkins-bot: [V: -1] When updating an email return early on email match, set on_hold to 0 if email is not on hold in DB already. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [20:23:59] ah dang, what's up with that? [20:24:35] ohhh, the test depended on those 3 lines! [20:24:55] (CR) jerkins-bot: [V: -1] When updating an email return early on email match, set on_hold to 0 if email is not on hold in DB already. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379467 (https://phabricator.wikimedia.org/T170350) (owner: Eileen) [20:26:44] eileen: mind nudging the parent of the duplicate invoice patch too? https://gerrit.wikimedia.org/r/380576 [20:26:51] ejegg: this looks good / makes sense https://gerrit.wikimedia.org/r/#/c/381012 - I don't know when I last tried to test something like that tho [20:27:26] ah yeah, that darn test requires a specific db setup locally [20:27:37] db 'test', user 'test' w/ no password [20:28:05] (CR) Eileen: [C: 2] "I think Jenkins is the ultimate arbiter of this one!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380576 (owner: Ejegg) [20:28:17] Thanks! [20:29:40] (Abandoned) Ejegg: Search for invoice ID before inserting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379941 (https://phabricator.wikimedia.org/T171349) (owner: Ejegg) [20:29:41] hmm that test blew up! [20:30:04] yep, looks like your test was specifically for the matching email condition [20:31:54] (Merged) jenkins-bot: CiviFixtures cleans up after itself better [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380576 (owner: Ejegg) [20:31:55] (Merged) jenkins-bot: Duplicate invoice special handling in message requeue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/379945 (https://phabricator.wikimedia.org/T171349) (owner: Ejegg) [20:32:43] I'll try to review ths silverpop first - I know what to do for that email one now. I'll pull these in too https://github.com/civicrm/civicrm-core/pull/11030 [20:34:30] thanks! [21:15:50] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3641117 (Jgreen) We ran package updates and restarts on frdb1001, frdb1002, frdev1001, and frdb2001 yesterday, at the same time as we replaced eqiad network hardware.... [21:29:59] Fundraising-Backlog: adyen cc form disappears after entering information on ipad - https://phabricator.wikimedia.org/T176913#3641192 (DStrine) [21:50:44] (PS1) Eileen: Alter definition of silverpop_countrylangs to match actual [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381135 [21:51:07] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Synchronized Screaming, and 3 others: CentralNotice: JS selection widgets no longer work in interface to add a campaign - https://phabricator.wikimedia.org/T172023#3641260 (Ej... [21:51:46] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Synchronized Screaming, and 3 others: CentralNotice: JS selection widgets no longer work in interface to add a campaign - https://phabricator.wikimedia.org/T172023#3483202 (Ej... [21:52:35] (CR) Eileen: "ejegg I have more or less got this running locally - I had to do this" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) (owner: Ejegg) [21:56:50] (CR) Ejegg: "ooh, good catch! I'll get it into the view" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) (owner: Ejegg) [22:03:07] (PS2) Ejegg: Add 'first_donation_date' column to Silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) [22:08:00] ejegg: thx for the synchronized task re-columnizing! [22:08:24] heh, fer sure [22:09:23] Fundraising-Backlog: adyen cc form disappears after entering information on ipad - https://phabricator.wikimedia.org/T176913#3641335 (DStrine) update I didn't realize I was also getting this error: "Unfortunately we were unable to process this request. Perhaps your browser does not accept cookies or the p... [22:25:51] (PS1) XenoRyet: Handle additional paypal refund reason codes. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/381141 (https://phabricator.wikimedia.org/T176225) [22:27:01] (CR) jerkins-bot: [V: -1] Handle additional paypal refund reason codes. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/381141 (https://phabricator.wikimedia.org/T176225) (owner: XenoRyet) [22:32:05] (PS2) XenoRyet: Handle additional paypal refund reason codes. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/381141 (https://phabricator.wikimedia.org/T176225) [22:40:37] Fundraising Sprint Autotune Earphones, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Civi: make selecting the Deceased checkbox also unsubscribe donor's email address - https://phabricator.wikimedia.org/T153110#3641412 (DStrine) [22:47:00] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, and 3 others: Investigate Redis connection issues in GC audit parser - https://phabricator.wikimedia.org/T155150#3641424 (DStrine) [22:58:52] Fundraising Sprint Autotune Earphones, Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising Sprint Waiting for Godot, and 2 others: Spike: investigate the ingenico reintegration - https://phabricator.wikimedia.org/T149238#3641429 (DStrine) [22:59:35] Fundraising Sprint Costlier Alternative, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Engage import error when comma present in amount - https://phabricator.wikimedia.org/T158005#3641432 (DStrine) [22:59:53] oops, forgot to change that back. [23:01:49] Fundraising Sprint Baudelaire Bowdlerizer, Fundraising Sprint Costlier Alternative, Fundraising-Backlog, FR-Ingenico, and 2 others: Spike: determine whether to use SDK for Ingenico Connect - https://phabricator.wikimedia.org/T152649#3641435 (DStrine) [23:03:16] Fundraising Sprint Costlier Alternative, Fundraising Sprint Waiting for Godot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Slow query: core civicrm affecting one of the scheduled jobs - https://phabricator.wikimedia.org/T153128#3641440 (DStrine) [23:11:08] Fundraising-Backlog: Start regularly tracking "lag" time of donations moving through the payments system - https://phabricator.wikimedia.org/T176920#3641457 (K4-713) [23:11:21] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: disable/remove accounts for Brent Cohn from CPS data - https://phabricator.wikimedia.org/T158051#3641469 (DStrine) [23:14:12] Fundraising Sprint Deferential Equations, Fundraising-Backlog, Unplanned-Sprint-Work: Teach CPS to save and aggregate banner history data - https://phabricator.wikimedia.org/T159173#3641483 (DStrine) [23:24:24] (CR) Eileen: "This works in terms of adding it to the exported csv - does anything have to happen at silverpop end to 'expect' the new field?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) (owner: Ejegg) [23:31:13] (CR) Ejegg: "Yep, they'll have to add a mapping. I stuck it in the last column of the CSV so it won't disrupt any existing mappings." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) (owner: Ejegg) [23:32:28] (CR) Eileen: [C: 2] "Well that covers off all the objections I can think of!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) (owner: Ejegg) [23:33:33] (Merged) jenkins-bot: Add 'first_donation_date' column to Silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381012 (https://phabricator.wikimedia.org/T150467) (owner: Ejegg) [23:35:00] ejegg: on the silverpop - I pt this up while looking https://gerrit.wikimedia.org/r/#/c/381135/ [23:35:18] arg - added the yml to it - need to fix [23:36:46] (PS2) Eileen: Alter definition of silverpop_countrylangs to match actual [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381135 [23:38:00] (PS3) Eileen: Alter definition of silverpop_countrylangs to match actual [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381135 [23:38:12] thash better [23:38:31] k, lemme double check prod [23:38:43] doesn't that table live on staging? [23:38:52] oops, right! [23:41:51] ejegg: are there any other things you want to point me to to review? [23:42:19] (before I re-immerse in dedupe) [23:42:47] eileen: there's this transaction one: https://gerrit.wikimedia.org/r/381004 [23:42:51] thanks! [23:45:26] ejegg: sure thing - looks good at first glance [23:54:24] (CR) Ejegg: [C: 2] "Wow, that is a weird definition! But it matches what we're using in production / staging, so..." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381135 (owner: Eileen) [23:55:16] (Merged) jenkins-bot: Alter definition of silverpop_countrylangs to match actual [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381135 (owner: Eileen)