[00:29:51] (PS1) Eileen: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) [01:56:00] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3663230 (Ejegg) @Pcoombe yes, the impression numbers are affected. Here's how I understand the pipeline works: The main wiki clust... [01:57:03] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3663235 (Ejegg) Hmm, actually, I'm not sure what does the banner impressions sampling, now that I think about it. @Jgreen is that a... [03:48:40] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3663336 (Jgreen) >>! In T177331#3662878, @Nuria wrote: > @Ottomata can you confirm that last statement, I thought we looked at this... [03:50:26] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3663337 (Jgreen) >>! In T177331#3663235, @Ejegg wrote: > Hmm, actually, I'm not sure what does the banner impressions sampling, now... [07:13:43] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Patch-For-Review: Update postal address in Thank You email - https://phabricator.wikimedia.org/T177230#3663513 (jrobell) Thank you @Ejegg ! I realized I totally missed to list English in the list of languages..! Terribly sorry. Could you... [16:02:14] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Patch-For-Review: Update postal address in Thank You email - https://phabricator.wikimedia.org/T177230#3664849 (Pcoombe) @jrobell The English one was fixed in the above change too (confirmed in Civi) [16:07:45] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Patch-For-Review: Update postal address in Thank You email - https://phabricator.wikimedia.org/T177230#3664885 (jrobell) Thanks @Pcoombe I checked it this morning and it wasn't the case. Looks like it's been updated now though. [16:17:49] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Validation not clearing error on blur - https://phabricator.wikimedia.org/T176501#3627759 (XenoRyet) a:XenoRyet [16:33:17] (CR) XenoRyet: [C: 2] Resolve conflicts on asymetrical whitespace when merging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382108 (https://phabricator.wikimedia.org/T175746) (owner: Eileen) [16:34:15] (CR) XenoRyet: [C: 2] Resolve conflicts on asymetrical punctuation when merging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382109 (https://phabricator.wikimedia.org/T175748) (owner: Eileen) [16:35:39] (CR) XenoRyet: [C: 2] Numbers are not people [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382112 (https://phabricator.wikimedia.org/T175747) (owner: Eileen) [16:36:58] (Merged) jenkins-bot: Resolve conflicts on asymetrical whitespace when merging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382108 (https://phabricator.wikimedia.org/T175746) (owner: Eileen) [16:40:11] (Merged) jenkins-bot: Resolve conflicts on asymetrical punctuation when merging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382109 (https://phabricator.wikimedia.org/T175748) (owner: Eileen) [16:54:32] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3665065 (Pcoombe) @Ejegg Where can I find the current minimum amounts so that I can update the checks on banners and donatewiki? I think they used to be in a file currencyMinimums.js in Do... [17:06:06] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3665164 (Ejegg) Ooh, right, that's now generated with a server-side module so we don't have to update twice every time. Can you try this? mw.loader.using("ext.donationInterface.currenc... [17:09:57] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3665199 (Ejegg) Darn, that's not going to work unless they install the extension with all of the composer dependencies, and I don't think they've done that on donatewiki. The stuff is all... [17:23:57] aargh, strtotime is giving non-utc timestamps in civi [17:24:42] in fact, those are assuming the input is in pacific time [17:24:51] but the server time is UTC? [17:25:04] and php's TZ is UTC.... [17:25:08] Civi-specific? [17:33:37] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382746 [17:36:26] (CR) Ejegg: [C: 2] "Oops... had only merged this to deployment before!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382746 (owner: Ejegg) [17:39:47] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382746 (owner: Ejegg) [17:42:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate use of strtotime() in Civi - https://phabricator.wikimedia.org/T177640#3665336 (Ejegg) [17:49:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate use of strtotime() in Civi - https://phabricator.wikimedia.org/T177640#3665371 (Ejegg) strtotime( "now" ) gives the right UTC timestamp as well... it's only when parsing the date/time strings that it adds 7 hours [18:07:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate use of strtotime() in Civi - https://phabricator.wikimedia.org/T177640#3665432 (Ejegg) Well shoot, in the drupal settings UI at /admin/config/regional/settings, the default timezone is America/Los Angeles. How parochial! [18:14:12] (PS1) Ejegg: Fix message ages reported to prometheus [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/382754 (https://phabricator.wikimedia.org/T177640) [18:14:32] XenoRyet: looks like we're doing silly things with dates in a few places on Civi ^^^ [18:14:53] Looking [18:14:59] that patch will get the stats for message age right, but there's more to do [18:15:12] thanks! Going to eat something... [18:16:46] (CR) XenoRyet: [C: 2] Fix message ages reported to prometheus [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/382754 (https://phabricator.wikimedia.org/T177640) (owner: Ejegg) [18:17:48] (Merged) jenkins-bot: Fix message ages reported to prometheus [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/382754 (https://phabricator.wikimedia.org/T177640) (owner: Ejegg) [18:51:00] (PS5) Ejegg: Function extraction [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382110 (https://phabricator.wikimedia.org/T175748) (owner: Eileen) [18:51:14] (PS4) Ejegg: Numbers are not people [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382112 (https://phabricator.wikimedia.org/T175747) (owner: Eileen) [18:51:46] (CR) Ejegg: [C: 2] "Functionally equivalent, less indentation, slightly less repetitive" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382110 (https://phabricator.wikimedia.org/T175748) (owner: Eileen) [18:54:59] (PS1) Ejegg: Fix message ages reported to prometheus [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382762 (https://phabricator.wikimedia.org/T177640) [18:55:25] (Merged) jenkins-bot: Function extraction [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382110 (https://phabricator.wikimedia.org/T175748) (owner: Eileen) [18:55:35] (CR) Ejegg: [C: 2] "Oh man, another patch reviewed against deployment..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382762 (https://phabricator.wikimedia.org/T177640) (owner: Ejegg) [18:55:55] (Merged) jenkins-bot: Numbers are not people [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382112 (https://phabricator.wikimedia.org/T175747) (owner: Eileen) [18:58:05] !log updated CiviCRM from 197b22dce5a6c60a6e3697f5b9ba49de536d0bbb to 276cbfd4ebbf4b1630ab9eb87fe5ea365d624767 [18:58:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:59:00] (Merged) jenkins-bot: Fix message ages reported to prometheus [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382762 (https://phabricator.wikimedia.org/T177640) (owner: Ejegg) [19:54:54] Fundraising-Backlog, Patch-For-Review: Start regularly tracking "lag" time of donations moving through the payments system - https://phabricator.wikimedia.org/T176920#3641457 (Ejegg) Not going to add the ducks this sprint, so taking the tag off. [19:56:20] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3665952 (DStrine) p:Triage>High [20:00:27] Fundraising-Backlog: Ask GlobalCollect to let us cancel status 600 transactions - https://phabricator.wikimedia.org/T114205#1687915 (DStrine) p:Triage>High [20:16:13] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3666036 (Ejegg) @Pcoombe OK, this works, if you're willing to wait for the payments-wiki request to come back: $.getScript("https://payments.wikimedia.org/load.php?modules=ext.donation... [20:28:16] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3666075 (Ejegg) @Jgreen Yep, that's the one. Is that created by another kafkatee filter on americium? [20:43:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Email: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3666112 (Ejegg) [20:44:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Email: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3666124 (Ejegg) @CCogdill_WMF what do you think of adding the extra column to the output / extra vari... [20:51:23] (PS1) Umherirrender: Improve some parameter docs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/382813 [21:26:06] (PS1) VolkerE: Remove obsolete mockup-template.txt [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/382840 [21:41:30] (PS1) Ejegg: Pass contact_id and contact_hash when both given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382844 (https://phabricator.wikimedia.org/T177663) [22:20:56] (CR) Krinkle: [C: 2] Improve some parameter docs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/382813 (owner: Umherirrender) [22:25:17] (PS1) Ejegg: Export civicrm_contact.hash to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/382856 (https://phabricator.wikimedia.org/T177663) [22:27:14] (PS1) Ejegg: WIP only report age of messages from payments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382858 (https://phabricator.wikimedia.org/T176920) [22:29:13] (Merged) jenkins-bot: Improve some parameter docs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/382813 (owner: Umherirrender) [23:15:49] (PS1) Umherirrender: Improve some parameter docs [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/382889