[03:58:52] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Chinese-Sites, Patch-For-Review: Update postal address in Thank You email - https://phabricator.wikimedia.org/T177230#3668226 (Shizhao) [13:53:38] (PS4) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [13:55:32] (CR) jerkins-bot: [V: -1] Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [14:20:35] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3669548 (Pcoombe) Thanks @Ejegg. I've just copied the updated amounts into donatewiki and banners, since it seems they don't change very often and feels like overkill to add a request every... [14:27:19] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Chinese-Sites, Patch-For-Review: Update postal address in Thank You email - https://phabricator.wikimedia.org/T177230#3669580 (Pcoombe) Open>Resolved [14:51:51] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3669645 (Ottomata) > We're seeing dropped log message sequence numbers where they should be contiguous for each log producing host... [15:58:36] (PS2) Ejegg: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [16:48:14] hey ejegg! [16:48:19] hi mepps! [16:48:25] how's it going? [16:48:39] I've got another bug with an unwanted limit on a select box [16:49:01] only the first 25 conutries (alphabetically) are available in the contact address form [16:49:07] Do you see the same thing locally? [16:49:20] ...but besides that, it's going great! [16:49:24] how's things with you? [16:50:01] Somewhere, $config->countryLimit is getting set to that 25 value list, and I'm trying to track that down [16:50:45] i'll take a look! [16:51:15] good! got in late last night so a little sleepy today but working on tracking down why these tests are failing [16:51:37] ool, want to walk through that together? [16:51:39] *cool [17:00:06] sure ejgg, maybe in a half an hour? [17:00:20] i assume fr-all standup isn't happening today [17:00:55] yeah, probably not [17:01:10] half hour works for me! [17:05:38] huh, it's stored in the settings table [17:05:45] I sure didn't set that explicitly... [17:08:19] yeah i did a quick search too (it's the same way on my local page)--are we seeing this on prod? [17:08:35] I feel like we would have heard about it [17:08:42] checking [17:13:06] I'm seeing the full list on prod [17:13:40] well, deleting the setting in the db seems to have fixed it locally [17:17:35] weird, seems to be something in the benevity test that sets it to the full list [17:17:47] but I can't find anything that would be setting it to just the first 25 [17:20:19] so weird [17:28:03] (PS5) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [17:29:49] (CR) jerkins-bot: [V: -1] Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [17:33:45] (PS6) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [17:36:56] (CR) jerkins-bot: [V: -1] Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [17:37:40] ejegg okay take a look at most recent failures ^^ these have me stumped [17:41:57] who all is working form fr-tech today? [17:42:18] good question! [17:42:27] maybe eileen? [17:44:42] I just saw AndyRussG respond to an email [17:50:21] (CR) Ejegg: [C: -1] "Minor quibble: this will happily merge someone from Poland, Maine, USA with someone whose address is just the country Poland (or Armenia, " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [17:53:07] ok mepps, taking a look [17:55:28] hmm, looks like some test data changed? [17:55:47] and something's getting exta-escaped [17:55:51] so... [17:56:53] yeah just not seeing where my changes touched that [17:57:17] oh weird, yeah, nothing in there is touching tests [17:57:26] is something throwing an exception somewhere? [17:57:29] (PS7) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [17:59:20] (CR) jerkins-bot: [V: -1] Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [17:59:42] mepps oho! [17:59:47] the old test data was bad [17:59:59] oh? [18:00:08] Take a look at GetExpressCheckoutDetails_OK.testresponse [18:00:21] and GetExpressCheckoutDetails_Recurring-OK.testresponse [18:01:29] for the 'normal' case, we should be using test responses that look like the donor actually clicked through the process on paypal's site [18:01:56] we should add a _NotInitiated response too... [18:02:06] for testing the current patch [18:02:19] yeah ejegg, haha that's where i was heading but wanted to fix these tests first [18:02:28] so i could isolate any issues with that test specifically [18:02:50] OK, so we might need to get some fresh responses, not sure if the CHECKOUTSTATUS is the only bogus thing about them [18:03:05] want me to help with that? [18:04:41] sure ejegg, thanks! [18:05:16] how come my patch caused us to notice this? [18:05:32] Because we were never checking for that status before! [18:06:01] All those tests are now hitting your if clause and breaking before they unstage data from the response [18:06:43] The fact that they have any donor data at all also means the tests aren't set up realistically [18:07:18] since for PayPal, we don't even have an email or name for the donor before they come back to our site and we get it from PayPal [18:08:28] (PS8) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [18:10:15] mepps argh, their sandbox site is still giving 'PaymentActionNotInitiated' even after clicking through [18:10:17] (CR) jerkins-bot: [V: -1] Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [18:10:35] so... do we need to get live data to test with? [18:10:36] ejegg weird! [18:10:49] Yeah, definitely [18:11:00] this might merit an email asking for clarification [18:11:19] well.... I'mma eat a bit of lunch and see what I can come up with after that. [18:11:24] sounds good! [18:13:11] https://stackoverflow.com/questions/23707243/paypal-express-checkout-checkoutstatus-always-be-paymentactionnotinitiated-in-sa [18:13:31] oh, that's unhelpful [18:13:49] but at least we're not the only ones [18:15:00] and onther one: https://stackoverflow.com/questions/21617528/paymentactionnotinitiated-when-do-express-checkout [18:24:57] ahh good catch ejegg [18:33:49] ejegg|food: mepps humm it's a holiday in ths U.S., right? So, no meetings I guess? [18:34:13] AndyRussG ejegg|food i think that's up to us! [18:34:20] mepps: ah K [18:34:45] :) [18:34:56] I'm here, in any case :) [18:49:11] (CR) Mepps: [C: 2] Pass contact_id and contact_hash when both given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382844 (https://phabricator.wikimedia.org/T177663) (owner: Ejegg) [18:51:47] (Merged) jenkins-bot: Pass contact_id and contact_hash when both given [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382844 (https://phabricator.wikimedia.org/T177663) (owner: Ejegg) [18:53:01] mepps ok, so, those responses look good except for that status [18:54:19] So it should be PaymentActionInProgress, right? [18:55:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1271 [18:56:03] do we want to have completed? [18:56:34] mepps I think that would be after we call the doPayment finishing thing [18:56:57] okay [19:00:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1489 [19:05:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1606 [19:05:26] oh boy, replication lag... [19:05:34] Ohnoes [19:07:16] cd [19:07:28] focus, man! [19:07:32] derp... [19:08:02] mepps the really annoying thing is that we'll have to code around the paypal sandbox bug [19:08:17] if we want to be able to try stuff on the sandbox :( [19:09:39] hmm yeah :( [19:09:47] that is a very annoying bug [19:10:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1490 [19:15:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1654 [19:17:21] ejegg AndyRussG, do we want to do a standup? [19:17:31] yeah, let's! [19:18:33] did a campaign just go up? [19:18:39] or a mailing? [19:18:59] not sure, let's see [19:19:51] i guess, as a workaround for replication lag, we should probably plan a regular maintenance window with queue consumers off so we can safely restart mysql on all the slaves [19:20:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1745 [19:20:21] mepps oh right, backlog grooming. let's see what we can get through [19:20:36] Jeff_Green: that sounds reasonable [19:21:51] Jeff_Green: looks like an email just went out [19:21:57] ok [19:22:00] thx [19:23:40] Jeff_Green: also, I think I should be using those 'summary' metrics for things like the queue message stats [19:24:00] they let you group a bunch of related stats under one metric with multiple 'labels' [19:25:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1966 [19:25:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1252 [19:30:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2186 [19:32:02] AndyRussG: want to do some backlog grooming? [19:35:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2398 [19:37:01] ejegg: sure! [19:37:07] Sorry just saw ur ping now [19:39:01] ejegg: i'm not sure what you mean re. stats? [19:40:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2576 [19:41:47] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add editorconfig files to our codebase to deal with whitespace pain? - https://phabricator.wikimedia.org/T177725#3670440 (Ejegg) p:Triage>Normal [19:45:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2820 [19:50:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3035 [19:50:54] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Email, and 2 others: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3670463 (Ejegg) p:Triage>Normal @CCogdill_WMF yes, we would be adding a contact... [19:54:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Email, and 2 others: Epic: Don't duplicate contact for email donations - https://phabricator.wikimedia.org/T177663#3670497 (CCogdill_WMF) Sounds fine to me. Let me know when the new column is being added. [19:55:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3230 [19:55:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Investigate use of strtotime() in Civi - https://phabricator.wikimedia.org/T177640#3665336 (Eileenmcnaughton) https://civicrm.wikimedia.org/admin/config/regional/settings [19:59:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Investigate use of strtotime() in Civi - https://phabricator.wikimedia.org/T177640#3670521 (Ejegg) p:Triage>High [20:00:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3413 [20:00:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1336 [20:00:36] do we have a plan to knock the lag down? [20:01:08] cwd Jeff_Green had something ^^^ [20:01:40] restart all the slaves? [20:01:58] * cwd tries to remember the last time he had an actual day off [20:04:20] all 4 slaves are just at wildly different places in the exec log [20:05:10] and have ever increasing open temp table counts https://grafana.wikimedia.org/dashboard/db/fundraising-database?refresh=1m&panelId=28&fullscreen&orgId=1 [20:05:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1454 [20:05:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3479 [20:05:59] cwd Jeff_Green there are 4 of fr-tech in the chat if you guys want to talk it out live [20:10:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3523 [20:10:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1349 [20:13:50] sorry not convenient atm [20:14:16] sure, no worries, just wanted to let you know we're available [20:15:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1356 [20:15:11] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3463 [20:18:18] ty, just several irons in the fire [20:18:53] we could try rolling restarts of the slaves, not sure if it woulc cause chaos with jobs [20:20:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1504 [20:20:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3406 [20:25:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3525 [20:25:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1572 [20:30:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3741 [20:30:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1678 [20:35:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1651 [20:35:11] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 3911 [20:40:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4098 [20:41:12] ejegg: i don't think it has anything to do with the replag but i see 30+ sleeping connections for user 'dash' on the read server [20:41:38] oh, we were all looking at dash in the standup [20:42:00] oh heh, that explains it then, thanks [20:42:21] but... maybe we should be closing them better? [20:43:17] yeah since it's a nodejs daemon (right?) i could see how it might leave them dangling if not explicitly closed [20:45:02] yeah, nodejs [20:45:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4299 [20:46:03] ejegg: would you be interested in a coordinated effort to restart the slaves? specifically if i could get you to shut off all the jobs while i do it :) [20:46:32] or any jobs that might be affected anyway, if we can determine that [20:46:58] sure, give me 5 minutes? [20:47:11] cwd we schemed about that a little earlier, the idea of a declared maintenance window where with a gap in queue consumption, so we can restart slaves [20:47:11] np! just ping me when you are ready [20:47:40] cwd: can you leave frdb1003 lagging? it won't page us and I'd like to be able to see its long term behaviro [20:47:40] i do not have a better idea at this point [20:47:42] or [20:47:47] ah yeah definitely [20:48:38] i think the dangling open temp tables is a good lead, as i have never found anything to support that that value should get bigger than like 10 during normal operation [20:48:47] and it should go down, not just up [20:49:16] i think so too [20:49:20] but there is perilously little information available on the topic [20:49:40] i wonder if there are trigger queries spawning them [20:49:59] yeah [20:50:03] a good line of inquiry [20:50:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4498 [20:51:49] cwd ok, I can turn those jobs off [20:51:59] great [20:52:37] i'm going to do 2001 right now cause i'm pretty positive nothing looks at it [20:54:44] OK, that's the crontab regenerated, let's see what's still running [20:55:10] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4678 [20:55:37] cwd OK, they're quiescent [20:57:19] (PS3) Eileen: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) [20:58:05] oh look, an .editorconfig file appeared! [20:58:19] ejegg: ty! i will let you know when they are all done [20:58:24] couple minutes [20:58:26] cwd cool [21:00:10] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 365517 Threads: 1 Questions: 35138444 Slow queries: 24725 Opens: 12364 Flush tables: 1 Open tables: 540 Queries per second avg: 96.133 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 522 [21:00:11] PROBLEM - check_mysql on frdb1002 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) [21:00:12] RECOVERY - check_swap on frdb1002 is OK: SWAP OK - 97% free (7324 MB out of 7629 MB) [21:01:10] what the heck [21:01:14] i didn't restart frdev1001 [21:01:16] was that frdev recovering on its own? [21:01:48] apparently? [21:02:04] well i guess it hasn't actually recovered but did drop below the alert threshold [21:02:09] i'm still going to restart it [21:02:28] cool, have it fresh for wednesday's test [21:02:37] ya [21:05:07] (PS1) Ejegg: WIP Check contact_hash if contact_id exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383260 (https://phabricator.wikimedia.org/T177663) [21:05:10] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 279 Threads: 4 Questions: 892682 Slow queries: 165 Opens: 665 Flush tables: 1 Open tables: 599 Queries per second avg: 3199.577 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [21:06:02] ejegg: ok i'd say go ahead and re-enable the jobs [21:06:32] OK, re-enabled! (had done all but the rsync) [21:07:10] thanks! [21:07:35] https://grafana-admin.wikimedia.org/dashboard/db/fundraising-mariadb?orgId=1 [21:07:40] they are all synced up again [21:10:01] (PS1) Ejegg: Add config for Big English 2017 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383272 [21:10:23] ^^^ and its parent patch are pretty trivial, just to bring the dash up to date [21:10:30] in case anyone wants to review [21:14:48] thanks for fixing the lag guys! [21:15:02] i'm going to head over to my folks. have a good night [21:16:47] (PS1) Ejegg: WIP add contact_id and _hash to the rest of the places [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383283 (https://phabricator.wikimedia.org/T177663) [21:20:41] (CR) Ejegg: "Thanks for looking at that edge case! Neither of the new test cases quite cover this one, though: contact 1 is Poland, ME, USA, and conta" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [21:24:48] (CR) jerkins-bot: [V: -1] WIP add contact_id and _hash to the rest of the places [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383283 (https://phabricator.wikimedia.org/T177663) (owner: Ejegg) [21:34:09] (CR) Ejegg: [C: -1] "Good catch! I think the import change needs to be a bit more accepting of bool-ish values though (and the offline imports need to test tho" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [21:40:21] (CR) Ejegg: [C: 2] "This one looks good!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382062 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [21:40:54] (CR) Ejegg: [C: 2] Remove attempt to set sort_name & display_name. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382106 (owner: Eileen) [21:41:23] (PS2) Ejegg: Remove attempt to set sort_name & display_name. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382106 (owner: Eileen) [21:43:43] (CR) Eileen: Manage merge on Country vs full address (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [21:47:03] (PS6) Eileen: Fix ImportMessageTest to actually test contact. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) [21:47:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation queue consumer crash on unknown country - https://phabricator.wikimedia.org/T177803#3670769 (Ejegg) [21:48:51] (CR) Eileen: Fix ImportMessageTest to actually test contact. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [21:49:38] ejegg: did you replicate that country-poland thing? I tried in a unit test but couldn't [21:50:33] eileen1: yep, I set one contact to just have country 'Poland' [21:50:49] in your tests, the ones with a country set both also have a street_address [21:52:33] ejegg: if you look at line 719 [21:52:40] (CR) jerkins-bot: [V: -1] Fix ImportMessageTest to actually test contact. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [21:52:44] you mean the second example should have no street address? [21:53:27] right, there should be one contact with a country and nothing else [21:53:52] the other contact can have a full address that just has the country name as a substring someplace [21:54:07] I don't think we get contacts with city & no country from anyplace [22:01:12] (PS7) Eileen: Fix ImportMessageTest to actually test contact. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) [22:18:53] (PS1) Ejegg: Fix failmail suppression [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/383284 (https://phabricator.wikimedia.org/T172303) [22:19:05] d'oh, python fail ^^^ [22:20:16] but, that should actually get the 'alresdy running' failmail under control [22:20:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Search for email only works if primary email address - https://phabricator.wikimedia.org/T152048#3670803 (LeanneS) @Eileenmcnaughton and @mepps thanks for following up on this. It would be great if we could test this before Big English to help with merg... [22:31:17] (PS8) Ejegg: Fix ImportMessageTest to actually test contact. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [22:31:35] (CR) Ejegg: [C: 2] "Thanks for finding this!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [22:37:10] (Merged) jenkins-bot: Fix ImportMessageTest to actually test contact. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381923 (https://phabricator.wikimedia.org/T175744) (owner: Eileen) [22:49:26] (PS8) Eileen: Remove duplicate spaces, html & and odd whitespace in name fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382062 (https://phabricator.wikimedia.org/T175744) [22:55:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import error - https://phabricator.wikimedia.org/T177806#3670849 (LeanneS) [22:57:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import error - https://phabricator.wikimedia.org/T177806#3670861 (Eileenmcnaughton) Leanne - can you put a copy of the file you are trying to import on the drive & also indicate the impact this has on you so we can prioritise [22:58:38] (PS4) Eileen: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) [23:09:45] (CR) Eileen: [C: -1] "This looks like a straight forward change & syntax makes sense." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383272 (owner: Ejegg) [23:11:36] (CR) Eileen: [C: 2] Update links in donation age widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/382362 (owner: Ejegg) [23:21:46] (PS5) Eileen: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) [23:24:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import error - https://phabricator.wikimedia.org/T177806#3670849 (LeanneS) Yes, of course! I've added the file here: Fundraising/Tech/Major Gifts/Coinbase. Looping in @Ppena for her insight on how this might impact her reconciliation. [23:30:11] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18: Improve conflict handling by doing postal-suffix only address conflicts - https://phabricator.wikimedia.org/T177807#3670877 (Eileenmcnaughton) [23:52:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation queue consumer crash on unknown country - https://phabricator.wikimedia.org/T177803#3670916 (Ejegg) This is a DB Error: constraint violation