[00:02:10] (CR) Ejegg: [C: -1] "Looks good, except for one glitch with parentheses" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [00:05:59] (PS6) Eileen: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) [00:06:26] (PS1) Eileen: Manage merge on has-postal-suffix vs no-has-postal-suffix. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383290 (https://phabricator.wikimedia.org/T177807) [00:07:53] ejegg: what would you like me to review? [00:16:37] eileen2: There are some trivial bits floating around that would be nice to get out [00:17:08] I think this will fix the failmail fix: https://gerrit.wikimedia.org/r/383284 [00:17:31] and there's this other dash patch to add the 2017 campaign: https://gerrit.wikimedia.org/r/383272 [00:19:14] and I'd welcome any preliminary feedback on the contact ID / hash patches: https://gerrit.wikimedia.org/r/383260 , https://gerrit.wikimedia.org/r/382856 [00:19:30] ejegg: did you see my query on the second dash patch? [00:19:40] oh, oops! [00:20:19] eileen2: the patch is actually October 2... Javascript months go 0..11 :( [00:20:41] though the days are still 1-based [00:21:12] ejegg: ah ok - will merge then [00:21:44] (CR) Eileen: [C: 2] "ejegg told me the date is correct but it's an array (0 based) not a month (1 based)" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383272 (owner: Ejegg) [00:22:04] ejegg: so this one https://gerrit.wikimedia.org/r/#/c/383284/1/processcontrol/runner.py [00:22:35] the changed version makes sense to me - I don't know that much about python so the thing you are changing if from looks like an equivalent of php is_a ? [00:22:49] (Merged) jenkins-bot: Add config for Big English 2017 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383272 (owner: Ejegg) [00:25:39] eileen2: right, 'is' in python means is it the exact same object as the other thing [00:25:50] I was mistaken in thinking that it mean instanceof [00:29:13] (CR) Ejegg: [C: 2] "Nice to be tidy, can't hurt to try this!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/382533 (owner: Eileen) [00:29:31] (CR) Eileen: [C: 2] "I wish I was a bit more knowledgeable about some of these other areas of code. However I'm ok to merge this as the change is only a slight" [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/383284 (https://phabricator.wikimedia.org/T172303) (owner: Ejegg) [00:29:57] (Merged) jenkins-bot: Fix failmail suppression [wikimedia/fundraising/process-control] - https://gerrit.wikimedia.org/r/383284 (https://phabricator.wikimedia.org/T172303) (owner: Ejegg) [00:30:55] thanks eileen2! [00:31:47] (PS7) Ejegg: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [00:31:58] (CR) Ejegg: [C: 2] Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [00:32:03] ejegg: re the hash one - it looks like if contact_id IS set then it will currently be passed through into wmf_civicrm_message_contact_insert [00:32:03] & then the api? [00:32:14] (which would mean it works as an update) [00:32:46] (Merged) jenkins-bot: Remove temp tables pro-actively. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/382533 (owner: Eileen) [00:33:20] ah no - it's currently skipping create on them [00:33:21] if (!empty($msg['contact_id'])) { [00:34:01] hmm, maybe I shouldn't touch the existing stuff, just add a block before that line which checks for hash and unsets [00:34:11] yeah, seems clearer than adding a new variable [00:35:33] (Merged) jenkins-bot: Manage merge on Country vs full address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382634 (https://phabricator.wikimedia.org/T176699) (owner: Eileen) [00:35:46] I don't like the new var - when I see that it says to me 'extract to a function' - but I also hate how jumbled that file is [00:36:01] I have aspirations to move all the merge stuff out to it's own place... [00:36:31] so what bothers me is that if contact_id is set we are currently ignoring updates to prefix, language & a few other things [00:36:53] right, we're doing that for things like benevity imports too [00:36:56] does seem wrong [00:36:57] but that kind of reflects the fact that perhaps we don't gather much data about that stuff from from end form [00:37:30] I guess for Benevity etc we already decided which fields we have & so it's perhaps a little over-tailored [00:38:04] If I look in wmf_civicrm_message_contact_insert [00:38:09] the front end form always gets language [00:38:18] I see some default-setting - e.g contact_source & a few more [00:38:38] perhaps we could always call that but be clearer about what parts are just default setting & skip those [00:38:48] if is is set [00:39:18] ok, I like that thought [00:39:19] although for speed - we are kinda-hoping to save a whole write... [00:39:36] so we might want to do some sort of diff at the end before we commit to writing? [00:39:37] lemme put up a minimalist version of the hash check, without the new var [00:41:34] (PS2) Ejegg: WIP Check contact_hash if contact_id exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383260 (https://phabricator.wikimedia.org/T177663) [00:43:21] ejegg: yeah I like that [00:43:37] it feels very clean & readable - [00:44:07] 2 thoughts [00:44:38] no only 1 [00:45:00] we should probably add a comment saying that if the contact is deleted it won't be found [00:45:10] just to save confusion later [00:45:29] OK, cool [00:45:33] and of course it needs tests [00:46:16] :-) [00:46:58] (PS4) Ejegg: The big group clean up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380667 (https://phabricator.wikimedia.org/T174407) (owner: Eileen) [00:47:11] So, to security - if someone wanted to hack it… [00:47:53] they would need to know John Olivers contact id & his hash if they wanted to reroute all his emails to them & change his name to Donald Duck? [00:48:07] hah, right [00:48:18] & we really can't see how they would get those 2 pieces of info…. [00:48:33] unless they'd already hacked his email [00:49:07] right … do we permit changing of email or only name in that case [00:49:24] we'd actually change the email but not the name [00:49:32] I think email and mailing address [00:49:46] & then our security would be breached by sending out donation solicitations to a hacker :-) [00:49:50] with the ..._location_update [00:50:00] heh, right [00:50:24] I guess the PI we possibly include is last donation info - but if someone has already hacked his email.... [00:50:56] I feel reasonably secure about that version [00:51:03] Perhaps we should just make sure Katie & Jeff are aware of the change in case they have any concerns [00:51:07] but it's worth mulling over for a few days [00:51:31] yeah, makes sense to get wider feedback. I'll email some folks [00:51:36] cool [00:55:02] (PS5) Eileen: The big group clean up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380667 (https://phabricator.wikimedia.org/T174407) [00:55:04] (PS2) Eileen: Manage merge on has-postal-suffix vs no-has-postal-suffix. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383290 (https://phabricator.wikimedia.org/T177807) [00:55:57] I'm going to do a deploy shortly - if you feel up to checking this first I'll include it [00:55:57] https://gerrit.wikimedia.org/r/#/c/383290/ [01:09:05] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/383294 [01:10:25] ejegg: only thing in the above that is not mine is the prometheus one [01:12:06] eileen2: oh, that's actually already cherry-picked to deployment [01:12:16] just looking at the group cleanup now [01:13:12] seems kosher, don't know how far I want to go proofreading group IDs :P [01:13:42] :-) [01:13:48] Well, there's always log tables if we need to restore! [01:13:54] Yeah I think so! [01:14:26] it feels scary but it was hard to get anyone to demonstrate that they cared much about them…. [01:14:44] looks like it oughtta pep things up a bunch! [01:15:12] possibly only from very specific screens - but still I think it will make them more usable too [01:15:54] (CR) Ejegg: [C: 2] "Ooh, some of these refer to 2008. A much overdue cleaning!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380667 (https://phabricator.wikimedia.org/T174407) (owner: Eileen) [01:16:14] what I like is that from now on there is a contact_id assigned [01:16:27] as the caretaker? [01:16:47] yep [01:17:03] since about 4.6 all new groups have had created_id [01:17:15] so for the last 2 years or so for us [01:17:35] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/383294 (owner: Eileen) [01:17:48] I'm gonna deploy in 2 steps since there seem to be a few [01:17:55] so just merged the one already open [01:19:10] k, sounds good [01:19:28] (Merged) jenkins-bot: The big group clean up. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/380667 (https://phabricator.wikimedia.org/T174407) (owner: Eileen) [01:19:30] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/383294 (owner: Eileen) [01:21:25] !log update civicrm from 276cbfd4ebbf4b1630ab9eb87fe5ea365d624767 to 00da4b0e7c03e8ffebbf0de580203d50b67b998e [01:21:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:23:07] looks like a few things might have already been cherry-picked - less change than I expected [01:37:38] so this is odd - civicrm/contact/view?reset=1&cid=266376 - but I think it's just a display issue with it mishandling the slash [01:39:59] oh weird [01:40:19] ahh, a backslash [01:40:46] might be a candidate for escaping before feeding to the template? [01:43:06] ejegg: you mean when civi renders? I think it's not being fully substituted in - it's weird [01:43:18] I guess I should add a phab to investigate [01:43:31] I feel like there are all these niggly things building up [01:44:07] I just ran the major gifts dedupe after that country deploy & got a tonne - but it errored our - I can't quite see why [01:44:15] the ones I spot checked were good [01:45:52] sure, worth a phab task. Doesn't seem like an actual data issue, if you click edit [01:46:17] well, I'm going to call it a night! [01:46:42] night! [01:46:47] good luck with the group cleanup, ping me if it goes boom [01:46:49] thanks! [02:02:40] (CR) VolkerE: "@AndyRussG I see your point, but it would be good to have at least one example of such a banner being designed around the rounded cross." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/376851 (https://phabricator.wikimedia.org/T50067) (owner: VolkerE) [02:23:45] (PS1) Eileen: Last change introduced an error when no address conflict exits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383295 [02:24:27] ejegg|away: if you see this - that last fix introduced an error https://gerrit.wikimedia.org/r/#/c/383295/ (impact is that it causes the job to crash so not too scary) [02:25:54] ahh, oops! [02:26:02] looks like a pretty simple fix [02:26:05] yep [02:26:11] it was just trying a bit too hard [02:26:55] passing first_name into 'Address' 'create' ? [02:28:11] nah - the first name is probably a red herring [02:28:22] it just reflects the contact I found the bug on [02:28:27] any reason to have them in the tests? [02:28:37] probably not - but it's good variety [02:28:46] I mean, to pass them in on the 'Address' 'create' call? [02:28:51] oh - no [02:28:52] they're just ignored, right? [02:29:01] or does that get applied to the associated contact? [02:29:20] (PS2) Eileen: Last change introduced an error when no address conflict exits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383295 [02:29:27] ignored - I just fixed them [02:29:35] removed [02:29:41] k, sorry to pester over a no-op [02:29:49] nah - better to get it right [02:29:58] I read it as a contact create but of course it wasn't [02:30:33] (CR) Ejegg: [C: 2] Last change introduced an error when no address conflict exits [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383295 (owner: Eileen) [02:31:45] thanks! [02:34:08] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/383296 [02:34:21] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/383296 (owner: Eileen) [02:35:31] !log update civicrm from 00da4b0e7c03e8ffebbf0de580203d50b67b998e to 47de9768872243cbe763acd4184d767ddf69daba [02:35:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:36:10] Red is the tastiest herring. [02:38:40] wat [03:39:48] (PS3) Eileen: Manage merge on has-postal-suffix vs no-has-postal-suffix. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383290 (https://phabricator.wikimedia.org/T177807) [03:39:50] (PS1) Eileen: Add editorconfig to various drupal dirs with drupal whitespace standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383300 (https://phabricator.wikimedia.org/T177725) [03:58:23] (PS1) Eileen: Add .editorconfig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383301 (https://phabricator.wikimedia.org/T177725) [04:03:36] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add editorconfig files to our codebase to deal with whitespace pain? - https://phabricator.wikimedia.org/T177725#3671074 (Eileenmcnaughton) I added a bunch of these. They turn out to b... [08:09:18] Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, Fundraising-Backlog, FR-Smashpig, Patch-For-Review: Handle iDEAL push notifications - https://phabricator.wikimedia.org/T161153#3123126 (TheDJ) > This is actually unhelpful 'cause we're contractually not allowe... [09:50:11] PROBLEM - check_swap on frdb1002 is CRITICAL: SWAP CRITICAL - 89% free (6762 MB out of 7629 MB) [09:55:11] PROBLEM - check_swap on frdb1002 is CRITICAL: SWAP CRITICAL - 89% free (6763 MB out of 7629 MB) [10:00:11] PROBLEM - check_swap on frdb1002 is CRITICAL: SWAP CRITICAL - 89% free (6714 MB out of 7629 MB) [10:05:11] PROBLEM - check_swap on frdb1002 is CRITICAL: SWAP CRITICAL - 89% free (6718 MB out of 7629 MB) [10:07:16] ACKNOWLEDGEMENT - check_swap on frdb1002 is CRITICAL: SWAP CRITICAL - 89% free (6718 MB out of 7629 MB) Jeff_Green yep, swapping. [13:49:35] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3672022 (jrobell) Thank you all for your work on this. @Ejegg and @Jgreen Given that this issue was resolved on 10/4 (?) , are w... [14:56:46] fundraising-tech-ops, Operations, ops-eqiad: frpm1001 is dead, looks like hardware failure - https://phabricator.wikimedia.org/T177710#3672233 (Cmjohnson) Ticket submitted with Dell You have successfully submitted request SR955002039. [15:17:30] (PS9) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [15:17:55] ejegg|away i'm having a really annoying issue with the patch above ^^ [15:18:12] the filename the test is looking for isn't consistent with how the other tests are named [15:18:16] and i can't figure out why [15:20:18] (CR) jerkins-bot: [V: -1] Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [15:24:24] or AndyRussG if you know much of donationinterface [15:32:45] (CR) Mepps: [C: 2] "I feel comfortable approving this after more review." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259795 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [15:34:06] (CR) Mepps: "I'm not totally sure if this is doing what the commit message says. Maybe XenoRyet wants to take a look?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/381292 (owner: Ejegg) [15:36:19] (Merged) jenkins-bot: Log client-side errors on payments forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259795 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [15:38:18] (CR) Mepps: [C: -1] "Looks good and I like the test but fix whitespace!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381237 (https://phabricator.wikimedia.org/T176923) (owner: Ejegg) [15:42:12] (PS2) Mepps: Add .editorconfig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383301 (https://phabricator.wikimedia.org/T177725) (owner: Eileen) [15:42:20] (CR) Mepps: [C: 2] "Awesome!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383301 (https://phabricator.wikimedia.org/T177725) (owner: Eileen) [15:43:13] (CR) jerkins-bot: [V: -1] Add .editorconfig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383301 (https://phabricator.wikimedia.org/T177725) (owner: Eileen) [15:44:51] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: PayPal EC cURL timeouts - https://phabricator.wikimedia.org/T177438#3658664 (mepps) @ejegg is this pretty much resolved? [16:14:58] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Operations: mintaka disk space warning - https://phabricator.wikimedia.org/T177852#3672488 (herron) [16:17:58] Wikimedia-Fundraising-Banners, fundraising-tech-ops, Operations: alnitak disk space warning - https://phabricator.wikimedia.org/T177854#3672524 (herron) [16:34:52] Wikimedia-Fundraising-Banners, fundraising-tech-ops, Operations: alnitak disk space warning - https://phabricator.wikimedia.org/T177854#3672524 (cwdent) @herron Thanks for the heads up! Just curious, how did you notice that? Thought Jeff and I were the only ones to get alerted about frack stuff any... [16:40:52] Wikimedia-Fundraising-Banners, fundraising-tech-ops, Operations: alnitak disk space warning - https://phabricator.wikimedia.org/T177854#3672670 (herron) Hey @cwdent, I just noticed the disk alert listed in the icinga "unhandled services" board and created this to acknowledge it. So the icinga number... [16:42:05] hmm, looks like the new php7/docker test env lacks sqlite? [16:43:51] asking how to fix in -releng [16:46:33] (PS2) Ejegg: Allow importing gateway and Contribution Tracking ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381237 (https://phabricator.wikimedia.org/T176923) [16:47:18] (CR) Ejegg: "ok mepps, got that WS fixed. thanks for catching that!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381237 (https://phabricator.wikimedia.org/T176923) (owner: Ejegg) [16:49:25] Wikimedia-Fundraising-Banners, fundraising-tech-ops, Operations: alnitak disk space warning - https://phabricator.wikimedia.org/T177854#3672706 (cwdent) @herron ah yes of course, pardon my brain fart :P We are aggregating kafka data on that disk right now so it is extra full, but will be freeing it... [16:53:24] mepps: taking a look at that PS9 [16:53:25] Wikimedia-Fundraising-Banners, fundraising-tech-ops, Operations: alnitak disk space warning - https://phabricator.wikimedia.org/T177854#3672714 (herron) Sounds good! [16:55:04] fundraising-tech-ops, Operations, netops, Patch-For-Review: move frav1001's to the frack-fundraising VLAN so we can use it for database testing - https://phabricator.wikimedia.org/T176492#3672724 (Cmjohnson) [16:58:03] (CR) Ejegg: "Ah, it's this line messing up, interpreting the '0' as false: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/mas" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [16:58:59] cwd: ah right, Kafka data! [16:59:15] So, I can try importing one of those files [16:59:30] ok awesome [16:59:37] want to overwrite one of the ones in the archive dir? [16:59:44] i have a couple chores i have to take care of (hard frost last night) [16:59:55] but i will get my head back into that game [17:00:08] do you have any other way to run a single one? [17:00:42] we can shuffle the files on disk around if necessary [17:01:42] cwd the other way would be to put one in its own dir [17:02:02] and update the django settings file in /etc/fundraising to point to that dir [17:02:19] we'd have to switch it back quick to keep up with the latest files [17:02:24] no way to run a one off? [17:02:29] ....ehh, but they're full of holes [17:02:47] cwd I could probably add an override without much work [17:03:03] ah it's no big deal [17:03:14] cwd oh hey, there is an override! [17:03:14] i think the new data is good right? [17:03:25] the data stopped being bad on the 4th? [17:03:39] ah, that's right, I forgot [17:03:48] as soon as we noticed it, basically [17:03:58] shroedenbug [17:04:39] ok i'll be back shortly and can pull the levers [17:04:46] ok, I'll get stuff ready [17:05:34] oh wow, there's even an arg to stash stuff in an alternate table [17:06:12] phehres thought of everything! [17:06:18] *pgehres [17:14:33] he sure deserved the database then I guess [17:33:05] I'd hate for someone to name a database after me if I didn't deserve it [17:33:11] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, FR-Paypal: PayPal IPN processing jobs: undefined index subscr_id - https://phabricator.wikimedia.org/T176152#3615140 (XenoRyet) Appears to have been a transient bug on PayPal's side. Affected recurring payments appear to be recurring no... [17:33:25] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, FR-Paypal: PayPal IPN processing jobs: undefined index subscr_id - https://phabricator.wikimedia.org/T176152#3672893 (XenoRyet) Open>Resolved [17:53:27] (CR) Mepps: [C: 2] Allow importing gateway and Contribution Tracking ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381237 (https://phabricator.wikimedia.org/T176923) (owner: Ejegg) [17:54:21] ejegg i can't follow the link you sent because it's truncated but i was unsure about using 0 anyways, should i just change the name? [17:55:58] mepps sorry, it's this: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/tests/phpunit/includes/test_gateway/test.adapter.php#L129 [17:56:24] but yeah, it might make sense to use something more descriptive [17:56:28] ahh [17:57:01] dang, more donation queue failure [17:57:22] (Merged) jenkins-bot: Allow importing gateway and Contribution Tracking ID [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381237 (https://phabricator.wikimedia.org/T176923) (owner: Ejegg) [17:58:57] (PS1) Ejegg: Add sqlite3 to requre-dev [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383388 [17:59:12] (CR) jerkins-bot: [V: -1] Add sqlite3 to requre-dev [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383388 (owner: Ejegg) [18:06:27] (PS10) Mepps: Handle payment not initiated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 [18:07:08] ejegg: were you gonna try and import one of those manually or you want me to replace the file? [18:34:53] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, FR-PayPal-ExpressCheckout, Patch-For-Review: Handle additional reason codes for Paypay-EC refunds - https://phabricator.wikimedia.org/T176225#3673074 (XenoRyet) Open>Resolved [18:35:42] eileen1 ejegg it looks like we were getting some failmail related to country code AN [18:36:31] mepps yep, there's a bug for that... [18:37:24] https://phabricator.wikimedia.org/T177803 [18:38:21] okay cool [19:12:55] (CR) Ejegg: "recheck" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383301 (https://phabricator.wikimedia.org/T177725) (owner: Eileen) [19:29:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#3673380 (Eileenmcnaughton) [19:29:46] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Implement merge rule to allow resolution on conflicts on punctuation to prefer more punctuation - https://phabricator.wikimedia.org/T175748#3673379 (Eil... [19:40:59] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, and 3 others: Find source of unlimited dedupe queries, prevent them - https://phabricator.wikimedia.org/T175382#3673443 (Eileenmcnaughton) Open>Resolved i t... [19:42:04] Fundraising-Backlog: Still an issue in merge screen display -not showing all contacts after UI batch merge dedupe - https://phabricator.wikimedia.org/T177873#3673448 (Eileenmcnaughton) [19:42:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#3673461 (Eileenmcnaughton) [19:42:59] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Implement merge rule to allow overwriting any name fields that are wholly numeric in the case of a conf... - https://phabricator.wikimedia.org/T175747#3673460 [19:43:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#2555439 (Eileenmcnaughton) [19:43:18] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Implement merge rule on whitespace to prefer ones with more whitespace - https://phabricator.wikimedia.org/T175746#3673469 (Eileenmcnaughton) Open>... [19:44:18] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add editorconfig files to our codebase to deal with whitespace pain? - https://phabricator.wikimedia.org/T177725#3668035 (Eileenmcnaughton) Open>Resolved a:Eileenmcnaughton [19:44:54] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI batch merge dropping limit at the end - https://phabricator.wikimedia.org/T176256#3673475 (Eileenmcnaughton) Open>Resolved [19:47:02] Fundraising-Backlog: weird UI address display if postal_code has a '/' in it - https://phabricator.wikimedia.org/T177874#3673491 (Eileenmcnaughton) [19:47:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#3673504 (Eileenmcnaughton) [19:47:43] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, and 2 others: Improve dedupe handling of Country only addresses - https://phabricator.wikimedia.org/T176699#3673503 (Eileenmcnaughton) Open>Resolved [19:53:08] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: PayPal EC cURL timeouts - https://phabricator.wikimedia.org/T177438#3673543 (Ejegg) Open>Resolved a:Ejegg Sure, let's call this closed. Only 6 timeouts in the last 5 days with the 12 se... [19:54:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Dedupe V2: resolve top conflicts - https://phabricator.wikimedia.org/T143057#3673548 (Eileenmcnaughton) [19:54:08] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Update wmf_civicrm import normalisation to replace htmlampersand with & - https://phabricator.wikimedia.org/T175744#3673547 (Eileenmcnaughton) Open... [19:54:36] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog: Clean up Damaged queue - https://phabricator.wikimedia.org/T175862#3673552 (Ejegg) Open>Resolved This looks as good as it's going to for now. [19:56:57] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3673558 (DStrine) a:Ejegg [19:58:29] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI batch merge dropping limit at the end - https://phabricator.wikimedia.org/T176256#3673559 (Eileenmcnaughton) [19:59:18] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Implement merge rule to allow overwriting any name fields that are wholly numeric in the case of a conf... - https://phabricator.wikimedia.org/T175747#3673560 [19:59:36] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Implement merge rule to allow resolution on conflicts on punctuation to prefer more punctuation - https://phabricator.wikimedia.org/T175748#3673561 (Eil... [20:00:18] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Implement merge rule on whitespace to prefer ones with more whitespace - https://phabricator.wikimedia.org/T175746#3673577 (Eileenmcnaughton) [20:00:55] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Patch-For-Review: Update wmf_civicrm import normalisation to replace htmlampersand with & - https://phabricator.wikimedia.org/T175744#3673578 (Eileenmcnaughton) [20:03:46] Fundraising Sprint Kickstopper, Fundraising Sprint Loose Lego Carpeting, Fundraising Sprint Murphy's Lawyer, Fundraising Sprint Navel Warfare, and 7 others: process-control should not crash on bad utf-8 from stdout or stderr - https://phabricator.wikimedia.org/T167849#3673613 (Ejegg) Open>... [20:08:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: EPIC: CentralNotice: Tracking: Issues related to old JS widgets in Admin UI - https://phabricator.wikimedia.org/T172024#3673632 (AndyRussG) [20:08:18] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Synchronized Screaming, and 3 others: CentralNotice: JS selection widgets no longer work in interface to add a campaign - https://phabricator.wikimedia.org/T172023#3673631 (An... [20:08:23] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: civicrm mail settings vs outcome snafu - https://phabricator.wikimedia.org/T177244#3673633 (Ejegg) Open>Resolved [20:08:47] Fundraising Sprint Synchronized Screaming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review: New payments-wiki errors: We don't have an order status after... - https://phabricator.wikimedia.org/T176355#3673634 [20:16:17] Fundraising-Backlog: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3673642 (DStrine) [20:17:01] hmm lost connection I think [20:17:53] Fundraising-Backlog: weird UI address display if postal_code has a '/' in it - https://phabricator.wikimedia.org/T177874#3673491 (Ejegg) The one I saw was a '\', so something like an escape char oddity seems likely [20:23:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Implement concept of 'load' action to dedupe (& api in general) - https://phabricator.wikimedia.org/T177882#3673697 (Eileenmcnaughton) [20:24:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WMF FR: weird UI address display if postal_code has a '/' in it - https://phabricator.wikimedia.org/T177874#3673711 (Ejegg) [20:26:48] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#3673724 (Ejegg) @MBeat33 I think you had a quest... [20:28:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation queue consumer crash on unknown country - https://phabricator.wikimedia.org/T177803#3673730 (DStrine) p:Triage>High [20:30:35] Fundraising Sprint T 2017, Fundraising-Backlog: New thank you email for big english 2017 - https://phabricator.wikimedia.org/T177878#3673751 (DStrine) [20:30:37] Fundraising Sprint T 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Implement concept of 'load' action to dedupe (& api in general) - https://phabricator.wikimedia.org/T177882#3673750 (DStrine) [20:30:44] Fundraising Sprint T 2017, Fundraising-Backlog: Still an issue in merge screen display -not showing all contacts after UI batch merge dedupe - https://phabricator.wikimedia.org/T177873#3673752 (DStrine) [20:30:47] Fundraising Sprint T 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import error - https://phabricator.wikimedia.org/T177806#3673754 (DStrine) [20:30:49] Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Improve conflict handling by doing postal-suffix only address conflicts - https://phabricator.wikimedia.org/T177807#3673753 (DStrine) [20:30:54] Fundraising Sprint T 2017, Fundraising-Backlog: Move tracking of silverpop out of settings table - https://phabricator.wikimedia.org/T177451#3673758 (DStrine) [20:30:56] Fundraising Sprint T 2017, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation queue consumer crash on unknown country - https://phabricator.wikimedia.org/T177803#3673757 (DStrine) [20:31:01] Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3673759 (DStrine) [20:31:03] Fundraising Sprint T 2017, Fundraising-Backlog, Patch-For-Review: Start regularly tracking "lag" time of donations moving through the payments system - https://phabricator.wikimedia.org/T176920#3673760 (DStrine) [20:31:05] Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, Fundraising-Backlog, Unplanned-Sprint-Work: adyen cookie error after entering information on Safari - https://phabricator.wikimedia.org/T176913#3673761 (DStrine) [20:31:07] Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Validation not clearing error on blur - https://phabricator.wikimedia.org/T176501#3673763 (DStrine) [20:31:10] Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Registering test in impressions - https://phabricator.wikimedia.org/T176334#3673764 (DStrine) [20:31:15] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, and 5 others: CN Campaign Suppression prior to scheduled start time - https://phabricator.wikimedia.org/T175358#3673766 (DStrine) [20:31:18] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint T 2017, and 4 others: Investigate email: BH data storage/transfer issue for iPad donations - https://phabricator.wikimedia.org/T174719#3673772 (DStrine) [20:31:21] Fundraising Sprint Navel Warfare, Fundraising Sprint Outie Inverter, Fundraising Sprint Prank Seatbelt, Fundraising Sprint Quill Pencil, and 6 others: Create orphan rectifier for PayPal Express Checkout - https://phabricator.wikimedia.org/T172202#3673775 (DStrine) [20:37:55] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint Judgement Suspenders, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Thank you letter from civi mangles non-$ currencies - https://phabricator.wikimedia.org/T151957#3673792 (MBeat33) That's great @Ejegg thank you! [20:58:33] jack wants me to share his 'moment in time' writing with you [20:58:34] https://docs.google.com/document/d/1y3Ir6Au7eI6y66MuoocnuxSEJGNAgUPTf1SZGF4YrD0/edit?usp=sharing [21:08:41] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Implement concept of 'load' action to dedupe (& api in general) - https://phabricator.wikimedia.org/T177882#3673846 (... [21:09:05] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import error - https://phabricator.wikimedia.org/T177806#3673848 (Eileenmcnaughton) Open>Resolved a:Eileenmcnaughton [21:09:11] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Coinbase import error - https://phabricator.wikimedia.org/T177806#3670849 (Eileenmcnaughton) Resolved>Open [21:46:37] Fundraising-Backlog, Patch-For-Review: Start regularly tracking "lag" time of donations moving through the payments system - https://phabricator.wikimedia.org/T176920#3673977 (Ejegg) Oops, I forgot to move this on the backlog board after finishing the part that we can do pre-BE [22:21:43] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3674036 (Ejegg) Yep, that seems incre... [22:28:06] (CR) Ejegg: "Looking good so far. If you want the test to actually look at how many times curl_transaction has been called, you can look at $gateway->c" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [22:28:44] !log changed civicrm smart group cache timeout to 5 civicrm/admin/setting/search?reset=1 [22:28:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:38:50] (CR) Ejegg: "I'm having second thoughts about reusing all of processDonorReturn in the orphan adapter. In the live adapter, the right thing to do on th" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [22:41:40] I'm gonna run the groups cleanup now ejegg [22:41:46] great eileen1 ! [22:42:07] dang missing module on ganglia [22:44:56] someone help me understand the payment request api email thread - isn't that just normal processing? [22:45:30] or is he describing transparent-redirect (which we implement with js) [22:51:24] Fundraising-Backlog, FR-Smashpig: Adyen jobs should retry at least once on connect failure - https://phabricator.wikimedia.org/T177893#3674140 (Ejegg) [22:53:39] eileen1: it's the new thing that Android Pay uses [22:54:18] where the merchant sends your browser an identifiable payment request [22:54:57] and your browser sends the merchant a token that only works for that merchant (and maybe for the requested amount) [22:55:10] ah ok [23:07:02] Fundraising Sprint Quill Pencil, Fundraising Sprint RadioActivewear, Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, and 3 others: Create lists of CiviCRM groups to... - https://phabricator.wikimedia.org/T174407#3674182 [23:08:27] !log ran the group clean up script (reduced smart groups) [23:08:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:10:21] PROBLEM - check_swap on mintaka is CRITICAL: SWAP CRITICAL - 13% free (978 MB out of 7627 MB) [23:12:57] oops, that's me abusing mintaka with grep [23:13:36] :-) [23:14:07] I've now learnt to read 'SWAP CRITICAL' and think 'have I heard anyone talking about logs recently'? [23:15:11] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1377 [23:15:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1379 [23:16:03] X| [23:20:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1609 [23:20:12] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1598 [23:25:11] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1820 [23:25:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1820 [23:25:41] PROBLEM - check_swap on mintaka is CRITICAL: SWAP CRITICAL - 5% free (371 MB out of 7627 MB) [23:30:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2056 [23:30:12] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2049 [23:35:11] PROBLEM - check_mysql on frdb1002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2272 [23:35:11] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2295 [23:40:11] RECOVERY - check_mysql on frdb1002 is OK: Uptime: 95979 Threads: 1 Questions: 25779966 Slow queries: 64504 Opens: 3922 Flush tables: 1 Open tables: 698 Queries per second avg: 268.600 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [23:40:12] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 95812 Threads: 2 Questions: 24819502 Slow queries: 6581 Opens: 3619 Flush tables: 1 Open tables: 525 Queries per second avg: 259.043 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [23:50:21] RECOVERY - check_swap on mintaka is OK: SWAP OK - 100% free (7627 MB out of 7627 MB)