[00:52:36] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3654959 (Milimetric) For context, I j... [05:49:38] (PS1) Eileen: CRM-21294 Fix js error on dedupe find screen. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/383501 (https://phabricator.wikimedia.org/T177873) [15:08:38] (CR) Mepps: "Could we use the payer-id as a check? If we use some sort of confirm method, we'll have to make it something universal and write it into i" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [15:13:20] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3675922 (Jgreen) Casey noticed that 'open temporary tables' is very high on slaves once they have been up for a few days, typically over 10K open tables. We don't have... [15:54:45] (CR) Ejegg: "Hmm, seems a bit muddy to look at one piece of data to decide the intent of the user. We might very well add payer ID to the donation mess" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/382513 (owner: Mepps) [16:00:57] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: Email click data not tracking properly - https://phabricator.wikimedia.org/T177331#3676117 (Jgreen) Luca recommends as a... [17:21:27] (CR) XenoRyet: [C: 2] Manage merge on has-postal-suffix vs no-has-postal-suffix. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383290 (https://phabricator.wikimedia.org/T177807) (owner: Eileen) [17:25:09] (Merged) jenkins-bot: Manage merge on has-postal-suffix vs no-has-postal-suffix. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383290 (https://phabricator.wikimedia.org/T177807) (owner: Eileen) [17:25:10] fr-tech any news for scrum of scrums? [17:25:18] None here [17:28:55] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: DonationInterface should log client-si... - https://phabricator.wikimedia.org/T121800#3676487 [17:31:37] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation queue consumer crash on unknown country - https://phabricator.wikimedia.org/T177803#3676513 (XenoRyet) a:XenoRyet [17:35:18] XenoRyet: that may be mislabeled, I think it's actually unknown states [17:35:54] Cool. Got curious about it and was looking through that log file. [17:36:05] Just figured I was spending enough time that I better put my face on it. [17:36:20] cool [18:33:23] argh why are we using this minification stuff on dash [18:51:32] hey ejegg i think there's still a crm deploy needed for the thank you letter updates--are we going to be deploying the new text soon too? [18:52:04] mepps: I deployed the one you generated last week [18:52:13] oh awesome ejegg [18:54:23] * ejegg has now wasted more time trying to minify the damn dash for deploy than all of the person-seconds ever spent waiting for it to load [18:54:49] ha! [18:54:54] :S [18:55:18] mepps i forget, did you get that set up locally? [18:55:21] Isn't that how all technology gets developed? ;-) [18:55:31] XenoRyet: do you have dash set up locally? [18:55:38] ejegg i have the repo but never got to the point of being able to see anything [18:56:01] I think I do. I haven't looked at it in a while though. [18:56:22] Would you mind trying to run gulp on the deploy banch? [18:56:44] the uglify part is just hanging forever with no output for me [18:57:07] tried updating to gulp4, no help [18:58:53] Actually no, it looks like I don't have dash set up. [18:59:09] I could've sworn I did that at some point, but I'm not finding it. [18:59:14] huh, I thought so too [18:59:22] Anyway, brb, gotta change a diaper. [19:00:40] well, guess I'll try deploying that client-side error logging in DI [19:01:31] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/383641 [19:02:15] fundraising-tech-ops: frdb1002 swap use spike associated with mysql dump run - https://phabricator.wikimedia.org/T177982#3676890 (Jgreen) [19:08:01] ejegg i'm getting this error trying to run gulp: Error: ENOENT: no such file or directory, lstat '/var/www/fr-tech/dash/dist/images/amt-per-sec.png' [19:16:43] mepps yeah, that's a known issue :( [19:16:46] try a few more times [19:16:55] I think the 'clean' thing is buggy [19:17:12] and we can just use a 'del' plugin instead [19:27:25] ejegg it ran this time [19:28:00] mepps whew! [19:28:42] Would you mind merging the latest couple things over from master to deployment and minifying, then putting those commits up for review? [19:28:48] or I can do the merge at least [19:29:46] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383649 [19:30:03] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383649 (owner: Ejegg) [19:36:25] (PS1) Ejegg: Fixes to client-side error logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383650 (https://phabricator.wikimedia.org/T121800) [19:38:55] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383649 (owner: Ejegg) [19:42:15] (PS1) Mepps: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383654 [19:43:32] (PS2) Mepps: Merge branch 'master' into deployment + gulp files [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383654 [19:43:38] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment + gulp files [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383654 (owner: Mepps) [19:43:51] done ejegg ^^ [19:44:03] thanks so much! [19:44:26] oops, looks like the merge is clashing [19:44:37] sorry, I did the merge part already [19:44:47] should end up with all the same stuff in dist though... [19:45:22] lemme rebase that manually [19:49:15] ejegg: meeting? [19:49:20] (PS3) Ejegg: Gulp for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383654 (owner: Mepps) [19:49:26] dstrine: oops, be right there! [19:55:30] (CR) jerkins-bot: [V: -1] Fixes to client-side error logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383650 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [19:59:15] (CR) Ejegg: [C: 2] Gulp for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383654 (owner: Mepps) [20:03:29] (Merged) jenkins-bot: Gulp for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/383654 (owner: Mepps) [20:34:26] Fundraising-Backlog: Add link to contact summary to assist in finding & deduping the contact - https://phabricator.wikimedia.org/T177999#3677467 (Eileenmcnaughton) [20:41:26] Fundraising-Backlog: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3677490 (Eileenmcnaughton) [20:43:37] Fundraising Dash, Fundraising-Backlog: dash should group <1% things under 'other' - https://phabricator.wikimedia.org/T178001#3677501 (Ejegg) [20:52:33] Fundraising-Backlog: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3677546 (Eileenmcnaughton) [20:53:22] the problem with the iptables molly guard is it gives you like 5 seconds to try to establish a new connection before it rolls back [20:53:32] which when you have an auth scheme like ours is really not enough time [20:59:02] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impressions missing in pgehres database - https://phabricator.wikimedia.org/T177331#3677581 (... [21:03:22] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impressions missing in pgehres database - https://phabricator.wikimedia.org/T177331#3677598 (... [21:04:12] Fundraising-Backlog: Improve major gifts email links when a contact has already been merged so there is not a findy-game - https://phabricator.wikimedia.org/T178000#3677600 (DStrine) [21:04:57] eileen1: I like that you used "findy-game" in a phab task [21:06:14] Fundraising-Backlog: Add link to contact summary to assist in finding & deduping the contact - https://phabricator.wikimedia.org/T177999#3677602 (DStrine) [21:07:47] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impressions missing in pgehres database - https://phabricator.wikimedia.org/T177331#3677603 (... [21:08:32] boss sprint name fr-tech [21:08:47] busting all horizontal page limits [21:09:11] Yep [21:10:05] Fundraising-Backlog: Make it easier to move from contact deleted by merge to the contact they were merged to - https://phabricator.wikimedia.org/T178003#3677604 (DStrine) [21:19:33] dstrine: I try to use clear language :-) [21:25:18] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3529511 (Eileenmcnaughton) Those tables are created in CRM_Mailing_BAO_Mailing::getRecipients() - the order in the code is correct (which seems obvious :-). I'm diggi... [21:28:51] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3677668 (Eileenmcnaughton) One more question / clarification @Jgreen - this is what you are seeing in the binary logs on the slaves but not on master? [21:38:49] (PS1) Ejegg: Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 [21:40:16] (CR) jerkins-bot: [V: -1] Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 (owner: Ejegg) [21:44:18] (PS1) Eileen: purely for testing purposes - do not merge [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/383711 [21:44:20] (PS2) Ejegg: Fixes to client-side error logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383650 (https://phabricator.wikimedia.org/T121800) [21:44:22] (PS1) Ejegg: Add an off switch for client-side error logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383712 (https://phabricator.wikimedia.org/T121800) [21:45:51] (PS2) Ejegg: Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 [21:46:55] (CR) jerkins-bot: [V: -1] Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 (owner: Ejegg) [21:48:40] (PS3) Ejegg: Label dates better in Big English chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/383708 [22:01:06] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: Back-fill missing pgehres data - https://phabricator.wikimedia.org/T178009#3677774 (cwdent) [22:04:20] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3677794 (Jgreen) >>! In T173472#3677660, @Eileenmcnaughton wrote: > Those tables are created in CRM_Mailing_BAO_Mailing::getRecipients() - the order in the code is cor... [22:05:02] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3677797 (Jgreen) >>! In T173472#3677668, @Eileenmcnaughton wrote: > One more question / clarification @Jgreen - this is what you are seeing in the binary logs on the s... [22:09:03] Fundraising-Backlog: Minimum amount changes from CA donation form to Paypal - https://phabricator.wikimedia.org/T177415#3677813 (Ejegg) @Pcoombe the AstroPay minimum is $1.50, so you can just multiply the regular ones by 1.5. [22:18:20] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impressions missing in pgehres database - https://phabricator.wikimedia.org/T177331#3677832 (... [22:19:44] (PS13) Ejegg: Capture Adyen payments missing pending messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/319489 (https://phabricator.wikimedia.org/T149861) [22:25:01] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3677867 (Eileenmcnaughton) OK - I have confirmed that part of the code is reached by the omnimail job that retrieves civimails & stores them & there is an easy fix. Th... [22:33:25] (PS2) Ejegg: Add contact_id and _hash to the rest of the places [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/383283 (https://phabricator.wikimedia.org/T177663) [22:42:09] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3677941 (Jgreen) >>! In T173472#3677867, @Eileenmcnaughton wrote: > OK - I have confirmed that part of the code is reached by the omnimail job that retrieves civimails... [22:50:36] Fundraising-Backlog, fundraising-tech-ops: fundraising database replication lag master thread - https://phabricator.wikimedia.org/T173472#3677982 (Eileenmcnaughton) We are directly dropping those tables in the code - so session cleanup isn't the pattern [22:52:51] Fundraising Sprint Synchronized Screaming, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, Unplanned-Sprint-Work: donatewiki_counts and banner impressions missing in pgehres database - https://phabricator.wikimedia.org/T177331#3678013 (... [22:54:31] (PS3) Ejegg: Check contact_hash if contact_id exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383260 (https://phabricator.wikimedia.org/T177663) [22:58:18] (CR) jerkins-bot: [V: -1] Check contact_hash if contact_id exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383260 (https://phabricator.wikimedia.org/T177663) (owner: Ejegg) [22:59:19] (PS2) Ejegg: Only report age of messages from payments [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/382858 (https://phabricator.wikimedia.org/T176920) [23:00:51] (PS3) Ejegg: Report consumer run time and drush startup time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/381856 [23:01:16] (Abandoned) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/383641 (owner: Ejegg) [23:01:37] (CR) Ejegg: "recheck" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383388 (owner: Ejegg) [23:03:29] (CR) jerkins-bot: [V: -1] Add sqlite3 to requre-dev [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383388 (owner: Ejegg) [23:08:10] (PS4) Ejegg: Check contact_hash if contact_id exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383260 (https://phabricator.wikimedia.org/T177663) [23:13:45] (PS2) Ejegg: Add sqlite3 to requre-dev [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/383388 [23:25:49] Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, fundraising-tech-ops, Unplanned-Sprint-Work: Eliminate creating of temp tables from Omnimailing.load task - https://phabricator.wikimedia.org/T178020#3678119 (Eileenmcnaughton) [23:28:23] (CR) jerkins-bot: [V: -1] Check contact_hash if contact_id exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383260 (https://phabricator.wikimedia.org/T177663) (owner: Ejegg) [23:39:20] (PS2) Eileen: Add editorconfig to various drupal dirs with drupal whitespace standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383300 (https://phabricator.wikimedia.org/T177725) [23:39:22] (PS1) Eileen: Fix Omnimailing.load job to bypass creating recipients & to use internal replace, add test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383734 (https://phabricator.wikimedia.org/T178020) [23:40:44] I like the way we see fhe full sprint tile in the spring [23:40:46] sprint [23:41:57] (CR) Eileen: "I applied this patch locally when running tests for this" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383734 (https://phabricator.wikimedia.org/T178020) (owner: Eileen) [23:46:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird contribution merge in Civi - https://phabricator.wikimedia.org/T178021#3678168 (LeanneS) [23:51:05] (CR) jerkins-bot: [V: -1] Fix Omnimailing.load job to bypass creating recipients & to use internal replace, add test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383734 (https://phabricator.wikimedia.org/T178020) (owner: Eileen) [23:53:55] (PS2) Eileen: Fix Omnimailing.load job to bypass creating recipients & to use internal replace, add test. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/383734 (https://phabricator.wikimedia.org/T178020) [23:55:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Weird contribution merge in Civi - https://phabricator.wikimedia.org/T178021#3678203 (Eileenmcnaughton) There are known issues in Civi when editing in 2 tabs & I seem to be seeing them a bit more lately :-(